e145d48f22
* feat: add plugin system with grpc runtime and native ui plugins - go plugin backends ship as release tarballs (per-platform binaries, checksums) that kandev installs from url/upload or filesystem sideload+sync, then spawns and supervises via hashicorp/go-plugin (unix socket / loopback tcp+automtls) - strict typed grpc contract (kandev.plugin.v1): DeliverEvent/InvokeTool/HandleWebhook plus a capability-gated host service (state, secrets, emit); author sdk in pkg/pluginsdk; packaging cli in cmd/plugin-pack - native frontend bundles: window.registerKandevPlugin + registry/host loader with dynamic routes, nav items, slots and ws handlers; plugins settings page with install dialog, sync button and enable/disable/uninstall - gated behind the plugins feature flag (prod off, dev/e2e on); covered by unit and integration tests plus playwright e2e against a real packaged fixture plugin Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): hydrate base app context on plugin routes Plugin-owned SPA routes classify as RouteUnknown, so the boot payload shipped only feature flags — no workspaces, workflows, or kanban context. Native plugin UI (e.g. host.ui.TaskCreateDialog) then had an empty store. Hydrate the same base context as the Home route for unknown SPA routes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(plugins): expose TaskCreateDialog on host.ui Lets a native plugin open kandev's real create-task modal (prefilled via initialValues) instead of POSTing directly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): harden filesystem/URL sinks against CodeQL findings Add sink-level guards on the plugin trust boundary: securejoin containment on archive extraction (zip-slip), plugin-id validation before every fs_store path, http/https scheme validation on install-from-URL, and non-interpolated ws-handler error logging. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address review findings (races, resource caps, lifecycle) - serialize per-plugin startup to close a TOCTOU double-spawn race, and let a plugin restart after exhausting attempts - bound plugin startup with an explicit 30s timeout - reject backslash paths and cap decompressed bytes by actual size in pkgtar; only mark a package Signed when a verifier actually ran and passed - delete plugin_state on uninstall; validate webhook keys against the manifest and cap webhook body size; restart an active plugin when a new version installs Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): sanitize plugin-id path sinks for CodeQL Pin the plugin id to a single path segment with filepath.Base at recordPath/ configPath and pkgtar.Remove — a barrier the taint analysis recognizes. Behaviour-identical for valid ids (already validated by safePluginID); clears the go/path-injection alerts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): inline plugin-id validation at path sinks for CodeQL filepath.Base does not strip '..', so it is not a path-injection barrier. Call the recognized safePluginID / id-pattern guard inline in Delete/GetConfig/ SetConfig and pkgtar.Remove — the same barrier that already cleared the Get sink. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address code-review findings (backend) - add capability-gating tests for the Host RPC service (was untested) - close a stop-during-start orphan race so Disable/Uninstall can't leave a supervised subprocess behind - on failed upgrade, remove only the new version dir (not all versions + data); restart the prior version - validate manifest version and reject ids ending in .config (record-file alias) - make Deliverer.Refresh non-blocking and cancel in-flight delivery on worker stop - clamp out-of-range webhook status, skip-and-warn corrupt records in List, write records atomically, semver-aware sideload version pick Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address code-review findings (frontend) - wrap plugin routes + settings routes in a shared PluginErrorBoundary so a throwing plugin page shows a fallback instead of white-screening the SPA - fix disable/re-enable in one session: keep the cached registration and re-run initialize instead of relying on a cached ES-module re-import - prefix root-relative bundle/style URLs with apiBaseUrl (split-origin/Tauri) - surface partial-install warnings via toast.warning instead of a bare success - dedupe/remove injected style links on unload; gate PluginNavItems on the flag Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): serialize per-plugin lifecycle + guard config writes - add a per-plugin keyed lock in Service so concurrent Enable/Disable/Install/ Uninstall/UpdateConfig for one id are serialized (no status-machine race) - take s.mu in SetConfig/GetConfig and write config atomically - bound each plugin initialize() with a timeout so one hung bundle can't stall the rest of the boot load Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(plugins): split service_test.go to satisfy file-length lint Move the install/URL test group into service_install_test.go; no logic change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * ci: build and ship the e2e fixture plugin package to E2E shards The plugin E2E specs' global-setup requires apps/backend/.build/kandev-plugin-e2e-1.0.0.tar.gz. Build it in the E2E build job, upload it as an artifact, and download it in both the regular and container shard jobs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
104 lines
2.8 KiB
Go
104 lines
2.8 KiB
Go
package delivery
|
|
|
|
import (
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/kandev/kandev/pkg/pluginsdk"
|
|
)
|
|
|
|
// Delivery is one queued/buffered event delivery job for a single plugin.
|
|
type Delivery struct {
|
|
PluginID string
|
|
Event *pluginsdk.Event
|
|
}
|
|
|
|
// bufferedDelivery pairs a Delivery with the time it was buffered, for TTL
|
|
// eviction.
|
|
type bufferedDelivery struct {
|
|
delivery Delivery
|
|
addedAt time.Time
|
|
}
|
|
|
|
// ringBuffer holds events for one plugin while it is in the error state, so
|
|
// Deliverer.Flush can replay them in order after a health-poller recovery
|
|
// transition. Capacity and TTL are the numbers in
|
|
// docs/specs/plugins/spec.md ("Event webhook delivery"): 100 events / 5
|
|
// minutes. The oldest entry is dropped on overflow; expired entries are
|
|
// purged lazily on the next Add, Drain, or Len call.
|
|
type ringBuffer struct {
|
|
mu sync.Mutex
|
|
cap int
|
|
ttl time.Duration
|
|
items []bufferedDelivery
|
|
nowFn func() time.Time
|
|
}
|
|
|
|
// newRingBuffer returns a ring buffer bounded to capacity entries, each
|
|
// evicted after ttl. nowFn defaults to time.Now when nil; tests inject a
|
|
// fake clock for deterministic TTL assertions.
|
|
func newRingBuffer(capacity int, ttl time.Duration, nowFn func() time.Time) *ringBuffer {
|
|
if nowFn == nil {
|
|
nowFn = time.Now
|
|
}
|
|
return &ringBuffer{cap: capacity, ttl: ttl, nowFn: nowFn}
|
|
}
|
|
|
|
// Add appends d to the buffer, purging expired entries first and then
|
|
// evicting the oldest remaining entry if still at capacity. Returns the
|
|
// event id of the entry dropped due to overflow, or "" if none was
|
|
// dropped.
|
|
func (r *ringBuffer) Add(d Delivery) (droppedID string) {
|
|
r.mu.Lock()
|
|
defer r.mu.Unlock()
|
|
|
|
r.purgeExpiredLocked()
|
|
|
|
if r.cap > 0 && len(r.items) >= r.cap && len(r.items) > 0 {
|
|
droppedID = r.items[0].delivery.Event.EventID
|
|
r.items = r.items[1:]
|
|
}
|
|
r.items = append(r.items, bufferedDelivery{delivery: d, addedAt: r.nowFn()})
|
|
return droppedID
|
|
}
|
|
|
|
// Drain returns every non-expired buffered delivery in insertion (oldest
|
|
// first) order and empties the buffer.
|
|
func (r *ringBuffer) Drain() []Delivery {
|
|
r.mu.Lock()
|
|
defer r.mu.Unlock()
|
|
|
|
r.purgeExpiredLocked()
|
|
out := make([]Delivery, len(r.items))
|
|
for i, it := range r.items {
|
|
out[i] = it.delivery
|
|
}
|
|
r.items = nil
|
|
return out
|
|
}
|
|
|
|
// Len reports the number of currently buffered (non-expired) deliveries.
|
|
func (r *ringBuffer) Len() int {
|
|
r.mu.Lock()
|
|
defer r.mu.Unlock()
|
|
r.purgeExpiredLocked()
|
|
return len(r.items)
|
|
}
|
|
|
|
// purgeExpiredLocked drops entries older than ttl from the front of items
|
|
// (insertion order == age order, so this is a prefix trim). Caller must
|
|
// hold mu.
|
|
func (r *ringBuffer) purgeExpiredLocked() {
|
|
if r.ttl <= 0 {
|
|
return
|
|
}
|
|
cutoff := r.nowFn().Add(-r.ttl)
|
|
idx := 0
|
|
for idx < len(r.items) && r.items[idx].addedAt.Before(cutoff) {
|
|
idx++
|
|
}
|
|
if idx > 0 {
|
|
r.items = r.items[idx:]
|
|
}
|
|
}
|