7de788ceed
* feat: add cross-integration entity references * fix(web): anchor entity reference menu to composer * fix: keep Kandev tasks under @ mentions * fix: address entity reference review findings * test(e2e): use option role for prompt menu * test(e2e): update passthrough mention roles * fix: preserve queued references and paginate Azure PRs
249 lines
7.2 KiB
TypeScript
249 lines
7.2 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { getMarkdownText, textToEditorContent } from "./tiptap-helpers";
|
|
import * as tiptapHelpers from "./tiptap-helpers";
|
|
|
|
describe("entity reference trigger", () => {
|
|
it("provides a trigger-context guard for # suggestions", () => {
|
|
expect(typeof (tiptapHelpers as Record<string, unknown>).isEntityReferenceTriggerAllowed).toBe(
|
|
"function",
|
|
);
|
|
});
|
|
|
|
it("allows # only at a block start or after whitespace outside code", () => {
|
|
const allowed = tiptapHelpers.isEntityReferenceTriggerAllowed as unknown as (args: {
|
|
textBeforeTrigger: string;
|
|
parentType: string;
|
|
hasCodeMark: boolean;
|
|
}) => boolean;
|
|
|
|
expect(allowed({ textBeforeTrigger: "", parentType: "paragraph", hasCodeMark: false })).toBe(
|
|
true,
|
|
);
|
|
expect(
|
|
allowed({ textBeforeTrigger: "Discuss ", parentType: "paragraph", hasCodeMark: false }),
|
|
).toBe(true);
|
|
expect(
|
|
allowed({ textBeforeTrigger: "issue", parentType: "paragraph", hasCodeMark: false }),
|
|
).toBe(false);
|
|
expect(allowed({ textBeforeTrigger: "", parentType: "codeBlock", hasCodeMark: false })).toBe(
|
|
false,
|
|
);
|
|
expect(allowed({ textBeforeTrigger: "", parentType: "paragraph", hasCodeMark: true })).toBe(
|
|
false,
|
|
);
|
|
});
|
|
});
|
|
|
|
describe("entity reference metadata", () => {
|
|
it("provides structured extraction from editor JSON", () => {
|
|
expect(typeof (tiptapHelpers as Record<string, unknown>).extractEntityReferences).toBe(
|
|
"function",
|
|
);
|
|
});
|
|
|
|
it("extracts valid atoms in first-appearance order and deduplicates by ref", () => {
|
|
const reference = {
|
|
version: 1,
|
|
ref: "mention:v1:linear:issue:linear.app%2Forg-1:issue-1",
|
|
provider: "linear",
|
|
kind: "issue",
|
|
id: "issue-1",
|
|
key: "ENG-1",
|
|
title: "Fix login",
|
|
url: "https://linear.app/acme/issue/ENG-1/fix-login",
|
|
scope: "linear.app/org-1",
|
|
};
|
|
const extract = tiptapHelpers.extractEntityReferences as unknown as (doc: {
|
|
content: unknown[];
|
|
}) => (typeof reference)[];
|
|
|
|
expect(
|
|
extract({
|
|
content: [
|
|
{
|
|
type: "paragraph",
|
|
content: [
|
|
{ type: "entityReference", attrs: reference },
|
|
{ type: "entityReference", attrs: reference },
|
|
{ type: "entityReference", attrs: { ref: "malformed" } },
|
|
],
|
|
},
|
|
],
|
|
}),
|
|
).toEqual([reference]);
|
|
});
|
|
});
|
|
|
|
describe("getMarkdownText", () => {
|
|
it("serializes entity reference atoms as portable Markdown links", () => {
|
|
expect(
|
|
getMarkdownText({
|
|
getJSON: () => ({
|
|
content: [
|
|
{
|
|
type: "paragraph",
|
|
content: [
|
|
{ type: "text", text: "Track " },
|
|
{
|
|
type: "entityReference",
|
|
attrs: {
|
|
key: "ENG-123",
|
|
title: "Fix [auth] flow",
|
|
url: "https://jira.example.test/browse/ENG-123",
|
|
},
|
|
},
|
|
],
|
|
},
|
|
],
|
|
}),
|
|
}),
|
|
).toBe("Track [#ENG-123](https://jira.example.test/browse/ENG-123)");
|
|
});
|
|
|
|
it("serializes slash command chips as slash command text", () => {
|
|
expect(
|
|
getMarkdownText({
|
|
getJSON: () => ({
|
|
content: [
|
|
{
|
|
type: "paragraph",
|
|
content: [
|
|
{ type: "text", text: "please run " },
|
|
{ type: "slashCommand", attrs: { label: "/slow" } },
|
|
{ type: "text", text: " 1s" },
|
|
],
|
|
},
|
|
],
|
|
}),
|
|
}),
|
|
).toBe("please run /slow 1s");
|
|
});
|
|
|
|
it("serializes slash command chips from commandName-only attrs", () => {
|
|
expect(
|
|
getMarkdownText({
|
|
getJSON: () => ({
|
|
content: [
|
|
{
|
|
type: "paragraph",
|
|
content: [
|
|
{ type: "text", text: "please run " },
|
|
{ type: "slashCommand", attrs: { commandName: "slow" } },
|
|
],
|
|
},
|
|
],
|
|
}),
|
|
}),
|
|
).toBe("please run /slow");
|
|
});
|
|
|
|
it("normalizes slash command chip labels when serializing", () => {
|
|
expect(
|
|
getMarkdownText({
|
|
getJSON: () => ({
|
|
content: [
|
|
{
|
|
type: "paragraph",
|
|
content: [{ type: "slashCommand", attrs: { label: "slow" } }],
|
|
},
|
|
],
|
|
}),
|
|
}),
|
|
).toBe("/slow");
|
|
});
|
|
});
|
|
|
|
describe("textToEditorContent", () => {
|
|
const slowCommand = {
|
|
id: "agent-slow",
|
|
label: "/slow",
|
|
description: "Run a slow response",
|
|
action: "agent" as const,
|
|
agentCommandName: "slow",
|
|
};
|
|
|
|
it("restores known slash commands as slash command nodes", () => {
|
|
const content = textToEditorContent("/slow 1s", [slowCommand]);
|
|
|
|
expect(content).toEqual({
|
|
type: "doc",
|
|
content: [
|
|
{
|
|
type: "paragraph",
|
|
content: [
|
|
{
|
|
type: "slashCommand",
|
|
attrs: {
|
|
id: "agent-slow",
|
|
label: "/slow",
|
|
commandName: "slow",
|
|
description: "Run a slow response",
|
|
},
|
|
},
|
|
{ type: "text", text: " 1s" },
|
|
],
|
|
},
|
|
],
|
|
});
|
|
});
|
|
|
|
it("does not restore slash command chips inside recalled code fences", () => {
|
|
const content = textToEditorContent("```python\n/slow arg\n```", [slowCommand]);
|
|
|
|
expect(JSON.stringify(content)).not.toContain('"slashCommand"');
|
|
expect(content).toEqual({
|
|
type: "doc",
|
|
content: [
|
|
{ type: "paragraph", content: [{ type: "text", text: "```python" }] },
|
|
{ type: "paragraph", content: [{ type: "text", text: "/slow arg" }] },
|
|
{ type: "paragraph", content: [{ type: "text", text: "```" }] },
|
|
],
|
|
});
|
|
});
|
|
|
|
it("restores generated reference Markdown only when matching metadata is present", () => {
|
|
const reference = {
|
|
version: 1,
|
|
ref: "mention:v1:jira:issue:scope:10001",
|
|
provider: "jira",
|
|
kind: "issue",
|
|
id: "10001",
|
|
key: "ENG-123",
|
|
title: "Fix authentication",
|
|
url: "https://jira.example.test/browse/ENG-123",
|
|
scope: "jira.example.test/site-1",
|
|
};
|
|
const restore = textToEditorContent as unknown as (
|
|
text: string,
|
|
commands: readonly (typeof slowCommand)[],
|
|
references: readonly (typeof reference)[],
|
|
) => ReturnType<typeof textToEditorContent>;
|
|
|
|
const content = restore(
|
|
"See [#ENG-123](https://jira.example.test/browse/ENG-123) and [docs](https://example.test)",
|
|
[],
|
|
[reference],
|
|
);
|
|
|
|
expect(content.content?.[0]?.content).toEqual([
|
|
{ type: "text", text: "See " },
|
|
{ type: "entityReference", attrs: reference },
|
|
{ type: "text", text: " and [docs](https://example.test)" },
|
|
]);
|
|
});
|
|
|
|
it("keeps generated-looking links literal without structured metadata", () => {
|
|
const content = textToEditorContent(
|
|
"See [#ENG-123](https://jira.example.test/browse/ENG-123)",
|
|
[],
|
|
);
|
|
|
|
expect(content.content?.[0]?.content).toEqual([
|
|
{
|
|
type: "text",
|
|
text: "See [#ENG-123](https://jira.example.test/browse/ENG-123)",
|
|
},
|
|
]);
|
|
});
|
|
});
|