c11a6bbfd2
* feat(github): add issue watcher with task creation and auto-cleanup
Add a GitHub Issue Watcher feature that polls for new issues matching
configurable filters and automatically creates tasks for them. This
complements the existing PR Review Watcher with the same patterns.
Backend:
- Issue watch CRUD (models, store, service, controller, WS handlers)
- Poller integration with configurable intervals
- Event-driven task creation via orchestrator
- Repository resolution and worktree support for issue tasks
- Auto-cleanup of tasks for closed issues (CleanupClosedIssueTasks)
- GetIssueState client method across all implementations
- Default branch auto-detection from cloned repo HEAD
Frontend:
- Issue watch settings UI (table, dialog, placeholders)
- Issue link icon on task cards (green circle-dot)
- API client, store slice, and hook for issue watches
- SSR and WS hydration of issue metadata
* fix: resolve golangci-lint errors (goconst, nestif, dupl) and prettier formatting
* fix(github): fix issue watch update shape, trigger key, and label quoting
- httpUpdateIssueWatch now returns the full IssueWatch object instead of
{updated:true} so the frontend store correctly refreshes after edits
- httpTriggerIssueWatch returns new_issues_found to match TriggerIssueResponse
type; was returning new_issues so the toast count was always 0
- buildIssueFilter uses conditional quoting instead of fmt.Sprintf %q to
avoid Go escape sequences in GitHub search qualifiers
Co-authored-by: João Salavisa <undefined@users.noreply.github.com>
* fix: resolve eslint warnings (max-lines-per-function, no-nested-ternary)
* test(github): add issue watcher tests and fix review feedback
- Add TestInterpolateIssuePrompt (4 cases: empty/all/none/partial)
- Add TestCreateIssueTask (3 cases: skip/reserve+assign/release on fail)
- Add TestShouldDeleteIssueTask (4 cases: open/closed+sessions/closed/error)
- Fix WS response key new_issues -> new_issues_found
- Fix fmt.Printf -> fmt.Fprintf(os.Stderr) in store.go
- Add CleanupClosedIssueTasks call in WS trigger handler
* fix: address PR review feedback and CI failures
- Split test files to fix revive file-length-limit (service_test.go,
event_handlers_github_test.go)
- Add session checker guard in CleanupClosedIssueTasks
- Normalize poll intervals on UpdateIssueWatch
- Add cleanup call in TriggerAllIssueChecks loop
- Log cleanup errors in controller and WS handler
- Prefer refs/remotes/origin/HEAD in detectGitDefaultBranch
- Add aria-label to issue task icon
- Fix TypeScript type errors: add linkedIssues to GitHubSlice,
fix hook exports, remove invalid imports
* fix: split test files exceeding revive limit and clean up minor issues
- Split service_test.go (883→779 lines): move TestTriggerPRSync_* to
service_pr_sync_test.go
- Split event_handlers_github_test.go (806→677 lines): move
TestCreateReviewTask_* and helpers to event_handlers_github_review_test.go
- Remove redundant s.taskSessionChecker nil-check inside shouldDeleteIssueTask
(early guard at CleanupClosedIssueTasks already ensures it is non-nil)
- Remove unreachable dead guard in detectAndPersistDefaultBranch
(repo.DefaultBranch is always "" at that call site)
- Fix bogus #0 issue badge in task-session-sidebar.tsx when issueNumber is absent
Co-authored-by: João Salavisa <undefined@users.noreply.github.com>
* fix: address Claude review — poll clamp and prompt injection
- Handle v <= 0 in UpdateIssueWatch poll interval (fall back to default)
- Remove {{issue.body}} from default template to prevent prompt injection
- Update test expected output for new default template
* fix: remove {{issue.body}} from frontend DEFAULT_ISSUE_WATCH_PROMPT
Mirrors the backend fix — the UI pre-fills the prompt so the backend
fallback was never reached. The placeholder stays in
ISSUE_WATCH_PLACEHOLDERS for explicit opt-in.
* feat(github): add isIssueWatch sidebar filter dimension
Add isIssueWatch boolean to KanbanState, TaskSwitcherItem, and sidebar
filter registry — mirroring the isPRReview pattern. Issue-watch tasks
(created from issue_watch_id in metadata) can now be explicitly filtered
in the sidebar, just like PR review tasks.
Files changed:
- sidebar-view-types: add isIssueWatch dimension
- filter-dimension-registry: add Issue watch filter meta
- apply-view: add isIssueWatch extractor
- kanban types: add isIssueWatch field
- TaskSwitcherItem: add isIssueWatch field
- use-all-workflow-snapshots: derive isIssueWatch from metadata
- ssr/mapper: derive isIssueWatch from metadata
- task-session-sidebar: pass isIssueWatch, extract helpers to fix complexity
* fix: correct deleteIssueWatch response type to match backend
Backend httpDeleteIssueWatch returns {"deleted": true}; the frontend
type was { success: boolean } — a mismatch with no functional impact
(return value is ignored) but wrong per TypeScript contract.
Co-authored-by: João Salavisa <undefined@users.noreply.github.com>
* refactor: extract metadata helpers to shared lib/metadata-utils.ts
- Move isPRReviewFromMetadata, isIssueWatchFromMetadata, and
issueFieldsFromMetadata to a shared module to eliminate duplicate
definitions (sonarjs/no-identical-functions).
- Fix deleteIssueWatch response type: { success: boolean } -> { deleted: boolean }
to match the actual backend response.
* style: fix prettier formatting
* test(web): add tests for isIssueWatch filter dimension and metadata-utils
Co-authored-by: João Salavisa <undefined@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* style: fix prettier formatting in test files
* fix(github): cascade-delete issue watch tasks on watch deletion and add isPRReview to SSR mapper
- DeleteIssueWatch now wraps in a transaction and deletes related
github_issue_watch_tasks rows before removing the watch; prevents
orphaned dedup rows accumulating after a watch is deleted
- snapshotToState in mapper.ts now also sets isPRReview from metadata,
matching the mapping already done in use-all-workflow-snapshots.ts
Co-authored-by: João Salavisa <undefined@users.noreply.github.com>
* style: extract duplicate string constant in metadata-utils test
* style: extract repeated WS error strings into constants in handlers.go
goconst min-occurrences: 3 — 'invalid payload' (6x) and 'id required' (4x)
both exceed the threshold. Extract to package-level constants.
Co-authored-by: João Salavisa <undefined@users.noreply.github.com>
* style: extract repeated issue key strings into constants in event_handlers_github.go
goconst min-occurrences: 3 — 'issue_number' (9x) and 'issue_watch_id' (5x)
both newly introduced in this PR exceed the threshold.
Co-authored-by: João Salavisa <undefined@users.noreply.github.com>
* style: fix prettier formatting in metadata-utils test
---------
Co-authored-by: Kandev Agent <agent@kandev.dev>
Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: João Salavisa <undefined@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
82 lines
2.6 KiB
TypeScript
82 lines
2.6 KiB
TypeScript
import { describe, it, expect } from "vitest";
|
|
import {
|
|
isPRReviewFromMetadata,
|
|
isIssueWatchFromMetadata,
|
|
issueFieldsFromMetadata,
|
|
} from "./metadata-utils";
|
|
|
|
describe("isPRReviewFromMetadata", () => {
|
|
it("returns true when review_watch_id is a non-empty string", () => {
|
|
expect(isPRReviewFromMetadata({ review_watch_id: "rw-abc" })).toBe(true);
|
|
});
|
|
|
|
it("returns false when review_watch_id is absent", () => {
|
|
expect(isPRReviewFromMetadata({ other_key: "val" })).toBe(false);
|
|
});
|
|
|
|
it("returns false when review_watch_id is an empty string", () => {
|
|
expect(isPRReviewFromMetadata({ review_watch_id: "" })).toBe(false);
|
|
});
|
|
|
|
it("returns false for null metadata", () => {
|
|
expect(isPRReviewFromMetadata(null)).toBe(false);
|
|
});
|
|
|
|
it("returns false for non-object metadata", () => {
|
|
expect(isPRReviewFromMetadata("string" as unknown as Record<string, unknown>)).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("isIssueWatchFromMetadata", () => {
|
|
it("returns true when issue_watch_id is a non-empty string", () => {
|
|
expect(isIssueWatchFromMetadata({ issue_watch_id: "iw-xyz" })).toBe(true);
|
|
});
|
|
|
|
it("returns false when issue_watch_id is absent", () => {
|
|
expect(isIssueWatchFromMetadata({ review_watch_id: "rw-abc" })).toBe(false);
|
|
});
|
|
|
|
it("returns false when issue_watch_id is an empty string", () => {
|
|
expect(isIssueWatchFromMetadata({ issue_watch_id: "" })).toBe(false);
|
|
});
|
|
|
|
it("returns false for null metadata", () => {
|
|
expect(isIssueWatchFromMetadata(null)).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("issueFieldsFromMetadata", () => {
|
|
const ISSUE_URL = "https://github.com/a/b/issues/7";
|
|
|
|
it("extracts issueUrl and issueNumber when both are present", () => {
|
|
expect(issueFieldsFromMetadata({ issue_url: ISSUE_URL, issue_number: 7 })).toEqual({
|
|
issueUrl: ISSUE_URL,
|
|
issueNumber: 7,
|
|
});
|
|
});
|
|
|
|
it("returns only issueUrl when issue_number is absent", () => {
|
|
expect(issueFieldsFromMetadata({ issue_url: ISSUE_URL })).toEqual({
|
|
issueUrl: ISSUE_URL,
|
|
});
|
|
});
|
|
|
|
it("returns only issueNumber when issue_url is absent", () => {
|
|
expect(issueFieldsFromMetadata({ issue_number: 42 })).toEqual({ issueNumber: 42 });
|
|
});
|
|
|
|
it("returns empty object when neither field is present", () => {
|
|
expect(issueFieldsFromMetadata({ other: "val" })).toEqual({});
|
|
});
|
|
|
|
it("ignores issue_number if it is a string instead of a number", () => {
|
|
expect(issueFieldsFromMetadata({ issue_url: "https://x", issue_number: "7" })).toEqual({
|
|
issueUrl: "https://x",
|
|
});
|
|
});
|
|
|
|
it("returns empty object for null metadata", () => {
|
|
expect(issueFieldsFromMetadata(null)).toEqual({});
|
|
});
|
|
});
|