Files
kandev/apps/backend/internal/github/action_presets_service.go
T
João Salavisa ccc62d9324 feat(github): configurable quick-action presets and PR branch checkout (#689)
* feat(github): configurable quick-action presets and PR branch checkout

- Add workspace-scoped action presets (icon, label, hint, prompt template) for PRs and Issues, editable from GitHub settings with reset-to-defaults.
- When starting a task from a PR, check out the PR head branch directly in the worktree instead of branching off main.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(github): extract action-preset service to keep service.go under line limit

Splits the preset CRUD methods out of the oversized service.go and applies prettier formatting to three frontend files flagged by CI.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(github): address review feedback on action presets

- Prevent infinite refetch loop when fetching presets fails by tracking attempted workspaces in a ref instead of re-entering the effect on every loading-state change.
- Drop unused savePR/saveIssue helpers from the hook; only save() is consumed.
- Reorder the init spread in updateGitHubActionPresets/resetGitHubActionPresets so callers can't accidentally overwrite method/body.
- Tighten the GitHubActionPreset.icon type with string & {} so known icon keys keep autocomplete.
- Sharpen the eye-icon test to assert the exact IconEye mapping.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(github): address second round of review feedback

- Seed preset editor drafts from current store state via lazy initializers so a warm mount shows the user's saved customisations instead of silently reverting to defaults when Save is clicked.
- Guard Reset button with its own in-flight state to prevent double-firing.
- Stop freezing resolved defaults into the stored row on a partial update; persist only what the store has for the untouched kind so future default improvements still reach those workspaces.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* refactor(github): tighten quick-actions editor UI

Replace the stacked PR/Issue editors and multi-line preset cards with a tabbed layout and single-line rows. Each row shows icon · label · hint inline; an "Edit prompt" toggle reveals the template textarea only when needed. Drops the redundant section headings, up/down reorder buttons, and verbose template helper label (hint moved into the textarea placeholder).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(github): widen icon select trigger so the icon is visible

The icon select trigger had a fixed 40px width which the SelectTrigger's built-in chevron, padding, and icon gap all competed for, clipping the icon out of view. Drop the width override so the trigger sizes to its content.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Kandev Agent <agent@kandev.dev>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-24 14:10:59 +01:00

97 lines
2.7 KiB
Go

package github
import (
"context"
"fmt"
"strings"
"github.com/google/uuid"
)
// GetActionPresets returns the stored preset lists for a workspace, falling
// back to the built-in defaults for any list that hasn't been customised yet.
func (s *Service) GetActionPresets(ctx context.Context, workspaceID string) (*ActionPresets, error) {
stored, err := s.store.GetActionPresets(ctx, workspaceID)
if err != nil {
return nil, err
}
result := &ActionPresets{
WorkspaceID: workspaceID,
PR: DefaultPRActionPresets(),
Issue: DefaultIssueActionPresets(),
}
if stored == nil {
return result, nil
}
if len(stored.PR) > 0 {
result.PR = stored.PR
}
if len(stored.Issue) > 0 {
result.Issue = stored.Issue
}
return result, nil
}
// UpdateActionPresets replaces the PR or Issue preset lists for a workspace.
// Nil request fields leave that list untouched. For any kind not in the
// request, we persist whatever the store currently has (possibly empty)
// rather than the resolved defaults — otherwise future default improvements
// would never reach workspaces that have only customised one side.
func (s *Service) UpdateActionPresets(ctx context.Context, req *UpdateActionPresetsRequest) (*ActionPresets, error) {
if req == nil || req.WorkspaceID == "" {
return nil, fmt.Errorf("workspace_id is required")
}
stored, err := s.store.GetActionPresets(ctx, req.WorkspaceID)
if err != nil {
return nil, err
}
next := &ActionPresets{WorkspaceID: req.WorkspaceID}
if stored != nil {
next.PR = stored.PR
next.Issue = stored.Issue
}
if req.PR != nil {
next.PR = normalisePresets(*req.PR)
}
if req.Issue != nil {
next.Issue = normalisePresets(*req.Issue)
}
if err := s.store.UpsertActionPresets(ctx, next); err != nil {
return nil, err
}
return s.GetActionPresets(ctx, req.WorkspaceID)
}
// ResetActionPresets drops any stored overrides so the defaults apply again.
func (s *Service) ResetActionPresets(ctx context.Context, workspaceID string) (*ActionPresets, error) {
if workspaceID == "" {
return nil, fmt.Errorf("workspace_id is required")
}
if err := s.store.DeleteActionPresets(ctx, workspaceID); err != nil {
return nil, err
}
return s.GetActionPresets(ctx, workspaceID)
}
func normalisePresets(presets []ActionPreset) []ActionPreset {
out := make([]ActionPreset, 0, len(presets))
for _, p := range presets {
id := strings.TrimSpace(p.ID)
label := strings.TrimSpace(p.Label)
if label == "" {
continue
}
if id == "" {
id = uuid.New().String()
}
out = append(out, ActionPreset{
ID: id,
Label: label,
Hint: strings.TrimSpace(p.Hint),
Icon: strings.TrimSpace(p.Icon),
PromptTemplate: p.PromptTemplate,
})
}
return out
}