Files
kandev/docs/plans/mobile-saved-navigation/task-02-consolidate-plugin-navigation.md
T
João Salavisa 9885fd40ba fix(ui): polish mobile navigation and plugins (#3890)
Co-authored-by: Kandev Agent <agent@kandev.dev>
2026-09-23 21:30:36 +01:00

4.6 KiB

id, title, status, wave, depends_on, plan, requirements, acceptance_criteria, system_design
id title status wave depends_on plan requirements acceptance_criteria system_design
02-consolidate-plugin-navigation Consolidate mobile plugin navigation done 2
01-restore-phone-navigation
plan.md
REQ-UI-MOBILE-MENU-007
REQ-UI-SIDEBAR-CUSTOMIZATION-005
AC-UI-MOBILE-MENU-007.2
AC-UI-MOBILE-MENU-007.4
AC-UI-SIDEBAR-CUSTOMIZATION-005.5
../../specs/ui/system-design/unified-mobile-navigation.md
../../specs/ui/system-design/sidebar-customization.md

Task 02: Consolidate mobile plugin navigation

Scope

Combine the plugin grouping and resource placement from PR #3889 with the saved navigation fixes in PR #3890. The user requested one PR, adapted shared components, and new screenshots populated with tasks and installed plugins. The source handoff is b48359592 plus review/CI follow-up e27b2b466.

Acceptance and ASCII UI preview

Menu                         x
Workspace / Home / quick actions
Tasks v                      +
  [populated task rows]
Saved optional tools and plugin destinations
Integrations v
  GitHub / GitLab / Integration settings
Plugins
  Workspace: Project brief / Release notes
  Task: Review checklist
System metrics
Utilities

This saved-layout excerpt covers the criteria above. Default layouts retain their existing destination order. Plugin controls share one section; saved destinations render once. Workspace/task context, the single scroller, 44px phone targets, desktop composition, and metrics preferences remain intact.

Ownership, dependencies, and risks

Work stays in the primary session. Task 01 and the committed peer handoff are the inputs. Reconcile AppNavSheet, AppNavSections, workspace actions, scoped guidance, and the unified navigation design. Plugin-owned controls must retain their context, including the workspace label, without forced square sizing. No plugin SDK, backend, release-flag default, or persistence changes.

Verification

make build-web
(cd apps/web && pnpm e2e:run --no-build --project mobile-chrome tests/settings/mobile-sidebar-customization.spec.ts tests/layout/mobile-menu-hierarchy.spec.ts tests/integrations/mobile-integrations-nav.spec.ts tests/plugins/mobile-plugin-topbar.spec.ts tests/settings/mobile-resource-metrics-display.spec.ts tests/task/mobile-autopilot-mode.spec.ts -- --retries=0)
(cd apps/web && pnpm e2e:run --no-build --project chromium tests/settings/sidebar-customization.spec.ts -- --retries=0)
(cd apps/web && pnpm run typecheck)
python3 scripts/list-docs.py validate
python3 scripts/lint-spec-files.py --all
node scripts/validate-public-docs.mjs
git diff --check

Run the nine focused unit suites from Task 01 plus mobile-plugin-nav-section and main-top-bar-plugin-actions, and focused ESLint/Prettier. Capture from a fresh isolated E2E backend using this PR's production build. Seed four storefront tasks, synthetic GitHub/GitLab identities, and a packaged demonstration plugin with functioning project notes, release notes, and a task review checklist. Enable Canvases only in the disposable capture runtime. Inspect both themes, 320px/393px/767px phones, and a 1280px desktop. Publish media separately from code.

Results

  • Reconciled both committed peer changes while preserving task-first saved layouts, native built-in disclosures, and saved plugin destination ownership.
  • RED/GREEN: moved sidebar controls omitted the workspace label. The grouping test reproduces the omission and now passes with the full context forwarded.
  • 22 combined mobile scenarios passed, including the first saved visibility edit with installed plugins, task controls, metrics preference branches, 320px/767px containment, the 768px boundary, and the autopilot assertion fix.
  • All three desktop sidebar regressions passed after integration.
  • 77 focused unit cases across nine suites pass on the combined implementation. Typecheck, affected lint/formatting, catalog/specification checks, and public documentation validation passed.
  • After two rehearsals, the final capture ran from clean implementation commit 7de0b0f9c with a fresh production build. All nine screenshots were inspected: populated Tasks, integrations, workspace/task plugins, both themes, narrow and wide phones, and desktop. The real plugin checklist was exercised before capture. Temporary runtime data, ports, backend process, and capture spec were removed. Publication and current-head CI/review status are tracked in PR #3890.
  • The peer's intermittent history-recovery scenario passed three fresh diagnostic runs with retries disabled. Each observed the intended two dropped replies. No speculative fixture change is included; final CI remains the delivery gate.