José Almeida
5105ac224c
* feat: add anchored range selection to multi-select reducer * feat: cmd+click and shift+click multi-select on kanban board * feat: add cmd/shift multi-select to sidebar task list * test: e2e coverage for cmd/shift multi-select * fix: harden multi-select selection lifecycle from review feedback * test: scope multi-select e2e helpers to active containers * fix: add sidebar multi-select hook tests and tighten bulk-action lifecycle * fix: prune hidden sidebar selections and order bulk moves by view * test: cover visible-order bulk move and anchor realignment * fix: harden sidebar bulk-move scope and keyboard selection parity * fix: order kanban bulk moves by board position * test: cover multi-select helpers and fix stale-id sort fallback * fix: order kanban card context-menu moves by board position * feat: sidebar multi-select shows only bulk-valid actions with bulk pin and delete * fix: harden multi-select bulk ordering, selection clearing, and a11y * fix: gate kanban card move-to-step for mixed-workflow selections * fix: unpin fully pinned sidebar selections * refactor: keep sidebar task components under limits * test: restore sidebar selection console spy safely
94 lines
3.3 KiB
TypeScript
94 lines
3.3 KiB
TypeScript
import { describe, it, expect } from "vitest";
|
|
import type { TaskSwitcherItem } from "@/components/task/task-switcher";
|
|
import {
|
|
computeMixedWorkflowSelection,
|
|
flattenVisibleTaskIds,
|
|
sortIdsByVisibleOrder,
|
|
type GroupedSidebarList,
|
|
} from "./apply-view";
|
|
|
|
function task(id: string): TaskSwitcherItem {
|
|
return { id, title: id };
|
|
}
|
|
|
|
function grouped(
|
|
groups: GroupedSidebarList["groups"],
|
|
subs: Record<string, TaskSwitcherItem[]> = {},
|
|
): GroupedSidebarList {
|
|
return { groups, subTasksByParentId: new Map(Object.entries(subs)) };
|
|
}
|
|
|
|
describe("flattenVisibleTaskIds", () => {
|
|
it("walks groups then tasks in render order", () => {
|
|
const g = grouped([
|
|
{ key: "g1", label: "G1", tasks: [task("a"), task("b")] },
|
|
{ key: "g2", label: "G2", tasks: [task("c")] },
|
|
]);
|
|
expect(flattenVisibleTaskIds(g, [], [])).toEqual(["a", "b", "c"]);
|
|
});
|
|
|
|
it("expands subtasks depth-first under their parent", () => {
|
|
const g = grouped([{ key: "g1", label: "G1", tasks: [task("a"), task("d")] }], {
|
|
a: [task("a1"), task("a2")],
|
|
});
|
|
expect(flattenVisibleTaskIds(g, [], [])).toEqual(["a", "a1", "a2", "d"]);
|
|
});
|
|
|
|
it("skips tasks in collapsed groups", () => {
|
|
const g = grouped([
|
|
{ key: "g1", label: "G1", tasks: [task("a")] },
|
|
{ key: "g2", label: "G2", tasks: [task("b")] },
|
|
]);
|
|
expect(flattenVisibleTaskIds(g, ["g2"], [])).toEqual(["a"]);
|
|
});
|
|
|
|
it("hides subtasks of a collapsed parent but keeps the parent", () => {
|
|
const g = grouped([{ key: "g1", label: "G1", tasks: [task("a")] }], { a: [task("a1")] });
|
|
expect(flattenVisibleTaskIds(g, [], ["a"])).toEqual(["a"]);
|
|
});
|
|
});
|
|
|
|
describe("sortIdsByVisibleOrder", () => {
|
|
const visible = ["a", "b", "c", "d"];
|
|
|
|
it("reorders a backward range selection into visible order", () => {
|
|
// Anchor 'd' then shift to 'b' leaves the Set as [d, b, c] (insertion order).
|
|
expect(sortIdsByVisibleOrder(["d", "b", "c"], visible)).toEqual(["b", "c", "d"]);
|
|
});
|
|
|
|
it("leaves an already-ordered list unchanged", () => {
|
|
expect(sortIdsByVisibleOrder(["a", "c"], visible)).toEqual(["a", "c"]);
|
|
});
|
|
|
|
it("sorts ids missing from the visible list to the back", () => {
|
|
expect(sortIdsByVisibleOrder(["c", "zzz", "a"], visible)).toEqual(["a", "c", "zzz"]);
|
|
});
|
|
});
|
|
|
|
describe("computeMixedWorkflowSelection", () => {
|
|
const tasks = [
|
|
{ id: "a", workflowId: "wf1" },
|
|
{ id: "b", workflowId: "wf1" },
|
|
{ id: "c", workflowId: "wf2" },
|
|
{ id: "arch" }, // archived placeholder — no workflow
|
|
];
|
|
|
|
it("treats a single-workflow selection as not mixed and all movable", () => {
|
|
const r = computeMixedWorkflowSelection(tasks, new Set(["a", "b"]));
|
|
expect(r.isMixedWorkflowSelection).toBe(false);
|
|
expect(r.movableSelectedIds).toEqual(new Set(["a", "b"]));
|
|
});
|
|
|
|
it("flags a selection spanning two workflows as mixed", () => {
|
|
const r = computeMixedWorkflowSelection(tasks, new Set(["a", "c"]));
|
|
expect(r.isMixedWorkflowSelection).toBe(true);
|
|
expect(r.movableSelectedIds).toEqual(new Set(["a", "c"]));
|
|
});
|
|
|
|
it("flags a workflow-less selected row as mixed and excludes it from movable", () => {
|
|
const r = computeMixedWorkflowSelection(tasks, new Set(["a", "arch"]));
|
|
expect(r.isMixedWorkflowSelection).toBe(true);
|
|
expect(r.movableSelectedIds).toEqual(new Set(["a"]));
|
|
});
|
|
});
|