João Salavisa
57adf1449c
* feat(review): persist and publish native code-review findings Adds the backend core for reviewing a task's working diff before a PR exists: task-scoped review runs and anchored, advisory findings that the Changes/Review panel can render as inline comments. - task_review_runs / task_review_findings schema, models, and repository, with supersede-on-re-review and a restart sweep that cancels in-flight runs rather than leaving them looking alive. - ReviewService as the single write path, publishing bus events that the WS gateway forwards to the client. - internal/review: reviewer-identity resolution (agent profile > code-review utility agent > user default, failing closed on passthrough-only profiles), change-set collection, prompt batching, response parsing, anchor extraction, and run orchestration. - publish_review_findings_kandev MCP tool plus the task.review.* WS actions. - Go djb2 that matches apps/web/lib/utils/hash.ts, asserted from shared fixtures on both sides so stale detection agrees across the wire. Spec: docs/specs/native-code-review/spec.md Plan: docs/plans/native-code-review/plan.md Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(review): add run_code_review workflow step and wire the review runner Makes a review pass triggerable both ways and actually runnable end to end. - run_code_review on_enter action across models, engine compile, and an orchestrator callback that logs rather than propagates failures, so a task never gets stuck in a step because no reviewer was configured. - The step's optional agent_profile_id is what lets a step review with a different model than it implemented with; export/import swap it for a portable agent name/model/mode so it survives a cross-workspace round trip instead of carrying a dangling id. - Concrete adapters for reviewer identity, changed-file collection, prompt rendering from the code-review utility agent's editable prompt, and inference (session-bound agentctl, falling back to the host instance so a review works on a task whose agent is not running). - Boot sweep cancels review runs interrupted by a restart; the E2E reset clears review state before deleting the tasks that own it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(web): add review findings state, helpers, and live updates Frontend plumbing for native code review, ahead of the UI that renders it. - Review types, WS message map, and an API client that preserves the backend's machine-readable failure code so the surface can show an actionable message. - A review store slice that merges findings by id (a re-publish refreshes an issue rather than listing it twice) and keeps a bounded run history. - Findings helpers: composite file keys matching reviewFileKey, staleness via the same per-file diff hash that drives review marks, and best-effort re-anchoring from the stored anchor text so a moved finding follows the code it was written about instead of pointing at whatever now occupies its line. - Hooks for backfill, resolve/dismiss/reopen with optimistic rollback, and sending a finding to the agent as follow-up context without changing its status — handing a finding to an agent is not the human accepting it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(web): render review findings inline in the Changes diff Findings now appear where the code is, in the same annotation surface as anchored review comments, with the run control that produces them. - ReviewFindingCard: severity chip, category, Markdown body, and the three advisory actions. A suggestion is labelled "not applied automatically" because it is display-only in this iteration. Resolved and dismissed findings collapse to one muted line with an Undo, so a reviewed diff does not stay cluttered while the human can still change their mind. - A review-finding annotation type threaded through the diff viewer, anchored from the same per-file diff hash the backend stamped. A finding whose diff moved is re-anchored from its stored text when that text survives, and otherwise reported as unanchored rather than placed against unrelated code. - Review changes control with idle / running / cancel / failed states, and an inline Settings link for the one failure the user can actually fix. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(web): make the review control reachable from the Review toolbar Mounts the Review changes control next to the walkthrough action and lets an inline finding wire its own actions. The finding card container now reads the active task and session from the store instead of taking four callbacks threaded through FileDiffViewer and DiffViewer; an inline finding annotation only exists when the active task has findings, so the store is always present and every other diff consumer is spared the plumbing. Staleness likewise hashes the diff the viewer already holds, which is already normalized, so it matches the hash the backend stamped without passing it down. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(web): surface stale review findings above their file's diff A finding whose diff moved and whose anchor text is gone had nowhere to render, so it was silently dropped. It now appears in a collapsed per-file banner above the diff: the finding may still be valid, and placing it at its stored line would point at whatever code now occupies that line instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * docs(review): mark the landed native code-review plan tasks done Tasks 01-09 (backend persistence through inline diff rendering) are implemented, tested, and committed. Tasks 10-13 — findings overview and step editor, mobile parity, E2E, and public docs — remain pending. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * test(review): cover the on-demand review path end to end Adds the mock-agent review responder and a Playwright spec, so both the happy path and the no-reviewer path are verified against a real backend. The mock agent answers any prompt carrying the review sentinel with fenced JSON, deriving its anchors from the prompt's own diff rather than hardcoding them, so findings land on files and lines the fixture really changed. It includes one deliberately malformed entry to exercise the rejected-entry path. Writing it caught an off-by-one shared by three diff walkers: splitting on "\n" leaves an empty element after a trailing newline, which carries no diff marker and was being counted as a context line, pushing new-side numbering one past the end of a hunk. Interior blank lines still count, since a whitespace-stripped blank context line legitimately appears as "". Also adds a listInferenceAgents helper: default_utility_agent_id needs the registered agent-type id, and an agent row UUID is rejected as not inference-capable. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(review): close review-run races and stale client findings Addresses the three blockers and three suggestions from the PR #1957 automated reviews. Two independent reviewers found each blocker separately. - Launch claimed the task slot only after inserting the run row, so two concurrent launches both created a run and the loser returned a pending row with no goroutine behind it — a review that never finished until the next restart. The slot is now claimed before any DB write, and freed on every early return. - Cancelling only marked the row. The goroutine ran on the shared background context, finished inference, and its completion overwrote the cancelled status and published findings the user had declined. Runs now carry a cancel handle, the WS action routes through the runner so the live context is cancelled, CompleteRun/FailRun refuse to resurrect a terminal run, and a cancelled pass neither publishes nor re-reports itself as failed. - The backend deletes a superseded finding and inserts a replacement with a new id, but the publish event carried only the new one, so every open browser showed both at the same anchor until a reload. The event now names the superseded ids and the slice drops them. - Run() waited on the shared WaitGroup, blocking on every other task's review; it now waits on its own pass only. - createReviewSlice is typed over the `set` it actually uses, so call sites no longer pass superfluous arguments (CodeQL js/superfluous-trailing-arguments). - A GetAgentProfile fault no longer collapses into "profile not found", which would have told the user to configure an agent they already have. The cancel bug exposed a hole in the original tests: they asserted cancel could not override a terminal run, but never the reverse. Both directions are covered now, along with the concurrent-launch race, per-run waiting, and the supersede path on both sides of the wire. Test fakes now mirror the service's terminal guard rather than hiding it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
8.6 KiB
8.6 KiB
Feature Specs
Specs for kandev product features, grouped by umbrella. Each spec describes a user-invocable capability and is the source of truth for "is this feature done?"
The bar: an agent given only a spec (no source code) should be able to either reimplement the feature or test the existing system for conformance. See .agents/skills/spec/SKILL.md for the workflow and template.
Status: draft (being written) · building (in active development) · shipped (implemented, spec matches code) · archived (deprecated).
needs-upgrade in a spec's frontmatter flags template sections that the original sources did not cover and should be filled in from code (Data model, API surface, State machine, Permissions, Failure modes, Persistence guarantees). All office specs have been brought to the implementability bar; this flag is only used for newly-drafted specs that need a code-driven fill-in pass.
office/ — autonomous agent management
The office umbrella covers kandev's autonomous-agent product surface: workspaces of long-running agents that pick up tasks, coordinate via handoffs, and report through a dashboard.
| Spec | Status |
|---|---|
| overview | draft |
| agents | draft |
| tasks | draft |
| scheduler | draft |
| runtime | draft |
| routing | draft |
| costs | in-progress |
| dashboard | draft |
| live-updates | draft |
| inbox | draft |
| assistant | draft |
| automations-settings | draft |
| testing | shipped |
platform/ — cross-cutting capabilities
Product-wide capabilities that are not tied to a single feature area.
| Spec | Status |
|---|---|
| background-work-liveness | shipped |
| plugins | draft |
| plugins — marketplace | building |
| semantic-notifications | shipped |
| workspace-git-status | shipped |
tasks/ — task & workflow model
Kandev's task model: documents, execution stages, labels, blocker escalation, subtask checklists, subtree controls, and the unification with the workflow engine.
| Spec | Status |
|---|---|
| documents | shipped |
| execution-stages | shipped |
| labels | shipped |
| model-unification | draft |
| without-repositories | draft |
| attach-workspace-sources | building |
| subtask-checklist | shipped |
| subtask-detachment | shipped |
| subtask-completion-trigger | draft |
| subtree-controls | shipped |
| blocked-task-escalation | draft |
| runtime-cleanup | draft |
| archive-confirmation | shipped |
| link-existing-task-github-issue | building |
| wip-limit-pull-system | building |
| multi-branch | shipped |
| quick-chat-sessions | shipped |
| quick-chat-repository-context | shipped |
| parent-child-message-interrupt | shipped |
| parent-child-task-stop | shipped |
| mcp-task-agent-profile-default | shipped |
| explicit-completion-signal | shipped |
agents/ — agent governance
Roles, governance gates, and granular permissions that apply across human users and office agents.
| Spec | Status |
|---|---|
| roles | shipped |
| governance | shipped |
| granular-permissions | draft |
integrations/ — external service integrations
Per-workspace credentials and triage triggers for external services.
| Spec | Status |
|---|---|
| azure-devops-integration | shipped |
| slack | shipped |
| external-mcp | draft |
| github-authentication | draft |
| gitlab-integration | shipped |
| jira-status-filter | shipped |
workspaces/ — workspace lifecycle
| Spec | Status |
|---|---|
| creation | building |
| deletion | shipped |
| local-repositories | shipped |
costs/ — cost tracking & budgets
Subscription quota tracking and per-agent cheap-model profile routing.
| Spec | Status |
|---|---|
| subscription-usage | draft |
| cheap-model-profiles | shipped |
ui/ — cross-cutting UI features
| Spec | Status |
|---|---|
| ci-pr-automation | draft |
| github-pr-review-actions | shipped |
| comment-markdown | shipped |
| empty-turn-notice | shipped |
| acp-shell-command-output | shipped |
| acp-model-configuration-summary | shipped |
| review-file-status | building |
| sidebar-view-creation | shipped |
| slash-command-composer | shipped |
| entity-reference-composer | draft |
| settings-manual-save | shipped |
| app-status-bar | draft |
| mobile-task-navigation | shipped |
| task-layout-profiles | draft |
| agent-message-comments | shipped |
| external-vcs-file-links | shipped |
| task-listing-display-preferences | shipped |
system-page/ — operational diagnostics & maintenance UI
System pages (Radarr/Sonarr-style) for status, disk usage, database maintenance, backups, logs, updates, OSS licenses, and about.
| Spec | Status |
|---|---|
| system-page | draft |
| storage-maintenance | building |
| feature-toggles | draft |
Standalone
| Spec | Status |
|---|---|
| auth | building |
| create-local-repository | shipped |
| workflow-cycle-guardrails | building |
| improve-kandev | draft |
| homebrew-core | draft |
| native-kandev-cli | draft |
| desktop-tauri-app | shipped |
| public-share-links | draft |
| ssh-executor | draft |
| cli-mode-parity | draft |
| workflow-settings-autosave | archived; superseded by settings-manual-save |
| mobile-quick-chat-topbar | building |
| native-code-review | building |
Conventions
- Spec layout. Umbrella specs live as flat
.mdfiles under the umbrella directory (docs/specs/office/agents.md). Standalone specs use a folder (docs/specs/improve-kandev/spec.md). - Plans are not specs. Implementation plans are committed under
docs/plans/<feature>/with individual sibling task files namedtask-<NN>-<short-slug>.md. Specs are the durable requirements; plans and task files are implementation records for the current buildout. - Bug fixes are not specs. Bugs produce a regression test plus an ADR if they encoded a new convention. See
/fixskill. - Architecture decisions are not specs. ADRs live under
docs/decisions/. See/record decision.
Cross-references
- ADRs:
../decisions/INDEX.md - Spec workflow:
.agents/skills/spec/SKILL.md - Bug-fix workflow:
.agents/skills/fix/SKILL.md