2.0 KiB
2.0 KiB
id, title, status, wave, depends_on, plan, spec
| id | title | status | wave | depends_on | plan | spec | |
|---|---|---|---|---|---|---|---|
| 02-agentctl-shell-process-environment | Agentctl shell and process environment | done | 2 |
|
plan.md | ../../specs/integrations/requirements/github-authentication.md |
Task 02: Agentctl Shell and Process Environment
Acceptance
- The legacy agentctl shell, per-terminal agentctl shells, and task-scoped command processes
inherit the instance
AgentEnvbefore explicit call-site environment overrides. - Managed Git configuration and shim-first
PATHremain intact as one effective environment; explicit per-call values retain their established precedence. - Process startup reports an error before execution if managed environment preparation fails and
never falls back to an ambient Git helper or
ghlogin.
Verification
cd apps/backend && rtk go test ./internal/agentctl/server/process -run 'Test(StartShell|StartTerminalShell|StartProcess).*AgentEnvironment' -count=1
Files likely touched
apps/backend/internal/agentctl/server/process/manager.goapps/backend/internal/agentctl/server/process/runner.goapps/backend/internal/agentctl/server/process/interactive_shells.goapps/backend/internal/agentctl/server/process/runner_shells_test.goapps/backend/internal/agentctl/server/process/runner_test.go
Dependencies
Task 01 establishes the canonical runtime environment boundary and its credential-safety tests.
Parallelism
Sequential.
Inputs
- Spec:
docs/specs/integrations/requirements/github-authentication.md— What, Failure Modes, Scenarios. - Plan: Agentctl shell and command launch section.
- Existing patterns:
mergeAgentEnvIntoShellConfig,buildShellEnv,mergeEnvWithStrip, andgitEnvironment.
Output contract
Report precedence behavior, files changed, focused test output, and any need to revise the security contract. Explicit request values retain precedence over inherited instance values; focused and package-level process tests pass.