e145d48f22
* feat: add plugin system with grpc runtime and native ui plugins - go plugin backends ship as release tarballs (per-platform binaries, checksums) that kandev installs from url/upload or filesystem sideload+sync, then spawns and supervises via hashicorp/go-plugin (unix socket / loopback tcp+automtls) - strict typed grpc contract (kandev.plugin.v1): DeliverEvent/InvokeTool/HandleWebhook plus a capability-gated host service (state, secrets, emit); author sdk in pkg/pluginsdk; packaging cli in cmd/plugin-pack - native frontend bundles: window.registerKandevPlugin + registry/host loader with dynamic routes, nav items, slots and ws handlers; plugins settings page with install dialog, sync button and enable/disable/uninstall - gated behind the plugins feature flag (prod off, dev/e2e on); covered by unit and integration tests plus playwright e2e against a real packaged fixture plugin Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): hydrate base app context on plugin routes Plugin-owned SPA routes classify as RouteUnknown, so the boot payload shipped only feature flags — no workspaces, workflows, or kanban context. Native plugin UI (e.g. host.ui.TaskCreateDialog) then had an empty store. Hydrate the same base context as the Home route for unknown SPA routes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(plugins): expose TaskCreateDialog on host.ui Lets a native plugin open kandev's real create-task modal (prefilled via initialValues) instead of POSTing directly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): harden filesystem/URL sinks against CodeQL findings Add sink-level guards on the plugin trust boundary: securejoin containment on archive extraction (zip-slip), plugin-id validation before every fs_store path, http/https scheme validation on install-from-URL, and non-interpolated ws-handler error logging. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address review findings (races, resource caps, lifecycle) - serialize per-plugin startup to close a TOCTOU double-spawn race, and let a plugin restart after exhausting attempts - bound plugin startup with an explicit 30s timeout - reject backslash paths and cap decompressed bytes by actual size in pkgtar; only mark a package Signed when a verifier actually ran and passed - delete plugin_state on uninstall; validate webhook keys against the manifest and cap webhook body size; restart an active plugin when a new version installs Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): sanitize plugin-id path sinks for CodeQL Pin the plugin id to a single path segment with filepath.Base at recordPath/ configPath and pkgtar.Remove — a barrier the taint analysis recognizes. Behaviour-identical for valid ids (already validated by safePluginID); clears the go/path-injection alerts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): inline plugin-id validation at path sinks for CodeQL filepath.Base does not strip '..', so it is not a path-injection barrier. Call the recognized safePluginID / id-pattern guard inline in Delete/GetConfig/ SetConfig and pkgtar.Remove — the same barrier that already cleared the Get sink. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address code-review findings (backend) - add capability-gating tests for the Host RPC service (was untested) - close a stop-during-start orphan race so Disable/Uninstall can't leave a supervised subprocess behind - on failed upgrade, remove only the new version dir (not all versions + data); restart the prior version - validate manifest version and reject ids ending in .config (record-file alias) - make Deliverer.Refresh non-blocking and cancel in-flight delivery on worker stop - clamp out-of-range webhook status, skip-and-warn corrupt records in List, write records atomically, semver-aware sideload version pick Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address code-review findings (frontend) - wrap plugin routes + settings routes in a shared PluginErrorBoundary so a throwing plugin page shows a fallback instead of white-screening the SPA - fix disable/re-enable in one session: keep the cached registration and re-run initialize instead of relying on a cached ES-module re-import - prefix root-relative bundle/style URLs with apiBaseUrl (split-origin/Tauri) - surface partial-install warnings via toast.warning instead of a bare success - dedupe/remove injected style links on unload; gate PluginNavItems on the flag Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): serialize per-plugin lifecycle + guard config writes - add a per-plugin keyed lock in Service so concurrent Enable/Disable/Install/ Uninstall/UpdateConfig for one id are serialized (no status-machine race) - take s.mu in SetConfig/GetConfig and write config atomically - bound each plugin initialize() with a timeout so one hung bundle can't stall the rest of the boot load Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(plugins): split service_test.go to satisfy file-length lint Move the install/URL test group into service_install_test.go; no logic change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * ci: build and ship the e2e fixture plugin package to E2E shards The plugin E2E specs' global-setup requires apps/backend/.build/kandev-plugin-e2e-1.0.0.tar.gz. Build it in the E2E build job, upload it as an artifact, and download it in both the regular and container shard jobs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
244 lines
8.9 KiB
TypeScript
244 lines
8.9 KiB
TypeScript
import { cleanup, fireEvent, render, screen } from "@testing-library/react";
|
|
import type { ReactNode } from "react";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
|
|
const MAIN_WORKSPACE_ID = "ws-1";
|
|
const ARCHIVE_WORKSPACE_ID = "ws-10";
|
|
const MAIN_WORKSPACE_NAME = "Main Workspace";
|
|
const ARCHIVE_WORKSPACE_NAME = "Archive Workspace";
|
|
|
|
const state = {
|
|
workspaces: {
|
|
activeId: MAIN_WORKSPACE_ID,
|
|
items: [{ id: MAIN_WORKSPACE_ID, name: MAIN_WORKSPACE_NAME }],
|
|
},
|
|
setActiveWorkspace: vi.fn(),
|
|
settingsAgents: {
|
|
items: [],
|
|
},
|
|
executors: {
|
|
items: [],
|
|
},
|
|
features: {
|
|
office: false,
|
|
plugins: false,
|
|
},
|
|
};
|
|
|
|
vi.mock("@/components/state-provider", () => ({
|
|
useAppStore: (selector: (s: typeof state) => unknown) => selector(state),
|
|
}));
|
|
|
|
vi.mock("@/hooks/domains/settings/use-available-agents", () => ({
|
|
useAvailableAgents: () => undefined,
|
|
}));
|
|
|
|
vi.mock("@kandev/ui/collapsible", async () => {
|
|
const React = await vi.importActual<typeof import("react")>("react");
|
|
const CollapsibleContext = React.createContext(false);
|
|
return {
|
|
Collapsible: ({ open, children }: { open?: boolean; children: ReactNode }) =>
|
|
React.createElement(CollapsibleContext.Provider, { value: Boolean(open) }, children),
|
|
CollapsibleContent: ({ children, className }: { children: ReactNode; className?: string }) => {
|
|
const open = React.useContext(CollapsibleContext);
|
|
return open ? React.createElement("div", { className }, children) : null;
|
|
},
|
|
};
|
|
});
|
|
|
|
import { SettingsTree } from "./settings-tree";
|
|
import { WorkspacesGroup } from "./workspaces-group";
|
|
|
|
describe("SettingsTree rendering", () => {
|
|
beforeEach(() => {
|
|
state.workspaces.activeId = MAIN_WORKSPACE_ID;
|
|
state.workspaces.items = [{ id: MAIN_WORKSPACE_ID, name: MAIN_WORKSPACE_NAME }];
|
|
state.setActiveWorkspace.mockClear();
|
|
state.settingsAgents.items = [];
|
|
state.executors.items = [];
|
|
});
|
|
|
|
afterEach(() => cleanup());
|
|
|
|
it("renders workspace repository and workflow links when Workspaces is open", () => {
|
|
render(<WorkspacesGroup pathname="/settings/workspace" expanded />);
|
|
|
|
expect(screen.getByRole("link", { name: "Repositories" }).getAttribute("href")).toBe(
|
|
"/settings/workspace/ws-1/repositories",
|
|
);
|
|
expect(screen.getByRole("link", { name: "Workflows" }).getAttribute("href")).toBe(
|
|
"/settings/workspace/ws-1/workflows",
|
|
);
|
|
expect(screen.getByRole("link", { name: "Automations" }).getAttribute("href")).toBe(
|
|
"/settings/workspace/ws-1/automations",
|
|
);
|
|
expect(screen.getByRole("link", { name: "Integrations" }).getAttribute("href")).toBe(
|
|
"/settings/workspace/ws-1/integrations",
|
|
);
|
|
});
|
|
|
|
it("opens the active workspace by default when the settings tree opens", () => {
|
|
state.workspaces.items = [
|
|
{ id: MAIN_WORKSPACE_ID, name: MAIN_WORKSPACE_NAME },
|
|
{ id: ARCHIVE_WORKSPACE_ID, name: ARCHIVE_WORKSPACE_NAME },
|
|
];
|
|
|
|
render(<SettingsTree pathname="/settings" />);
|
|
|
|
expect(screen.getByRole("link", { name: `${MAIN_WORKSPACE_NAME} Active` })).toBeTruthy();
|
|
expect(screen.getByRole("link", { name: ARCHIVE_WORKSPACE_NAME })).toBeTruthy();
|
|
expect(screen.queryByText("[active]")).toBeNull();
|
|
expect(screen.getByRole("link", { name: "Repositories" }).getAttribute("href")).toBe(
|
|
"/settings/workspace/ws-1/repositories",
|
|
);
|
|
expect(screen.getByRole("link", { name: "Automations" }).getAttribute("href")).toBe(
|
|
"/settings/workspace/ws-1/automations",
|
|
);
|
|
});
|
|
|
|
it("uses an accordion for workspace subsections", () => {
|
|
state.workspaces.items = [
|
|
{ id: MAIN_WORKSPACE_ID, name: MAIN_WORKSPACE_NAME },
|
|
{ id: ARCHIVE_WORKSPACE_ID, name: ARCHIVE_WORKSPACE_NAME },
|
|
];
|
|
|
|
render(<WorkspacesGroup pathname="/settings" expanded />);
|
|
|
|
expect(screen.getByRole("link", { name: "Repositories" }).getAttribute("href")).toBe(
|
|
"/settings/workspace/ws-1/repositories",
|
|
);
|
|
|
|
fireEvent.click(screen.getByRole("button", { name: "Expand Archive Workspace" }));
|
|
|
|
expect(screen.getByRole("button", { name: "Expand Main Workspace" })).toBeTruthy();
|
|
expect(screen.getByRole("link", { name: "Repositories" }).getAttribute("href")).toBe(
|
|
"/settings/workspace/ws-10/repositories",
|
|
);
|
|
});
|
|
|
|
it("only opens the routed workspace subsection on workspace detail routes", () => {
|
|
state.workspaces.items = [
|
|
{ id: MAIN_WORKSPACE_ID, name: MAIN_WORKSPACE_NAME },
|
|
{ id: ARCHIVE_WORKSPACE_ID, name: ARCHIVE_WORKSPACE_NAME },
|
|
];
|
|
|
|
const { rerender } = render(<WorkspacesGroup pathname="/settings/workspace" expanded />);
|
|
|
|
expect(screen.getAllByRole("link", { name: "Repositories" })).toHaveLength(1);
|
|
|
|
rerender(<WorkspacesGroup pathname="/settings/workspace/ws-10/repositories" expanded />);
|
|
|
|
expect(
|
|
screen.getByRole("link", { name: `${MAIN_WORKSPACE_NAME} Active` }).getAttribute("href"),
|
|
).toBe("/settings/workspace/ws-1");
|
|
const repositoryLinks = screen.getAllByRole("link", { name: "Repositories" });
|
|
const workflowLinks = screen.getAllByRole("link", { name: "Workflows" });
|
|
|
|
expect(repositoryLinks).toHaveLength(1);
|
|
expect(workflowLinks).toHaveLength(1);
|
|
expect(repositoryLinks[0].getAttribute("href")).toBe("/settings/workspace/ws-10/repositories");
|
|
expect(workflowLinks[0].getAttribute("href")).toBe("/settings/workspace/ws-10/workflows");
|
|
expect(screen.getByRole("link", { name: ARCHIVE_WORKSPACE_NAME }).getAttribute("href")).toBe(
|
|
"/settings/workspace/ws-10",
|
|
);
|
|
});
|
|
|
|
it("opens workspace integrations when a workspace integration route is active", () => {
|
|
state.workspaces.items = [
|
|
{ id: MAIN_WORKSPACE_ID, name: MAIN_WORKSPACE_NAME },
|
|
{ id: ARCHIVE_WORKSPACE_ID, name: ARCHIVE_WORKSPACE_NAME },
|
|
];
|
|
|
|
render(<WorkspacesGroup pathname="/settings/workspace/ws-10/integrations/github" expanded />);
|
|
|
|
expect(screen.getByRole("link", { name: "GitHub" }).getAttribute("href")).toBe(
|
|
"/settings/workspace/ws-10/integrations/github",
|
|
);
|
|
expect(screen.getByRole("button", { name: "Expand Main Workspace" })).toBeTruthy();
|
|
});
|
|
|
|
it("keeps Voice Mode in the settings tree as a standalone active leaf", () => {
|
|
render(<SettingsTree pathname="/settings" />);
|
|
|
|
expect(screen.getByRole("link", { name: "Voice Mode" }).getAttribute("href")).toBe(
|
|
"/settings/voice-mode",
|
|
);
|
|
|
|
cleanup();
|
|
|
|
render(<SettingsTree pathname="/settings/voice-mode" />);
|
|
|
|
expect(screen.getByRole("link", { name: "Voice Mode" }).className).toContain(
|
|
"before:bg-primary",
|
|
);
|
|
expect(screen.queryByRole("link", { name: "Appearance" })).toBeNull();
|
|
});
|
|
});
|
|
|
|
describe("WorkspacesGroup active workspace presentation", () => {
|
|
beforeEach(() => {
|
|
state.workspaces.activeId = MAIN_WORKSPACE_ID;
|
|
state.workspaces.items = [
|
|
{ id: ARCHIVE_WORKSPACE_ID, name: ARCHIVE_WORKSPACE_NAME },
|
|
{ id: MAIN_WORKSPACE_ID, name: MAIN_WORKSPACE_NAME },
|
|
];
|
|
state.setActiveWorkspace.mockClear();
|
|
});
|
|
|
|
afterEach(() => cleanup());
|
|
|
|
it("keeps the active workspace first even when the API returns it later", () => {
|
|
render(<WorkspacesGroup pathname="/settings" expanded />);
|
|
|
|
const workspaceLinks = getWorkspaceRootLinks();
|
|
|
|
expect(workspaceLinks.map((link) => link.textContent)).toEqual([
|
|
`${MAIN_WORKSPACE_NAME}Active`,
|
|
ARCHIVE_WORKSPACE_NAME,
|
|
]);
|
|
});
|
|
|
|
it("expands another workspace without changing the active workspace", () => {
|
|
render(<WorkspacesGroup pathname="/settings" expanded />);
|
|
|
|
fireEvent.click(screen.getByRole("button", { name: "Expand Archive Workspace" }));
|
|
|
|
expect(state.setActiveWorkspace).not.toHaveBeenCalled();
|
|
expect(getWorkspaceRootLinks()[0].textContent).toBe(`${MAIN_WORKSPACE_NAME}Active`);
|
|
expect(screen.getByRole("link", { name: `${MAIN_WORKSPACE_NAME} Active` })).toBeTruthy();
|
|
});
|
|
});
|
|
|
|
describe("WorkspacesGroup integration route sync", () => {
|
|
beforeEach(() => {
|
|
state.workspaces.activeId = MAIN_WORKSPACE_ID;
|
|
state.workspaces.items = [
|
|
{ id: MAIN_WORKSPACE_ID, name: MAIN_WORKSPACE_NAME },
|
|
{ id: ARCHIVE_WORKSPACE_ID, name: ARCHIVE_WORKSPACE_NAME },
|
|
];
|
|
});
|
|
|
|
afterEach(() => cleanup());
|
|
|
|
it("opens workspace integrations after navigating into an integration route", async () => {
|
|
const { rerender } = render(
|
|
<WorkspacesGroup pathname="/settings/workspace/ws-10/repositories" expanded />,
|
|
);
|
|
|
|
expect(screen.queryByRole("link", { name: "GitHub" })).toBeNull();
|
|
|
|
rerender(<WorkspacesGroup pathname="/settings/workspace/ws-10/integrations/github" expanded />);
|
|
|
|
expect((await screen.findByRole("link", { name: "GitHub" })).getAttribute("href")).toBe(
|
|
"/settings/workspace/ws-10/integrations/github",
|
|
);
|
|
});
|
|
});
|
|
|
|
function getWorkspaceRootLinks(): HTMLAnchorElement[] {
|
|
return screen.getAllByRole("link").filter((link): link is HTMLAnchorElement => {
|
|
const href = link.getAttribute("href");
|
|
return Boolean(href?.match(/^\/settings\/workspace\/[^/]+$/));
|
|
});
|
|
}
|