e145d48f22
* feat: add plugin system with grpc runtime and native ui plugins - go plugin backends ship as release tarballs (per-platform binaries, checksums) that kandev installs from url/upload or filesystem sideload+sync, then spawns and supervises via hashicorp/go-plugin (unix socket / loopback tcp+automtls) - strict typed grpc contract (kandev.plugin.v1): DeliverEvent/InvokeTool/HandleWebhook plus a capability-gated host service (state, secrets, emit); author sdk in pkg/pluginsdk; packaging cli in cmd/plugin-pack - native frontend bundles: window.registerKandevPlugin + registry/host loader with dynamic routes, nav items, slots and ws handlers; plugins settings page with install dialog, sync button and enable/disable/uninstall - gated behind the plugins feature flag (prod off, dev/e2e on); covered by unit and integration tests plus playwright e2e against a real packaged fixture plugin Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): hydrate base app context on plugin routes Plugin-owned SPA routes classify as RouteUnknown, so the boot payload shipped only feature flags — no workspaces, workflows, or kanban context. Native plugin UI (e.g. host.ui.TaskCreateDialog) then had an empty store. Hydrate the same base context as the Home route for unknown SPA routes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(plugins): expose TaskCreateDialog on host.ui Lets a native plugin open kandev's real create-task modal (prefilled via initialValues) instead of POSTing directly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): harden filesystem/URL sinks against CodeQL findings Add sink-level guards on the plugin trust boundary: securejoin containment on archive extraction (zip-slip), plugin-id validation before every fs_store path, http/https scheme validation on install-from-URL, and non-interpolated ws-handler error logging. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address review findings (races, resource caps, lifecycle) - serialize per-plugin startup to close a TOCTOU double-spawn race, and let a plugin restart after exhausting attempts - bound plugin startup with an explicit 30s timeout - reject backslash paths and cap decompressed bytes by actual size in pkgtar; only mark a package Signed when a verifier actually ran and passed - delete plugin_state on uninstall; validate webhook keys against the manifest and cap webhook body size; restart an active plugin when a new version installs Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): sanitize plugin-id path sinks for CodeQL Pin the plugin id to a single path segment with filepath.Base at recordPath/ configPath and pkgtar.Remove — a barrier the taint analysis recognizes. Behaviour-identical for valid ids (already validated by safePluginID); clears the go/path-injection alerts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): inline plugin-id validation at path sinks for CodeQL filepath.Base does not strip '..', so it is not a path-injection barrier. Call the recognized safePluginID / id-pattern guard inline in Delete/GetConfig/ SetConfig and pkgtar.Remove — the same barrier that already cleared the Get sink. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address code-review findings (backend) - add capability-gating tests for the Host RPC service (was untested) - close a stop-during-start orphan race so Disable/Uninstall can't leave a supervised subprocess behind - on failed upgrade, remove only the new version dir (not all versions + data); restart the prior version - validate manifest version and reject ids ending in .config (record-file alias) - make Deliverer.Refresh non-blocking and cancel in-flight delivery on worker stop - clamp out-of-range webhook status, skip-and-warn corrupt records in List, write records atomically, semver-aware sideload version pick Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address code-review findings (frontend) - wrap plugin routes + settings routes in a shared PluginErrorBoundary so a throwing plugin page shows a fallback instead of white-screening the SPA - fix disable/re-enable in one session: keep the cached registration and re-run initialize instead of relying on a cached ES-module re-import - prefix root-relative bundle/style URLs with apiBaseUrl (split-origin/Tauri) - surface partial-install warnings via toast.warning instead of a bare success - dedupe/remove injected style links on unload; gate PluginNavItems on the flag Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): serialize per-plugin lifecycle + guard config writes - add a per-plugin keyed lock in Service so concurrent Enable/Disable/Install/ Uninstall/UpdateConfig for one id are serialized (no status-machine race) - take s.mu in SetConfig/GetConfig and write config atomically - bound each plugin initialize() with a timeout so one hung bundle can't stall the rest of the boot load Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(plugins): split service_test.go to satisfy file-length lint Move the install/URL test group into service_install_test.go; no logic change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * ci: build and ship the e2e fixture plugin package to E2E shards The plugin E2E specs' global-setup requires apps/backend/.build/kandev-plugin-e2e-1.0.0.tar.gz. Build it in the E2E build job, upload it as an artifact, and download it in both the regular and container shard jobs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
86 lines
3.1 KiB
Go
86 lines
3.1 KiB
Go
package pluginsdk
|
|
|
|
import (
|
|
"context"
|
|
"sync"
|
|
)
|
|
|
|
// Plugin is the interface a plugin author implements. It is delivered RPCs
|
|
// from kandev over the go-plugin gRPC transport (§3 of
|
|
// docs/plans/plugins/GRPC-CONTRACT.md): DeliverEvent -> OnEvent, InvokeTool
|
|
// -> InvokeTool, HandleWebhook -> HandleWebhook.
|
|
type Plugin interface {
|
|
// OnEvent handles a single bus event delivery. A non-nil error causes
|
|
// kandev's delivery subsystem to retry per §5 (3 retries, 5s/15s/45s).
|
|
OnEvent(ctx context.Context, e *Event) error
|
|
|
|
// InvokeTool handles a tool call routed to this plugin.
|
|
InvokeTool(ctx context.Context, req *ToolRequest) (*ToolResponse, error)
|
|
|
|
// HandleWebhook handles an inbound webhook relayed by kandev's
|
|
// POST /api/plugins/{id}/webhooks/{key} endpoint.
|
|
HandleWebhook(ctx context.Context, req *WebhookRequest) (*WebhookResponse, error)
|
|
}
|
|
|
|
// HostSetter is implemented by Plugin values that want Serve to inject the
|
|
// Host once the broker connection back to kandev is established (see the
|
|
// "Host injection" section of the serve.go file header). UnimplementedPlugin
|
|
// implements this, so embedding it is the easiest way to opt in.
|
|
type HostSetter interface {
|
|
SetHost(Host)
|
|
}
|
|
|
|
// UnimplementedPlugin is an embeddable no-op base for Plugin. Authors that
|
|
// only care about one or two RPCs embed this and override the rest. It also
|
|
// implements HostSetter, storing the injected Host for retrieval via Host().
|
|
//
|
|
// SetHost is called from a background goroutine (see the GRPCPlugin doc
|
|
// comment in serve.go for why), so access to the stored Host is
|
|
// mutex-guarded — Host() may be called concurrently with SetHost from
|
|
// another goroutine.
|
|
type UnimplementedPlugin struct {
|
|
mu sync.RWMutex
|
|
host Host
|
|
}
|
|
|
|
var (
|
|
_ Plugin = (*UnimplementedPlugin)(nil)
|
|
_ HostSetter = (*UnimplementedPlugin)(nil)
|
|
)
|
|
|
|
// OnEvent is a no-op default: it accepts the event without doing anything.
|
|
//
|
|
// Pointer receiver (like every other UnimplementedPlugin method): the type
|
|
// embeds a sync.RWMutex, and a value receiver would trip go vet's copylocks
|
|
// check even though this method never touches it.
|
|
func (*UnimplementedPlugin) OnEvent(context.Context, *Event) error {
|
|
return nil
|
|
}
|
|
|
|
// InvokeTool is a no-op default: it returns an empty successful response.
|
|
func (*UnimplementedPlugin) InvokeTool(context.Context, *ToolRequest) (*ToolResponse, error) {
|
|
return &ToolResponse{}, nil
|
|
}
|
|
|
|
// HandleWebhook is a no-op default: it returns 404, since an unhandled
|
|
// webhook path has nothing sensible to serve.
|
|
func (*UnimplementedPlugin) HandleWebhook(context.Context, *WebhookRequest) (*WebhookResponse, error) {
|
|
return &WebhookResponse{Status: 404}, nil
|
|
}
|
|
|
|
// SetHost stores the Host injected by Serve. Call Host() from your
|
|
// overridden methods to reach kandev.
|
|
func (p *UnimplementedPlugin) SetHost(h Host) {
|
|
p.mu.Lock()
|
|
defer p.mu.Unlock()
|
|
p.host = h
|
|
}
|
|
|
|
// Host returns the Host injected by Serve, or nil if the broker connection
|
|
// hasn't completed yet (or Serve hasn't been called, e.g. in unit tests).
|
|
func (p *UnimplementedPlugin) Host() Host {
|
|
p.mu.RLock()
|
|
defer p.mu.RUnlock()
|
|
return p.host
|
|
}
|