45a46f9899
* feat: support tasks without a repository Lets users create a task with no repository attached — useful for research, brainstorming, design discussions, or pointing the agent at an existing non-git folder. The create-task dialog gains a 3-mode segmented control (Repo / URL / None); "None" mode replaces the chip row with a folder picker that browses the host filesystem via a new GET /api/v1/fs/list-dir endpoint and either commits an absolute path or falls back to a kandev- managed scratch workspace at <homeDir>/tasks/<workspaceID>/<taskID>/. The worktree executor is hidden from the picker in no-repo mode (it inherently needs a repo); the lifecycle manager also short-circuits worktree mode server-side as a belt-and-suspenders guard. The Changes panel auto-closes for repo-less tasks since it has nothing to show, and the cumulative-diff handler returns null instead of erroring when no base commit exists. Spec + plan added at docs/specs/tasks-without-repositories/. * fix(backend): anchor folder picker to discovery roots (CodeQL path traversal) CodeQL flagged the new GET /api/v1/fs/list-dir handler for piping a user-controlled path straight into os.Stat / os.ReadDir. Restrict the listing to paths inside the configured discovery roots (defaults to $HOME, same allowlist as repository discovery), reject anything outside with ErrPathNotAllowed → HTTP 403, and clip the breadcrumb's "up" button at the root so the picker can't be used to walk above the allowed prefix. Tests cover: rejection of paths outside roots, traversal escapes (../), default-to-first-root, and parent exposure for nested paths. * fix(backend): use os.Root for folder picker (recognized CodeQL sanitizer) Previous attempt anchored to discovery roots via isPathAllowed, but CodeQL's data flow doesn't model that helper as a sanitizer and kept flagging os.Stat / os.ReadDir. Switch to os.Root (Go 1.24+): open the matching discovery root once and run Stat/Open/ReadDir against the relative path within it. The OS itself enforces containment — symlinks and traversal cannot escape — and CodeQL recognizes os.Root as safe. * fix: address PR review feedback - Changes panel auto-close now distinguishes "task loading" from "task has no repos" (returns boolean | null), so the panel isn't permanently removed during the first-render window before task data lands in the store. - Reset noRepository / workspacePath in resetDiscoveryState so reopening the dialog after a None-mode task doesn't carry the flag forward. - Folder-picker breadcrumb: dropped dead `i > 0 && i > 1` condition (always equivalent to `i > 1`); chevrons now render between every segment as expected. - list-dir HTTP handler returns a generic error message instead of forwarding raw OS errors that leak host paths. - Document the dataDir → kandevHome inversion convention next to the scratch-path computation so future readers don't mistake the filepath.Dir call for a fragile derivation. * fix: address CodeRabbit review nitpicks - Trim whitespace on workspace_path before persisting to task metadata so a value of " " doesn't get stored as a non-empty path. - Extract the workspace_path metadata key into models.MetaKeyWorkspacePath alongside the existing MetaKeyAgentProfileID / MetaKeyExecutorProfileID so the set/read sites can't drift apart. - Folder picker: reset cached listing when the popover closes, so reopening reloads from `value` instead of showing the last browsed directory the user navigated away from without committing. - Submit payload: send `workspace_path: undefined` instead of an empty string when the trimmed value is empty, matching the noRepository=false case and keeping the API contract clear. * fix: scratch path lands in kandev home, not its parent Claude caught a real bug — `m.dataDir` is set from `cfg.ResolvedHomeDir()` in cmd/kandev/agents.go, not `ResolvedDataDir()` (the field name is misleading and the comment was wrong). My previous use of `filepath.Dir(m.dataDir)` therefore walked one level above the kandev home, so scratch dirs landed at e.g. `~/tasks/<ws>/<task>` instead of `~/.kandev/tasks/<ws>/<task>` — and at the project root in dev mode where `KANDEV_HOME_DIR=<project>/.kandev-dev`, which is what the user saw on their machine. Use `m.dataDir` directly (it's already the kandev home), document the field's misnamed-but-correct semantics, and tighten the test fixtures. Also: - folder-picker trigger gets `cursor-pointer` (CodeRabbit nitpick). * fix: pass workspacePath through handleCreateWithoutAgent too The "create without agent" path called buildCreateTaskPayload without the new workspacePath field, so picking a folder + clicking "Create without starting" silently dropped the path. Now matches the performCreate (with-agent) path. * fix: satisfy DialogFormState in new-subtask form stub PR #852 (merged after this branch was created) introduced new-subtask-form-state.ts which stubs out a DialogFormState for the subtask dialog. Adding noRepository / setNoRepository / workspacePath / setWorkspacePath to the type made that stub incomplete, breaking the Next.js production build (caught by CI, missed by tsc --noEmit). Add the four inert fields to the stub, alongside the existing fresh- branch inert fields, and pull both groups into named constants to keep the useMemo body under the per-function line cap. * fix: keep toggle-github-url testid as alias on URL-mode button The new source-mode segmented control replaced the previous "or paste a GitHub URL" text link, which had data-testid="toggle-github-url". The existing e2e suite (create-task-github-url.spec.ts and the new subtask.spec.ts from #852) still selects the URL toggle by that testid. Keep "toggle-github-url" as the testid on the URL-mode button so both suites pass without a sweep across all e2e files. Click semantics are unchanged — single click enters URL mode. * test(e2e): update toggle assertion for new source-mode segmented control create-task-github-url.spec.ts:892 was checking the old text-link toggle's two-way behavior with text labels ("or paste a GitHub URL" / "use a workspace repository"). The new segmented control has explicit mode buttons; assert aria-checked instead of label text. The other 9 clicks on `toggle-github-url` in this file still work via the legacy testid alias on the URL-mode button. * refactor: extract useActiveTaskHasRepos to its own hook file dockview-desktop-layout.tsx grew to 609 lines with the new hook + the Changes panel guard, over the 600-line cap documented in CLAUDE.md (lint passed but the convention is real). Move the hook to hooks/domains/kanban/use-active-task-has-repos.ts. File drops to 590 lines. * chore: gitignore .claude/scheduled_tasks.lock runtime file * fix(web): lock chip-row min-height so modal doesn't shift on mode toggle The chip row uses flex-wrap; Repo mode (chip + branch + add button + segmented control) sometimes occupies a different vertical extent than None mode (single folder picker + segmented control), causing the create-task modal to jump a few pixels when toggling between sources. Set min-h-9 so the row always reserves at least one chip-row of height regardless of the active mode. * feat: let folder picker browse anywhere, drop allowed-roots gate The picker is for choosing a starting folder for a repo-less task — users legitimately want /tmp, /var/log/foo, or any directory they have read access to. Coupling it to the repo-discover endpoint's discoveryRoots ($HOME by default) was too tight: paths like /tmp returned 403 "path is not within allowed roots". Decouple ListDirectory from discoveryRoots. The repo-discover endpoint (DiscoverLocalRepositories, ValidateLocalRepositoryPath, LocalRepositoryStatus, ListBranches) stays anchored to the allowlist since picking a repo to import is a workspace-scoped operation; the folder picker trusts the local-process boundary instead. CodeQL is kept happy by routing the FS operations through os.Root opened at "/" — the Go stdlib sanitizer for path injection still recognises it (containment to / is trivially satisfied for every absolute path on the host). --------- Co-authored-by: Kandev Agent <agent@kandev.dev>
230 lines
10 KiB
Go
230 lines
10 KiB
Go
package service
|
|
|
|
import (
|
|
v1 "github.com/kandev/kandev/pkg/api/v1"
|
|
|
|
"github.com/kandev/kandev/internal/task/models"
|
|
)
|
|
|
|
// Request types
|
|
|
|
// TaskRepositoryInput for creating/updating task repositories
|
|
type TaskRepositoryInput struct {
|
|
RepositoryID string `json:"repository_id"`
|
|
BaseBranch string `json:"base_branch"`
|
|
CheckoutBranch string `json:"checkout_branch,omitempty"`
|
|
LocalPath string `json:"local_path,omitempty"`
|
|
Name string `json:"name,omitempty"`
|
|
DefaultBranch string `json:"default_branch,omitempty"`
|
|
GitHubURL string `json:"github_url,omitempty"`
|
|
}
|
|
|
|
// CreateTaskRequest contains the data for creating a new task
|
|
type CreateTaskRequest struct {
|
|
WorkspaceID string `json:"workspace_id"`
|
|
WorkflowID string `json:"workflow_id"`
|
|
WorkflowStepID string `json:"workflow_step_id"`
|
|
Title string `json:"title"`
|
|
Description string `json:"description"`
|
|
Priority int `json:"priority"`
|
|
State *v1.TaskState `json:"state,omitempty"`
|
|
Repositories []TaskRepositoryInput `json:"repositories,omitempty"`
|
|
Position int `json:"position"`
|
|
Metadata map[string]interface{} `json:"metadata,omitempty"`
|
|
PlanMode bool `json:"plan_mode,omitempty"`
|
|
IsEphemeral bool `json:"is_ephemeral,omitempty"` // Ephemeral tasks are hidden from kanban, used for quick chat
|
|
ParentID string `json:"parent_id,omitempty"`
|
|
WorkspacePath string `json:"workspace_path,omitempty"` // Optional host folder for repo-less tasks
|
|
}
|
|
|
|
// UpdateTaskRequest contains the data for updating a task
|
|
type UpdateTaskRequest struct {
|
|
Title *string `json:"title,omitempty"`
|
|
Description *string `json:"description,omitempty"`
|
|
Priority *int `json:"priority,omitempty"`
|
|
State *v1.TaskState `json:"state,omitempty"`
|
|
Repositories []TaskRepositoryInput `json:"repositories,omitempty"`
|
|
Position *int `json:"position,omitempty"`
|
|
Metadata map[string]interface{} `json:"metadata,omitempty"`
|
|
}
|
|
|
|
// CreateWorkflowRequest contains the data for creating a new workflow
|
|
type CreateWorkflowRequest struct {
|
|
WorkspaceID string `json:"workspace_id"`
|
|
Name string `json:"name"`
|
|
Description string `json:"description"`
|
|
WorkflowTemplateID *string `json:"workflow_template_id,omitempty"`
|
|
// Hidden marks the workflow as system-only; excluded from management UI and pickers.
|
|
Hidden bool `json:"hidden,omitempty"`
|
|
}
|
|
|
|
// UpdateWorkflowRequest contains the data for updating a workflow
|
|
type UpdateWorkflowRequest struct {
|
|
Name *string `json:"name,omitempty"`
|
|
Description *string `json:"description,omitempty"`
|
|
AgentProfileID *string `json:"agent_profile_id,omitempty"`
|
|
}
|
|
|
|
// CreateWorkspaceRequest contains the data for creating a new workspace
|
|
type CreateWorkspaceRequest struct {
|
|
Name string `json:"name"`
|
|
Description string `json:"description"`
|
|
OwnerID string `json:"owner_id"`
|
|
DefaultExecutorID *string `json:"default_executor_id,omitempty"`
|
|
DefaultEnvironmentID *string `json:"default_environment_id,omitempty"`
|
|
DefaultAgentProfileID *string `json:"default_agent_profile_id,omitempty"`
|
|
DefaultConfigAgentProfileID *string `json:"default_config_agent_profile_id,omitempty"`
|
|
}
|
|
|
|
// UpdateWorkspaceRequest contains the data for updating a workspace
|
|
type UpdateWorkspaceRequest struct {
|
|
Name *string `json:"name,omitempty"`
|
|
Description *string `json:"description,omitempty"`
|
|
DefaultExecutorID *string `json:"default_executor_id,omitempty"`
|
|
DefaultEnvironmentID *string `json:"default_environment_id,omitempty"`
|
|
DefaultAgentProfileID *string `json:"default_agent_profile_id,omitempty"`
|
|
DefaultConfigAgentProfileID *string `json:"default_config_agent_profile_id,omitempty"`
|
|
}
|
|
|
|
// FindOrCreateRepositoryRequest contains the data for finding or creating a repository by provider info.
|
|
type FindOrCreateRepositoryRequest struct {
|
|
WorkspaceID string `json:"workspace_id"`
|
|
Provider string `json:"provider"`
|
|
ProviderOwner string `json:"provider_owner"`
|
|
ProviderName string `json:"provider_name"`
|
|
DefaultBranch string `json:"default_branch"`
|
|
LocalPath string `json:"local_path"`
|
|
}
|
|
|
|
// CreateRepositoryRequest contains the data for creating a new repository
|
|
type CreateRepositoryRequest struct {
|
|
WorkspaceID string `json:"workspace_id"`
|
|
Name string `json:"name"`
|
|
SourceType string `json:"source_type"`
|
|
LocalPath string `json:"local_path"`
|
|
Provider string `json:"provider"`
|
|
ProviderRepoID string `json:"provider_repo_id"`
|
|
ProviderOwner string `json:"provider_owner"`
|
|
ProviderName string `json:"provider_name"`
|
|
DefaultBranch string `json:"default_branch"`
|
|
WorktreeBranchPrefix string `json:"worktree_branch_prefix"`
|
|
PullBeforeWorktree *bool `json:"pull_before_worktree"`
|
|
SetupScript string `json:"setup_script"`
|
|
CleanupScript string `json:"cleanup_script"`
|
|
DevScript string `json:"dev_script"`
|
|
}
|
|
|
|
// UpdateRepositoryRequest contains the data for updating a repository
|
|
type UpdateRepositoryRequest struct {
|
|
Name *string `json:"name,omitempty"`
|
|
SourceType *string `json:"source_type,omitempty"`
|
|
LocalPath *string `json:"local_path,omitempty"`
|
|
Provider *string `json:"provider,omitempty"`
|
|
ProviderRepoID *string `json:"provider_repo_id,omitempty"`
|
|
ProviderOwner *string `json:"provider_owner,omitempty"`
|
|
ProviderName *string `json:"provider_name,omitempty"`
|
|
DefaultBranch *string `json:"default_branch,omitempty"`
|
|
WorktreeBranchPrefix *string `json:"worktree_branch_prefix,omitempty"`
|
|
PullBeforeWorktree *bool `json:"pull_before_worktree,omitempty"`
|
|
SetupScript *string `json:"setup_script,omitempty"`
|
|
CleanupScript *string `json:"cleanup_script,omitempty"`
|
|
DevScript *string `json:"dev_script,omitempty"`
|
|
}
|
|
|
|
// CreateExecutorRequest contains the data for creating an executor
|
|
type CreateExecutorRequest struct {
|
|
Name string `json:"name"`
|
|
Type models.ExecutorType `json:"type"`
|
|
Status models.ExecutorStatus `json:"status"`
|
|
IsSystem bool `json:"is_system"`
|
|
Resumable bool `json:"resumable"`
|
|
Config map[string]string `json:"config,omitempty"`
|
|
}
|
|
|
|
// UpdateExecutorRequest contains the data for updating an executor
|
|
type UpdateExecutorRequest struct {
|
|
Name *string `json:"name,omitempty"`
|
|
Type *models.ExecutorType `json:"type,omitempty"`
|
|
Status *models.ExecutorStatus `json:"status,omitempty"`
|
|
Resumable *bool `json:"resumable,omitempty"`
|
|
Config map[string]string `json:"config,omitempty"`
|
|
}
|
|
|
|
// CreateExecutorProfileRequest contains the data for creating an executor profile
|
|
type CreateExecutorProfileRequest struct {
|
|
ExecutorID string `json:"executor_id"`
|
|
Name string `json:"name"`
|
|
McpPolicy string `json:"mcp_policy"`
|
|
Config map[string]string `json:"config,omitempty"`
|
|
PrepareScript string `json:"prepare_script"`
|
|
CleanupScript string `json:"cleanup_script"`
|
|
EnvVars []models.ProfileEnvVar `json:"env_vars,omitempty"`
|
|
}
|
|
|
|
// UpdateExecutorProfileRequest contains the data for updating an executor profile
|
|
type UpdateExecutorProfileRequest struct {
|
|
Name *string `json:"name,omitempty"`
|
|
McpPolicy *string `json:"mcp_policy,omitempty"`
|
|
Config map[string]string `json:"config,omitempty"`
|
|
PrepareScript *string `json:"prepare_script,omitempty"`
|
|
CleanupScript *string `json:"cleanup_script,omitempty"`
|
|
EnvVars []models.ProfileEnvVar `json:"env_vars,omitempty"`
|
|
}
|
|
|
|
// CreateEnvironmentRequest contains the data for creating an environment
|
|
type CreateEnvironmentRequest struct {
|
|
Name string `json:"name"`
|
|
Kind models.EnvironmentKind `json:"kind"`
|
|
WorktreeRoot string `json:"worktree_root,omitempty"`
|
|
ImageTag string `json:"image_tag,omitempty"`
|
|
Dockerfile string `json:"dockerfile,omitempty"`
|
|
BuildConfig map[string]string `json:"build_config,omitempty"`
|
|
}
|
|
|
|
// UpdateEnvironmentRequest contains the data for updating an environment
|
|
type UpdateEnvironmentRequest struct {
|
|
Name *string `json:"name,omitempty"`
|
|
Kind *models.EnvironmentKind `json:"kind,omitempty"`
|
|
WorktreeRoot *string `json:"worktree_root,omitempty"`
|
|
ImageTag *string `json:"image_tag,omitempty"`
|
|
Dockerfile *string `json:"dockerfile,omitempty"`
|
|
BuildConfig map[string]string `json:"build_config,omitempty"`
|
|
}
|
|
|
|
// ListMessagesRequest contains options for paginated message listing
|
|
type ListMessagesRequest struct {
|
|
TaskSessionID string
|
|
Limit int
|
|
Before string
|
|
After string
|
|
Sort string
|
|
}
|
|
|
|
// CreateRepositoryScriptRequest contains the data for creating a repository script
|
|
type CreateRepositoryScriptRequest struct {
|
|
RepositoryID string `json:"repository_id"`
|
|
Name string `json:"name"`
|
|
Command string `json:"command"`
|
|
Position int `json:"position"`
|
|
}
|
|
|
|
// UpdateRepositoryScriptRequest contains the data for updating a repository script
|
|
type UpdateRepositoryScriptRequest struct {
|
|
Name *string `json:"name,omitempty"`
|
|
Command *string `json:"command,omitempty"`
|
|
Position *int `json:"position,omitempty"`
|
|
}
|
|
|
|
// CreateMessageRequest contains the data for creating a new message
|
|
type CreateMessageRequest struct {
|
|
TaskSessionID string `json:"session_id"`
|
|
TaskID string `json:"task_id,omitempty"`
|
|
TurnID string `json:"turn_id"`
|
|
Content string `json:"content"`
|
|
AuthorType string `json:"author_type,omitempty"` // "user" or "agent", defaults to "user"
|
|
AuthorID string `json:"author_id,omitempty"`
|
|
RequestsInput bool `json:"requests_input,omitempty"`
|
|
Type string `json:"type,omitempty"`
|
|
Metadata map[string]interface{} `json:"metadata,omitempty"`
|
|
}
|