85aa3ac0aa
* feat(github): add /github page for PRs and issues Dedicated page under /github lists pull requests and issues across the authenticated user's repos with preset filters, custom GitHub search queries, per-repo narrowing, saved queries, and one-click task launching for any PR or issue. Performance: - Cache user PR/issue search responses for 30s with singleflight to coalesce concurrent misses, so preset switching and pagination avoid upstream round trips. - Replace the per-row PR status fetch (N+1) with a batch endpoint POST /api/v1/github/prs/statuses that fans out concurrently on the backend with a semaphore and caches per-PR. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * style: apply Prettier formatting Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: address review feedback on PR cache + status batching - Harden searchCacheKey against separator collisions from user-controllable customQuery (length-prefix encoding). - Drop repositories.loaded hydration when inner workspace fetch fails so the client refetches instead of trusting a partial snapshot. - Guard useGitHubSearch with a monotonic request counter to drop stale responses when filter+page changes overlap. - Fix usePRStatuses teardown: depend only on composed key so a new array identity per render doesn't cancel the in-flight batch. - Correct godocs (duplicate, outdated state:open claim). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: address additional review feedback - Restore state:open for issue watcher: buildIssueSearchQuery no longer injects it as a default, so existing watches were starting to surface closed issues. Inject state:open in buildIssueFilter so only the watcher path is affected; the /github page presets already set their own state qualifiers. - countCheckResults now excludes in-progress checks from the denominator so a `1/3` badge reflects pass rate on completed checks, not a mix of running and failed. The pending state is still carried via ChecksState. - usePRStatuses retries after a transient fetch error (only mark the key as completed once the fetch resolves). This also fixes missing badges under React Strict Mode's intentional double-mount, since the first effect's cleanup fires before the response lands and the guard stays unset for the second mount to retry. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * test(github): add tests for my-github hooks Covers use-committed-query, buildParams from use-github-search, use-saved-presets readStorage validation, use-known-repos recordForKey accumulator semantics, and use-pr-statuses batch fetch lifecycle. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: address review feedback on search cache and repo accumulator - Clamp perPage before composing the search cache key so identical pages (e.g. perPage=150 and =100) share a cache entry instead of creating duplicates keyed on the raw value. - Add resetKnownReposStore and call it on /github unmount so the module-level repo accumulator doesn't carry across navigations. - Rename use-pr-statuses test to match its assertion (it verifies stale statuses are cleared when the key changes and fetch fails). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * style: apply Prettier formatting Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(web): distinguish blocked from dirty in PR mergeable badge GitHub's blocked state (required reviews/checks/branch protection) is not a merge conflict, so don't label it "Conflicts". Surface it as "Blocked" with the pending tone; keep "Conflicts" for dirty. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix: address remaining /github code review comments - Route PR status + batch through handleSearchError so ErrNoClient surfaces as 503 instead of 500 (matches the search endpoints). - Sort workflow steps by position in the quick-task-launcher default pick, matching the convention in issue-watch-dialog. - Make PresetItem keyboard-accessible: role=button, tabIndex, and Enter/Space handling on the wrapping div (it contains a nested delete button, so it can't itself be a button). - Extract useRepoOptions out of useGitHubPageState to bring the hook back under the 100-line complexity limit. - Honor ctx.Done() when acquiring the PR-status batch semaphore so a cancelled HTTP request releases queued goroutines instead of running each upstream fetch to completion. - Clarify parsePaginationQuery doc: the upper bound (100) is enforced by clampSearchPage in the client layer, not here. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(web): address /github review follow-ups - Merge duplicate @/lib/utils imports in pr-list. - Use rel="noopener noreferrer" on external PR/issue links (codebase convention) and add cursor-pointer per the UI guidelines. - Rewrite onOpenSaveDialog as an explicit if-block so the callback returns void rather than boolean | void. - Use PaginationEllipsis in its own PaginationItem so the ellipsis and the adjacent page link are separate list items instead of visually fused into a single cell. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * refactor(web): derive QuickTaskLauncher dialog state from props Replaces the useEffect+setState anti-pattern with useMemo-derived state driven directly by the payload prop. Drops the eslint suppression that was needed for react-hooks/set-state-in-effect. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
157 lines
4.8 KiB
TypeScript
157 lines
4.8 KiB
TypeScript
"use client";
|
|
|
|
import Link from "next/link";
|
|
import {
|
|
IconGitPullRequest,
|
|
IconGitPullRequestClosed,
|
|
IconGitMerge,
|
|
IconPlus,
|
|
IconChevronDown,
|
|
} from "@tabler/icons-react";
|
|
import type { Icon } from "@tabler/icons-react";
|
|
import { Button } from "@kandev/ui/button";
|
|
import {
|
|
DropdownMenu,
|
|
DropdownMenuContent,
|
|
DropdownMenuItem,
|
|
DropdownMenuTrigger,
|
|
} from "@kandev/ui/dropdown-menu";
|
|
import { Spinner } from "@kandev/ui/spinner";
|
|
import { cn, formatRelativeTime } from "@/lib/utils";
|
|
import type { GitHubPR, GitHubPRStatus } from "@/lib/types/github";
|
|
import { PR_TASK_PRESETS, type LaunchPayload, type TaskPreset } from "./quick-task-launcher";
|
|
import { PRStatusBadges } from "./pr-status-badges";
|
|
import { prStatusKey, usePRStatuses } from "./use-pr-statuses";
|
|
|
|
type PRListProps = {
|
|
items: GitHubPR[];
|
|
loading: boolean;
|
|
error: string | null;
|
|
onStartTask: (payload: LaunchPayload) => void;
|
|
};
|
|
|
|
function prStateIcon(pr: GitHubPR): { Icon: Icon; className: string } {
|
|
if (pr.state === "merged")
|
|
return { Icon: IconGitMerge, className: "text-purple-600 dark:text-purple-400" };
|
|
if (pr.state === "closed")
|
|
return { Icon: IconGitPullRequestClosed, className: "text-red-600 dark:text-red-400" };
|
|
if (pr.draft) return { Icon: IconGitPullRequest, className: "text-muted-foreground" };
|
|
return { Icon: IconGitPullRequest, className: "text-emerald-600 dark:text-emerald-400" };
|
|
}
|
|
|
|
function StartTaskMenu({
|
|
pr,
|
|
onStartTask,
|
|
}: {
|
|
pr: GitHubPR;
|
|
onStartTask: PRListProps["onStartTask"];
|
|
}) {
|
|
const launch = (preset: TaskPreset) => onStartTask({ kind: "pr", pr, preset });
|
|
return (
|
|
<DropdownMenu>
|
|
<DropdownMenuTrigger asChild>
|
|
<Button size="sm" variant="outline" className="h-7 gap-1 cursor-pointer">
|
|
<IconPlus className="h-3.5 w-3.5" />
|
|
Task
|
|
<IconChevronDown className="h-3 w-3" />
|
|
</Button>
|
|
</DropdownMenuTrigger>
|
|
<DropdownMenuContent align="end" className="w-48">
|
|
{PR_TASK_PRESETS.map((p) => {
|
|
const ItemIcon = p.icon;
|
|
return (
|
|
<DropdownMenuItem
|
|
key={p.id}
|
|
className="cursor-pointer gap-2 py-1.5"
|
|
onSelect={() => launch(p)}
|
|
>
|
|
<ItemIcon className="h-3.5 w-3.5 text-muted-foreground shrink-0" />
|
|
<div className="flex flex-col min-w-0">
|
|
<span className="text-xs font-medium leading-tight">{p.label}</span>
|
|
<span className="text-[11px] text-muted-foreground leading-tight">{p.hint}</span>
|
|
</div>
|
|
</DropdownMenuItem>
|
|
);
|
|
})}
|
|
</DropdownMenuContent>
|
|
</DropdownMenu>
|
|
);
|
|
}
|
|
|
|
function PRRow({
|
|
pr,
|
|
status,
|
|
onStartTask,
|
|
}: {
|
|
pr: GitHubPR;
|
|
status: GitHubPRStatus | null | undefined;
|
|
onStartTask: PRListProps["onStartTask"];
|
|
}) {
|
|
const { Icon: StateIcon, className: stateIconClass } = prStateIcon(pr);
|
|
return (
|
|
<div className="flex items-start gap-3 px-4 py-3 hover:bg-muted/40 transition-colors">
|
|
<StateIcon className={cn("h-4 w-4 mt-1 shrink-0", stateIconClass)} />
|
|
<div className="min-w-0 flex-1">
|
|
<Link
|
|
href={pr.html_url}
|
|
target="_blank"
|
|
rel="noopener noreferrer"
|
|
className="text-sm font-semibold hover:underline block truncate cursor-pointer"
|
|
>
|
|
{pr.title}
|
|
</Link>
|
|
<div className="flex flex-wrap items-center gap-x-2 gap-y-1 mt-0.5 text-xs text-muted-foreground">
|
|
<span className="whitespace-nowrap">
|
|
{pr.repo_owner}/{pr.repo_name}#{pr.number}
|
|
</span>
|
|
<span>·</span>
|
|
<span className="whitespace-nowrap">
|
|
by {pr.author_login} · opened {formatRelativeTime(pr.created_at)}
|
|
</span>
|
|
<PRStatusBadges pr={pr} status={status} />
|
|
</div>
|
|
</div>
|
|
<div className="shrink-0">
|
|
<StartTaskMenu pr={pr} onStartTask={onStartTask} />
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function PRListBody({ loading, error, items, onStartTask }: PRListProps) {
|
|
const statuses = usePRStatuses(items);
|
|
if (loading) {
|
|
return (
|
|
<div className="flex justify-center py-10">
|
|
<Spinner />
|
|
</div>
|
|
);
|
|
}
|
|
if (error) {
|
|
return <div className="text-center py-10 text-destructive text-sm">{error}</div>;
|
|
}
|
|
if (items.length === 0) {
|
|
return (
|
|
<div className="text-center py-10 text-muted-foreground text-sm">
|
|
No pull requests match this filter.
|
|
</div>
|
|
);
|
|
}
|
|
return (
|
|
<div className="divide-y">
|
|
{items.map((pr) => {
|
|
const key = prStatusKey(pr.repo_owner, pr.repo_name, pr.number);
|
|
return <PRRow key={key} pr={pr} status={statuses.get(key)} onStartTask={onStartTask} />;
|
|
})}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
export function PRList(props: PRListProps) {
|
|
return (
|
|
<div className="rounded-md border overflow-hidden">
|
|
<PRListBody {...props} />
|
|
</div>
|
|
);
|
|
}
|