85aa3ac0aa
* feat(github): add /github page for PRs and issues Dedicated page under /github lists pull requests and issues across the authenticated user's repos with preset filters, custom GitHub search queries, per-repo narrowing, saved queries, and one-click task launching for any PR or issue. Performance: - Cache user PR/issue search responses for 30s with singleflight to coalesce concurrent misses, so preset switching and pagination avoid upstream round trips. - Replace the per-row PR status fetch (N+1) with a batch endpoint POST /api/v1/github/prs/statuses that fans out concurrently on the backend with a semaphore and caches per-PR. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * style: apply Prettier formatting Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: address review feedback on PR cache + status batching - Harden searchCacheKey against separator collisions from user-controllable customQuery (length-prefix encoding). - Drop repositories.loaded hydration when inner workspace fetch fails so the client refetches instead of trusting a partial snapshot. - Guard useGitHubSearch with a monotonic request counter to drop stale responses when filter+page changes overlap. - Fix usePRStatuses teardown: depend only on composed key so a new array identity per render doesn't cancel the in-flight batch. - Correct godocs (duplicate, outdated state:open claim). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: address additional review feedback - Restore state:open for issue watcher: buildIssueSearchQuery no longer injects it as a default, so existing watches were starting to surface closed issues. Inject state:open in buildIssueFilter so only the watcher path is affected; the /github page presets already set their own state qualifiers. - countCheckResults now excludes in-progress checks from the denominator so a `1/3` badge reflects pass rate on completed checks, not a mix of running and failed. The pending state is still carried via ChecksState. - usePRStatuses retries after a transient fetch error (only mark the key as completed once the fetch resolves). This also fixes missing badges under React Strict Mode's intentional double-mount, since the first effect's cleanup fires before the response lands and the guard stays unset for the second mount to retry. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * test(github): add tests for my-github hooks Covers use-committed-query, buildParams from use-github-search, use-saved-presets readStorage validation, use-known-repos recordForKey accumulator semantics, and use-pr-statuses batch fetch lifecycle. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: address review feedback on search cache and repo accumulator - Clamp perPage before composing the search cache key so identical pages (e.g. perPage=150 and =100) share a cache entry instead of creating duplicates keyed on the raw value. - Add resetKnownReposStore and call it on /github unmount so the module-level repo accumulator doesn't carry across navigations. - Rename use-pr-statuses test to match its assertion (it verifies stale statuses are cleared when the key changes and fetch fails). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * style: apply Prettier formatting Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(web): distinguish blocked from dirty in PR mergeable badge GitHub's blocked state (required reviews/checks/branch protection) is not a merge conflict, so don't label it "Conflicts". Surface it as "Blocked" with the pending tone; keep "Conflicts" for dirty. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix: address remaining /github code review comments - Route PR status + batch through handleSearchError so ErrNoClient surfaces as 503 instead of 500 (matches the search endpoints). - Sort workflow steps by position in the quick-task-launcher default pick, matching the convention in issue-watch-dialog. - Make PresetItem keyboard-accessible: role=button, tabIndex, and Enter/Space handling on the wrapping div (it contains a nested delete button, so it can't itself be a button). - Extract useRepoOptions out of useGitHubPageState to bring the hook back under the 100-line complexity limit. - Honor ctx.Done() when acquiring the PR-status batch semaphore so a cancelled HTTP request releases queued goroutines instead of running each upstream fetch to completion. - Clarify parsePaginationQuery doc: the upper bound (100) is enforced by clampSearchPage in the client layer, not here. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(web): address /github review follow-ups - Merge duplicate @/lib/utils imports in pr-list. - Use rel="noopener noreferrer" on external PR/issue links (codebase convention) and add cursor-pointer per the UI guidelines. - Rewrite onOpenSaveDialog as an explicit if-block so the callback returns void rather than boolean | void. - Use PaginationEllipsis in its own PaginationItem so the ellipsis and the adjacent page link are separate list items instead of visually fused into a single cell. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * refactor(web): derive QuickTaskLauncher dialog state from props Replaces the useEffect+setState anti-pattern with useMemo-derived state driven directly by the payload prop. Drops the eslint suppression that was needed for react-hooks/set-state-in-effect. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
130 lines
3.2 KiB
Go
130 lines
3.2 KiB
Go
package github
|
|
|
|
import (
|
|
"fmt"
|
|
"sync"
|
|
"time"
|
|
|
|
"golang.org/x/sync/singleflight"
|
|
)
|
|
|
|
// Short-TTL cache around GitHub responses. The gh CLI subprocess path plus
|
|
// multi-step status builds make round trips expensive; caching within a brief
|
|
// window keeps preset switching, pagination, and list re-renders snappy.
|
|
const (
|
|
defaultCacheTTL = 30 * time.Second
|
|
defaultCacheMaxSize = 200
|
|
)
|
|
|
|
type ttlEntry struct {
|
|
value any
|
|
expiresAt time.Time
|
|
}
|
|
|
|
// ttlCache is a tiny TTL map guarded by singleflight to coalesce concurrent
|
|
// misses for the same key. When size exceeds the cap, entries with the
|
|
// earliest expiry are dropped — good enough for a sub-minute window.
|
|
type ttlCache struct {
|
|
mu sync.Mutex
|
|
entries map[string]ttlEntry
|
|
sf singleflight.Group
|
|
ttl time.Duration
|
|
maxSize int
|
|
now func() time.Time
|
|
}
|
|
|
|
func newTTLCache() *ttlCache {
|
|
return &ttlCache{
|
|
entries: make(map[string]ttlEntry),
|
|
ttl: defaultCacheTTL,
|
|
maxSize: defaultCacheMaxSize,
|
|
now: time.Now,
|
|
}
|
|
}
|
|
|
|
func (c *ttlCache) get(key string) (any, bool) {
|
|
c.mu.Lock()
|
|
defer c.mu.Unlock()
|
|
entry, ok := c.entries[key]
|
|
if !ok {
|
|
return nil, false
|
|
}
|
|
if c.now().After(entry.expiresAt) {
|
|
delete(c.entries, key)
|
|
return nil, false
|
|
}
|
|
return entry.value, true
|
|
}
|
|
|
|
func (c *ttlCache) set(key string, value any) {
|
|
c.mu.Lock()
|
|
defer c.mu.Unlock()
|
|
if len(c.entries) >= c.maxSize {
|
|
c.evictLocked()
|
|
}
|
|
c.entries[key] = ttlEntry{value: value, expiresAt: c.now().Add(c.ttl)}
|
|
}
|
|
|
|
// evictLocked first drops expired entries; if still over the cap, drops the
|
|
// entries with the earliest expiry until back under the limit. Caller must
|
|
// hold c.mu.
|
|
func (c *ttlCache) evictLocked() {
|
|
now := c.now()
|
|
for k, e := range c.entries {
|
|
if now.After(e.expiresAt) {
|
|
delete(c.entries, k)
|
|
}
|
|
}
|
|
if len(c.entries) < c.maxSize {
|
|
return
|
|
}
|
|
var oldestKey string
|
|
var oldestExp time.Time
|
|
for len(c.entries) >= c.maxSize {
|
|
oldestKey = ""
|
|
for k, e := range c.entries {
|
|
if oldestKey == "" || e.expiresAt.Before(oldestExp) {
|
|
oldestKey = k
|
|
oldestExp = e.expiresAt
|
|
}
|
|
}
|
|
if oldestKey == "" {
|
|
return
|
|
}
|
|
delete(c.entries, oldestKey)
|
|
}
|
|
}
|
|
|
|
// doOrFetch returns a cached value when fresh; otherwise runs fetch under a
|
|
// singleflight guard, caches the result, and returns it. Errors are not
|
|
// cached. The returned value is shared — callers must not mutate it.
|
|
func (c *ttlCache) doOrFetch(key string, fetch func() (any, error)) (any, error) {
|
|
if v, ok := c.get(key); ok {
|
|
return v, nil
|
|
}
|
|
v, err, _ := c.sf.Do(key, func() (any, error) {
|
|
if v, ok := c.get(key); ok {
|
|
return v, nil
|
|
}
|
|
v, err := fetch()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
c.set(key, v)
|
|
return v, nil
|
|
})
|
|
return v, err
|
|
}
|
|
|
|
// searchCacheKey composes a cache key with length-prefixed string fields so
|
|
// that user-controllable inputs (e.g. customQuery) cannot collide with other
|
|
// keys by embedding the separator.
|
|
func searchCacheKey(kind, filter, customQuery string, page, perPage int) string {
|
|
return fmt.Sprintf("%d:%s|%d:%s|%d:%s|%d|%d",
|
|
len(kind), kind, len(filter), filter, len(customQuery), customQuery, page, perPage)
|
|
}
|
|
|
|
func prStatusCacheKey(owner, repo string, number int) string {
|
|
return fmt.Sprintf("%s/%s#%d", owner, repo, number)
|
|
}
|