5105ac224c
* feat: add anchored range selection to multi-select reducer * feat: cmd+click and shift+click multi-select on kanban board * feat: add cmd/shift multi-select to sidebar task list * test: e2e coverage for cmd/shift multi-select * fix: harden multi-select selection lifecycle from review feedback * test: scope multi-select e2e helpers to active containers * fix: add sidebar multi-select hook tests and tighten bulk-action lifecycle * fix: prune hidden sidebar selections and order bulk moves by view * test: cover visible-order bulk move and anchor realignment * fix: harden sidebar bulk-move scope and keyboard selection parity * fix: order kanban bulk moves by board position * test: cover multi-select helpers and fix stale-id sort fallback * fix: order kanban card context-menu moves by board position * feat: sidebar multi-select shows only bulk-valid actions with bulk pin and delete * fix: harden multi-select bulk ordering, selection clearing, and a11y * fix: gate kanban card move-to-step for mixed-workflow selections * fix: unpin fully pinned sidebar selections * refactor: keep sidebar task components under limits * test: restore sidebar selection console spy safely
397 lines
13 KiB
TypeScript
397 lines
13 KiB
TypeScript
"use client";
|
|
|
|
import { useCallback, useEffect, useLayoutEffect, useReducer, useRef, type RefObject } from "react";
|
|
import { useTaskActions } from "@/hooks/use-task-actions";
|
|
import { useAppStoreApi } from "@/components/state-provider";
|
|
import type { KanbanState } from "@/lib/state/slices";
|
|
import { sortIdsByCreatedDesc } from "@/lib/kanban/task-order";
|
|
|
|
/** @internal Exported for reuse by the sidebar multi-select hook. */
|
|
export function useTaskMultiSelectStore() {
|
|
const store = useAppStoreApi();
|
|
|
|
const removeTasksFromStore = useCallback(
|
|
(ids: Set<string>) => {
|
|
const state = store.getState();
|
|
// Remove from single-workflow view
|
|
const currentKanban = state.kanban;
|
|
state.hydrate({
|
|
kanban: {
|
|
...currentKanban,
|
|
tasks: currentKanban.tasks.filter((t: KanbanState["tasks"][number]) => !ids.has(t.id)),
|
|
},
|
|
});
|
|
// Remove from multi-workflow snapshots
|
|
for (const [wfId, snapshot] of Object.entries(state.kanbanMulti.snapshots)) {
|
|
const affected = snapshot.tasks.some((t: KanbanState["tasks"][number]) => ids.has(t.id));
|
|
if (affected) {
|
|
state.setWorkflowSnapshot(wfId, {
|
|
...snapshot,
|
|
tasks: snapshot.tasks.filter((t: KanbanState["tasks"][number]) => !ids.has(t.id)),
|
|
});
|
|
}
|
|
}
|
|
},
|
|
[store],
|
|
);
|
|
|
|
const applyMoveInStore = useCallback(
|
|
(succeededIds: Set<string>, targetStepId: string) => {
|
|
const state = store.getState();
|
|
// Update single-workflow view
|
|
const currentKanban = state.kanban;
|
|
state.hydrate({
|
|
kanban: {
|
|
...currentKanban,
|
|
tasks: currentKanban.tasks.map((t: KanbanState["tasks"][number]) =>
|
|
succeededIds.has(t.id) ? { ...t, workflowStepId: targetStepId } : t,
|
|
),
|
|
},
|
|
});
|
|
// Update multi-workflow snapshots
|
|
for (const [wfId, snapshot] of Object.entries(state.kanbanMulti.snapshots)) {
|
|
const affected = snapshot.tasks.filter((t: KanbanState["tasks"][number]) =>
|
|
succeededIds.has(t.id),
|
|
);
|
|
if (affected.length > 0) {
|
|
state.setWorkflowSnapshot(wfId, {
|
|
...snapshot,
|
|
tasks: snapshot.tasks.map((t: KanbanState["tasks"][number]) =>
|
|
succeededIds.has(t.id) ? { ...t, workflowStepId: targetStepId } : t,
|
|
),
|
|
});
|
|
}
|
|
}
|
|
},
|
|
[store],
|
|
);
|
|
|
|
const getWorkflowIdForTask = useCallback(
|
|
(taskId: string): string | null => {
|
|
const snapshots = store.getState().kanbanMulti.snapshots;
|
|
for (const [wfId, snapshot] of Object.entries(snapshots)) {
|
|
if (snapshot.tasks.some((t: KanbanState["tasks"][number]) => t.id === taskId)) {
|
|
return wfId;
|
|
}
|
|
}
|
|
return store.getState().kanban.workflowId;
|
|
},
|
|
[store],
|
|
);
|
|
|
|
// Sort ids into the board's visible (created-desc) order. A backward range
|
|
// selection leaves `selectedIds` in anchor-first Set order, which would land
|
|
// scrambled when the move assigns sequential positions.
|
|
const sortByDisplayOrder = useCallback(
|
|
(ids: string[]): string[] => {
|
|
const state = store.getState();
|
|
const taskById = new Map<string, { createdAt?: string }>();
|
|
for (const snap of Object.values(state.kanbanMulti.snapshots)) {
|
|
for (const t of snap.tasks) taskById.set(t.id, t);
|
|
}
|
|
for (const t of state.kanban.tasks) if (!taskById.has(t.id)) taskById.set(t.id, t);
|
|
return sortIdsByCreatedDesc(ids, taskById);
|
|
},
|
|
[store],
|
|
);
|
|
|
|
return { removeTasksFromStore, applyMoveInStore, getWorkflowIdForTask, sortByDisplayOrder };
|
|
}
|
|
|
|
function useBulkOperations({
|
|
workflowId,
|
|
selectedIdsRef,
|
|
setSelectedIds,
|
|
setIsDeleting,
|
|
setIsArchiving,
|
|
setIsMultiSelectEnabled,
|
|
moveTaskById,
|
|
deleteTaskById,
|
|
archiveTaskById,
|
|
removeTasksFromStore,
|
|
applyMoveInStore,
|
|
getWorkflowIdForTask,
|
|
sortByDisplayOrder,
|
|
}: {
|
|
workflowId: string | null;
|
|
selectedIdsRef: RefObject<Set<string>>;
|
|
setSelectedIds: (ids: Set<string>) => void;
|
|
setIsDeleting: (v: boolean) => void;
|
|
setIsArchiving: (v: boolean) => void;
|
|
setIsMultiSelectEnabled: (v: boolean) => void;
|
|
moveTaskById: ReturnType<typeof useTaskActions>["moveTaskById"];
|
|
deleteTaskById: ReturnType<typeof useTaskActions>["deleteTaskById"];
|
|
archiveTaskById: ReturnType<typeof useTaskActions>["archiveTaskById"];
|
|
removeTasksFromStore: (ids: Set<string>) => void;
|
|
applyMoveInStore: (ids: Set<string>, stepId: string) => void;
|
|
getWorkflowIdForTask: (id: string) => string | null;
|
|
sortByDisplayOrder: (ids: string[]) => string[];
|
|
}) {
|
|
const runBulk = useCallback(
|
|
async (
|
|
per: (id: string, opts?: { cascade?: boolean }) => Promise<void>,
|
|
setBusy: (v: boolean) => void,
|
|
opts?: { cascade?: boolean },
|
|
) => {
|
|
const ids = selectedIdsRef.current;
|
|
if (!ids || ids.size === 0) return;
|
|
setBusy(true);
|
|
try {
|
|
const idList = [...ids];
|
|
const results = await Promise.allSettled(idList.map((id) => per(id, opts)));
|
|
const succeeded = new Set(idList.filter((_, i) => results[i].status === "fulfilled"));
|
|
removeTasksFromStore(succeeded);
|
|
const failed = new Set(idList.filter((_, i) => results[i].status === "rejected"));
|
|
setSelectedIds(failed);
|
|
if (failed.size === 0) setIsMultiSelectEnabled(false);
|
|
} finally {
|
|
setBusy(false);
|
|
}
|
|
},
|
|
[removeTasksFromStore, selectedIdsRef, setIsMultiSelectEnabled, setSelectedIds],
|
|
);
|
|
|
|
const bulkDelete = useCallback(
|
|
(opts?: { cascade?: boolean }) => runBulk(deleteTaskById, setIsDeleting, opts),
|
|
[runBulk, deleteTaskById, setIsDeleting],
|
|
);
|
|
|
|
const bulkArchive = useCallback(
|
|
(opts?: { cascade?: boolean }) => runBulk(archiveTaskById, setIsArchiving, opts),
|
|
[runBulk, archiveTaskById, setIsArchiving],
|
|
);
|
|
|
|
const bulkMove = useCallback(
|
|
async (targetStepId: string) => {
|
|
// Move in board order so a backward range selection isn't reordered when
|
|
// sequential positions are assigned below.
|
|
const idList = sortByDisplayOrder([...(selectedIdsRef.current ?? [])]);
|
|
if (idList.length === 0) return;
|
|
const results = await Promise.allSettled(
|
|
idList.map((id, i) => {
|
|
const wfId = getWorkflowIdForTask(id) ?? workflowId;
|
|
if (!wfId) return Promise.reject(new Error("no workflow"));
|
|
return moveTaskById(id, {
|
|
workflow_id: wfId,
|
|
workflow_step_id: targetStepId,
|
|
position: i,
|
|
});
|
|
}),
|
|
);
|
|
const succeeded = new Set(idList.filter((_, i) => results[i].status === "fulfilled"));
|
|
applyMoveInStore(succeeded, targetStepId);
|
|
},
|
|
[
|
|
workflowId,
|
|
moveTaskById,
|
|
applyMoveInStore,
|
|
getWorkflowIdForTask,
|
|
sortByDisplayOrder,
|
|
selectedIdsRef,
|
|
],
|
|
);
|
|
|
|
return { bulkDelete, bulkArchive, bulkMove };
|
|
}
|
|
|
|
type MultiSelectState = {
|
|
selectedIds: Set<string>;
|
|
isMultiSelectEnabled: boolean;
|
|
isDeleting: boolean;
|
|
isArchiving: boolean;
|
|
/**
|
|
* The task that anchors a shift-click range selection — the last task the
|
|
* user toggled/range-selected. `null` when there is no active anchor.
|
|
*/
|
|
anchorId: string | null;
|
|
};
|
|
|
|
type MultiSelectAction =
|
|
| { type: "reset" }
|
|
| { type: "toggle_select"; taskId: string }
|
|
| { type: "select_range"; taskId: string; orderedIds: string[] }
|
|
| { type: "set_selected"; ids: Set<string> }
|
|
| { type: "set_enabled"; value: boolean }
|
|
| { type: "set_deleting"; value: boolean }
|
|
| { type: "set_archiving"; value: boolean };
|
|
|
|
/** @internal Exported for testing. */
|
|
export const INITIAL_STATE: MultiSelectState = {
|
|
selectedIds: new Set(),
|
|
isMultiSelectEnabled: false,
|
|
isDeleting: false,
|
|
isArchiving: false,
|
|
anchorId: null,
|
|
};
|
|
|
|
/**
|
|
* Pick a valid range anchor after the selection set is replaced wholesale: keep
|
|
* the existing anchor if it survived, otherwise fall back to any remaining id
|
|
* (or null when the selection is now empty).
|
|
*/
|
|
function realignAnchor(state: MultiSelectState, ids: Set<string>): string | null {
|
|
if (ids.size === 0) return null;
|
|
if (state.anchorId && ids.has(state.anchorId)) return state.anchorId;
|
|
return ids.values().next().value ?? null;
|
|
}
|
|
|
|
/**
|
|
* Union-select every id from the anchor to `taskId` (inclusive) within
|
|
* `orderedIds`. When there is no valid anchor in `orderedIds` (first shift
|
|
* click, or anchor lives in a different column), fall back to union-selecting
|
|
* just `taskId` — the previous selection is preserved — and make it the new
|
|
* anchor.
|
|
*/
|
|
function applyRangeSelect(
|
|
state: MultiSelectState,
|
|
taskId: string,
|
|
orderedIds: string[],
|
|
): MultiSelectState {
|
|
const anchor = state.anchorId;
|
|
const anchorIdx = anchor ? orderedIds.indexOf(anchor) : -1;
|
|
const targetIdx = orderedIds.indexOf(taskId);
|
|
if (anchorIdx === -1 || targetIdx === -1) {
|
|
const next = new Set(state.selectedIds);
|
|
next.add(taskId);
|
|
return { ...state, selectedIds: next, anchorId: taskId };
|
|
}
|
|
const [lo, hi] = anchorIdx < targetIdx ? [anchorIdx, targetIdx] : [targetIdx, anchorIdx];
|
|
const next = new Set(state.selectedIds);
|
|
for (let i = lo; i <= hi; i++) next.add(orderedIds[i]);
|
|
return { ...state, selectedIds: next };
|
|
}
|
|
|
|
/** @internal Exported for testing. */
|
|
export function multiSelectReducer(
|
|
state: MultiSelectState,
|
|
action: MultiSelectAction,
|
|
): MultiSelectState {
|
|
switch (action.type) {
|
|
case "reset":
|
|
return INITIAL_STATE;
|
|
case "toggle_select": {
|
|
const next = new Set(state.selectedIds);
|
|
const added = !next.has(action.taskId);
|
|
if (added) next.add(action.taskId);
|
|
else next.delete(action.taskId);
|
|
// Adding anchors to the toggled task; removing realigns to a surviving id
|
|
// (or clears the anchor when the selection is now empty) so a later
|
|
// Shift+click can't range from a stale anchor.
|
|
return {
|
|
...state,
|
|
selectedIds: next,
|
|
anchorId: added ? action.taskId : realignAnchor(state, next),
|
|
};
|
|
}
|
|
case "select_range":
|
|
return applyRangeSelect(state, action.taskId, action.orderedIds);
|
|
case "set_selected":
|
|
// Keep the range anchor pointing at a still-selected task. After a partial
|
|
// bulk failure (selection replaced with the failed ids) the old anchor may
|
|
// be gone, so realign to a remaining id rather than stranding the next
|
|
// Shift+click on an invalid anchor.
|
|
return { ...state, selectedIds: action.ids, anchorId: realignAnchor(state, action.ids) };
|
|
case "set_enabled":
|
|
return { ...state, isMultiSelectEnabled: action.value };
|
|
case "set_deleting":
|
|
return { ...state, isDeleting: action.value };
|
|
case "set_archiving":
|
|
return { ...state, isArchiving: action.value };
|
|
}
|
|
}
|
|
|
|
export function useTaskMultiSelect(workflowId: string | null) {
|
|
const [state, dispatch] = useReducer(multiSelectReducer, INITIAL_STATE);
|
|
const { selectedIds, isMultiSelectEnabled, isDeleting, isArchiving } = state;
|
|
const selectedIdsRef = useRef(selectedIds);
|
|
useLayoutEffect(() => {
|
|
selectedIdsRef.current = selectedIds;
|
|
});
|
|
const isProcessing = isDeleting || isArchiving;
|
|
|
|
const setSelectedIds = useCallback(
|
|
(ids: Set<string>) => dispatch({ type: "set_selected", ids }),
|
|
[],
|
|
);
|
|
const setIsMultiSelectEnabled = useCallback(
|
|
(value: boolean) => dispatch({ type: "set_enabled", value }),
|
|
[],
|
|
);
|
|
const setIsDeleting = useCallback(
|
|
(value: boolean) => dispatch({ type: "set_deleting", value }),
|
|
[],
|
|
);
|
|
const setIsArchiving = useCallback(
|
|
(value: boolean) => dispatch({ type: "set_archiving", value }),
|
|
[],
|
|
);
|
|
|
|
useEffect(() => {
|
|
dispatch({ type: "reset" });
|
|
}, [workflowId]);
|
|
|
|
const { moveTaskById, deleteTaskById, archiveTaskById } = useTaskActions();
|
|
const { removeTasksFromStore, applyMoveInStore, getWorkflowIdForTask, sortByDisplayOrder } =
|
|
useTaskMultiSelectStore();
|
|
|
|
const toggleSelect = useCallback(
|
|
(taskId: string) => dispatch({ type: "toggle_select", taskId }),
|
|
[],
|
|
);
|
|
|
|
const selectRange = useCallback(
|
|
(taskId: string, orderedIds: string[]) =>
|
|
dispatch({ type: "select_range", taskId, orderedIds }),
|
|
[],
|
|
);
|
|
|
|
const enableMultiSelect = useCallback(
|
|
() => setIsMultiSelectEnabled(true),
|
|
[setIsMultiSelectEnabled],
|
|
);
|
|
|
|
const clearSelection = useCallback(() => {
|
|
setSelectedIds(new Set());
|
|
setIsMultiSelectEnabled(false);
|
|
}, [setSelectedIds, setIsMultiSelectEnabled]);
|
|
|
|
const toggleMultiSelect = useCallback(() => {
|
|
if (isMultiSelectEnabled || selectedIds.size > 0) {
|
|
setSelectedIds(new Set());
|
|
setIsMultiSelectEnabled(false);
|
|
} else {
|
|
setIsMultiSelectEnabled(true);
|
|
}
|
|
}, [isMultiSelectEnabled, selectedIds, setSelectedIds, setIsMultiSelectEnabled]);
|
|
|
|
const { bulkDelete, bulkArchive, bulkMove } = useBulkOperations({
|
|
workflowId,
|
|
selectedIdsRef,
|
|
setSelectedIds,
|
|
setIsDeleting,
|
|
setIsArchiving,
|
|
setIsMultiSelectEnabled,
|
|
moveTaskById,
|
|
deleteTaskById,
|
|
archiveTaskById,
|
|
removeTasksFromStore,
|
|
applyMoveInStore,
|
|
getWorkflowIdForTask,
|
|
sortByDisplayOrder,
|
|
});
|
|
|
|
return {
|
|
selectedIds,
|
|
isMultiSelectMode: isMultiSelectEnabled || selectedIds.size > 0,
|
|
isProcessing,
|
|
enableMultiSelect,
|
|
toggleMultiSelect,
|
|
toggleSelect,
|
|
selectRange,
|
|
clearSelection,
|
|
bulkDelete,
|
|
bulkArchive,
|
|
bulkMove,
|
|
};
|
|
}
|