e145d48f22
* feat: add plugin system with grpc runtime and native ui plugins - go plugin backends ship as release tarballs (per-platform binaries, checksums) that kandev installs from url/upload or filesystem sideload+sync, then spawns and supervises via hashicorp/go-plugin (unix socket / loopback tcp+automtls) - strict typed grpc contract (kandev.plugin.v1): DeliverEvent/InvokeTool/HandleWebhook plus a capability-gated host service (state, secrets, emit); author sdk in pkg/pluginsdk; packaging cli in cmd/plugin-pack - native frontend bundles: window.registerKandevPlugin + registry/host loader with dynamic routes, nav items, slots and ws handlers; plugins settings page with install dialog, sync button and enable/disable/uninstall - gated behind the plugins feature flag (prod off, dev/e2e on); covered by unit and integration tests plus playwright e2e against a real packaged fixture plugin Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): hydrate base app context on plugin routes Plugin-owned SPA routes classify as RouteUnknown, so the boot payload shipped only feature flags — no workspaces, workflows, or kanban context. Native plugin UI (e.g. host.ui.TaskCreateDialog) then had an empty store. Hydrate the same base context as the Home route for unknown SPA routes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(plugins): expose TaskCreateDialog on host.ui Lets a native plugin open kandev's real create-task modal (prefilled via initialValues) instead of POSTing directly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): harden filesystem/URL sinks against CodeQL findings Add sink-level guards on the plugin trust boundary: securejoin containment on archive extraction (zip-slip), plugin-id validation before every fs_store path, http/https scheme validation on install-from-URL, and non-interpolated ws-handler error logging. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address review findings (races, resource caps, lifecycle) - serialize per-plugin startup to close a TOCTOU double-spawn race, and let a plugin restart after exhausting attempts - bound plugin startup with an explicit 30s timeout - reject backslash paths and cap decompressed bytes by actual size in pkgtar; only mark a package Signed when a verifier actually ran and passed - delete plugin_state on uninstall; validate webhook keys against the manifest and cap webhook body size; restart an active plugin when a new version installs Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): sanitize plugin-id path sinks for CodeQL Pin the plugin id to a single path segment with filepath.Base at recordPath/ configPath and pkgtar.Remove — a barrier the taint analysis recognizes. Behaviour-identical for valid ids (already validated by safePluginID); clears the go/path-injection alerts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): inline plugin-id validation at path sinks for CodeQL filepath.Base does not strip '..', so it is not a path-injection barrier. Call the recognized safePluginID / id-pattern guard inline in Delete/GetConfig/ SetConfig and pkgtar.Remove — the same barrier that already cleared the Get sink. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address code-review findings (backend) - add capability-gating tests for the Host RPC service (was untested) - close a stop-during-start orphan race so Disable/Uninstall can't leave a supervised subprocess behind - on failed upgrade, remove only the new version dir (not all versions + data); restart the prior version - validate manifest version and reject ids ending in .config (record-file alias) - make Deliverer.Refresh non-blocking and cancel in-flight delivery on worker stop - clamp out-of-range webhook status, skip-and-warn corrupt records in List, write records atomically, semver-aware sideload version pick Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address code-review findings (frontend) - wrap plugin routes + settings routes in a shared PluginErrorBoundary so a throwing plugin page shows a fallback instead of white-screening the SPA - fix disable/re-enable in one session: keep the cached registration and re-run initialize instead of relying on a cached ES-module re-import - prefix root-relative bundle/style URLs with apiBaseUrl (split-origin/Tauri) - surface partial-install warnings via toast.warning instead of a bare success - dedupe/remove injected style links on unload; gate PluginNavItems on the flag Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): serialize per-plugin lifecycle + guard config writes - add a per-plugin keyed lock in Service so concurrent Enable/Disable/Install/ Uninstall/UpdateConfig for one id are serialized (no status-machine race) - take s.mu in SetConfig/GetConfig and write config atomically - bound each plugin initialize() with a timeout so one hung bundle can't stall the rest of the boot load Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(plugins): split service_test.go to satisfy file-length lint Move the install/URL test group into service_install_test.go; no logic change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * ci: build and ship the e2e fixture plugin package to E2E shards The plugin E2E specs' global-setup requires apps/backend/.build/kandev-plugin-e2e-1.0.0.tar.gz. Build it in the E2E build job, upload it as an artifact, and download it in both the regular and container shard jobs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
219 lines
6.1 KiB
TypeScript
219 lines
6.1 KiB
TypeScript
"use client";
|
|
|
|
import { useRef, useState } from "react";
|
|
import { Button } from "@kandev/ui/button";
|
|
import {
|
|
Dialog,
|
|
DialogContent,
|
|
DialogDescription,
|
|
DialogFooter,
|
|
DialogHeader,
|
|
DialogTitle,
|
|
} from "@kandev/ui/dialog";
|
|
import { Input } from "@kandev/ui/input";
|
|
import { Label } from "@kandev/ui/label";
|
|
import { Tabs, TabsContent, TabsList, TabsTrigger } from "@kandev/ui/tabs";
|
|
import { cn } from "@/lib/utils";
|
|
|
|
type InstallTab = "url" | "upload";
|
|
|
|
type InstallPluginDialogProps = {
|
|
open: boolean;
|
|
busy: boolean;
|
|
error: string | null;
|
|
onOpenChange: (open: boolean) => void;
|
|
onSubmitUrl: (url: string) => void;
|
|
onSubmitFile: (file: File) => void;
|
|
};
|
|
|
|
/**
|
|
* Replaces the old "Register plugin" manifest-paste dialog with the
|
|
* install-based flow (docs/plans/plugins/GRPC-CONTRACT.md §7): install from a
|
|
* remote tarball URL, or upload a .tar.gz package directly. No credentials
|
|
* are ever shown — installing a plugin has nothing to copy or reveal.
|
|
*/
|
|
export function InstallPluginDialog({
|
|
open,
|
|
busy,
|
|
error,
|
|
onOpenChange,
|
|
onSubmitUrl,
|
|
onSubmitFile,
|
|
}: InstallPluginDialogProps) {
|
|
const [tab, setTab] = useState<InstallTab>("url");
|
|
const [url, setUrl] = useState("");
|
|
|
|
const handleOpenChange = (next: boolean) => {
|
|
if (!next) {
|
|
setUrl("");
|
|
setTab("url");
|
|
}
|
|
onOpenChange(next);
|
|
};
|
|
|
|
return (
|
|
<Dialog open={open} onOpenChange={handleOpenChange}>
|
|
<DialogContent className="sm:max-w-lg" data-testid="install-plugin-dialog">
|
|
<DialogHeader>
|
|
<DialogTitle>Install plugin</DialogTitle>
|
|
<DialogDescription>
|
|
Install a plugin package from a URL, or upload a .tar.gz file directly.
|
|
</DialogDescription>
|
|
</DialogHeader>
|
|
|
|
<Tabs value={tab} onValueChange={(v) => setTab(v as InstallTab)}>
|
|
<TabsList>
|
|
<TabsTrigger
|
|
value="url"
|
|
className="cursor-pointer"
|
|
data-testid="install-plugin-tab-url"
|
|
>
|
|
From URL
|
|
</TabsTrigger>
|
|
<TabsTrigger
|
|
value="upload"
|
|
className="cursor-pointer"
|
|
data-testid="install-plugin-tab-upload"
|
|
>
|
|
Upload file
|
|
</TabsTrigger>
|
|
</TabsList>
|
|
<TabsContent value="url" className="pt-3">
|
|
<UrlTab url={url} setUrl={setUrl} busy={busy} onSubmit={onSubmitUrl} />
|
|
</TabsContent>
|
|
<TabsContent value="upload" className="pt-3">
|
|
<UploadTab busy={busy} onSubmit={onSubmitFile} />
|
|
</TabsContent>
|
|
</Tabs>
|
|
|
|
{error && (
|
|
<div data-testid="install-plugin-error" className="text-xs text-destructive" role="alert">
|
|
{error}
|
|
</div>
|
|
)}
|
|
|
|
<DialogFooter>
|
|
<Button
|
|
type="button"
|
|
variant="outline"
|
|
onClick={() => handleOpenChange(false)}
|
|
className="cursor-pointer"
|
|
>
|
|
Cancel
|
|
</Button>
|
|
</DialogFooter>
|
|
</DialogContent>
|
|
</Dialog>
|
|
);
|
|
}
|
|
|
|
function UrlTab({
|
|
url,
|
|
setUrl,
|
|
busy,
|
|
onSubmit,
|
|
}: {
|
|
url: string;
|
|
setUrl: (v: string) => void;
|
|
busy: boolean;
|
|
onSubmit: (url: string) => void;
|
|
}) {
|
|
return (
|
|
<div className="space-y-3">
|
|
<div className="space-y-1.5">
|
|
<Label htmlFor="install-plugin-url">Package URL</Label>
|
|
<Input
|
|
id="install-plugin-url"
|
|
data-testid="install-plugin-url-input"
|
|
value={url}
|
|
onChange={(e) => setUrl(e.target.value)}
|
|
placeholder="https://example.com/acme-tools-1.0.0.tar.gz"
|
|
className="font-mono text-sm"
|
|
/>
|
|
</div>
|
|
<Button
|
|
type="button"
|
|
data-testid="install-plugin-url-submit"
|
|
onClick={() => onSubmit(url.trim())}
|
|
disabled={busy || url.trim().length === 0}
|
|
className="cursor-pointer"
|
|
>
|
|
Install
|
|
</Button>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function UploadTab({ busy, onSubmit }: { busy: boolean; onSubmit: (file: File) => void }) {
|
|
const inputRef = useRef<HTMLInputElement>(null);
|
|
const [file, setFile] = useState<File | null>(null);
|
|
const [isDragging, setIsDragging] = useState(false);
|
|
|
|
const handleDragOver = (e: React.DragEvent) => {
|
|
e.preventDefault();
|
|
e.stopPropagation();
|
|
};
|
|
|
|
const handleDragEnter = (e: React.DragEvent) => {
|
|
e.preventDefault();
|
|
e.stopPropagation();
|
|
if (e.dataTransfer.types.includes("Files")) setIsDragging(true);
|
|
};
|
|
|
|
const handleDragLeave = (e: React.DragEvent) => {
|
|
e.preventDefault();
|
|
e.stopPropagation();
|
|
setIsDragging(false);
|
|
};
|
|
|
|
const handleDrop = (e: React.DragEvent) => {
|
|
e.preventDefault();
|
|
e.stopPropagation();
|
|
setIsDragging(false);
|
|
const dropped = e.dataTransfer.files[0];
|
|
if (dropped) setFile(dropped);
|
|
};
|
|
|
|
return (
|
|
<div className="space-y-3">
|
|
<div
|
|
data-testid="install-plugin-dropzone"
|
|
onDragOver={handleDragOver}
|
|
onDragEnter={handleDragEnter}
|
|
onDragLeave={handleDragLeave}
|
|
onDrop={handleDrop}
|
|
onClick={() => inputRef.current?.click()}
|
|
className={cn(
|
|
"flex flex-col items-center justify-center gap-2 rounded-lg border border-dashed border-border/70 p-6 text-center text-sm text-muted-foreground cursor-pointer",
|
|
isDragging && "border-primary bg-primary/5 ring-1 ring-primary/30",
|
|
)}
|
|
>
|
|
<span>
|
|
{file ? (
|
|
<span className="font-mono text-foreground">{file.name}</span>
|
|
) : (
|
|
"Drag and drop a .tar.gz package here, or click to browse"
|
|
)}
|
|
</span>
|
|
<input
|
|
ref={inputRef}
|
|
type="file"
|
|
accept=".tar.gz,.tgz,application/gzip"
|
|
data-testid="install-plugin-file-input"
|
|
onChange={(e) => setFile(e.target.files?.[0] ?? null)}
|
|
className="hidden"
|
|
/>
|
|
</div>
|
|
<Button
|
|
type="button"
|
|
data-testid="install-plugin-upload-submit"
|
|
onClick={() => file && onSubmit(file)}
|
|
disabled={busy || !file}
|
|
className="cursor-pointer"
|
|
>
|
|
Install
|
|
</Button>
|
|
</div>
|
|
);
|
|
}
|