Files
kandev/apps/web/components/app-sidebar/sections/settings/settings-tree.tsx
T
João Salavisa e145d48f22 feat: add plugin system with grpc runtime and native ui plugins (#1742)
* feat: add plugin system with grpc runtime and native ui plugins

- go plugin backends ship as release tarballs (per-platform binaries, checksums) that
  kandev installs from url/upload or filesystem sideload+sync, then spawns and
  supervises via hashicorp/go-plugin (unix socket / loopback tcp+automtls)
- strict typed grpc contract (kandev.plugin.v1): DeliverEvent/InvokeTool/HandleWebhook
  plus a capability-gated host service (state, secrets, emit); author sdk in
  pkg/pluginsdk; packaging cli in cmd/plugin-pack
- native frontend bundles: window.registerKandevPlugin + registry/host loader with
  dynamic routes, nav items, slots and ws handlers; plugins settings page with
  install dialog, sync button and enable/disable/uninstall
- gated behind the plugins feature flag (prod off, dev/e2e on); covered by unit and
  integration tests plus playwright e2e against a real packaged fixture plugin

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): hydrate base app context on plugin routes

Plugin-owned SPA routes classify as RouteUnknown, so the boot payload shipped
only feature flags — no workspaces, workflows, or kanban context. Native plugin
UI (e.g. host.ui.TaskCreateDialog) then had an empty store. Hydrate the same
base context as the Home route for unknown SPA routes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(plugins): expose TaskCreateDialog on host.ui

Lets a native plugin open kandev's real create-task modal (prefilled via
initialValues) instead of POSTing directly.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): harden filesystem/URL sinks against CodeQL findings

Add sink-level guards on the plugin trust boundary: securejoin containment on
archive extraction (zip-slip), plugin-id validation before every fs_store path,
http/https scheme validation on install-from-URL, and non-interpolated ws-handler
error logging.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): address review findings (races, resource caps, lifecycle)

- serialize per-plugin startup to close a TOCTOU double-spawn race, and let a
  plugin restart after exhausting attempts
- bound plugin startup with an explicit 30s timeout
- reject backslash paths and cap decompressed bytes by actual size in pkgtar;
  only mark a package Signed when a verifier actually ran and passed
- delete plugin_state on uninstall; validate webhook keys against the manifest
  and cap webhook body size; restart an active plugin when a new version installs

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): sanitize plugin-id path sinks for CodeQL

Pin the plugin id to a single path segment with filepath.Base at recordPath/
configPath and pkgtar.Remove — a barrier the taint analysis recognizes.
Behaviour-identical for valid ids (already validated by safePluginID); clears
the go/path-injection alerts.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): inline plugin-id validation at path sinks for CodeQL

filepath.Base does not strip '..', so it is not a path-injection barrier. Call
the recognized safePluginID / id-pattern guard inline in Delete/GetConfig/
SetConfig and pkgtar.Remove — the same barrier that already cleared the Get sink.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): address code-review findings (backend)

- add capability-gating tests for the Host RPC service (was untested)
- close a stop-during-start orphan race so Disable/Uninstall can't leave a
  supervised subprocess behind
- on failed upgrade, remove only the new version dir (not all versions + data);
  restart the prior version
- validate manifest version and reject ids ending in .config (record-file alias)
- make Deliverer.Refresh non-blocking and cancel in-flight delivery on worker stop
- clamp out-of-range webhook status, skip-and-warn corrupt records in List,
  write records atomically, semver-aware sideload version pick

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): address code-review findings (frontend)

- wrap plugin routes + settings routes in a shared PluginErrorBoundary so a
  throwing plugin page shows a fallback instead of white-screening the SPA
- fix disable/re-enable in one session: keep the cached registration and
  re-run initialize instead of relying on a cached ES-module re-import
- prefix root-relative bundle/style URLs with apiBaseUrl (split-origin/Tauri)
- surface partial-install warnings via toast.warning instead of a bare success
- dedupe/remove injected style links on unload; gate PluginNavItems on the flag

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): serialize per-plugin lifecycle + guard config writes

- add a per-plugin keyed lock in Service so concurrent Enable/Disable/Install/
  Uninstall/UpdateConfig for one id are serialized (no status-machine race)
- take s.mu in SetConfig/GetConfig and write config atomically
- bound each plugin initialize() with a timeout so one hung bundle can't stall
  the rest of the boot load

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test(plugins): split service_test.go to satisfy file-length lint

Move the install/URL test group into service_install_test.go; no logic change.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* ci: build and ship the e2e fixture plugin package to E2E shards

The plugin E2E specs' global-setup requires apps/backend/.build/kandev-plugin-e2e-1.0.0.tar.gz.
Build it in the E2E build job, upload it as an artifact, and download it in both
the regular and container shard jobs.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Kandev Agent <agent@kandev.dev>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-17 12:00:26 +01:00

124 lines
4.3 KiB
TypeScript

"use client";
import { useEffect, useState } from "react";
import {
IconKey,
IconMessageCircle,
IconMicrophone,
IconPlugConnected,
IconPuzzle,
IconWand,
} from "@tabler/icons-react";
import { PluginSlot } from "@/components/plugins/plugin-slot";
import { useFeature } from "@/hooks/domains/features/use-feature";
import { AgentsGroup } from "./agents-group";
import { ExecutorsGroup } from "./executors-group";
import { GeneralGroup } from "./general-group";
import { SettingsLeaf } from "./settings-nav-primitives";
import { SystemGroup } from "./system-group";
import { WorkspacesGroup } from "./workspaces-group";
const PROMPTS_HREF = "/settings/prompts";
const VOICE_MODE_HREF = "/settings/voice-mode";
const UTILITY_HREF = "/settings/utility-agents";
const SECRETS_HREF = "/settings/general/secrets";
const EXT_MCP_HREF = "/settings/external-mcp";
const PLUGINS_HREF = "/settings/plugins";
const DEFAULT_OPEN_GROUP = "workspaces";
// Single-open accordion: each top-level group owns a route prefix. The group
// whose prefix matches the current path is the open one. Prefixes are disjoint,
// so first match wins and ordering is irrelevant.
const GROUP_ROUTES = [
{ id: "general", prefix: "/settings/general" },
{ id: "workspaces", prefix: "/settings/workspace" },
{ id: "agents", prefix: "/settings/agents" },
{ id: "executors", prefix: "/settings/executors" },
{ id: "system", prefix: "/settings/system" },
] as const;
/** The settings accordion group that owns `pathname`, or null for a standalone leaf. */
export function settingsGroupIdForPath(pathname: string): string | null {
return GROUP_ROUTES.find((g) => pathname.startsWith(g.prefix))?.id ?? null;
}
export function settingsOpenGroupIdForPath(pathname: string): string {
return settingsGroupIdForPath(pathname) ?? DEFAULT_OPEN_GROUP;
}
/**
* The settings nav tree. Top-level groups behave as a single-open accordion:
* opening one closes the others and reveals its subsections. Routes without a
* top-level group open Workspaces so the active workspace settings stay visible.
*
* Rendered both inside the collapsible "Settings" sidebar section and, when the
* footer gear is active, as the full-height sidebar takeover.
*/
export function SettingsTree({ pathname }: { pathname: string }) {
const pluginsEnabled = useFeature("plugins");
const [openGroup, setOpenGroup] = useState<string | null>(() =>
settingsOpenGroupIdForPath(pathname),
);
// Re-sync when navigation lands on a different section so the open group
// always reflects the current page (a leaf with no owning group → all closed).
useEffect(() => {
setOpenGroup(settingsOpenGroupIdForPath(pathname));
}, [pathname]);
const groupProps = (id: string) => ({
expanded: openGroup === id,
onToggle: () => setOpenGroup((prev) => (prev === id ? null : id)),
});
return (
<>
<GeneralGroup pathname={pathname} {...groupProps("general")} />
<WorkspacesGroup pathname={pathname} {...groupProps("workspaces")} />
<AgentsGroup pathname={pathname} {...groupProps("agents")} />
<SettingsLeaf
href={PROMPTS_HREF}
label="Prompts"
icon={IconMessageCircle}
isActive={pathname === PROMPTS_HREF}
/>
<SettingsLeaf
href={VOICE_MODE_HREF}
label="Voice Mode"
icon={IconMicrophone}
isActive={pathname === VOICE_MODE_HREF}
/>
<SettingsLeaf
href={UTILITY_HREF}
label="Utility Agents"
icon={IconWand}
isActive={pathname === UTILITY_HREF}
/>
<ExecutorsGroup pathname={pathname} {...groupProps("executors")} />
{/* Editors lives under General (see GeneralGroup) — no duplicate top-level leaf. */}
<SettingsLeaf
href={SECRETS_HREF}
label="Secrets"
icon={IconKey}
isActive={pathname === SECRETS_HREF}
/>
<SettingsLeaf
href={EXT_MCP_HREF}
label="External MCP"
icon={IconPlugConnected}
isActive={pathname === EXT_MCP_HREF}
/>
<SystemGroup pathname={pathname} {...groupProps("system")} />
{pluginsEnabled && (
<SettingsLeaf
href={PLUGINS_HREF}
label="Plugins"
icon={IconPuzzle}
isActive={pathname === PLUGINS_HREF}
/>
)}
<PluginSlot name="settings-nav" />
</>
);
}