e145d48f22
* feat: add plugin system with grpc runtime and native ui plugins - go plugin backends ship as release tarballs (per-platform binaries, checksums) that kandev installs from url/upload or filesystem sideload+sync, then spawns and supervises via hashicorp/go-plugin (unix socket / loopback tcp+automtls) - strict typed grpc contract (kandev.plugin.v1): DeliverEvent/InvokeTool/HandleWebhook plus a capability-gated host service (state, secrets, emit); author sdk in pkg/pluginsdk; packaging cli in cmd/plugin-pack - native frontend bundles: window.registerKandevPlugin + registry/host loader with dynamic routes, nav items, slots and ws handlers; plugins settings page with install dialog, sync button and enable/disable/uninstall - gated behind the plugins feature flag (prod off, dev/e2e on); covered by unit and integration tests plus playwright e2e against a real packaged fixture plugin Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): hydrate base app context on plugin routes Plugin-owned SPA routes classify as RouteUnknown, so the boot payload shipped only feature flags — no workspaces, workflows, or kanban context. Native plugin UI (e.g. host.ui.TaskCreateDialog) then had an empty store. Hydrate the same base context as the Home route for unknown SPA routes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(plugins): expose TaskCreateDialog on host.ui Lets a native plugin open kandev's real create-task modal (prefilled via initialValues) instead of POSTing directly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): harden filesystem/URL sinks against CodeQL findings Add sink-level guards on the plugin trust boundary: securejoin containment on archive extraction (zip-slip), plugin-id validation before every fs_store path, http/https scheme validation on install-from-URL, and non-interpolated ws-handler error logging. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address review findings (races, resource caps, lifecycle) - serialize per-plugin startup to close a TOCTOU double-spawn race, and let a plugin restart after exhausting attempts - bound plugin startup with an explicit 30s timeout - reject backslash paths and cap decompressed bytes by actual size in pkgtar; only mark a package Signed when a verifier actually ran and passed - delete plugin_state on uninstall; validate webhook keys against the manifest and cap webhook body size; restart an active plugin when a new version installs Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): sanitize plugin-id path sinks for CodeQL Pin the plugin id to a single path segment with filepath.Base at recordPath/ configPath and pkgtar.Remove — a barrier the taint analysis recognizes. Behaviour-identical for valid ids (already validated by safePluginID); clears the go/path-injection alerts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): inline plugin-id validation at path sinks for CodeQL filepath.Base does not strip '..', so it is not a path-injection barrier. Call the recognized safePluginID / id-pattern guard inline in Delete/GetConfig/ SetConfig and pkgtar.Remove — the same barrier that already cleared the Get sink. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address code-review findings (backend) - add capability-gating tests for the Host RPC service (was untested) - close a stop-during-start orphan race so Disable/Uninstall can't leave a supervised subprocess behind - on failed upgrade, remove only the new version dir (not all versions + data); restart the prior version - validate manifest version and reject ids ending in .config (record-file alias) - make Deliverer.Refresh non-blocking and cancel in-flight delivery on worker stop - clamp out-of-range webhook status, skip-and-warn corrupt records in List, write records atomically, semver-aware sideload version pick Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address code-review findings (frontend) - wrap plugin routes + settings routes in a shared PluginErrorBoundary so a throwing plugin page shows a fallback instead of white-screening the SPA - fix disable/re-enable in one session: keep the cached registration and re-run initialize instead of relying on a cached ES-module re-import - prefix root-relative bundle/style URLs with apiBaseUrl (split-origin/Tauri) - surface partial-install warnings via toast.warning instead of a bare success - dedupe/remove injected style links on unload; gate PluginNavItems on the flag Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): serialize per-plugin lifecycle + guard config writes - add a per-plugin keyed lock in Service so concurrent Enable/Disable/Install/ Uninstall/UpdateConfig for one id are serialized (no status-machine race) - take s.mu in SetConfig/GetConfig and write config atomically - bound each plugin initialize() with a timeout so one hung bundle can't stall the rest of the boot load Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(plugins): split service_test.go to satisfy file-length lint Move the install/URL test group into service_install_test.go; no logic change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * ci: build and ship the e2e fixture plugin package to E2E shards The plugin E2E specs' global-setup requires apps/backend/.build/kandev-plugin-e2e-1.0.0.tar.gz. Build it in the E2E build job, upload it as an artifact, and download it in both the regular and container shard jobs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
108 lines
3.9 KiB
Go
108 lines
3.9 KiB
Go
package pluginsdk
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
hcplugin "github.com/hashicorp/go-plugin"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
// fakeAuthorPlugin is a minimal author-facing Plugin used to exercise the
|
|
// real go-plugin gRPC + broker wiring end to end (no subprocess spawn —
|
|
// hcplugin.TestPluginGRPCConn wires a real unix-socket grpc.Server/Client
|
|
// pair with a real GRPCBroker, matching production transport behavior).
|
|
type fakeAuthorPlugin struct {
|
|
UnimplementedPlugin
|
|
events []*Event
|
|
}
|
|
|
|
func (p *fakeAuthorPlugin) OnEvent(_ context.Context, e *Event) error {
|
|
p.events = append(p.events, e)
|
|
return nil
|
|
}
|
|
|
|
func (p *fakeAuthorPlugin) InvokeTool(_ context.Context, req *ToolRequest) (*ToolResponse, error) {
|
|
return &ToolResponse{Output: map[string]any{"echo": req.ToolName}}, nil
|
|
}
|
|
|
|
func (p *fakeAuthorPlugin) HandleWebhook(_ context.Context, req *WebhookRequest) (*WebhookResponse, error) {
|
|
return &WebhookResponse{Status: 200, Body: append([]byte("got:"), req.Body...)}, nil
|
|
}
|
|
|
|
// TestServe_EndToEnd exercises the same GRPCPlugin wiring Serve() (plugin
|
|
// side) and kandev's runtime manager (host side, via plugin.NewClient)
|
|
// use, over a real go-plugin gRPC connection + broker
|
|
// (hcplugin.TestPluginGRPCConn). It covers all three Plugin RPCs plus the
|
|
// Host broker round trip (§3/§4 of docs/plans/plugins/GRPC-CONTRACT.md).
|
|
func TestServe_EndToEnd(t *testing.T) {
|
|
author := &fakeAuthorPlugin{}
|
|
hostImpl := &recordingHost{
|
|
getStateFn: func(_ context.Context, scope, scopeID, key string) (map[string]any, bool, error) {
|
|
if scope == "task" && scopeID == "t1" && key == "k1" {
|
|
return map[string]any{"greeting": "hi"}, true, nil
|
|
}
|
|
return nil, false, nil
|
|
},
|
|
}
|
|
// hcplugin.TestPluginGRPCConn dispenses/serves the SAME Plugin value on
|
|
// both ends of the harness (there's no real process boundary), so one
|
|
// GRPCPlugin with both Impl and Host set plays both roles: GRPCServer
|
|
// runs as the "plugin subprocess" would, GRPCClient runs as "kandev"
|
|
// would. In production these are two separate processes each setting
|
|
// only one of Impl/Host.
|
|
gp := &GRPCPlugin{Impl: author, Host: hostImpl, HostDialTimeout: 5 * time.Second}
|
|
|
|
client, server := hcplugin.TestPluginGRPCConn(t, false, map[string]hcplugin.Plugin{
|
|
PluginMapKey: gp,
|
|
})
|
|
defer func() { _ = client.Close() }()
|
|
defer server.Stop()
|
|
|
|
raw, err := client.Dispense(PluginMapKey)
|
|
require.NoError(t, err)
|
|
remote, ok := raw.(*RemotePlugin)
|
|
require.True(t, ok, "Dispense(%q) should return *RemotePlugin, got %T", PluginMapKey, raw)
|
|
|
|
t.Run("DeliverEvent", func(t *testing.T) {
|
|
err := remote.DeliverEvent(context.Background(), &Event{
|
|
EventID: "e1",
|
|
EventType: "task.created",
|
|
Payload: map[string]any{"a": float64(1)},
|
|
})
|
|
require.NoError(t, err)
|
|
require.Len(t, author.events, 1)
|
|
require.Equal(t, "e1", author.events[0].EventID)
|
|
require.Equal(t, map[string]any{"a": float64(1)}, author.events[0].Payload)
|
|
})
|
|
|
|
t.Run("InvokeTool", func(t *testing.T) {
|
|
resp, err := remote.InvokeTool(context.Background(), &ToolRequest{ToolName: "search"})
|
|
require.NoError(t, err)
|
|
require.Equal(t, "search", resp.Output["echo"])
|
|
})
|
|
|
|
t.Run("HandleWebhook", func(t *testing.T) {
|
|
resp, err := remote.HandleWebhook(context.Background(), &WebhookRequest{Body: []byte("hi")})
|
|
require.NoError(t, err)
|
|
require.Equal(t, int32(200), resp.Status)
|
|
require.Equal(t, []byte("got:hi"), resp.Body)
|
|
})
|
|
|
|
t.Run("HostBrokerRoundTrip", func(t *testing.T) {
|
|
require.Eventually(t, func() bool {
|
|
return author.Host() != nil
|
|
}, 5*time.Second, 10*time.Millisecond, "Serve-equivalent GRPCServer should inject Host via the broker")
|
|
|
|
value, found, err := author.Host().GetState(context.Background(), "task", "t1", "k1")
|
|
require.NoError(t, err)
|
|
require.True(t, found)
|
|
require.Equal(t, map[string]any{"greeting": "hi"}, value)
|
|
|
|
_, found, err = author.Host().GetState(context.Background(), "task", "t1", "missing")
|
|
require.NoError(t, err)
|
|
require.False(t, found)
|
|
})
|
|
}
|