9381a6a9f7
* fix(scripts): launch dev-isolated backend via __backend subcommand The kandev binary became a bundle launcher with the restart supervisor (ADR 0019) and exits without KANDEV_BUNDLE_DIR when invoked bare; the isolated dev instance must run the backend entrypoint directly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(mcp): session spawning, sibling messaging, and renameable tabs - spawn_session_kandev spawns an additional agent session on an existing task (default: the caller's own) via LaunchSession(IntentStart), with optional agent_profile_id (defaults to the spawner's profile) and a session name; the initial prompt carries spawner attribution and reply instructions. - message_task_kandev accepts an optional session_id to target a specific session, enabling same-task sibling messaging. Explicit targets are pinned through dispatch so the idle-path primary-session re-resolution cannot reroute a sibling message back to its sender (regression-tested). - task_sessions gains a name column (migration ordered after the agent_execution_id-drop rebuild), a session.rename WS action, and inline tab rename UI; custom names take precedence over derived agent/model labels across the tab, agents dropdown, mobile list, chat header, and dockview panel titles. - Inter-session messages stamp sender_session_name into metadata so the sender badge shows which session sent the message. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(mcp): address review findings on session spawn/rename/messaging - include name in task-session DTOs (list + full, no omitempty) so persisted tab names survive list hydration and clears propagate - sanitize sender task/session ids embedded in <kandev-system> blocks - reject cross-workspace spawn targets; require sender_task_id - truncate session names by runes, not bytes - distinguish not-found from internal errors in message target lookup - guard TabRenameInput blur-commit after Enter/Escape resolution - cap optimistic rename length client-side and toast on rename failure - add tests: spawn launch-failure and cross-workspace paths, renameSession API client Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(mcp): round-two review fixes for spawn/rename lint and hardening - extract spawn validation/authorization helpers (cyclop/nestif limits) - make stripSystemTag replace until stable to block nested tag evasion - load session before rename so a durable rename can never skip its broadcast; surface lookup failures to the caller instead - drop redundant sessionLauncher nil check (guarded registration) - add maxLength to the rename input matching the server cap - add tests: nested sanitizer evasion, spawn rename-failure tolerance Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
159 lines
4.8 KiB
Go
159 lines
4.8 KiB
Go
package orchestrator
|
|
|
|
import v1 "github.com/kandev/kandev/pkg/api/v1"
|
|
|
|
// UserMessageMeta holds metadata fields for a user message.
|
|
// Use NewUserMessageMeta to construct and ToMap to serialize.
|
|
type UserMessageMeta struct {
|
|
PlanMode bool
|
|
HasReviewComments bool
|
|
AutoStart bool
|
|
Attachments []v1.MessageAttachment
|
|
ContextFiles []v1.ContextFileMeta
|
|
SenderTaskID string
|
|
SenderTaskTitle string
|
|
SenderSessionID string
|
|
SenderSessionName string
|
|
WorkflowMessage bool
|
|
WorkflowStepID string
|
|
WorkflowStepName string
|
|
WorkflowStepColor string
|
|
}
|
|
|
|
// NewUserMessageMeta creates a UserMessageMeta builder.
|
|
func NewUserMessageMeta() *UserMessageMeta {
|
|
return &UserMessageMeta{}
|
|
}
|
|
|
|
// WithPlanMode marks the message as having plan mode enabled.
|
|
func (m *UserMessageMeta) WithPlanMode(enabled bool) *UserMessageMeta {
|
|
m.PlanMode = enabled
|
|
return m
|
|
}
|
|
|
|
// WithReviewComments marks the message as containing review comments.
|
|
func (m *UserMessageMeta) WithReviewComments(has bool) *UserMessageMeta {
|
|
m.HasReviewComments = has
|
|
return m
|
|
}
|
|
|
|
// WithAutoStart marks the message as having been created by an automated
|
|
// trigger (workflow auto-start, PR/issue watch, Jira/Linear integration)
|
|
// rather than direct user input. Used by the GitHub cleanup logic to
|
|
// distinguish "the agent ran on its own" from "the user actually engaged".
|
|
func (m *UserMessageMeta) WithAutoStart(enabled bool) *UserMessageMeta {
|
|
m.AutoStart = enabled
|
|
return m
|
|
}
|
|
|
|
// WithAttachments sets the message attachments.
|
|
func (m *UserMessageMeta) WithAttachments(attachments []v1.MessageAttachment) *UserMessageMeta {
|
|
m.Attachments = attachments
|
|
return m
|
|
}
|
|
|
|
// WithContextFiles sets the context files attached to the message.
|
|
func (m *UserMessageMeta) WithContextFiles(files []v1.ContextFileMeta) *UserMessageMeta {
|
|
m.ContextFiles = files
|
|
return m
|
|
}
|
|
|
|
// WithSenderTask records that the message originated from another task's agent
|
|
// (via the message_task_kandev MCP tool). Title is a snapshot at send time;
|
|
// session ID is optional and identifies the sender's specific session.
|
|
func (m *UserMessageMeta) WithSenderTask(taskID, taskTitle, sessionID string) *UserMessageMeta {
|
|
m.SenderTaskID = taskID
|
|
m.SenderTaskTitle = taskTitle
|
|
m.SenderSessionID = sessionID
|
|
return m
|
|
}
|
|
|
|
// WithSenderSessionName records the sender session's user-supplied name (a
|
|
// snapshot at send time) so the receiving chat's sender badge can show which
|
|
// session sent the message, not just which task.
|
|
func (m *UserMessageMeta) WithSenderSessionName(name string) *UserMessageMeta {
|
|
m.SenderSessionName = name
|
|
return m
|
|
}
|
|
|
|
// WithWorkflowStep records that the message was generated by workflow step
|
|
// automation rather than a direct user or inter-task agent message.
|
|
func (m *UserMessageMeta) WithWorkflowStep(stepID, stepName, stepColor string) *UserMessageMeta {
|
|
m.WorkflowMessage = true
|
|
m.WorkflowStepID = stepID
|
|
m.WorkflowStepName = stepName
|
|
m.WorkflowStepColor = stepColor
|
|
return m
|
|
}
|
|
|
|
// ToMap returns the metadata as a map suitable for message creation.
|
|
// Returns nil if no metadata fields are set.
|
|
func (m *UserMessageMeta) ToMap() map[string]interface{} {
|
|
if !m.PlanMode && !m.HasReviewComments && !m.AutoStart && len(m.Attachments) == 0 && len(m.ContextFiles) == 0 && m.SenderTaskID == "" && !m.WorkflowMessage {
|
|
return nil
|
|
}
|
|
meta := make(map[string]interface{})
|
|
if m.PlanMode {
|
|
meta["plan_mode"] = true
|
|
}
|
|
if m.HasReviewComments {
|
|
meta["has_review_comments"] = true
|
|
}
|
|
if m.AutoStart {
|
|
meta["auto_start"] = true
|
|
}
|
|
if len(m.Attachments) > 0 {
|
|
meta["attachments"] = m.Attachments
|
|
}
|
|
if len(m.ContextFiles) > 0 {
|
|
meta["context_files"] = m.ContextFiles
|
|
}
|
|
if m.SenderTaskID != "" {
|
|
meta["sender_task_id"] = m.SenderTaskID
|
|
meta["sender_task_title"] = m.SenderTaskTitle
|
|
if m.SenderSessionID != "" {
|
|
meta["sender_session_id"] = m.SenderSessionID
|
|
}
|
|
if m.SenderSessionName != "" {
|
|
meta["sender_session_name"] = m.SenderSessionName
|
|
}
|
|
}
|
|
if m.WorkflowMessage {
|
|
meta["workflow_message"] = true
|
|
if m.WorkflowStepID != "" {
|
|
meta["workflow_step_id"] = m.WorkflowStepID
|
|
}
|
|
if m.WorkflowStepName != "" {
|
|
meta["workflow_step_name"] = m.WorkflowStepName
|
|
}
|
|
if m.WorkflowStepColor != "" {
|
|
meta["workflow_step_color"] = m.WorkflowStepColor
|
|
}
|
|
}
|
|
return meta
|
|
}
|
|
|
|
// mergeMetadata returns a single metadata map combining base and extra. extra
|
|
// values take precedence on key collision. Returns nil only when both inputs
|
|
// are nil/empty so callers can keep the "no metadata" branch in the message
|
|
// store.
|
|
func mergeMetadata(base, extra map[string]interface{}) map[string]interface{} {
|
|
if len(base) == 0 && len(extra) == 0 {
|
|
return nil
|
|
}
|
|
if len(extra) == 0 {
|
|
return base
|
|
}
|
|
if len(base) == 0 {
|
|
return extra
|
|
}
|
|
merged := make(map[string]interface{}, len(base)+len(extra))
|
|
for k, v := range base {
|
|
merged[k] = v
|
|
}
|
|
for k, v := range extra {
|
|
merged[k] = v
|
|
}
|
|
return merged
|
|
}
|