e145d48f22
* feat: add plugin system with grpc runtime and native ui plugins - go plugin backends ship as release tarballs (per-platform binaries, checksums) that kandev installs from url/upload or filesystem sideload+sync, then spawns and supervises via hashicorp/go-plugin (unix socket / loopback tcp+automtls) - strict typed grpc contract (kandev.plugin.v1): DeliverEvent/InvokeTool/HandleWebhook plus a capability-gated host service (state, secrets, emit); author sdk in pkg/pluginsdk; packaging cli in cmd/plugin-pack - native frontend bundles: window.registerKandevPlugin + registry/host loader with dynamic routes, nav items, slots and ws handlers; plugins settings page with install dialog, sync button and enable/disable/uninstall - gated behind the plugins feature flag (prod off, dev/e2e on); covered by unit and integration tests plus playwright e2e against a real packaged fixture plugin Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): hydrate base app context on plugin routes Plugin-owned SPA routes classify as RouteUnknown, so the boot payload shipped only feature flags — no workspaces, workflows, or kanban context. Native plugin UI (e.g. host.ui.TaskCreateDialog) then had an empty store. Hydrate the same base context as the Home route for unknown SPA routes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(plugins): expose TaskCreateDialog on host.ui Lets a native plugin open kandev's real create-task modal (prefilled via initialValues) instead of POSTing directly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): harden filesystem/URL sinks against CodeQL findings Add sink-level guards on the plugin trust boundary: securejoin containment on archive extraction (zip-slip), plugin-id validation before every fs_store path, http/https scheme validation on install-from-URL, and non-interpolated ws-handler error logging. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address review findings (races, resource caps, lifecycle) - serialize per-plugin startup to close a TOCTOU double-spawn race, and let a plugin restart after exhausting attempts - bound plugin startup with an explicit 30s timeout - reject backslash paths and cap decompressed bytes by actual size in pkgtar; only mark a package Signed when a verifier actually ran and passed - delete plugin_state on uninstall; validate webhook keys against the manifest and cap webhook body size; restart an active plugin when a new version installs Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): sanitize plugin-id path sinks for CodeQL Pin the plugin id to a single path segment with filepath.Base at recordPath/ configPath and pkgtar.Remove — a barrier the taint analysis recognizes. Behaviour-identical for valid ids (already validated by safePluginID); clears the go/path-injection alerts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): inline plugin-id validation at path sinks for CodeQL filepath.Base does not strip '..', so it is not a path-injection barrier. Call the recognized safePluginID / id-pattern guard inline in Delete/GetConfig/ SetConfig and pkgtar.Remove — the same barrier that already cleared the Get sink. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address code-review findings (backend) - add capability-gating tests for the Host RPC service (was untested) - close a stop-during-start orphan race so Disable/Uninstall can't leave a supervised subprocess behind - on failed upgrade, remove only the new version dir (not all versions + data); restart the prior version - validate manifest version and reject ids ending in .config (record-file alias) - make Deliverer.Refresh non-blocking and cancel in-flight delivery on worker stop - clamp out-of-range webhook status, skip-and-warn corrupt records in List, write records atomically, semver-aware sideload version pick Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address code-review findings (frontend) - wrap plugin routes + settings routes in a shared PluginErrorBoundary so a throwing plugin page shows a fallback instead of white-screening the SPA - fix disable/re-enable in one session: keep the cached registration and re-run initialize instead of relying on a cached ES-module re-import - prefix root-relative bundle/style URLs with apiBaseUrl (split-origin/Tauri) - surface partial-install warnings via toast.warning instead of a bare success - dedupe/remove injected style links on unload; gate PluginNavItems on the flag Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): serialize per-plugin lifecycle + guard config writes - add a per-plugin keyed lock in Service so concurrent Enable/Disable/Install/ Uninstall/UpdateConfig for one id are serialized (no status-machine race) - take s.mu in SetConfig/GetConfig and write config atomically - bound each plugin initialize() with a timeout so one hung bundle can't stall the rest of the boot load Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(plugins): split service_test.go to satisfy file-length lint Move the install/URL test group into service_install_test.go; no logic change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * ci: build and ship the e2e fixture plugin package to E2E shards The plugin E2E specs' global-setup requires apps/backend/.build/kandev-plugin-e2e-1.0.0.tar.gz. Build it in the E2E build job, upload it as an artifact, and download it in both the regular and container shard jobs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
160 lines
4.9 KiB
Go
160 lines
4.9 KiB
Go
// Package main implements fixturePlugin, the pluginsdk.Plugin backing the
|
|
// plugin-fixture binary (see the package doc comment in main.go).
|
|
package main
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"sync"
|
|
|
|
"github.com/kandev/kandev/pkg/pluginsdk"
|
|
)
|
|
|
|
const (
|
|
deliveriesFileName = "deliveries.jsonl"
|
|
webhooksFileName = "webhooks.jsonl"
|
|
|
|
toolNameEcho = "echo"
|
|
)
|
|
|
|
// deliveryRecord is one recorded OnEvent delivery, appended as a JSON line
|
|
// to deliveries.jsonl. e2e tests poll this file as evidence that an event
|
|
// reached the plugin over the real gRPC transport.
|
|
type deliveryRecord struct {
|
|
EventType string `json:"event_type"`
|
|
EventID string `json:"event_id"`
|
|
}
|
|
|
|
// webhookRecord is one recorded HandleWebhook delivery, appended as a JSON
|
|
// line to webhooks.jsonl.
|
|
type webhookRecord struct {
|
|
WebhookKey string `json:"webhook_key"`
|
|
Method string `json:"method"`
|
|
}
|
|
|
|
// fixturePlugin implements pluginsdk.Plugin (via UnimplementedPlugin) for
|
|
// Go integration tests and Playwright e2e: it records every delivery to
|
|
// disk under dataDir so tests can poll for evidence without needing their
|
|
// own gRPC client.
|
|
type fixturePlugin struct {
|
|
pluginsdk.UnimplementedPlugin
|
|
|
|
dataDir string
|
|
|
|
mu sync.Mutex
|
|
sawFirstEvent bool
|
|
}
|
|
|
|
var _ pluginsdk.Plugin = (*fixturePlugin)(nil)
|
|
|
|
// newFixturePlugin builds a fixturePlugin whose data directory is resolved
|
|
// from KANDEV_PLUGIN_DATA_DIR (falling back to the current working
|
|
// directory), per §2 of docs/plans/plugins/GRPC-CONTRACT.md.
|
|
func newFixturePlugin() *fixturePlugin {
|
|
return &fixturePlugin{dataDir: resolveDataDir()}
|
|
}
|
|
|
|
// resolveDataDir returns KANDEV_PLUGIN_DATA_DIR if set, otherwise the
|
|
// current working directory.
|
|
func resolveDataDir() string {
|
|
if dir := os.Getenv("KANDEV_PLUGIN_DATA_DIR"); dir != "" {
|
|
return dir
|
|
}
|
|
wd, err := os.Getwd()
|
|
if err != nil {
|
|
return "."
|
|
}
|
|
return wd
|
|
}
|
|
|
|
// OnEvent appends a deliveries.jsonl line recording the event, then — only
|
|
// for the first event this process instance has seen — best-effort
|
|
// exercises the Host.SetState round trip (errors are ignored; this is
|
|
// coverage, not a critical path).
|
|
func (p *fixturePlugin) OnEvent(ctx context.Context, e *pluginsdk.Event) error {
|
|
rec := deliveryRecord{EventType: e.EventType, EventID: e.EventID}
|
|
if err := appendJSONLine(filepath.Join(p.dataDir, deliveriesFileName), rec); err != nil {
|
|
return err
|
|
}
|
|
|
|
if p.markFirstEvent() {
|
|
p.recordLastEventBestEffort(ctx, e)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// markFirstEvent returns true exactly once (on the first call), false on
|
|
// every subsequent call.
|
|
func (p *fixturePlugin) markFirstEvent() bool {
|
|
p.mu.Lock()
|
|
defer p.mu.Unlock()
|
|
if p.sawFirstEvent {
|
|
return false
|
|
}
|
|
p.sawFirstEvent = true
|
|
return true
|
|
}
|
|
|
|
// recordLastEventBestEffort calls Host.SetState("instance", "",
|
|
// "last_event", ...) if a Host has been injected. Errors (including "no
|
|
// Host yet") are silently ignored — this exists purely to exercise the
|
|
// Host round trip for e2e coverage, not to guarantee delivery.
|
|
func (p *fixturePlugin) recordLastEventBestEffort(ctx context.Context, e *pluginsdk.Event) {
|
|
host := p.Host()
|
|
if host == nil {
|
|
return
|
|
}
|
|
_ = host.SetState(ctx, "instance", "", "last_event", map[string]any{
|
|
"event_type": e.EventType,
|
|
"event_id": e.EventID,
|
|
})
|
|
}
|
|
|
|
// InvokeTool implements the fixture's only declared tool ("echo"): it
|
|
// returns the request's input unchanged as the response output.
|
|
func (p *fixturePlugin) InvokeTool(_ context.Context, req *pluginsdk.ToolRequest) (*pluginsdk.ToolResponse, error) {
|
|
if req.ToolName != toolNameEcho {
|
|
return &pluginsdk.ToolResponse{Error: fmt.Sprintf("unknown tool %q", req.ToolName)}, nil
|
|
}
|
|
return &pluginsdk.ToolResponse{Output: req.Input}, nil
|
|
}
|
|
|
|
// HandleWebhook appends a webhooks.jsonl line recording the delivery, and
|
|
// responds 200 "ok".
|
|
func (p *fixturePlugin) HandleWebhook(_ context.Context, req *pluginsdk.WebhookRequest) (*pluginsdk.WebhookResponse, error) {
|
|
rec := webhookRecord{WebhookKey: req.WebhookKey, Method: req.Method}
|
|
if err := appendJSONLine(filepath.Join(p.dataDir, webhooksFileName), rec); err != nil {
|
|
return nil, err
|
|
}
|
|
return &pluginsdk.WebhookResponse{Status: 200, Body: []byte("ok")}, nil
|
|
}
|
|
|
|
// appendJSONLine marshals v to a single JSON line and appends it to path,
|
|
// creating path's parent directory and the file itself as needed.
|
|
func appendJSONLine(path string, v any) error {
|
|
if err := os.MkdirAll(filepath.Dir(path), 0o755); err != nil {
|
|
return fmt.Errorf("plugin-fixture: creating data dir for %s: %w", path, err)
|
|
}
|
|
|
|
data, err := json.Marshal(v)
|
|
if err != nil {
|
|
return fmt.Errorf("plugin-fixture: marshaling record: %w", err)
|
|
}
|
|
data = append(bytes.TrimRight(data, "\n"), '\n')
|
|
|
|
f, err := os.OpenFile(path, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0o644)
|
|
if err != nil {
|
|
return fmt.Errorf("plugin-fixture: opening %s: %w", path, err)
|
|
}
|
|
defer func() { _ = f.Close() }()
|
|
|
|
if _, err := f.Write(data); err != nil {
|
|
return fmt.Errorf("plugin-fixture: writing %s: %w", path, err)
|
|
}
|
|
return f.Close()
|
|
}
|