5936bb6808
* test: add e2e coverage and mock backends for jira and linear integrations
Adds in-memory MockClient + MockController for both integrations gated by
KANDEV_MOCK_{JIRA,LINEAR}=true, plus apiClient mock helpers and Playwright
specs covering settings and import flows.
Also fixes ValidatedPopover's TriggerButton silently dropping radix Slot's
onClick handler — the popover wouldn't open under any synthetic-click path
(including Playwright). Spreads `...rest` onto the inner Button.
Reworks the integration cleanup hook in test-base as an auto fixture so it
runs for every test using the imported `test` object, not just tests in the
fixture file itself.
* fix: address PR review feedback on jira/linear mocks and e2e specs
- Fix SetAuthResult docstrings: nil simulates an unconfigured state, not the default success.
- Drop unused JSON tags from doneTransitionCall and setStateCall (Go-only test fixtures).
- Track Linear issue insertion order so SearchIssues returns deterministic results instead of map-iteration shuffle.
- Document filterByJQL precedence at the SearchTickets call site so the all-hits-on-no-match fallback is visible.
- Wait for the post-save auth-health probe before forcing a failure in the seeded-failure tests, eliminating a goroutine race.
- Reorder authMethod precedence in setJiraConfig/setLinearConfig to put the spread first so 'caller wins' reads naturally.
---------
Co-authored-by: Kandev Agent <agent@kandev.dev>
55 lines
1.7 KiB
Go
55 lines
1.7 KiB
Go
package linear
|
|
|
|
import (
|
|
"os"
|
|
|
|
"github.com/gin-gonic/gin"
|
|
"github.com/jmoiron/sqlx"
|
|
|
|
"github.com/kandev/kandev/internal/common/logger"
|
|
)
|
|
|
|
// mockEnvVar gates the in-memory mock client used in E2E tests.
|
|
const mockEnvVar = "KANDEV_MOCK_LINEAR"
|
|
|
|
// MockEnabled reports whether KANDEV_MOCK_LINEAR is set to "true".
|
|
func MockEnabled() bool {
|
|
return os.Getenv(mockEnvVar) == "true"
|
|
}
|
|
|
|
// Provide builds the Linear service. Cleanup is a no-op today — the service
|
|
// holds only in-memory client caches — but the signature mirrors other
|
|
// integration providers so callers can register it uniformly.
|
|
//
|
|
// When KANDEV_MOCK_LINEAR=true, the service is wired to a process-wide
|
|
// MockClient and the same instance is exposed via Service.MockClient() so the
|
|
// E2E mock controller can drive it.
|
|
func Provide(writer, reader *sqlx.DB, secrets SecretStore, log *logger.Logger) (*Service, func() error, error) {
|
|
store, err := NewStore(writer, reader)
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
clientFn := DefaultClientFactory
|
|
var mock *MockClient
|
|
if MockEnabled() {
|
|
mock = NewMockClient()
|
|
clientFn = MockClientFactory(mock)
|
|
log.Info("linear: using in-memory mock client (KANDEV_MOCK_LINEAR=true)")
|
|
}
|
|
svc := NewService(store, secrets, clientFn, log)
|
|
svc.mockClient = mock
|
|
cleanup := func() error { return nil }
|
|
return svc, cleanup, nil
|
|
}
|
|
|
|
// RegisterMockRoutes mounts the mock control routes when the service was built
|
|
// with a MockClient. No-op otherwise.
|
|
func RegisterMockRoutes(router *gin.Engine, svc *Service, log *logger.Logger) {
|
|
mock := svc.MockClient()
|
|
if mock == nil {
|
|
return
|
|
}
|
|
NewMockController(mock, svc.Store(), log).RegisterRoutes(router)
|
|
log.Info("registered Linear mock control endpoints")
|
|
}
|