83e01477df
* refactor: extract shared shapes between jira and linear integrations Factors out the duplicated logic between internal/jira + internal/linear (backend) and components/jira + components/linear (frontend) into reusable shared shapes. Follow-up to PR #736. Backend: - New internal/integrations/secretadapter wraps secrets.SecretStore with the upsert API both jira.SecretStore and linear.SecretStore expect; drops both adapter copies from cmd/kandev/services.go. - New internal/integrations/healthpoll owns the 90s auth-health loop via a Prober interface; linear/poller.go is a thin wrapper, jira/poller.go keeps only its (jira-specific) issue-watch loop. - provideServices split into initGitHubService / initJiraService / initLinearService — now 75 lines (was ~125, exceeded the 80-line limit). Frontend: - New hooks/domains/integrations/use-integration-availability.ts and use-integration-enabled.ts; jira/linear hooks reduce to one-line delegates and move from components/<x>/ to hooks/domains/<x>/ per the project convention Greptile flagged on PR #736. - New components/integrations/{auth-status-banner,auth-error-message, validated-popover}.tsx; the four link/import-bar wrappers drop from ~110 lines to ~35 each, and JiraLinkButton picks up the clear-error-on-close behaviour LinearLinkButton already had. Docs: - New 'Adding a new third-party integration' section in CLAUDE.md/AGENTS.md documenting the shared shapes and intentional Jira/Linear divergence (transition vs state, JQL vs filter object, eventBus only on jira). * fix: address PR #759 review feedback - validated-popover: outline-with-label trigger now sets type="button" and honours triggerDisabled, matching ghost-icon (Greptile, Claude, CodeRabbit). - jira-link-button / linear-link-button: move updateTask() into the awaited fetch path so a failed title update surfaces as the popover's inline error instead of an unhandled rejection (CodeRabbit). - use-integration-availability: monotonic requestId race guard prevents a slow earlier probe from overwriting a newer auth result (CodeRabbit). - use-integration-enabled: drop unnecessary async on synchronous init (Claude). - jira/linear poller smoke tests: wrap in testing/synctest instead of time.After(2s) per backend testing convention (CodeRabbit nitpick). Skipped with reasoning on the threads: - secretadapter Set TOCTOU — single-process SQLite + single-writer per workspace; constraint violation on conflict surfaces as an error to the caller, not silent corruption. - healthpoll SetInterval validation — the function isn't called from production code today; a panic on misuse would be a footgun and silent ignore would just hide bugs differently. * fix: address PR #759 round-2 review feedback - jira-settings / linear-settings: drop the local STATUS_REFRESH_MS = 90_000 copies and import the shared INTEGRATION_STATUS_REFRESH_MS so changing the cadence only touches one file (Claude). - healthpoll: rename Poller.ProbeAll → probeAll. The only callers are the loop and the in-package tests, so widening the public API wasn't buying anything (Claude). * fix: invalidate ValidatedPopover in-flight submits on close If the user clicked Submit and dismissed the popover before the request settled, the next time they re-opened it would inherit `loading=true` (the disabled-while-loading submit button was stuck) and a late rejection from the previous session could repopulate `error` in the new one. Track the submit via a `useRef` token, bump it on close, and ignore any result/rejection whose token no longer matches. Also reset `loading` and `error` on close so the next open starts clean. Adds a regression test covering both the late-resolution and late-rejection paths. Addresses CodeRabbit review on PR #759. * ci: trigger workflow re-run GitHub Actions did not dispatch the pull_request workflows on the previous two pushes (1d869f0e,0ab6c034); only pull_request_target and CodeQL fired. Empty commit to nudge synchronize event. * fix: address PR #759 round-3 review feedback - jira.Poller.Stop: add nil-receiver guard so callers using the defer-Stop-after-NewPoller pattern don't panic when initJiraService returned nil (Greptile + Claude). Matches linear.Poller's guard. - healthpoll TestStart_RunsImmediateProbe + TestStart_IsIdempotent: rewrap in testing/synctest with synctest.Wait() instead of time.After(2s) wall-clock waits. Drops the now-unused probedAll signal channel from fakeProber (Claude). --------- Co-authored-by: Kandev Agent <agent@kandev.dev>
141 lines
4.1 KiB
Go
141 lines
4.1 KiB
Go
package linear
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"testing"
|
|
"testing/synctest"
|
|
|
|
"github.com/kandev/kandev/internal/common/logger"
|
|
)
|
|
|
|
// pollerFixture wires a Service against a real in-memory store and fake
|
|
// client/secret store. The auth-loop semantics live in
|
|
// internal/integrations/healthpoll; the tests here cover the linear-specific
|
|
// integration of the loop with Service.RecordAuthHealth (org_slug capture,
|
|
// error preservation) and the Start/Stop smoke wiring.
|
|
type pollerFixture struct {
|
|
store *Store
|
|
secrets *fakeSecretStore
|
|
client *fakeClient
|
|
svc *Service
|
|
poller *Poller
|
|
}
|
|
|
|
func newPollerFixture(t *testing.T) *pollerFixture {
|
|
t.Helper()
|
|
f := &pollerFixture{
|
|
store: newTestStore(t),
|
|
secrets: newFakeSecretStore(),
|
|
client: &fakeClient{},
|
|
}
|
|
f.svc = NewService(f.store, f.secrets, func(_ *LinearConfig, _ string) Client {
|
|
return f.client
|
|
}, logger.Default())
|
|
f.poller = NewPoller(f.svc, logger.Default())
|
|
return f
|
|
}
|
|
|
|
// saveConfig persists a workspace config directly via the store + secret
|
|
// fakes — bypassing Service.SetConfig avoids racing against its async probe.
|
|
func (f *pollerFixture) saveConfig(t *testing.T, workspaceID, secret string) {
|
|
t.Helper()
|
|
ctx := context.Background()
|
|
if err := f.store.UpsertConfig(ctx, &LinearConfig{
|
|
WorkspaceID: workspaceID,
|
|
AuthMethod: AuthMethodAPIKey,
|
|
}); err != nil {
|
|
t.Fatalf("save config %s: %v", workspaceID, err)
|
|
}
|
|
if err := f.secrets.Set(ctx, SecretKeyForWorkspace(workspaceID),
|
|
"linear", secret); err != nil {
|
|
t.Fatalf("save secret %s: %v", workspaceID, err)
|
|
}
|
|
}
|
|
|
|
func TestService_RecordAuthHealth_RecordsSuccess(t *testing.T) {
|
|
f := newPollerFixture(t)
|
|
f.saveConfig(t, "ws-1", "tok")
|
|
f.client.testAuthFn = func() (*TestConnectionResult, error) {
|
|
return &TestConnectionResult{OK: true, OrgSlug: "acme"}, nil
|
|
}
|
|
|
|
f.svc.RecordAuthHealth(context.Background(), "ws-1")
|
|
|
|
cfg, _ := f.store.GetConfig(context.Background(), "ws-1")
|
|
if cfg == nil {
|
|
t.Fatal("config disappeared")
|
|
}
|
|
if !cfg.LastOk {
|
|
t.Error("expected LastOk=true after successful probe")
|
|
}
|
|
if cfg.OrgSlug != "acme" {
|
|
t.Errorf("expected org_slug captured, got %q", cfg.OrgSlug)
|
|
}
|
|
}
|
|
|
|
func TestService_RecordAuthHealth_RecordsFailure(t *testing.T) {
|
|
f := newPollerFixture(t)
|
|
f.saveConfig(t, "ws-1", "tok")
|
|
f.client.testAuthFn = func() (*TestConnectionResult, error) {
|
|
return &TestConnectionResult{OK: false, Error: "401 unauthorized"}, nil
|
|
}
|
|
|
|
f.svc.RecordAuthHealth(context.Background(), "ws-1")
|
|
|
|
cfg, _ := f.store.GetConfig(context.Background(), "ws-1")
|
|
if cfg.LastOk {
|
|
t.Error("expected LastOk=false after failed probe")
|
|
}
|
|
if cfg.LastError != "401 unauthorized" {
|
|
t.Errorf("expected error preserved, got %q", cfg.LastError)
|
|
}
|
|
}
|
|
|
|
func TestService_RecordAuthHealth_ClientError(t *testing.T) {
|
|
f := newPollerFixture(t)
|
|
f.saveConfig(t, "ws-1", "tok")
|
|
f.client.testAuthFn = func() (*TestConnectionResult, error) {
|
|
return nil, errors.New("network timeout")
|
|
}
|
|
|
|
f.svc.RecordAuthHealth(context.Background(), "ws-1")
|
|
|
|
cfg, _ := f.store.GetConfig(context.Background(), "ws-1")
|
|
if cfg.LastOk {
|
|
t.Error("expected LastOk=false on client error")
|
|
}
|
|
}
|
|
|
|
func TestPoller_Start_ProbesEachConfiguredWorkspace(t *testing.T) {
|
|
// Smoke test: confirms the prober adapter actually wires
|
|
// Service.Store().ListConfiguredWorkspaces → Service.RecordAuthHealth
|
|
// when the loop is started, end-to-end. Wrapped in synctest so the
|
|
// goroutine the poller spawns runs deterministically against fake time
|
|
// instead of relying on a wall-clock deadline.
|
|
synctest.Test(t, func(t *testing.T) {
|
|
f := newPollerFixture(t)
|
|
f.saveConfig(t, "ws-a", "tok-a")
|
|
f.saveConfig(t, "ws-b", "tok-b")
|
|
probed := map[string]bool{}
|
|
f.client.testAuthFn = func() (*TestConnectionResult, error) {
|
|
return &TestConnectionResult{OK: true}, nil
|
|
}
|
|
f.svc.SetProbeHook(func(workspaceID string) {
|
|
probed[workspaceID] = true
|
|
})
|
|
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
defer cancel()
|
|
f.poller.Start(ctx)
|
|
defer f.poller.Stop()
|
|
|
|
// Wait for the immediate-on-Start probe pass to finish.
|
|
synctest.Wait()
|
|
|
|
if !probed["ws-a"] || !probed["ws-b"] {
|
|
t.Errorf("expected both ws-a and ws-b probed, got %v", probed)
|
|
}
|
|
})
|
|
}
|