d62b51b0be
* fix: route controlled diff comment updates * fix: address review comments overview feedback * fix: address automated review feedback * fix: keep failed controlled edits open * fix: guard controlled comment deletes * fix: compare controlled delete handler * test: cover controlled update rerender
127 lines
3.9 KiB
TypeScript
127 lines
3.9 KiB
TypeScript
import { act, renderHook } from "@testing-library/react";
|
|
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
|
|
import { useCommentActions } from "./comment-utils";
|
|
import type { DiffComment } from "./types";
|
|
|
|
const COMMENT_ID = "comment-1";
|
|
const EDITED_TEXT = "edited text";
|
|
|
|
function comment(): DiffComment {
|
|
return {
|
|
id: COMMENT_ID,
|
|
source: "diff",
|
|
sessionId: "session-1",
|
|
filePath: "src/example.ts",
|
|
startLine: 1,
|
|
endLine: 1,
|
|
side: "additions",
|
|
codeContent: "new line",
|
|
text: "original",
|
|
createdAt: "2026-01-01T00:00:00Z",
|
|
status: "pending",
|
|
};
|
|
}
|
|
|
|
type UseCommentActionsParams = Parameters<typeof useCommentActions>[0];
|
|
|
|
function renderCommentActions(overrides: Partial<UseCommentActionsParams> = {}) {
|
|
const removeComment = vi.fn();
|
|
const updateComment = vi.fn();
|
|
const setEditingComment = vi.fn();
|
|
const params = {
|
|
removeComment,
|
|
updateComment,
|
|
setEditingComment,
|
|
...overrides,
|
|
};
|
|
const { result } = renderHook(() => useCommentActions(params));
|
|
return { result, removeComment, updateComment, setEditingComment };
|
|
}
|
|
|
|
afterEach(() => {
|
|
vi.restoreAllMocks();
|
|
});
|
|
|
|
describe("useCommentActions", () => {
|
|
it("routes updates to the external handler in controlled comment mode", () => {
|
|
const onCommentUpdate = vi.fn();
|
|
const { result, removeComment, updateComment, setEditingComment } = renderCommentActions({
|
|
onCommentUpdate,
|
|
externalComments: [comment()],
|
|
});
|
|
|
|
act(() => {
|
|
result.current.handleCommentUpdate(COMMENT_ID, EDITED_TEXT);
|
|
});
|
|
|
|
expect(onCommentUpdate).toHaveBeenCalledWith(COMMENT_ID, { text: EDITED_TEXT });
|
|
expect(updateComment).not.toHaveBeenCalled();
|
|
expect(setEditingComment).toHaveBeenCalledWith(null);
|
|
expect(removeComment).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("updates the internal store handler when comments are uncontrolled", () => {
|
|
const { result, updateComment, setEditingComment } = renderCommentActions();
|
|
|
|
act(() => {
|
|
result.current.handleCommentUpdate(COMMENT_ID, EDITED_TEXT);
|
|
});
|
|
|
|
expect(updateComment).toHaveBeenCalledWith(COMMENT_ID, { text: EDITED_TEXT });
|
|
expect(setEditingComment).toHaveBeenCalledWith(null);
|
|
});
|
|
|
|
it("does not write to the internal store when controlled updates lack a handler", () => {
|
|
const warn = vi.spyOn(console, "warn").mockImplementation(() => {});
|
|
const { result, updateComment, setEditingComment } = renderCommentActions({
|
|
externalComments: [comment()],
|
|
});
|
|
|
|
act(() => {
|
|
result.current.handleCommentUpdate(COMMENT_ID, EDITED_TEXT);
|
|
});
|
|
|
|
expect(updateComment).not.toHaveBeenCalled();
|
|
expect(warn).toHaveBeenCalledWith(expect.stringContaining("`onCommentUpdate`"));
|
|
expect(setEditingComment).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("routes deletes to the external handler in controlled comment mode", () => {
|
|
const onCommentDelete = vi.fn();
|
|
const { result, removeComment } = renderCommentActions({
|
|
onCommentDelete,
|
|
externalComments: [comment()],
|
|
});
|
|
|
|
act(() => {
|
|
result.current.handleCommentDelete(COMMENT_ID);
|
|
});
|
|
|
|
expect(onCommentDelete).toHaveBeenCalledWith(COMMENT_ID);
|
|
expect(removeComment).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("does not write to the internal store when controlled deletes lack a handler", () => {
|
|
const warn = vi.spyOn(console, "warn").mockImplementation(() => {});
|
|
const { result, removeComment } = renderCommentActions({ externalComments: [comment()] });
|
|
|
|
act(() => {
|
|
result.current.handleCommentDelete(COMMENT_ID);
|
|
});
|
|
|
|
expect(removeComment).not.toHaveBeenCalled();
|
|
expect(warn).toHaveBeenCalledWith(expect.stringContaining("`onCommentDelete`"));
|
|
});
|
|
|
|
it("routes deletes to the internal store handler when comments are uncontrolled", () => {
|
|
const { result, removeComment } = renderCommentActions();
|
|
|
|
act(() => {
|
|
result.current.handleCommentDelete(COMMENT_ID);
|
|
});
|
|
|
|
expect(removeComment).toHaveBeenCalledWith(COMMENT_ID);
|
|
});
|
|
});
|