Files
kandev/apps/backend/internal/agentctl/server/process/workspace_files.go
T
João Salavisa 2c06cf5b6f fix: keep file tree paths workspace-relative (#3855)
Co-authored-by: Kandev Agent <agent@kandev.dev>
2026-09-22 08:15:41 +01:00

1144 lines
37 KiB
Go

package process
import (
"context"
"crypto/sha256"
"encoding/base64"
"encoding/hex"
"errors"
"fmt"
"io"
"io/fs"
"os"
"os/exec"
"path/filepath"
"sort"
"strconv"
"strings"
"sync/atomic"
"time"
"unicode/utf8"
"github.com/kandev/kandev/internal/agentctl/types"
"github.com/kandev/kandev/internal/common/readselector"
"github.com/kandev/kandev/internal/common/subproc"
"github.com/kandev/kandev/internal/common/workspacepath"
storageworkspaces "github.com/kandev/kandev/internal/system/storage/workspaces"
"go.uber.org/zap"
)
const (
// ResolutionApplied indicates the diff was applied normally via git apply.
ResolutionApplied = "applied"
// ResolutionOverwritten indicates the file was overwritten with desired content.
ResolutionOverwritten = "overwritten"
)
const maxFileSize = 10 * 1024 * 1024 // 10MB
var (
// ErrFileNotFound identifies a workspace file that does not exist.
ErrFileNotFound = errors.New("file not found")
errPathTraversal = errors.New("path traversal detected")
)
// workspaceMutationBarrier provides a deterministic synchronization point for
// filesystem-race regression tests. It is unset in production.
var workspaceMutationBarrier atomic.Value // func()
func runWorkspaceMutationBarrier() {
barrier, _ := workspaceMutationBarrier.Load().(func())
if barrier != nil {
barrier()
}
}
func isRootOwnershipMarkerPath(path string) bool {
return filepath.Clean(filepath.FromSlash(path)) == storageworkspaces.OwnershipMarkerFilename
}
// updateFiles updates the file listing
func (wt *WorkspaceTracker) updateFiles(ctx context.Context) {
wt.updateFilesClass(ctx, subproc.GitBackground)
}
func (wt *WorkspaceTracker) updateFilesClass(ctx context.Context, class subproc.GitWorkClass) {
files, err := wt.getFileListClass(ctx, class)
if err != nil {
wt.recordFilesystemFailure("workspace.file_monitor", workspaceTrigger(ctx, "poll"), err)
return
}
if err := ctx.Err(); err != nil || (wt.cancelCtx != nil && wt.cancelCtx.Err() != nil) {
return
}
wt.mu.Lock()
wt.currentFiles = files
wt.mu.Unlock()
}
// getFileList retrieves the list of files in the workspace
func (wt *WorkspaceTracker) getFileList(ctx context.Context) (types.FileListUpdate, error) {
return wt.getFileListClass(ctx, subproc.GitInteractive)
}
func (wt *WorkspaceTracker) getFileListClass(ctx context.Context, class subproc.GitWorkClass) (types.FileListUpdate, error) {
update := types.FileListUpdate{
Timestamp: time.Now(),
RepositoryName: wt.repositoryName,
Files: []types.FileEntry{},
}
// Use git ls-files to get tracked files AND untracked files (excluding ignored)
// --cached: include tracked files
// --others: include untracked files
// --exclude-standard: respect .gitignore
// --stage: expose tracked file modes so submodule Gitlinks can be excluded
out, runErr, execCtxErr := subproc.RunGitOutputAfterAcquire(ctx, class, gitCommandTimeout, func(execCtx context.Context) *exec.Cmd {
cmd := subproc.NewGitCommand(execCtx, "ls-files", "--cached", "--others", "--exclude-standard", "--stage")
cmd.Dir = wt.workDir
return cmd
})
err := gitCommandError(runErr, execCtxErr)
if err != nil {
return update, err
}
lines := strings.Split(string(out), "\n")
for _, line := range lines {
line = strings.TrimSpace(line)
if metadata, path, tracked := strings.Cut(line, "\t"); tracked {
if strings.HasPrefix(metadata, "160000 ") {
continue
}
line = strings.TrimSpace(path)
}
if line == "" || isRootOwnershipMarkerPath(line) {
continue
}
update.Files = append(update.Files, types.FileEntry{
Path: line,
IsDir: false,
})
}
return update, nil
}
// GetFileTree returns the file tree for a given path and depth
func (wt *WorkspaceTracker) GetFileTree(reqPath string, depth int) (*types.FileTreeNode, error) {
if err := workspacepath.ValidateTreePath(reqPath); err != nil {
return nil, err
}
// Resolve the full path with path traversal protection
safePath := filepath.Join(wt.workDir, filepath.Clean(reqPath))
cleanWorkDir := filepath.Clean(wt.workDir)
if !strings.HasPrefix(safePath, cleanWorkDir+string(os.PathSeparator)) && safePath != cleanWorkDir {
return nil, fmt.Errorf("path traversal detected")
}
// Check if path exists
info, err := os.Stat(safePath)
if err != nil {
wt.recordFilesystemFailure("workspace.file_tree", "user_select", err)
return nil, fmt.Errorf("path not found: %w", err)
}
// Build the tree
node, err := wt.buildFileTreeNode(safePath, reqPath, info, depth, 0)
if err != nil {
return nil, err
}
return node, nil
}
// buildFileTreeNode recursively builds a file tree node
func (wt *WorkspaceTracker) buildFileTreeNode(safePath, relPath string, info os.FileInfo, maxDepth, currentDepth int) (*types.FileTreeNode, error) {
node := &types.FileTreeNode{
Name: info.Name(),
Path: relPath,
IsDir: info.IsDir(),
Size: info.Size(),
}
// If it's a file or we've reached max depth, return
if !info.IsDir() || (maxDepth > 0 && currentDepth >= maxDepth) {
return node, nil
}
// Read directory contents
entries, err := os.ReadDir(safePath)
if err != nil {
wt.recordFilesystemFailure("workspace.file_tree", "user_select", err)
return node, nil // Return node without children on error
}
// Build children
node.Children = make([]*types.FileTreeNode, 0, len(entries))
for _, entry := range entries {
// Skip specific directories that should be ignored
name := entry.Name()
childRelPath := filepath.Join(relPath, name)
if isRootOwnershipMarkerPath(childRelPath) {
continue
}
if name == ".git" || name == "node_modules" || name == ".next" || name == "dist" || name == "build" {
continue
}
childFullPath := filepath.Join(safePath, name)
isSymlink := entry.Type()&os.ModeSymlink != 0
var childInfo os.FileInfo
if isSymlink {
// Follow symlink to get target's info (IsDir, Size).
// os.Stat returns ELOOP for circular symlinks, which we skip.
childInfo, err = os.Stat(childFullPath)
} else {
childInfo, err = entry.Info()
}
if err != nil {
continue
}
childNode, err := wt.buildFileTreeNode(childFullPath, childRelPath, childInfo, maxDepth, currentDepth+1)
if err != nil {
continue
}
childNode.IsSymlink = isSymlink
node.Children = append(node.Children, childNode)
}
return node, nil
}
// resolvedWorkDir returns the workspace directory with symlinks resolved.
func (wt *WorkspaceTracker) resolvedWorkDir() string {
resolved, err := filepath.EvalSymlinks(filepath.Clean(wt.workDir))
if err != nil {
return filepath.Clean(wt.workDir)
}
return resolved
}
func absoluteReadPath(reqPath string) (string, bool) {
cleanReqPath := filepath.Clean(reqPath)
if !filepath.IsAbs(cleanReqPath) {
return "", false
}
realPath, err := filepath.EvalSymlinks(cleanReqPath)
if err != nil {
return "", false
}
// codeql[go/path-injection] Intentional read-only absolute file access; see ADR 0016.
info, err := os.Stat(realPath)
if err != nil || !info.Mode().IsRegular() {
return "", false
}
return realPath, true
}
// resolveSafePath resolves reqPath to an absolute path within workDir,
// rejecting any path traversal attempts. The returned path is always
// constructed as filepath.Join(resolvedWorkDir, validatedRelPath) so that
// static analysis tools (CodeQL) can verify it stays within the workspace.
func (wt *WorkspaceTracker) resolveSafePath(reqPath string) (string, error) {
cleanWorkDir := filepath.Clean(wt.workDir)
cleanReqPath := filepath.Clean(reqPath)
// Resolve workspace directory symlinks first so that all constructed
// paths share the same canonical prefix (e.g. /private/var on macOS
// where /var is a symlink).
realWorkDir, err := filepath.EvalSymlinks(cleanWorkDir)
if err != nil {
realWorkDir = cleanWorkDir
}
var safePath string
if filepath.IsAbs(cleanReqPath) {
safePath = cleanReqPath
} else {
safePath = filepath.Join(realWorkDir, cleanReqPath)
}
// Resolve symlinks to prevent bypassing validation.
// When the path doesn't exist yet, walk up until we find an existing
// ancestor so symlinks (e.g. /tmp -> /private/tmp on macOS) are resolved
// consistently with realWorkDir below. Only fall back for not-found errors;
// propagate permission denied, symlink loops, etc.
realPath, err := filepath.EvalSymlinks(safePath)
if err != nil {
if !errors.Is(err, fs.ErrNotExist) {
return "", fmt.Errorf("failed to resolve path: %w", err)
}
realPath, err = resolveNonExistentPath(safePath)
if err != nil {
return "", err
}
}
// A path may leave the workspace only through a durable source link whose
// canonical target was registered by lifecycle. Re-resolving every request
// rejects stale or later-mutated links instead of trusting their old name.
root := realWorkDir
relPath, err := filepath.Rel(root, realPath)
if err != nil || pathEscapesRoot(relPath) {
root, relPath, err = wt.allowedSourcePath(realPath)
if err != nil {
return "", fmt.Errorf("%w: %s", errPathTraversal, reqPath)
}
}
// Reconstruct the absolute path from the trusted workspace root and the
// validated relative path. This ensures the returned path is provably
// inside the workspace, satisfying static-analysis taint checks.
return filepath.Join(root, relPath), nil
}
func pathEscapesRoot(relPath string) bool {
return relPath == ".." || strings.HasPrefix(relPath, ".."+string(os.PathSeparator))
}
func (wt *WorkspaceTracker) allowedSourcePath(realPath string) (string, string, error) {
wt.mu.RLock()
roots := append([]string(nil), wt.allowedSourceRoots...)
wt.mu.RUnlock()
for _, root := range roots {
rel, err := filepath.Rel(root, realPath)
if err == nil && !pathEscapesRoot(rel) {
return root, rel, nil
}
}
return "", "", errPathTraversal
}
// SetAllowedSourceRoots replaces the durable-source allowlist. Each root is
// canonicalized now and requests resolve their target again before matching,
// so a stale or mutated workspace link cannot inherit access to a new target.
func (wt *WorkspaceTracker) SetAllowedSourceRoots(roots []string) {
canonical := make([]string, 0, len(roots))
seen := make(map[string]struct{}, len(roots))
for _, root := range roots {
resolved, err := filepath.EvalSymlinks(filepath.Clean(root))
if err != nil {
continue
}
info, err := os.Stat(resolved)
if err != nil || !info.IsDir() {
continue
}
if _, ok := seen[resolved]; ok {
continue
}
seen[resolved] = struct{}{}
canonical = append(canonical, resolved)
}
wt.mu.Lock()
wt.allowedSourceRoots = canonical
wt.mu.Unlock()
}
// resolveNonExistentPath walks up from path until it finds an existing
// ancestor, resolves its symlinks, then reattaches the non-existent tail.
// This ensures paths under symlinked directories (e.g. /tmp on macOS)
// resolve consistently even when the target doesn't exist yet.
// Returns an error if an ancestor fails with something other than ErrNotExist
// (e.g. permission denied, symlink loop).
func resolveNonExistentPath(path string) (string, error) {
current := path
var tail []string
for {
resolved, err := filepath.EvalSymlinks(current)
if err == nil {
for i := len(tail) - 1; i >= 0; i-- {
resolved = filepath.Join(resolved, tail[i])
}
return resolved, nil
}
if !errors.Is(err, fs.ErrNotExist) {
return "", fmt.Errorf("failed to resolve ancestor %q: %w", current, err)
}
parent := filepath.Dir(current)
if parent == current {
return "", fmt.Errorf("no existing ancestor for %q: %w", path, err)
}
tail = append(tail, filepath.Base(current))
current = parent
}
}
// GetFileContent returns the content of a file.
// If the file is not valid UTF-8, it is base64-encoded and isBinary is true.
// If the file is a symlink, resolvedPath contains the target path relative to the workspace root.
func (wt *WorkspaceTracker) GetFileContent(reqPath string) (string, int64, bool, string, error) {
// Try the path exactly as requested first, so a real workspace file whose
// name contains a colon (e.g. "notes.txt:2-3") or a literal "~" path
// segment still opens. Only if the literal open fails do we treat a
// trailing piece as an omp read selector (e.g. "foo.go:43-94", multi-range)
// and/or a "~"-home shorthand, strip/expand it, and retry — so agent links
// that embed a selector open without breaking valid filenames.
content, size, isBinary, resolved, err := wt.readResolvedPath(reqPath)
if err == nil {
return content, size, isBinary, resolved, nil
}
if alt := expandHomePath(stripReadSelector(reqPath)); alt != reqPath {
c, s, b, r, altErr := wt.readResolvedPath(alt)
if altErr == nil {
return c, s, b, r, nil
}
// When the request used a "~" home shorthand, the literal attempt
// joins the tilde onto the workspace root (".../<workspace>/~/...:
// no such file"), which reads as a mangled path rather than a missing
// file. Surface the expanded-path error, which names the real home
// location that was actually checked.
if isHomeShorthand(reqPath) {
return c, s, b, r, altErr
}
}
// Neither the literal path nor the stripped/expanded fallback opened;
// surface the original (literal-path) error.
return content, size, isBinary, resolved, err
}
// stripReadSelector removes a trailing omp read selector from reqPath (the line
// range itself is irrelevant to serving content); paths without a selector are
// returned unchanged.
func stripReadSelector(reqPath string) string {
clean, _, _ := readselector.Split(reqPath)
return clean
}
// readResolvedPath resolves reqPath within the workspace, falling back to the
// read-only external-absolute-path path (ADR 0016), and returns its content.
func (wt *WorkspaceTracker) readResolvedPath(reqPath string) (string, int64, bool, string, error) {
safePath, err := wt.resolveSafePath(reqPath)
if err != nil {
if errors.Is(err, errPathTraversal) {
externalPath, ok := absoluteReadPath(reqPath)
if ok {
content, size, isBinary, readErr := readFileContent(externalPath)
return content, size, isBinary, "", readErr
}
// An absolute path that simply doesn't exist is not a traversal
// attempt — report a plain "file not found" naming the real path
// instead of the alarming "path traversal detected". Only remap
// genuine not-exist errors; permission/IO failures keep the
// original error so they aren't mislabeled as missing.
if cleaned := filepath.Clean(reqPath); filepath.IsAbs(cleaned) {
if _, statErr := os.Stat(cleaned); errors.Is(statErr, fs.ErrNotExist) {
return "", 0, false, "", fmt.Errorf("%w: %w", ErrFileNotFound, statErr)
}
}
return "", 0, false, "", err
}
return "", 0, false, "", err
}
// Check if the original path is a symlink and compute the resolved relative path.
resolvedPath := wt.resolveSymlinkRelPath(reqPath)
content, size, isBinary, err := readFileContent(safePath)
return content, size, isBinary, resolvedPath, err
}
// expandHomePath expands a leading "~" or "~/" to the current user's home
// directory. omp emits read paths like "~/.kandev/…"; a literal tilde is not a
// real filesystem path, so it must be expanded before stat/serve. Other paths
// (absolute, workspace-relative) are returned unchanged.
func expandHomePath(path string) string {
if !isHomeShorthand(path) {
return path
}
home, err := os.UserHomeDir()
if err != nil || home == "" {
return path
}
if path == "~" {
return home
}
return filepath.Join(home, path[2:])
}
// isHomeShorthand reports whether path uses the leading "~" / "~/" (or "~\" on
// Windows) home shorthand that expandHomePath rewrites.
func isHomeShorthand(path string) bool {
return path == "~" || strings.HasPrefix(path, "~/") || strings.HasPrefix(path, `~\`)
}
func readFileContent(safePath string) (string, int64, bool, error) {
// Check if file exists and is a regular file
// codeql[go/path-injection] safePath is canonical containment-validated by resolveSafePath; read-only external paths reach here only through absoluteReadPath validation.
info, err := os.Stat(safePath)
if err != nil {
if errors.Is(err, fs.ErrNotExist) {
return "", 0, false, fmt.Errorf("%w: %w", ErrFileNotFound, err)
}
return "", 0, false, fmt.Errorf("failed to stat file: %w", err)
}
if !info.Mode().IsRegular() {
return "", 0, false, fmt.Errorf("path is not a regular file")
}
// Check file size
if info.Size() > maxFileSize {
return "", info.Size(), false, fmt.Errorf("file too large (max 10MB)")
}
// Read file content
file, err := os.Open(safePath)
if err != nil {
return "", 0, false, fmt.Errorf("failed to open file: %w", err)
}
defer func() {
_ = file.Close()
}()
content, err := io.ReadAll(file)
if err != nil {
return "", 0, false, fmt.Errorf("failed to read file: %w", err)
}
// Detect binary: if content is not valid UTF-8, base64-encode it
if !utf8.Valid(content) {
encoded := base64.StdEncoding.EncodeToString(content)
return encoded, info.Size(), true, nil
}
return string(content), info.Size(), false, nil
}
// resolveSymlinkRelPath checks if reqPath is a symlink and returns the resolved
// target path relative to the workspace root. Returns "" if not a symlink.
func (wt *WorkspaceTracker) resolveSymlinkRelPath(reqPath string) string {
cleanReqPath := filepath.Clean(reqPath)
if strings.Contains(cleanReqPath, "..") || filepath.IsAbs(cleanReqPath) {
return ""
}
unresolvedPath := filepath.Join(wt.workDir, cleanReqPath)
info, err := os.Lstat(unresolvedPath)
if err != nil || info.Mode()&os.ModeSymlink == 0 {
return ""
}
// Resolve the symlink target
realTarget, err := filepath.EvalSymlinks(unresolvedPath)
if err != nil {
return ""
}
realWorkDir, _ := filepath.EvalSymlinks(filepath.Clean(wt.workDir))
if realWorkDir == "" {
realWorkDir = filepath.Clean(wt.workDir)
}
rel, err := filepath.Rel(realWorkDir, realTarget)
if err != nil {
return ""
}
return rel
}
// ApplyFileDiff applies a unified diff to a file with conflict detection.
// Uses git apply for reliable, battle-tested patch application.
// For symlinked files, resolves to the real path and rewrites the diff header
// so that git apply operates on the actual file.
// When desiredContent is provided and the diff cannot be applied (hash conflict),
// the file is overwritten with the desired content as a fallback.
// Returns the new hash and a resolution string ("applied" or "overwritten").
func (wt *WorkspaceTracker) ApplyFileDiff(ctx context.Context, reqPath, unifiedDiff, originalHash string, desiredContent *string) (string, string, error) {
safePath, err := wt.resolveSafePath(reqPath)
if err != nil {
return "", "", err
}
cleanWorkDir := filepath.Clean(wt.workDir)
// Read current file content
currentContent, _, _, _, err := wt.GetFileContent(reqPath)
if err != nil {
return "", "", fmt.Errorf("failed to read current file: %w", err)
}
// Calculate hash of current content for conflict detection
currentHash := calculateSHA256(currentContent)
if originalHash != "" && currentHash != originalHash {
if desiredContent != nil {
return wt.writeDesiredContent(reqPath, *desiredContent, currentHash)
}
return "", "", fmt.Errorf("conflict detected: file has been modified (expected hash %s, got %s)", originalHash, currentHash)
}
// If the file is a symlink, resolve to the real path and rewrite the diff header.
// git apply cannot patch through symlinks — it needs the real file path.
applyPath, unifiedDiff := wt.resolveSymlinkForDiff(reqPath, safePath, cleanWorkDir, unifiedDiff)
// Write diff to a temporary patch file
patchFile := filepath.Join(wt.workDir, ".kandev-patch.tmp")
err = os.WriteFile(patchFile, []byte(unifiedDiff), 0o644)
if err != nil {
return "", "", fmt.Errorf("failed to write patch file: %w", err)
}
defer func() {
_ = os.Remove(patchFile) // Best effort cleanup
}()
// Use git apply to apply the patch directly to the file
output, runErr, execCtxErr := subproc.RunGitCombinedAfterAcquire(
ctx,
subproc.GitInteractive,
gitCommandTimeout,
func(execCtx context.Context) *exec.Cmd {
cmd := subproc.NewGitCommand(execCtx, "apply", "-p0", "--unidiff-zero", "--whitespace=nowarn", patchFile)
cmd.Dir = wt.workDir
return cmd
},
)
err = gitCommandError(runErr, execCtxErr)
if err != nil {
// Treat caller cancellation / deadline as a transient failure and
// propagate rather than overwriting the file from desiredContent —
// the user pressing cancel must NOT silently clobber what's on disk.
if errors.Is(err, context.Canceled) || errors.Is(err, context.DeadlineExceeded) {
return "", "", fmt.Errorf("git apply cancelled: %w", err)
}
if desiredContent != nil {
return wt.writeDesiredContent(reqPath, *desiredContent, currentHash)
}
return "", "", fmt.Errorf("git apply failed: %w\nOutput: %s", err, string(output))
}
// Read the updated content (use the real file path for symlinks)
readPath := filepath.Join(cleanWorkDir, applyPath)
updatedContent, err := os.ReadFile(readPath)
if err != nil {
return "", "", fmt.Errorf("failed to read updated file: %w", err)
}
// Calculate new hash
newHash := calculateSHA256(string(updatedContent))
// Notify with the original relative path (not the resolved symlink target)
relPath := strings.TrimPrefix(safePath, cleanWorkDir+string(os.PathSeparator))
wt.notifyFileChange(relPath, types.FileOpWrite)
wt.logger.Debug("applied file diff using git apply",
zap.String("path", relPath),
zap.String("old_hash", currentHash),
zap.String("new_hash", newHash),
)
return newHash, ResolutionApplied, nil
}
// resolveSymlinkForDiff checks if reqPath is a symlink and, if so, rewrites the diff
// paths to target the real file. Returns the path to use for git apply and the
// (possibly rewritten) diff.
func (wt *WorkspaceTracker) resolveSymlinkForDiff(
reqPath, safePath, cleanWorkDir, unifiedDiff string,
) (string, string) {
cleanReqPath := filepath.Clean(reqPath)
if strings.Contains(cleanReqPath, "..") || filepath.IsAbs(cleanReqPath) {
return reqPath, unifiedDiff
}
unresolvedPath := filepath.Join(wt.workDir, cleanReqPath)
info, lErr := os.Lstat(unresolvedPath)
if lErr != nil || info.Mode()&os.ModeSymlink == 0 {
return reqPath, unifiedDiff
}
// File is a symlink. safePath already points to the real target.
realWorkDir, _ := filepath.EvalSymlinks(cleanWorkDir)
if realWorkDir == "" {
realWorkDir = cleanWorkDir
}
realRel, relErr := filepath.Rel(realWorkDir, safePath)
if relErr != nil {
return reqPath, unifiedDiff
}
return realRel, rewriteDiffPaths(unifiedDiff, reqPath, realRel)
}
// writeDesiredContent writes the desired content directly to the file as a fallback
// when the diff cannot be applied. Returns the new hash and "overwritten" resolution.
func (wt *WorkspaceTracker) writeDesiredContent(
reqPath, desiredContent, oldHash string,
) (string, string, error) {
path, err := wt.resolveMutationPath(reqPath)
if err != nil {
return "", "", err
}
defer func() { _ = path.root.Close() }()
runWorkspaceMutationBarrier()
if err := path.root.WriteFile(path.rel, []byte(desiredContent), 0o644); err != nil {
return "", "", fmt.Errorf("failed to write desired content: %w", err)
}
newHash := calculateSHA256(desiredContent)
relPath := wt.mutationNotificationPath(path.safe)
wt.notifyFileChange(relPath, types.FileOpWrite)
wt.logger.Warn("overwrote file with desired content (conflict fallback)",
zap.String("path", reqPath),
zap.String("old_hash", oldHash),
zap.String("new_hash", newHash),
)
return newHash, ResolutionOverwritten, nil
}
// rewriteDiffPaths replaces file paths in unified diff headers.
// Handles both "--- a/old" / "+++ b/new" (with strip prefix) and
// "--- old" / "+++ new" (p0 mode) formats.
func rewriteDiffPaths(diff, oldPath, newPath string) string {
lines := strings.Split(diff, "\n")
for i, line := range lines {
if strings.HasPrefix(line, "--- ") {
lines[i] = replaceDiffPath(line, "--- ", oldPath, newPath)
} else if strings.HasPrefix(line, "+++ ") {
lines[i] = replaceDiffPath(line, "+++ ", oldPath, newPath)
}
}
return strings.Join(lines, "\n")
}
// replaceDiffPath replaces oldPath with newPath in a diff header line.
func replaceDiffPath(line, prefix, oldPath, newPath string) string {
rest := line[len(prefix):]
// Handle "--- a/path" or "--- path" formats
cleaned := strings.TrimPrefix(rest, "a/")
cleaned = strings.TrimPrefix(cleaned, "b/")
if cleaned == oldPath || filepath.Clean(cleaned) == filepath.Clean(oldPath) {
return prefix + newPath
}
return line
}
// CreateFile creates a new file in the workspace
func (wt *WorkspaceTracker) CreateFile(reqPath string) error {
path, err := wt.resolveMutationPath(reqPath)
if err != nil {
return err
}
defer func() { _ = path.root.Close() }()
runWorkspaceMutationBarrier()
// Create intermediate directories
if err := path.root.MkdirAll(filepath.Dir(path.rel), 0o755); err != nil {
return fmt.Errorf("failed to create directories: %w", err)
}
// Atomically create the file, failing if it already exists
f, err := path.root.OpenFile(path.rel, os.O_CREATE|os.O_EXCL|os.O_WRONLY, 0o644)
if err != nil {
if os.IsExist(err) {
return fmt.Errorf("file already exists: %s", reqPath)
}
return fmt.Errorf("failed to create file: %w", err)
}
_ = f.Close()
// Notify with the relative path
wt.notifyFileChange(wt.mutationNotificationPath(path.safe), types.FileOpCreate)
return nil
}
// DeleteFile deletes a file or directory from the workspace.
func (wt *WorkspaceTracker) DeleteFile(reqPath string) error {
path, err := wt.resolveMutationPath(reqPath)
if err != nil {
return err
}
defer func() { _ = path.root.Close() }()
if path.rel == "." {
if path.rootPath != wt.resolvedWorkDir() {
return fmt.Errorf("path outside workspace")
}
return fmt.Errorf("cannot delete workspace root")
}
runWorkspaceMutationBarrier()
// Check if file exists
info, err := path.root.Stat(path.rel)
if err != nil {
if os.IsNotExist(err) {
return fmt.Errorf("file does not exist: %s", reqPath)
}
return fmt.Errorf("failed to stat file: %w", err)
}
if info.IsDir() {
if err := path.root.RemoveAll(path.rel); err != nil {
return fmt.Errorf("failed to delete directory: %w", err)
}
} else {
if err := path.root.Remove(path.rel); err != nil {
return fmt.Errorf("failed to delete file: %w", err)
}
}
wt.notifyFileChange(wt.mutationNotificationPath(path.safe), types.FileOpRemove)
return nil
}
// RenameFile renames/moves a file or directory in the workspace.
func (wt *WorkspaceTracker) RenameFile(oldPath, newPath string) error {
if oldPath == "" || newPath == "" {
return fmt.Errorf("old_path and new_path are required")
}
oldResolved, err := wt.resolveMutationPath(oldPath)
if err != nil {
return err
}
defer func() { _ = oldResolved.root.Close() }()
newResolved, err := wt.resolveMutationPath(newPath)
if err != nil {
return err
}
defer func() { _ = newResolved.root.Close() }()
if oldResolved.rootPath == newResolved.rootPath && oldResolved.rel == newResolved.rel {
return nil
}
if oldResolved.rootPath != newResolved.rootPath {
return fmt.Errorf("cannot rename across workspace roots")
}
runWorkspaceMutationBarrier()
if err := validateSourceExistsRooted(oldResolved.root, oldResolved.rel, oldPath); err != nil {
return err
}
if err := validateTargetAvailableRooted(newResolved.root, newResolved.rel, newPath); err != nil {
return err
}
if err := oldResolved.root.MkdirAll(filepath.Dir(newResolved.rel), 0o755); err != nil {
return fmt.Errorf("failed to create target parent directories: %w", err)
}
if err := oldResolved.root.Rename(oldResolved.rel, newResolved.rel); err != nil {
return fmt.Errorf("failed to rename path: %w", err)
}
wt.notifyRename(oldResolved.safe, newResolved.safe)
return nil
}
func (wt *WorkspaceTracker) notifyRename(oldSafePath, newSafePath string) {
oldRelPath := wt.mutationNotificationPath(oldSafePath)
newRelPath := wt.mutationNotificationPath(newSafePath)
wt.notifyFileChange(oldRelPath, types.FileOpRename)
if newRelPath != oldRelPath {
wt.notifyFileChange(newRelPath, types.FileOpRename)
}
}
type rootedMutationPath struct {
root *os.Root
rootPath string
rel string
safe string
}
// resolveMutationPath anchors a mutation at the canonical workspace or a
// registered durable-source root. Root methods retain that directory handle and
// reject symlink traversal outside it, including after this resolution returns.
func (wt *WorkspaceTracker) resolveMutationPath(reqPath string) (*rootedMutationPath, error) {
safePath, err := wt.resolveSafePath(reqPath)
if err != nil {
return nil, err
}
rootPath := wt.resolvedWorkDir()
rel, err := filepath.Rel(rootPath, safePath)
if err != nil || pathEscapesRoot(rel) {
rootPath, rel, err = wt.allowedSourcePath(safePath)
if err != nil {
return nil, fmt.Errorf("path outside workspace")
}
}
root, err := os.OpenRoot(rootPath)
if err != nil {
return nil, fmt.Errorf("failed to open workspace root: %w", err)
}
return &rootedMutationPath{root: root, rootPath: rootPath, rel: rel, safe: safePath}, nil
}
func (wt *WorkspaceTracker) mutationNotificationPath(safePath string) string {
cleanWorkDir := wt.resolvedWorkDir()
return strings.TrimPrefix(safePath, cleanWorkDir+string(os.PathSeparator))
}
func validateSourceExistsRooted(root *os.Root, relPath, reqPath string) error {
_, err := root.Stat(relPath)
if err == nil {
return nil
}
if os.IsNotExist(err) {
return fmt.Errorf("path does not exist: %s", reqPath)
}
return fmt.Errorf("failed to stat path: %w", err)
}
func validateTargetAvailableRooted(root *os.Root, relPath, reqPath string) error {
_, err := root.Stat(relPath)
if err == nil {
return fmt.Errorf("target already exists: %s", reqPath)
}
if os.IsNotExist(err) {
return nil
}
return fmt.Errorf("failed to stat target: %w", err)
}
// calculateSHA256 calculates the SHA256 hash of a string
func calculateSHA256(content string) string {
hash := sha256.Sum256([]byte(content))
return hex.EncodeToString(hash[:])
}
// scoredMatch holds a file path, repository identity, and match score for sorting.
type scoredMatch struct {
path string
matchPath string
repositoryName string
score int
}
type fileSearchCandidate struct {
path string
matchPath string
repositoryName string
}
const (
// fileSearchDefaultLimit applies when the caller passes a non-positive limit.
fileSearchDefaultLimit = 20
// fileSearchMaxLimit caps how many results one search may return. The limit
// reaches this code straight from the `limit` query parameter of
// GET /api/v1/workspace/search, so without a ceiling a request like
// `?limit=2000000000` would ask for a result set that can never exceed the
// number of tracked files. It also bounds the result slice's capacity,
// which is sized from this cap rather than from the request. Mirrors the
// clamp validateContentSearch already applies to content search.
fileSearchMaxLimit = 200
)
// GetFileContentAtRef returns the content of a file at a specific git ref (branch, commit, HEAD, etc).
// If the file is not valid UTF-8, it is base64-encoded and isBinary is true.
func (wt *WorkspaceTracker) GetFileContentAtRef(ctx context.Context, reqPath string, ref string) (string, int64, bool, error) {
// Validate path to prevent directory traversal
cleanPath := filepath.Clean(reqPath)
if strings.HasPrefix(cleanPath, "..") || filepath.IsAbs(cleanPath) {
return "", 0, false, fmt.Errorf("invalid path: path traversal detected")
}
// Use git show to get the file content at the specified ref
// Format: git show <ref>:<path>
gitRef := fmt.Sprintf("%s:%s", ref, cleanPath)
// Preflight: check blob size before materializing content to avoid memory spikes.
// Use CombinedOutput to capture stderr for error detection (git writes errors to stderr).
// Set LC_ALL=C to ensure English error messages for reliable parsing.
sizeOut, runErr, execCtxErr := subproc.RunGitCombinedAfterAcquire(
ctx,
subproc.GitInteractive,
gitCommandTimeout,
func(execCtx context.Context) *exec.Cmd {
sizeCmd := subproc.NewGitCommand(execCtx, "cat-file", "-s", gitRef)
sizeCmd.Dir = wt.workDir
sizeCmd.Env = append(os.Environ(), "LC_ALL=C")
return sizeCmd
},
)
err := gitCommandError(runErr, execCtxErr)
if err != nil {
output := string(sizeOut)
if strings.Contains(output, "does not exist") ||
strings.Contains(output, "Not a valid object") ||
strings.Contains(output, "fatal: path") ||
strings.Contains(output, "fatal: not a valid") {
return "", 0, false, fmt.Errorf("file not found at ref %s: %s", ref, cleanPath)
}
return "", 0, false, fmt.Errorf("failed to stat file at ref: %w", err)
}
blobSize, err := strconv.ParseInt(strings.TrimSpace(string(sizeOut)), 10, 64)
if err != nil {
return "", 0, false, fmt.Errorf("failed to parse file size at ref: %w", err)
}
if blobSize > maxFileSize {
return "", blobSize, false, fmt.Errorf("file too large (max 10MB)")
}
content, runErr, execCtxErr := subproc.RunGitOutputAfterAcquire(
ctx,
subproc.GitInteractive,
gitCommandTimeout,
func(execCtx context.Context) *exec.Cmd {
cmd := subproc.NewGitCommand(execCtx, "show", gitRef)
cmd.Dir = wt.workDir
return cmd
},
)
err = gitCommandError(runErr, execCtxErr)
if err != nil {
return "", 0, false, fmt.Errorf("failed to get file at ref: %w", err)
}
size := int64(len(content))
// Detect binary: if content is not valid UTF-8, base64-encode it
if !utf8.Valid(content) {
encoded := base64.StdEncoding.EncodeToString(content)
return encoded, size, true, nil
}
return string(content), size, false, nil
}
// SearchFiles searches for files matching the query string.
// It uses fuzzy matching with scoring based on how well the query matches.
func (wt *WorkspaceTracker) SearchFiles(query string, limit int) []string {
wt.mu.RLock()
candidates := make([]fileSearchCandidate, 0, len(wt.currentFiles.Files))
for _, file := range wt.currentFiles.Files {
candidates = append(candidates, fileSearchCandidate{
path: file.Path,
matchPath: file.Path,
})
}
wt.mu.RUnlock()
results := searchFileCandidates(candidates, query, limit)
paths := make([]string, 0, len(results))
for _, result := range results {
paths = append(paths, result.Path)
}
return paths
}
// SearchWorkspaceFileResults searches every repository represented by the manager.
// Multi-repo results retain their task-root-relative repository prefix so
// existing file consumers can open the returned path without extra metadata.
func (m *Manager) SearchWorkspaceFileResults(query string, limit int) []types.FileSearchResult {
root, repositories := m.snapshotTrackers()
if len(repositories) == 0 {
if root == nil {
return []types.FileSearchResult{}
}
candidates := appendTrackerFileSearchCandidates(nil, root)
return searchFileCandidates(candidates, query, limit)
}
candidates := make([]fileSearchCandidate, 0)
if root != nil && root.gitIndexPath != "" {
candidates = appendTrackerFileSearchCandidates(candidates, root)
}
for _, tracker := range repositories {
candidates = appendTrackerFileSearchCandidates(candidates, tracker)
}
return searchFileCandidates(candidates, query, limit)
}
func appendTrackerFileSearchCandidates(
candidates []fileSearchCandidate,
tracker *WorkspaceTracker,
) []fileSearchCandidate {
tracker.mu.RLock()
defer tracker.mu.RUnlock()
repository := tracker.RepositoryName()
for _, file := range tracker.currentFiles.Files {
path := file.Path
if repository != "" {
path = filepath.ToSlash(filepath.Join(repository, path))
}
candidates = append(candidates, fileSearchCandidate{
path: path,
matchPath: file.Path,
repositoryName: repository,
})
}
return candidates
}
func searchFileCandidates(
candidates []fileSearchCandidate,
query string,
limit int,
) []types.FileSearchResult {
if query == "" {
return []types.FileSearchResult{}
}
if limit <= 0 {
limit = fileSearchDefaultLimit
}
if limit > fileSearchMaxLimit {
limit = fileSearchMaxLimit
}
query = strings.ToLower(query)
var matches []scoredMatch
for _, candidate := range candidates {
if isRootOwnershipMarkerPath(candidate.path) {
continue
}
matchPath := candidate.matchPath
if matchPath == "" {
matchPath = candidate.path
}
lowerPath := strings.ToLower(matchPath)
name := filepath.Base(lowerPath)
score := 0
switch {
case name == query:
score = 100 // Exact filename match
case strings.HasPrefix(name, query):
score = 75 // Filename starts with query
case strings.Contains(name, query):
score = 50 // Filename contains query
case strings.Contains(lowerPath, query):
score = 25 // Path contains query
}
if score > 0 {
matches = append(matches, scoredMatch{
path: candidate.path,
matchPath: matchPath,
repositoryName: candidate.repositoryName,
score: score,
})
}
}
// Sort by score descending
sort.Slice(matches, func(i, j int) bool {
if matches[i].score != matches[j].score {
return matches[i].score > matches[j].score
}
// Secondary sort by path length (shorter paths first)
return len(matches[i].matchPath) < len(matches[j].matchPath)
})
// Return top limit results. The capacity is derived from values we own —
// the matches we actually collected and the hard cap — instead of the
// caller-supplied limit, so the allocation size never depends on request
// input even indirectly.
result := make([]types.FileSearchResult, 0, min(len(matches), fileSearchMaxLimit))
for i := 0; i < len(matches) && i < limit; i++ {
result = append(result, types.FileSearchResult{
RepositoryName: matches[i].repositoryName,
Path: matches[i].path,
})
}
return result
}