b20047b3eb
* feat(plugins): add auth capability for plugin-provided OIDC/SAML login Plugins can now authenticate a visitor against an external IdP (OIDC/SAML) and contribute a login button to the pre-auth screen: - new `auth` manifest capability + a capability-gated X-Kandev-Auth-Login webhook-response directive; the host mints the kandev_session (ADR 0050), the plugin never receives the raw token. Plugin-set Set-Cookie is dropped. - auth.Service.AuthenticateExternal: existing-identity / link-by-email / JIT member provisioning; refuses to auto-link to an admin; verified-email is the plugin's contract. - auth_providers manifest block + plugins.SSOProviders() populate the anonymous boot payload (auth.ssoProviders); the login page renders a "Continue with <provider>" button per provider. - ADR 0050 + plugin-manifest / plugin-authoring / auth spec docs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs: exclude publish_review_findings_kandev from public-docs coverage The native code-review agent (#1957) added the publish_review_findings_kandev MCP tool but did not update docs/public/coverage.json; that PR did not touch docs/public so the path-filtered validator never ran. It's an internal review reporting tool, not a user-facing feature, so record it as an exclusion. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(plugins,auth): address review on SSO directive and JIT provisioning - takeAuthLoginDirective strips every case variant of X-Kandev-Auth-Login and rejects (403) when a plugin sends more than one, so no variant leaks to the browser and login never uses a nondeterministically-picked assertion. - provisionExternalUser rolls back the just-created user when the identity insert fails (transient error or a lost UNIQUE(provider,subject) race) and resolves to the winning identity, so no account is left without a login and no email is reserved by an unusable row. Adds userstore.DeleteUser. - auth spec: mark the login-page SSO buttons + provider discovery as landed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs: drop redundant coverage exclusion; main now covers publish_review_findings_kandev Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
36 lines
1.1 KiB
Go
36 lines
1.1 KiB
Go
package plugins
|
|
|
|
// SSOProvider is a login option surfaced on the pre-auth login screen,
|
|
// contributed by an active auth-capable plugin's manifest auth_providers.
|
|
// InitiateURL is the plugin webhook the login button navigates to, which
|
|
// 302-redirects the browser to the IdP.
|
|
type SSOProvider struct {
|
|
ID string
|
|
DisplayName string
|
|
InitiateURL string
|
|
}
|
|
|
|
// SSOProviders returns the external login options from every active,
|
|
// auth-capable plugin that declares auth_providers. A provider whose Initiate
|
|
// does not match one of the plugin's declared webhook keys is skipped (its
|
|
// button would 404), mirroring the webhook handler's own key check.
|
|
func (s *Service) SSOProviders() []SSOProvider {
|
|
var out []SSOProvider
|
|
for _, rec := range s.List() {
|
|
if rec.Status != StatusActive || !rec.Capabilities.Auth {
|
|
continue
|
|
}
|
|
for _, p := range rec.AuthProviders {
|
|
if p.ID == "" || p.Initiate == "" || !manifestDeclaresWebhookKey(rec, p.Initiate) {
|
|
continue
|
|
}
|
|
out = append(out, SSOProvider{
|
|
ID: p.ID,
|
|
DisplayName: p.DisplayName,
|
|
InitiateURL: "/api/plugins/" + rec.ID + "/webhooks/" + p.Initiate,
|
|
})
|
|
}
|
|
}
|
|
return out
|
|
}
|