503 lines
17 KiB
TypeScript
503 lines
17 KiB
TypeScript
"use client";
|
|
|
|
import { useCallback, useEffect, useState } from "react";
|
|
import { setPanelTitle } from "@/lib/layout/panel-portal-manager";
|
|
import {
|
|
IconRefresh,
|
|
IconPlus,
|
|
IconMinus,
|
|
IconAlertTriangle,
|
|
IconGitMerge,
|
|
IconCheck,
|
|
IconLoader2,
|
|
} from "@tabler/icons-react";
|
|
import { Badge } from "@kandev/ui/badge";
|
|
import { Button } from "@kandev/ui/button";
|
|
import { Separator } from "@kandev/ui/separator";
|
|
import { ScrollArea } from "@kandev/ui/scroll-area";
|
|
import { Tooltip, TooltipContent, TooltipTrigger } from "@kandev/ui/tooltip";
|
|
import { useAppStore } from "@/components/state-provider";
|
|
import { useActiveTaskPR, useTaskPR } from "@/hooks/domains/github/use-task-pr";
|
|
import { prPanelLabel } from "@/components/github/pr-utils";
|
|
import { usePRFeedback } from "@/hooks/domains/github/use-pr-feedback";
|
|
import { useCommentsStore } from "@/lib/state/slices/comments";
|
|
import type { PRFeedbackComment } from "@/lib/state/slices/comments";
|
|
import { useToast } from "@/components/toast-provider";
|
|
import { submitPRReview } from "@/lib/api/domains/github-api";
|
|
import type { TaskPR, PRFeedback } from "@/lib/types/github";
|
|
import {
|
|
formatTimeAgo,
|
|
AuthorLink,
|
|
getTimeAgoColor,
|
|
CollapsibleSection,
|
|
PRMarkdownBody,
|
|
} from "./pr-shared";
|
|
import { ReviewStateBadge } from "./pr-reviews-section";
|
|
import { ChecksSection } from "./pr-checks-section";
|
|
import { ReviewsSection } from "./pr-reviews-section";
|
|
import { CommentsSection } from "./pr-comments-section";
|
|
|
|
// --- Dockview panel wrapper ---
|
|
|
|
type PRDetailPanelProps = {
|
|
panelId: string;
|
|
/** Per-PR params; multi-repo panels carry prKey="<owner>/<repo>/<pr_number>". */
|
|
params?: { prKey?: string };
|
|
};
|
|
|
|
export function PRDetailPanelComponent({ panelId, params }: PRDetailPanelProps) {
|
|
const activeTaskId = useAppStore((s) => s.tasks.activeTaskId);
|
|
const { prs } = useTaskPR(activeTaskId);
|
|
const activePR = useActiveTaskPR();
|
|
const sessionId = useAppStore((s) => s.tasks.activeSessionId);
|
|
|
|
// Multi-repo: when the panel was opened with a prKey, render the matching
|
|
// TaskPR. Falls back to the active (primary) PR for legacy single-repo
|
|
// panels that pre-date the prKey param.
|
|
const pr = (params?.prKey ? prs.find((p) => prTaskKey(p) === params.prKey) : null) ?? activePR;
|
|
|
|
useEffect(() => {
|
|
const title = pr ? prPanelLabel(pr.pr_number) : "Pull Request";
|
|
setPanelTitle(panelId, title);
|
|
}, [pr, panelId]);
|
|
|
|
if (!pr || !sessionId) {
|
|
return (
|
|
<div className="flex items-center justify-center h-full text-muted-foreground text-sm">
|
|
No pull request linked to this session.
|
|
</div>
|
|
);
|
|
}
|
|
|
|
return (
|
|
<div data-testid="pr-detail-panel" className="h-full">
|
|
<PRDetailContent taskPR={pr} sessionId={sessionId} />
|
|
</div>
|
|
);
|
|
}
|
|
|
|
/** Stable per-PR key used by addPRPanel and the multi-PR topbar buttons. */
|
|
export function prTaskKey(pr: TaskPR): string {
|
|
return `${pr.owner}/${pr.repo}/${pr.pr_number}`;
|
|
}
|
|
|
|
// --- Add PR feedback as chat context ---
|
|
|
|
function useAddPRFeedbackAsContext(sessionId: string, prNumber: number) {
|
|
const { toast } = useToast();
|
|
const addComment = useCommentsStore((s) => s.addComment);
|
|
|
|
const addAsContext = useCallback(
|
|
(feedbackType: PRFeedbackComment["feedbackType"], content: string) => {
|
|
const comment: PRFeedbackComment = {
|
|
id: `pr-feedback-${Date.now()}-${Math.random().toString(36).slice(2, 7)}`,
|
|
sessionId,
|
|
text: content,
|
|
createdAt: new Date().toISOString(),
|
|
status: "pending",
|
|
source: "pr-feedback",
|
|
prNumber,
|
|
feedbackType,
|
|
content,
|
|
};
|
|
addComment(comment);
|
|
toast({ description: "Added to chat context" });
|
|
},
|
|
[sessionId, prNumber, addComment, toast],
|
|
);
|
|
|
|
return { addAsContext };
|
|
}
|
|
|
|
type PRPanelMetrics = {
|
|
reviewCount: number;
|
|
pendingReviewCount: number;
|
|
commentCount: number;
|
|
reviewState: TaskPR["review_state"];
|
|
};
|
|
|
|
function computeLiveReviewState(feedback: PRFeedback, fallbackState: TaskPR["review_state"]) {
|
|
const requestedReviewers = feedback.pr.requested_reviewers ?? [];
|
|
const reviews = feedback.reviews ?? [];
|
|
if (reviews.length === 0) {
|
|
return requestedReviewers.length > 0 ? "pending" : fallbackState || "";
|
|
}
|
|
const latestByAuthor = new Map<string, { state: string; createdAt: number }>();
|
|
for (const review of reviews) {
|
|
const current = latestByAuthor.get(review.author);
|
|
const createdAt = new Date(review.created_at).getTime();
|
|
if (!current || createdAt > current.createdAt) {
|
|
latestByAuthor.set(review.author, { state: review.state, createdAt });
|
|
}
|
|
}
|
|
let hasChangesRequested = false;
|
|
let allApproved = true;
|
|
for (const review of latestByAuthor.values()) {
|
|
if (review.state === "CHANGES_REQUESTED") hasChangesRequested = true;
|
|
if (review.state !== "APPROVED") allApproved = false;
|
|
}
|
|
if (hasChangesRequested) return "changes_requested";
|
|
if (allApproved) return "approved";
|
|
return "pending";
|
|
}
|
|
|
|
function derivePanelMetrics(taskPR: TaskPR, feedback: PRFeedback | null): PRPanelMetrics {
|
|
if (!feedback) {
|
|
return {
|
|
reviewCount: taskPR.review_count,
|
|
pendingReviewCount: taskPR.pending_review_count,
|
|
commentCount: taskPR.comment_count,
|
|
reviewState: taskPR.review_state,
|
|
};
|
|
}
|
|
const pendingReviewCount = feedback.pr.requested_reviewers?.length ?? taskPR.pending_review_count;
|
|
return {
|
|
reviewCount: (feedback.reviews ?? []).length,
|
|
pendingReviewCount,
|
|
commentCount: (feedback.comments ?? []).length,
|
|
reviewState: computeLiveReviewState(feedback, taskPR.review_state),
|
|
};
|
|
}
|
|
|
|
// --- Main content ---
|
|
|
|
function DescriptionSection({ body }: { body: string }) {
|
|
if (!body) return null;
|
|
return (
|
|
<CollapsibleSection title="Description" count={1} defaultOpen={false}>
|
|
<div className="px-2">
|
|
<PRMarkdownBody body={body} />
|
|
</div>
|
|
</CollapsibleSection>
|
|
);
|
|
}
|
|
|
|
// GitHub logins are case-insensitive; normalize before comparing.
|
|
function shouldHideApproveButton(
|
|
taskPR: TaskPR,
|
|
feedback: PRFeedback | null,
|
|
currentUser: string | null,
|
|
): boolean {
|
|
const liveState = feedback?.pr.state ?? taskPR.state;
|
|
if (liveState !== "open") return true;
|
|
const normalizedUser = currentUser?.trim().toLowerCase();
|
|
if (!normalizedUser) return false;
|
|
const prAuthor = feedback?.pr.author_login ?? taskPR.author_login;
|
|
if (prAuthor?.trim().toLowerCase() === normalizedUser) return true;
|
|
return (
|
|
feedback?.reviews?.some(
|
|
(r) => r.state === "APPROVED" && r.author?.trim().toLowerCase() === normalizedUser,
|
|
) ?? false
|
|
);
|
|
}
|
|
|
|
function ApproveButton({
|
|
taskPR,
|
|
feedback,
|
|
onRefresh,
|
|
}: {
|
|
taskPR: TaskPR;
|
|
feedback: PRFeedback | null;
|
|
onRefresh: () => void;
|
|
}) {
|
|
const { toast } = useToast();
|
|
const [submitting, setSubmitting] = useState(false);
|
|
const currentUser = useAppStore((s) => s.githubStatus.status?.username ?? null);
|
|
|
|
if (shouldHideApproveButton(taskPR, feedback, currentUser)) return null;
|
|
|
|
const handleApprove = async () => {
|
|
setSubmitting(true);
|
|
try {
|
|
await submitPRReview(taskPR.owner, taskPR.repo, taskPR.pr_number, "APPROVE");
|
|
toast({ description: "PR approved", variant: "success" });
|
|
onRefresh();
|
|
} catch (e) {
|
|
toast({
|
|
title: "Failed to approve",
|
|
description: e instanceof Error ? e.message : "An error occurred",
|
|
variant: "error",
|
|
});
|
|
} finally {
|
|
setSubmitting(false);
|
|
}
|
|
};
|
|
|
|
return (
|
|
<Button
|
|
data-testid="pr-approve-button"
|
|
size="sm"
|
|
className="cursor-pointer gap-1.5 border-0 bg-green-600 text-white hover:bg-green-700 dark:bg-green-600 dark:hover:bg-green-500"
|
|
onClick={handleApprove}
|
|
disabled={submitting}
|
|
>
|
|
<IconCheck className="h-3.5 w-3.5" />
|
|
{submitting ? "Approving..." : "Approve PR"}
|
|
</Button>
|
|
);
|
|
}
|
|
|
|
export function PRDetailContent({ taskPR, sessionId }: { taskPR: TaskPR; sessionId: string }) {
|
|
const { feedback, loading, refresh } = usePRFeedback(taskPR.owner, taskPR.repo, taskPR.pr_number);
|
|
const { addAsContext } = useAddPRFeedbackAsContext(sessionId, taskPR.pr_number);
|
|
const setTaskPR = useAppStore((s) => s.setTaskPR);
|
|
|
|
// Sync live feedback data back to the store so topbar/other consumers stay up to date.
|
|
// Use primitive deps to avoid re-render loops from object reference changes.
|
|
// Guard: never regress the store to a less-terminal state (e.g. merged → open)
|
|
// because the feedback fetch may return stale data from before a backend poll update.
|
|
const prState = taskPR.state;
|
|
const prMergedAt = taskPR.merged_at ?? null;
|
|
const prClosedAt = taskPR.closed_at ?? null;
|
|
const prAdditions = taskPR.additions;
|
|
const prDeletions = taskPR.deletions;
|
|
const prTaskId = taskPR.task_id;
|
|
useEffect(() => {
|
|
if (!feedback) return;
|
|
const livePR = feedback.pr;
|
|
// State priority: merged > closed > open. Never regress to a less-terminal state.
|
|
const stateRank = (s: string) => {
|
|
if (s === "merged") return 2;
|
|
if (s === "closed") return 1;
|
|
return 0;
|
|
};
|
|
const effectiveState = stateRank(livePR.state) >= stateRank(prState) ? livePR.state : prState;
|
|
const effectiveMergedAt = effectiveState === prState ? prMergedAt : (livePR.merged_at ?? null);
|
|
const effectiveClosedAt = effectiveState === prState ? prClosedAt : (livePR.closed_at ?? null);
|
|
if (
|
|
effectiveState !== prState ||
|
|
effectiveMergedAt !== prMergedAt ||
|
|
effectiveClosedAt !== prClosedAt ||
|
|
livePR.additions !== prAdditions ||
|
|
livePR.deletions !== prDeletions
|
|
) {
|
|
setTaskPR(prTaskId, {
|
|
...taskPR,
|
|
state: effectiveState as TaskPR["state"],
|
|
additions: livePR.additions,
|
|
deletions: livePR.deletions,
|
|
merged_at: effectiveMergedAt,
|
|
closed_at: effectiveClosedAt,
|
|
});
|
|
}
|
|
// eslint-disable-next-line react-hooks/exhaustive-deps
|
|
}, [feedback, prState, prMergedAt, prClosedAt, prAdditions, prDeletions, prTaskId, setTaskPR]);
|
|
|
|
const metrics = derivePanelMetrics(taskPR, feedback);
|
|
|
|
return (
|
|
<div className="flex flex-col h-full">
|
|
<PRHeader
|
|
taskPR={taskPR}
|
|
feedback={feedback}
|
|
metrics={metrics}
|
|
loading={loading}
|
|
onRefresh={refresh}
|
|
/>
|
|
<Separator />
|
|
<ScrollArea className="flex-1 overflow-hidden">
|
|
<div className="p-3 space-y-1">
|
|
{loading && !feedback && (
|
|
<div className="flex items-center justify-center py-8">
|
|
<IconLoader2 className="h-6 w-6 text-blue-500 animate-spin" />
|
|
</div>
|
|
)}
|
|
{feedback && (
|
|
<>
|
|
<DescriptionSection body={feedback.pr.body ?? ""} />
|
|
<ReviewsSection
|
|
reviews={feedback.reviews ?? []}
|
|
requestedReviewers={feedback.pr.requested_reviewers ?? []}
|
|
prUrl={taskPR.pr_url}
|
|
reviewState={metrics.reviewState}
|
|
pendingReviewCount={metrics.pendingReviewCount}
|
|
onAddAsContext={(msg) => addAsContext("review", msg)}
|
|
/>
|
|
<ChecksSection
|
|
checks={feedback.checks ?? []}
|
|
onAddAsContext={(msg) => addAsContext("check", msg)}
|
|
/>
|
|
<CommentsSection
|
|
comments={feedback.comments ?? []}
|
|
prUrl={taskPR.pr_url}
|
|
onAddAsContext={(msg) => addAsContext("comment", msg)}
|
|
/>
|
|
</>
|
|
)}
|
|
</div>
|
|
</ScrollArea>
|
|
{taskPR.last_synced_at && (
|
|
<>
|
|
<Separator />
|
|
<div className="px-3 py-2 text-[10px] text-muted-foreground text-center">
|
|
Last synced {formatTimeAgo(taskPR.last_synced_at)}
|
|
</div>
|
|
</>
|
|
)}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
// --- Header ---
|
|
|
|
function StateBadge({ state }: { state: string }) {
|
|
const styles: Record<string, string> = {
|
|
open: "bg-green-100 text-green-700 dark:bg-green-900/30 dark:text-green-400",
|
|
draft: "bg-orange-100 text-orange-700 dark:bg-orange-900/30 dark:text-orange-400",
|
|
merged: "bg-purple-100 text-purple-700 dark:bg-purple-900/30 dark:text-purple-400",
|
|
closed: "bg-red-100 text-red-700 dark:bg-red-900/30 dark:text-red-400",
|
|
};
|
|
return (
|
|
<Badge variant="secondary" className={`text-[10px] px-1.5 py-0 ${styles[state] ?? ""}`}>
|
|
{state}
|
|
</Badge>
|
|
);
|
|
}
|
|
|
|
function HeaderTitleRow({
|
|
taskPR,
|
|
loading,
|
|
onRefresh,
|
|
}: {
|
|
taskPR: TaskPR;
|
|
loading: boolean;
|
|
onRefresh: () => void;
|
|
}) {
|
|
return (
|
|
<div className="flex items-start justify-between gap-2">
|
|
<a
|
|
href={taskPR.pr_url}
|
|
target="_blank"
|
|
rel="noopener noreferrer"
|
|
className="text-sm font-medium hover:underline truncate cursor-pointer min-w-0 flex-1"
|
|
>
|
|
{taskPR.pr_title}
|
|
</a>
|
|
<Tooltip>
|
|
<TooltipTrigger asChild>
|
|
<Button
|
|
size="sm"
|
|
variant="ghost"
|
|
className="h-6 w-6 p-0 cursor-pointer shrink-0 text-muted-foreground hover:text-foreground"
|
|
onClick={onRefresh}
|
|
disabled={loading}
|
|
>
|
|
<IconRefresh className={`h-3.5 w-3.5 ${loading ? "animate-spin" : ""}`} />
|
|
</Button>
|
|
</TooltipTrigger>
|
|
<TooltipContent>Refresh</TooltipContent>
|
|
</Tooltip>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function HeaderDateLine({ taskPR }: { taskPR: TaskPR }) {
|
|
return (
|
|
<div className="flex items-center gap-1.5 text-xs text-muted-foreground flex-wrap">
|
|
<span className="flex items-center gap-0.5">
|
|
by <AuthorLink author={taskPR.author_login} />
|
|
</span>
|
|
<span>·</span>
|
|
<span className={getTimeAgoColor(taskPR.created_at)}>
|
|
opened {formatTimeAgo(taskPR.created_at)}
|
|
</span>
|
|
{taskPR.merged_at && (
|
|
<>
|
|
<span>·</span>
|
|
<span className="flex items-center gap-0.5">
|
|
<IconGitMerge className="h-3 w-3 text-purple-500" />
|
|
merged {formatTimeAgo(taskPR.merged_at)}
|
|
</span>
|
|
</>
|
|
)}
|
|
{taskPR.closed_at && !taskPR.merged_at && (
|
|
<>
|
|
<span>·</span>
|
|
<span>closed {formatTimeAgo(taskPR.closed_at)}</span>
|
|
</>
|
|
)}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function HeaderStatsLine({ taskPR, metrics }: { taskPR: TaskPR; metrics: PRPanelMetrics }) {
|
|
return (
|
|
<div className="flex items-center gap-3 text-xs text-muted-foreground flex-wrap">
|
|
<span className="flex items-center gap-1">
|
|
<IconPlus className="h-3 w-3 text-green-500" />
|
|
{taskPR.additions}
|
|
</span>
|
|
<span className="flex items-center gap-1">
|
|
<IconMinus className="h-3 w-3 text-red-500" />
|
|
{taskPR.deletions}
|
|
</span>
|
|
<span>·</span>
|
|
<span>
|
|
{metrics.reviewCount} review{metrics.reviewCount !== 1 ? "s" : ""}
|
|
{metrics.pendingReviewCount > 0 && (
|
|
<span className="text-yellow-600 dark:text-yellow-400">
|
|
{" "}
|
|
({metrics.pendingReviewCount} pending)
|
|
</span>
|
|
)}
|
|
</span>
|
|
<span>·</span>
|
|
<span>
|
|
{metrics.commentCount} comment{metrics.commentCount !== 1 ? "s" : ""}
|
|
</span>
|
|
{metrics.reviewState && <ReviewStateBadge state={metrics.reviewState} />}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
function PRHeader({
|
|
taskPR,
|
|
feedback,
|
|
metrics,
|
|
loading,
|
|
onRefresh,
|
|
}: {
|
|
taskPR: TaskPR;
|
|
feedback: PRFeedback | null;
|
|
metrics: PRPanelMetrics;
|
|
loading: boolean;
|
|
onRefresh: () => void;
|
|
}) {
|
|
const liveState = feedback?.pr.state ?? taskPR.state;
|
|
const isDraft = feedback?.pr.draft ?? false;
|
|
const isMergeable = feedback?.pr.mergeable ?? true;
|
|
const showWarnings = !isDraft && !isMergeable && liveState === "open";
|
|
|
|
return (
|
|
<div className="p-3 space-y-2">
|
|
<div className="flex items-center gap-2">
|
|
<div className="flex-1 min-w-0">
|
|
<HeaderTitleRow taskPR={taskPR} loading={loading} onRefresh={onRefresh} />
|
|
</div>
|
|
<ApproveButton taskPR={taskPR} feedback={feedback} onRefresh={onRefresh} />
|
|
</div>
|
|
<div className="flex items-center gap-1.5 flex-wrap">
|
|
<StateBadge state={isDraft && liveState === "open" ? "draft" : liveState} />
|
|
<span className="text-xs text-muted-foreground">#{taskPR.pr_number}</span>
|
|
<code className="text-[10px] px-1 py-0.5 bg-muted rounded font-mono">
|
|
{taskPR.head_branch}
|
|
</code>
|
|
<span className="text-muted-foreground mx-0.5">→</span>
|
|
<code className="text-[10px] px-1 py-0.5 bg-muted rounded font-mono">
|
|
{taskPR.base_branch}
|
|
</code>
|
|
</div>
|
|
{showWarnings && (
|
|
<div className="flex items-center gap-1.5 flex-wrap">
|
|
<span className="flex items-center gap-1 text-[10px] text-yellow-600 dark:text-yellow-400">
|
|
<IconAlertTriangle className="h-3 w-3" />
|
|
Not mergeable
|
|
</span>
|
|
</div>
|
|
)}
|
|
<HeaderDateLine taskPR={taskPR} />
|
|
<HeaderStatsLine taskPR={taskPR} metrics={metrics} />
|
|
</div>
|
|
);
|
|
}
|