Files
kandev/apps/web/lib/plugins/host.ts
T
João Salavisa e145d48f22 feat: add plugin system with grpc runtime and native ui plugins (#1742)
* feat: add plugin system with grpc runtime and native ui plugins

- go plugin backends ship as release tarballs (per-platform binaries, checksums) that
  kandev installs from url/upload or filesystem sideload+sync, then spawns and
  supervises via hashicorp/go-plugin (unix socket / loopback tcp+automtls)
- strict typed grpc contract (kandev.plugin.v1): DeliverEvent/InvokeTool/HandleWebhook
  plus a capability-gated host service (state, secrets, emit); author sdk in
  pkg/pluginsdk; packaging cli in cmd/plugin-pack
- native frontend bundles: window.registerKandevPlugin + registry/host loader with
  dynamic routes, nav items, slots and ws handlers; plugins settings page with
  install dialog, sync button and enable/disable/uninstall
- gated behind the plugins feature flag (prod off, dev/e2e on); covered by unit and
  integration tests plus playwright e2e against a real packaged fixture plugin

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): hydrate base app context on plugin routes

Plugin-owned SPA routes classify as RouteUnknown, so the boot payload shipped
only feature flags — no workspaces, workflows, or kanban context. Native plugin
UI (e.g. host.ui.TaskCreateDialog) then had an empty store. Hydrate the same
base context as the Home route for unknown SPA routes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(plugins): expose TaskCreateDialog on host.ui

Lets a native plugin open kandev's real create-task modal (prefilled via
initialValues) instead of POSTing directly.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): harden filesystem/URL sinks against CodeQL findings

Add sink-level guards on the plugin trust boundary: securejoin containment on
archive extraction (zip-slip), plugin-id validation before every fs_store path,
http/https scheme validation on install-from-URL, and non-interpolated ws-handler
error logging.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): address review findings (races, resource caps, lifecycle)

- serialize per-plugin startup to close a TOCTOU double-spawn race, and let a
  plugin restart after exhausting attempts
- bound plugin startup with an explicit 30s timeout
- reject backslash paths and cap decompressed bytes by actual size in pkgtar;
  only mark a package Signed when a verifier actually ran and passed
- delete plugin_state on uninstall; validate webhook keys against the manifest
  and cap webhook body size; restart an active plugin when a new version installs

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): sanitize plugin-id path sinks for CodeQL

Pin the plugin id to a single path segment with filepath.Base at recordPath/
configPath and pkgtar.Remove — a barrier the taint analysis recognizes.
Behaviour-identical for valid ids (already validated by safePluginID); clears
the go/path-injection alerts.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): inline plugin-id validation at path sinks for CodeQL

filepath.Base does not strip '..', so it is not a path-injection barrier. Call
the recognized safePluginID / id-pattern guard inline in Delete/GetConfig/
SetConfig and pkgtar.Remove — the same barrier that already cleared the Get sink.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): address code-review findings (backend)

- add capability-gating tests for the Host RPC service (was untested)
- close a stop-during-start orphan race so Disable/Uninstall can't leave a
  supervised subprocess behind
- on failed upgrade, remove only the new version dir (not all versions + data);
  restart the prior version
- validate manifest version and reject ids ending in .config (record-file alias)
- make Deliverer.Refresh non-blocking and cancel in-flight delivery on worker stop
- clamp out-of-range webhook status, skip-and-warn corrupt records in List,
  write records atomically, semver-aware sideload version pick

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): address code-review findings (frontend)

- wrap plugin routes + settings routes in a shared PluginErrorBoundary so a
  throwing plugin page shows a fallback instead of white-screening the SPA
- fix disable/re-enable in one session: keep the cached registration and
  re-run initialize instead of relying on a cached ES-module re-import
- prefix root-relative bundle/style URLs with apiBaseUrl (split-origin/Tauri)
- surface partial-install warnings via toast.warning instead of a bare success
- dedupe/remove injected style links on unload; gate PluginNavItems on the flag

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): serialize per-plugin lifecycle + guard config writes

- add a per-plugin keyed lock in Service so concurrent Enable/Disable/Install/
  Uninstall/UpdateConfig for one id are serialized (no status-machine race)
- take s.mu in SetConfig/GetConfig and write config atomically
- bound each plugin initialize() with a timeout so one hung bundle can't stall
  the rest of the boot load

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test(plugins): split service_test.go to satisfy file-length lint

Move the install/URL test group into service_install_test.go; no logic change.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* ci: build and ship the e2e fixture plugin package to E2E shards

The plugin E2E specs' global-setup requires apps/backend/.build/kandev-plugin-e2e-1.0.0.tar.gz.
Build it in the E2E build job, upload it as an artifact, and download it in both
the regular and container shard jobs.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Kandev Agent <agent@kandev.dev>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-17 12:00:26 +01:00

194 lines
7.3 KiB
TypeScript

/**
* Plugin host: the `window.registerKandevPlugin` global + the loader that
* imports plugin bundles from the boot payload (docs/plans/plugins/PLUGIN-API.md).
*
* Loading sequence per bundle: inject `styleUrls` as `<link>` tags, dynamically
* `import(/* @vite-ignore *\/ bundleUrl)` the bundle (module-level side effect
* calls `window.registerKandevPlugin`), then call the registered plugin's
* `initialize(registry, host)`. A bad plugin (throwing bundle, missing
* registration, or throwing `initialize`) is logged and swallowed — it never
* breaks boot or blocks other plugins.
*
* `registeredPlugins` is never cleared on disable — only on a fresh import
* (see `resolveRegistration`). The browser's ES module cache means a repeat
* `import(bundleUrl)` after disable would resolve without re-running the
* bundle's top-level `registerKandevPlugin` call, so re-enabling in the same
* tab must reuse the cached registration instead of relying on re-import.
*/
import { getBackendConfig } from "@/lib/config";
import { pluginRegistry } from "./registry";
import type { ActivePlugin, KandevPlugin, PluginHostApi } from "./types";
/** Builds the per-plugin `PluginHostApi` for a given pluginId. */
export type PluginHostFactory = (pluginId: string) => PluginHostApi;
/** Injectable bundle loader — defaults to a real dynamic import. Tests pass a fake. */
export type BundleImporter = (url: string) => Promise<unknown>;
const defaultImporter: BundleImporter = (url) => import(/* @vite-ignore */ url);
/**
* How long `loadPlugin` waits for a single plugin's `initialize(registry, host)`
* to settle before giving up on it and moving on to the next plugin in the
* boot list. A plugin whose `initialize()` never resolves must not be able to
* stall every plugin queued behind it.
*/
const DEFAULT_INITIALIZE_TIMEOUT_MS = 10_000;
/**
* Races `promise` against a `timeoutMs` timer. Resolves with `promise`'s
* value (or rejects with its error) if it settles first; otherwise calls
* `onTimeout` and resolves with `undefined` once the timer fires — a timeout
* is deliberately not a rejection, so the caller's loop can continue to the
* next plugin instead of routing a hang through the same error-handling path
* as a thrown/rejected `initialize()`. The original promise is not
* cancelled; if it eventually settles nothing observes it.
*/
function raceTimeout<T>(
promise: Promise<T>,
timeoutMs: number,
onTimeout: () => void,
): Promise<T | void> {
return new Promise((resolve, reject) => {
const timer = setTimeout(() => {
onTimeout();
resolve();
}, timeoutMs);
promise.then(
(value) => {
clearTimeout(timer);
resolve(value);
},
(error: unknown) => {
clearTimeout(timer);
reject(error as Error);
},
);
});
}
type PluginGlobalWindow = Window & {
registerKandevPlugin?: (id: string, plugin: KandevPlugin) => void;
};
/** Bundles registered via `window.registerKandevPlugin`, keyed by pluginId. */
const registeredPlugins = new Map<string, KandevPlugin>();
/** Defines `window.registerKandevPlugin` before any bundle loads. Idempotent. */
export function installPluginGlobal(win: Window = window): void {
(win as PluginGlobalWindow).registerKandevPlugin = (id, plugin) => {
registeredPlugins.set(id, plugin);
};
}
/**
* Loads every plugin from the boot payload: injects styles, imports the
* bundle, then runs `initialize(registry, host)`. Each plugin is isolated —
* a failure anywhere in its load path is logged and does not affect the
* others or the boot sequence. `initTimeoutMs` (default
* `DEFAULT_INITIALIZE_TIMEOUT_MS`) bounds how long a single plugin's
* `initialize()` can block the (sequential) loop before the loader gives up
* on it and moves on — tests inject a short value instead of waiting out the
* real default.
*/
export async function loadPlugins(
bootPlugins: ActivePlugin[],
hostFactory: PluginHostFactory,
importer: BundleImporter = defaultImporter,
win: Window = window,
initTimeoutMs: number = DEFAULT_INITIALIZE_TIMEOUT_MS,
): Promise<void> {
installPluginGlobal(win);
for (const plugin of bootPlugins) {
await loadPlugin(plugin, hostFactory, importer, initTimeoutMs);
}
}
async function loadPlugin(
plugin: ActivePlugin,
hostFactory: PluginHostFactory,
importer: BundleImporter,
initTimeoutMs: number,
): Promise<void> {
const { apiBaseUrl } = getBackendConfig();
try {
injectStyles(plugin.id, plugin.styleUrls, apiBaseUrl);
const registered = await resolveRegistration(plugin, importer, apiBaseUrl);
if (!registered) {
console.error(`[plugins] "${plugin.id}" bundle did not call registerKandevPlugin`);
return;
}
const host = hostFactory(plugin.id);
const registry = pluginRegistry.forPlugin(plugin.id);
await raceTimeout(Promise.resolve(registered.initialize(registry, host)), initTimeoutMs, () => {
console.warn(
`[plugins] "${plugin.id}" initialize() timed out after ${initTimeoutMs}ms; continuing without it`,
);
});
} catch (error) {
console.error(`[plugins] failed to load plugin "${plugin.id}"`, error);
}
}
/**
* Returns the plugin's registration, importing the bundle only when it
* isn't already cached from a prior load in this tab (see module doc for
* why re-enable must not blindly re-import).
*/
async function resolveRegistration(
plugin: ActivePlugin,
importer: BundleImporter,
apiBaseUrl: string,
): Promise<KandevPlugin | undefined> {
const cached = registeredPlugins.get(plugin.id);
if (cached) return cached;
await importer(resolvePluginUrl(plugin.bundleUrl, apiBaseUrl));
return registeredPlugins.get(plugin.id);
}
/**
* Prefixes a root-relative plugin asset URL with the backend origin. Plain
* root-relative URLs only resolve correctly when the SPA and the API share
* an origin (same-origin production); split-origin dev and the Tauri
* desktop shell need the explicit `apiBaseUrl`, same as `host.api.fetch`.
*/
function resolvePluginUrl(url: string, apiBaseUrl: string): string {
if (!apiBaseUrl || !url.startsWith("/")) return url;
return `${apiBaseUrl}${url}`;
}
function injectStyles(pluginId: string, styleUrls: string[] | undefined, apiBaseUrl: string): void {
if (!styleUrls) return;
for (const href of styleUrls) {
const link = document.createElement("link");
link.rel = "stylesheet";
link.href = resolvePluginUrl(href, apiBaseUrl);
link.dataset.pluginId = pluginId;
document.head.appendChild(link);
}
}
/** Removes every `<link>` this plugin injected via `injectStyles`. */
function removeStyles(pluginId: string): void {
document.querySelectorAll(`link[data-plugin-id="${pluginId}"]`).forEach((link) => link.remove());
}
/**
* Disables a plugin: calls `destroy?.()`, bulk-revokes its registry
* registrations, and removes its injected stylesheets. Deliberately keeps
* the `registeredPlugins` entry — see module doc — so a later re-enable in
* the same tab can re-run `initialize` without depending on the browser
* re-executing the bundle's module-eval side effect.
*/
export function unloadPlugin(id: string): void {
const plugin = registeredPlugins.get(id);
try {
plugin?.destroy?.();
} catch (error) {
console.error(`[plugins] error destroying plugin "${id}"`, error);
} finally {
pluginRegistry.unregisterPlugin(id);
removeStyles(id);
}
}