e145d48f22
* feat: add plugin system with grpc runtime and native ui plugins - go plugin backends ship as release tarballs (per-platform binaries, checksums) that kandev installs from url/upload or filesystem sideload+sync, then spawns and supervises via hashicorp/go-plugin (unix socket / loopback tcp+automtls) - strict typed grpc contract (kandev.plugin.v1): DeliverEvent/InvokeTool/HandleWebhook plus a capability-gated host service (state, secrets, emit); author sdk in pkg/pluginsdk; packaging cli in cmd/plugin-pack - native frontend bundles: window.registerKandevPlugin + registry/host loader with dynamic routes, nav items, slots and ws handlers; plugins settings page with install dialog, sync button and enable/disable/uninstall - gated behind the plugins feature flag (prod off, dev/e2e on); covered by unit and integration tests plus playwright e2e against a real packaged fixture plugin Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): hydrate base app context on plugin routes Plugin-owned SPA routes classify as RouteUnknown, so the boot payload shipped only feature flags — no workspaces, workflows, or kanban context. Native plugin UI (e.g. host.ui.TaskCreateDialog) then had an empty store. Hydrate the same base context as the Home route for unknown SPA routes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(plugins): expose TaskCreateDialog on host.ui Lets a native plugin open kandev's real create-task modal (prefilled via initialValues) instead of POSTing directly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): harden filesystem/URL sinks against CodeQL findings Add sink-level guards on the plugin trust boundary: securejoin containment on archive extraction (zip-slip), plugin-id validation before every fs_store path, http/https scheme validation on install-from-URL, and non-interpolated ws-handler error logging. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address review findings (races, resource caps, lifecycle) - serialize per-plugin startup to close a TOCTOU double-spawn race, and let a plugin restart after exhausting attempts - bound plugin startup with an explicit 30s timeout - reject backslash paths and cap decompressed bytes by actual size in pkgtar; only mark a package Signed when a verifier actually ran and passed - delete plugin_state on uninstall; validate webhook keys against the manifest and cap webhook body size; restart an active plugin when a new version installs Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): sanitize plugin-id path sinks for CodeQL Pin the plugin id to a single path segment with filepath.Base at recordPath/ configPath and pkgtar.Remove — a barrier the taint analysis recognizes. Behaviour-identical for valid ids (already validated by safePluginID); clears the go/path-injection alerts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): inline plugin-id validation at path sinks for CodeQL filepath.Base does not strip '..', so it is not a path-injection barrier. Call the recognized safePluginID / id-pattern guard inline in Delete/GetConfig/ SetConfig and pkgtar.Remove — the same barrier that already cleared the Get sink. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address code-review findings (backend) - add capability-gating tests for the Host RPC service (was untested) - close a stop-during-start orphan race so Disable/Uninstall can't leave a supervised subprocess behind - on failed upgrade, remove only the new version dir (not all versions + data); restart the prior version - validate manifest version and reject ids ending in .config (record-file alias) - make Deliverer.Refresh non-blocking and cancel in-flight delivery on worker stop - clamp out-of-range webhook status, skip-and-warn corrupt records in List, write records atomically, semver-aware sideload version pick Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): address code-review findings (frontend) - wrap plugin routes + settings routes in a shared PluginErrorBoundary so a throwing plugin page shows a fallback instead of white-screening the SPA - fix disable/re-enable in one session: keep the cached registration and re-run initialize instead of relying on a cached ES-module re-import - prefix root-relative bundle/style URLs with apiBaseUrl (split-origin/Tauri) - surface partial-install warnings via toast.warning instead of a bare success - dedupe/remove injected style links on unload; gate PluginNavItems on the flag Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(plugins): serialize per-plugin lifecycle + guard config writes - add a per-plugin keyed lock in Service so concurrent Enable/Disable/Install/ Uninstall/UpdateConfig for one id are serialized (no status-machine race) - take s.mu in SetConfig/GetConfig and write config atomically - bound each plugin initialize() with a timeout so one hung bundle can't stall the rest of the boot load Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(plugins): split service_test.go to satisfy file-length lint Move the install/URL test group into service_install_test.go; no logic change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * ci: build and ship the e2e fixture plugin package to E2E shards The plugin E2E specs' global-setup requires apps/backend/.build/kandev-plugin-e2e-1.0.0.tar.gz. Build it in the E2E build job, upload it as an artifact, and download it in both the regular and container shard jobs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
203 lines
7.3 KiB
Go
203 lines
7.3 KiB
Go
// host.go implements the Host side of the kandev.plugin.v1.Host service
|
|
// (§3 of docs/plans/plugins/GRPC-CONTRACT.md) in both directions:
|
|
//
|
|
// - grpcHostClient: used inside the plugin subprocess. Wraps a
|
|
// pluginv1.HostClient dialed over the go-plugin broker (see serve.go)
|
|
// and satisfies the Go-native Host interface that Serve injects into
|
|
// the author's Plugin.
|
|
// - grpcHostServer: used inside kandev. Wraps kandev's own Go-native Host
|
|
// implementation (state store, secrets, event bus) and satisfies the
|
|
// generated pluginv1.HostServer interface so it can be registered on
|
|
// the broker-served grpc.Server that GRPCPlugin.GRPCClient spins up
|
|
// (see serve.go's "Host injection" section).
|
|
//
|
|
// Both directions share the same Go-native Host interface and the same
|
|
// proto conversion helpers in types.go, so kandev's runtime manager
|
|
// implements Host exactly once and gets both the client and server wiring
|
|
// for free via GRPCPlugin.
|
|
package pluginsdk
|
|
|
|
import (
|
|
"context"
|
|
|
|
pluginv1 "github.com/kandev/kandev/proto/kandev/plugin/v1"
|
|
"google.golang.org/grpc"
|
|
)
|
|
|
|
// Host is the set of operations kandev exposes back to a running plugin,
|
|
// per §3's Host service. On the plugin side, Serve injects an
|
|
// SDK-provided implementation that proxies these calls to kandev over the
|
|
// go-plugin broker. On the kandev side, the runtime manager provides its
|
|
// own Go-native implementation of this same interface (backed by the real
|
|
// state store / secrets / event bus) and hands it to GRPCPlugin.Host; the
|
|
// SDK wraps it into the generated pluginv1.HostServer for registration.
|
|
type Host interface {
|
|
// GetState looks up a single state entry. found is false, err is nil
|
|
// when the key does not exist.
|
|
GetState(ctx context.Context, scope, scopeID, key string) (value map[string]any, found bool, err error)
|
|
|
|
// SetState upserts a single state entry.
|
|
SetState(ctx context.Context, scope, scopeID, key string, value map[string]any) error
|
|
|
|
// DeleteState removes a single state entry. Deleting a missing key is
|
|
// not an error.
|
|
DeleteState(ctx context.Context, scope, scopeID, key string) error
|
|
|
|
// ListState returns every state entry for a scope/scopeID pair.
|
|
ListState(ctx context.Context, scope, scopeID string) ([]StateEntry, error)
|
|
|
|
// RevealSecret resolves a secret reference to its cleartext value.
|
|
RevealSecret(ctx context.Context, ref string) (string, error)
|
|
|
|
// EmitEvent publishes a plugin-originated event onto kandev's bus.
|
|
EmitEvent(ctx context.Context, name string, payload map[string]any) error
|
|
}
|
|
|
|
// newHostClient wraps a *grpc.ClientConn (dialed over the go-plugin broker)
|
|
// as a Go-native Host implementation.
|
|
func newHostClient(conn *grpc.ClientConn) Host {
|
|
return &grpcHostClient{client: pluginv1.NewHostClient(conn)}
|
|
}
|
|
|
|
type grpcHostClient struct {
|
|
client pluginv1.HostClient
|
|
}
|
|
|
|
func (h *grpcHostClient) GetState(ctx context.Context, scope, scopeID, key string) (map[string]any, bool, error) {
|
|
resp, err := h.client.GetState(ctx, &pluginv1.GetStateRequest{Scope: scope, ScopeId: scopeID, Key: key})
|
|
if err != nil {
|
|
return nil, false, err
|
|
}
|
|
if !resp.GetFound() {
|
|
return nil, false, nil
|
|
}
|
|
value, err := structToMap(resp.GetValue())
|
|
if err != nil {
|
|
return nil, false, err
|
|
}
|
|
return value, true, nil
|
|
}
|
|
|
|
func (h *grpcHostClient) SetState(ctx context.Context, scope, scopeID, key string, value map[string]any) error {
|
|
protoValue, err := mapToStruct(value)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
_, err = h.client.SetState(ctx, &pluginv1.SetStateRequest{Scope: scope, ScopeId: scopeID, Key: key, Value: protoValue})
|
|
return err
|
|
}
|
|
|
|
func (h *grpcHostClient) DeleteState(ctx context.Context, scope, scopeID, key string) error {
|
|
_, err := h.client.DeleteState(ctx, &pluginv1.DeleteStateRequest{Scope: scope, ScopeId: scopeID, Key: key})
|
|
return err
|
|
}
|
|
|
|
func (h *grpcHostClient) ListState(ctx context.Context, scope, scopeID string) ([]StateEntry, error) {
|
|
resp, err := h.client.ListState(ctx, &pluginv1.ListStateRequest{Scope: scope, ScopeId: scopeID})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return stateEntriesFromProto(resp.GetEntries())
|
|
}
|
|
|
|
func (h *grpcHostClient) RevealSecret(ctx context.Context, ref string) (string, error) {
|
|
resp, err := h.client.RevealSecret(ctx, &pluginv1.RevealSecretRequest{Ref: ref})
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
return resp.GetValue(), nil
|
|
}
|
|
|
|
func (h *grpcHostClient) EmitEvent(ctx context.Context, name string, payload map[string]any) error {
|
|
protoPayload, err := mapToStruct(payload)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
_, err = h.client.EmitEvent(ctx, &pluginv1.EmitEventRequest{EventName: name, Payload: protoPayload})
|
|
return err
|
|
}
|
|
|
|
var _ Host = (*grpcHostClient)(nil)
|
|
|
|
// registerHostServer registers a grpc server that dispatches
|
|
// kandev.plugin.v1.Host RPCs to impl (kandev's Go-native Host
|
|
// implementation), converting proto<->Go-native types at the boundary.
|
|
func registerHostServer(s grpc.ServiceRegistrar, impl Host) {
|
|
pluginv1.RegisterHostServer(s, &grpcHostServer{impl: impl})
|
|
}
|
|
|
|
type grpcHostServer struct {
|
|
pluginv1.UnimplementedHostServer
|
|
impl Host
|
|
}
|
|
|
|
func (s *grpcHostServer) GetState(ctx context.Context, req *pluginv1.GetStateRequest) (*pluginv1.GetStateResponse, error) {
|
|
value, found, err := s.impl.GetState(ctx, req.GetScope(), req.GetScopeId(), req.GetKey())
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if !found {
|
|
return &pluginv1.GetStateResponse{Found: false}, nil
|
|
}
|
|
protoValue, err := mapToStruct(value)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return &pluginv1.GetStateResponse{Found: true, Value: protoValue}, nil
|
|
}
|
|
|
|
func (s *grpcHostServer) SetState(ctx context.Context, req *pluginv1.SetStateRequest) (*pluginv1.SetStateResponse, error) {
|
|
value, err := structToMap(req.GetValue())
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if err := s.impl.SetState(ctx, req.GetScope(), req.GetScopeId(), req.GetKey(), value); err != nil {
|
|
return nil, err
|
|
}
|
|
return &pluginv1.SetStateResponse{}, nil
|
|
}
|
|
|
|
func (s *grpcHostServer) DeleteState(ctx context.Context, req *pluginv1.DeleteStateRequest) (*pluginv1.DeleteStateResponse, error) {
|
|
if err := s.impl.DeleteState(ctx, req.GetScope(), req.GetScopeId(), req.GetKey()); err != nil {
|
|
return nil, err
|
|
}
|
|
return &pluginv1.DeleteStateResponse{}, nil
|
|
}
|
|
|
|
func (s *grpcHostServer) ListState(ctx context.Context, req *pluginv1.ListStateRequest) (*pluginv1.ListStateResponse, error) {
|
|
entries, err := s.impl.ListState(ctx, req.GetScope(), req.GetScopeId())
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
protoEntries := make([]*pluginv1.StateEntry, len(entries))
|
|
for i := range entries {
|
|
converted, err := entries[i].toProto()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
protoEntries[i] = converted
|
|
}
|
|
return &pluginv1.ListStateResponse{Entries: protoEntries}, nil
|
|
}
|
|
|
|
func (s *grpcHostServer) RevealSecret(ctx context.Context, req *pluginv1.RevealSecretRequest) (*pluginv1.RevealSecretResponse, error) {
|
|
value, err := s.impl.RevealSecret(ctx, req.GetRef())
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return &pluginv1.RevealSecretResponse{Value: value}, nil
|
|
}
|
|
|
|
func (s *grpcHostServer) EmitEvent(ctx context.Context, req *pluginv1.EmitEventRequest) (*pluginv1.EmitEventResponse, error) {
|
|
payload, err := structToMap(req.GetPayload())
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if err := s.impl.EmitEvent(ctx, req.GetEventName(), payload); err != nil {
|
|
return nil, err
|
|
}
|
|
return &pluginv1.EmitEventResponse{}, nil
|
|
}
|
|
|
|
var _ pluginv1.HostServer = (*grpcHostServer)(nil)
|