João Salavisa
1ba81a7cd0
Plugin `tools[]` overlapped with MCP, kandev's established mechanism for exposing tools to agents (`internal/mcp/`), and the `InvokeTool` path was never wired into agent tool sets — the `listTools` handler was listing-only. Rather than maintain a half-built parallel surface, remove it. If plugins ever contribute agent tools, they should feed through MCP, not a separate `InvokeTool` RPC. Removes: - proto `InvokeTool` RPC + `ToolRequest`/`ToolResponse`/`ToolContext` messages (regenerated `*.pb.go` / `*_grpc.pb.go`) - pkg/pluginsdk `InvokeTool` from the `Plugin` interface and `UnimplementedPlugin`, the Tool* Go-native types, and the `RemotePlugin`/`GRPCServer` dispatch - internal/plugins `Service.InvokeTool`, the `listTools` handler + `GET /api/plugins/tools` route, `PluginToolDTO`, and the manifest `Tools` field + tool-name uniqueness validation - frontend `PluginTool`/`PluginToolDTO` types, `listPluginTools`, and the manifest-card tools list - fixture/e2e `InvokeTool` echo impl and the `tools:` manifest block Test doubles that used the "crash" tool to exercise crash-restart now use a "crash" webhook key instead. Internal specs (GRPC-CONTRACT, spec) drop the tool RPC/feature; docs/public was already updated in #1774. Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
63 lines
2.7 KiB
Go
63 lines
2.7 KiB
Go
package plugins
|
|
|
|
import "github.com/kandev/kandev/internal/plugins/store"
|
|
|
|
// InstallRequest is the JSON body of POST /api/plugins/install when
|
|
// installing from a URL: {"url": "https://.../plugin-1.0.0.tar.gz"}. The
|
|
// same endpoint also accepts a multipart/form-data upload with a "package"
|
|
// field instead of this body — see Controller.install.
|
|
type InstallRequest struct {
|
|
URL string `json:"url"`
|
|
}
|
|
|
|
// InstallResponse is the body of a successful POST /api/plugins/install.
|
|
// Warning is set (and the plugin's status left as "error") when the
|
|
// package was installed but its initial spawn/handshake failed — the
|
|
// operator can inspect Plugin.Status and retry via POST /:id/enable.
|
|
type InstallResponse struct {
|
|
Plugin *store.Record `json:"plugin"`
|
|
Warning string `json:"warning,omitempty"`
|
|
}
|
|
|
|
// UpdateConfigRequest is the PATCH /api/plugins/:id body: the full
|
|
// operator-editable config, replacing whatever was previously stored (see
|
|
// store.Store.SetConfig).
|
|
type UpdateConfigRequest struct {
|
|
Config map[string]any `json:"config"`
|
|
}
|
|
|
|
// SyncResult is the body of a successful POST /api/plugins/sync (and the
|
|
// return value of Service.Sync / Service.bootScan): what the filesystem
|
|
// scan under the plugins directory found and did this run, per
|
|
// docs/specs/plugins/spec.md ("Filesystem sideloading & sync").
|
|
type SyncResult struct {
|
|
// Added lists the plugin ids of directory sideloads
|
|
// (<pluginsDir>/<id>/<version>/manifest.yaml found with no existing
|
|
// {id}.yml record) registered this run. Always registered
|
|
// StatusDisabled — sideloads are unverified and are never auto-spawned.
|
|
Added []string `json:"added"`
|
|
// Installed lists the plugin ids of dropped *.tar.gz packages installed
|
|
// (and, on a healthy spawn, activated) via the normal verified install
|
|
// pipeline (Service.Install) this run. Each source tarball is deleted
|
|
// from the plugins directory once its install succeeds.
|
|
Installed []string `json:"installed"`
|
|
// Missing lists the plugin ids of existing records whose InstallPath no
|
|
// longer exists on disk. Each is stopped (if running) and transitioned
|
|
// to StatusError.
|
|
Missing []string `json:"missing"`
|
|
// Errors lists every per-item failure encountered this run: a rejected
|
|
// dir-sideload candidate (invalid/mismatched manifest.yaml, or a
|
|
// lower-priority version dir skipped in favor of the lexically greatest
|
|
// when more than one is found for the same unregistered id), or a
|
|
// dropped tarball that failed pkgtar's verify/validate pipeline and was
|
|
// left in place.
|
|
Errors []SyncError `json:"errors"`
|
|
}
|
|
|
|
// SyncError is one entry of SyncResult.Errors: the filesystem path the
|
|
// problem was found at, and a human-readable reason.
|
|
type SyncError struct {
|
|
Path string `json:"path"`
|
|
Reason string `json:"reason"`
|
|
}
|