Files

T

João Salavisa 0df2bbac0a feat(plugins): typed capability-gated Host data API (ADR 0043) (#1753 )

* docs(plugins): draft Host data API proto (read + write DTOs)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs(plugins): ADR + spec + plan for the Host data API

Plugins access kandev data via capability-gated Host gRPC RPCs returning
hand-mapped DTOs, never the DB directly. ADR 0042.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(plugins): add Host data API RPCs and DTOs to plugin proto

Extends the existing service Host (per ADR 0042) with read RPCs
(ListTasks/GetTask, ListWorkspaces, ListWorkflows, ListWorkflowSteps,
ListAgentProfiles, ListRepositories, ListSessions, ListSessionCodeStats)
and declares the deferred phase-2 write RPCs (CreateTask, UpdateTask,
CreateComment) so the contract is stable for later tasks. Regenerates
plugin.pb.go/plugin_grpc.pb.go via `make -C apps/backend proto`.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* feat(plugins): Host data API SDK accessors + session LOC aggregation

Wave 1-2 of ADR 0042: pkg/pluginsdk gains typed reader accessors (host.Tasks(),
host.Sessions().CodeStats(), host.Workflows(), ...) over the extended Host gRPC
service, with proto<->native DTO conversions and an UnimplementedHostData seam
for the kandev-side impl. internal/analytics gains the per-session LOC
aggregation those readers surface. Backend handlers + capability gating land in
the next wave.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(plugins): capability-gated Host data read handlers (ADR 0042)

Implement pluginHost Tasks/Sessions/Workspaces/Workflows/AgentProfiles/
Repositories readers: each gated on api_read:<resource> (PermissionDenied
otherwise), backed by the service layer via narrow injected interfaces, and
hand-mapped to the pluginsdk DTOs. Sessions().CodeStats routes through the
analytics aggregation; acp_session_id preserves the metadata->resume_token
fallback. Wired through plugins.Service.SetDataSources + backendapp.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test(plugins): wire test for Host data reads + docs (ADR 0042 accepted)

End-to-end test over the real go-plugin transport: session data round-trips,
per-resource api_read gating returns PermissionDenied over the wire, cursor
pagination. Document the Host data API + SDK accessors in GRPC-CONTRACT.md,
reconcile the spec to shipped code, mark ADR 0042 accepted.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(plugins): full session history + snapshot profile name in data API

Sessions().List now fetches tasks with includeArchived=true — an archived
task's sessions are still real sessions, and CodeStats already made the
same call at the SQL layer, so the two session reads were inconsistent
(26 of 359 sessions visible on a real instance). Tasks().List keeps
archived tasks excluded.

Session gains agent_profile_name (proto field 10) sourced from the
profile snapshot, so sessions of since-uninstalled agents keep a human
label — the AgentProfiles registry only lists live agents.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs(plugins): renumber Host data API ADR 0042 -> 0043

main merged its own ADR 0042 (project shell output); renumber this one to the
next free slot and update all references.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(plugins): address Host data API review (perf, pagination, filters, proto)

- paginate before DTO conversion so per-session ACP lookups run <=limit times
- fetch all source pages (no silent 1000/workspace truncation); accurate HasMore
- stable id tiebreaker on paginated sorts
- AND SessionFilter.TaskIDs with WorkspaceIDs; exclude config-mode sessions from
  CodeStats (shared dialect.ExcludeConfigModePredicate) so List/CodeStats match
- Get returns codes.NotFound consistently in-process and over the wire
- wrap bare-DTO RPC responses (GetTaskResponse etc.) for Buf response uniqueness

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* docs(plugins): mark Host data API plan tasks done

---------

Co-authored-by: Kandev Agent <agent@kandev.dev>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

2026-07-17 13:43:58 +01:00

2.7 KiB

Raw Blame History

id, title, status, wave, depends_on, plan, spec, adr

title

status

wave

depends_on

plan

spec

adr

03-sdk-data-accessors

SDK Go-native data DTOs, Host interface, and author accessors

done

01-proto-contract

plan.md

../../../specs/plugins/spec.md

../../../decisions/0043-plugin-host-data-api.md

Task 03: SDK Go-native data DTOs, Host interface, and author accessors

Extend pkg/pluginsdk so authors read kandev data through Go-native typed structs — proto types never leak past the package boundary, matching the existing state/secrets pattern in host.go/types.go.

Scope

Go-native DTOs in types.go mirroring the proto: Task, TaskRepository, Session, SessionCodeStats, Workspace, Workflow, WorkflowStep, AgentProfile, Repository, plus Page/PageInfo/filter structs, each with toProto/fromProto helpers alongside the existing ones.
Host interface extension (host.go): add data read methods. Prefer grouping behind sub-accessors exposed from the Host interface — host.Tasks(), host.Sessions(), host.Workspaces(), host.Workflows(), host.AgentProfiles(), host.Repositories() — each returning a small typed accessor (e.g. TasksAPI.List(ctx, filter, page), TasksAPI.Get(ctx, id), SessionsAPI.List(...), SessionsAPI.CodeStats(...)). Keep write methods off the surface this phase (deferred).
Client + server conversions: grpcHostClient (plugin side) calls the generated data RPCs and converts responses to Go-native; grpcHostServer (kandev side) dispatches to the Go-native interface. Follow the existing GetState/ListState conversion shape exactly.
Keep the existing Host state/secrets/emit methods intact.

Acceptance

Author can call host.Sessions().List(ctx, filter, page) and host.Sessions().CodeStats(ctx, filter, page) (etc.) receiving Go-native structs; proto types are not exposed.
grpcHostServer satisfies the generated server interface for the new RPCs; grpcHostClient satisfies the extended Host interface.
Round-trip conversion unit tests pass.

Verification

cd apps/backend && go test ./pkg/pluginsdk/...
cd apps/backend && go build ./...

Files likely touched

apps/backend/pkg/pluginsdk/types.go
apps/backend/pkg/pluginsdk/host.go
apps/backend/pkg/pluginsdk/*_test.go

Inputs

Generated stubs from task-01.
Existing pattern: pkg/pluginsdk/host.go (grpcHostClient/grpcHostServer), types.go (toProto/fromProto, mapToStruct/structToMap).
Spec: "Host data API" resource/capability table.

Dependencies

Task 01 (needs regenerated proto stubs).

Output contract

Summary, the accessor shape chosen (sub-accessors vs flat methods), files changed, test result, and status update here + in plan.md.

2.7 KiB Raw Blame History