Files
kandev/apps/web/e2e/tests/chat/implement-plan-fresh.spec.ts
T
Luan Martins 1066ac5b16 feat: extend implement plan button with fresh-agent path and server-side plan mode (#832)
* feat: extend implement plan button with fresh-agent path and server-side plan mode

- Split-button: primary click = same-session, chevron = fresh agent with clean context window
- Forward draft attachments and context files on implement (adds getAttachments() to handle)
- Authoritatively clear plan_mode via new session.set_plan_mode WS endpoint, not a message flag
- Add on_exit:disable_plan_mode to plan-and-build.yml plan step (mirrors feature-dev.yml)
- Drop localStorage plan-mode rehydration; server session metadata is the single source of truth
- Delete dead DocumentPanel component (no callers)
- Add SetSessionPlanModeByID on orchestrator Service; wire wsSetPlanMode handler

* test: fix store isolation in useImplementFresh test + extract duplicate strings

- Fix test isolation: reset store directly and clear mocks before rendering
- Extract sessionId, appFilePath, appFileName to constants to fix ESLint duplicate-string warnings

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* test(e2e): cover implement-plan fresh-agent split-button path

Adds Playwright coverage for the new chevron menu on the violet Implement
button: asserts a brand-new TaskSession is launched on the same task with
the planning session's agent profile inherited, and that the planning
session is left running in parallel. Second spec verifies the split-button
is gated behind plan mode.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix: defer plan-mode exit and surface error toast on implement failures

Move handlePlanModeChange(false) into the message.add success callback in
useImplementPlan so a failed send leaves the plan layout intact for retry.
Add error toast to useImplementFresh catch so launchSession failures are
visible to the user instead of silently logged.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: guard fresh-agent launch on planning session executor_id

TaskSession.executor_id is optional, so the fresh-agent path could call
launchSession with an undefined executor and silently inherit the
workspace default instead of the planning session's executor. Add the
field to the early-return guard so the hook no-ops when the planning
session is missing either an agent profile or an executor.

* feat: mark fresh-agent session as primary and focus it

When useImplementFresh launches a new implementation session, the fresh
session is now automatically:
1. Set as primary via session.set_primary WS endpoint
2. Focused/selected as the active session in the UI

This improves UX by switching the focus to the fresh implementation context
immediately rather than keeping the planning session active.

Addresses comment in PR #832 from carlosflorencio.

- Extract setupFreshSession helper to keep complexity under 15
- Add tests for primary session marking and UI focus
- Add test for graceful handling of set_primary failures
- Update JSDoc to document the new behavior
- Extract test constants to avoid duplicate string warnings

* fix(test): replace self-referential test constants

`const TASK_ID = TASK_ID;` (and SESS_PLAN, SESS_FRESH) caused a TDZ
ReferenceError at module load, so vitest reported `(0 test)` and none of
the new fresh-agent coverage actually ran. Replace with literal values
so the 13 tests in this file execute again.

* fix: drop strict executor_id guard and skip composer clear on missing session_id

Two related issues:

1. e2e regression — the planning session in the FE store does not always
   carry executor_id (the field is omitempty on the backend DTO and isn't
   populated for fresh task sessions in the WS push path). The earlier
   guard required it before calling launchSession, so the fresh-agent
   path silently no-op'd in real flows. Drop executor_id from the guard
   and only forward it when set; backend resolves it from the agent
   profile / workspace default when omitted.

2. PR review (Greptile P1) — when launchSession resolves without a
   session_id, the previous flow still cleared the composer and draft
   even though no fresh session was activated. Bail out before the
   clear so the user keeps their typed text and can retry.

Tests updated:
- replace the no-op-on-missing-executor test with one that asserts the
  hook still launches and omits the key from the payload
- add coverage for the no-session_id branch keeping the composer intact

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-10 17:30:24 +01:00

149 lines
5.5 KiB
TypeScript

import { type Page } from "@playwright/test";
import { test, expect } from "../../fixtures/test-base";
import type { SeedData } from "../../fixtures/test-base";
import type { ApiClient } from "../../helpers/api-client";
import { SessionPage } from "../../pages/session-page";
// ---------------------------------------------------------------------------
// "Implement plan" split-button — fresh-agent path
// ---------------------------------------------------------------------------
//
// The toolbar shows the violet 🚀 Implement button only while plan mode is
// active and the workflow's next step is not a work step. The split-button has
// two paths:
// - Primary click → same-session message.add (existing behavior)
// - Chevron menu → "Implement in fresh agent" → launchSession(intent: start)
// which spawns a brand-new TaskSession on the same task.
//
// These tests exercise the fresh-agent path end-to-end and assert the new
// session inherits the planning session's agent profile.
async function seedTaskAndEnterPlanMode(
testPage: Page,
apiClient: ApiClient,
seedData: SeedData,
title: string,
) {
const task = await apiClient.createTaskWithAgent(
seedData.workspaceId,
title,
seedData.agentProfileId,
{
description: "/e2e:simple-message",
workflow_id: seedData.workflowId,
workflow_step_id: seedData.startStepId,
repository_ids: [seedData.repositoryId],
},
);
await testPage.goto(`/t/${task.id}`);
const session = new SessionPage(testPage);
await session.waitForLoad();
await expect(session.idleInput()).toBeVisible({ timeout: 30_000 });
await session.togglePlanMode();
await expect(session.planModeInput()).toBeVisible({ timeout: 10_000 });
return { session, taskId: task.id, planningSessionId: task.session_id! };
}
test.describe("Implement plan — fresh-agent path", () => {
test.describe.configure({ retries: 1 });
test("split-button menu launches a new session inheriting the planning session's agent profile", async ({
testPage,
apiClient,
seedData,
}) => {
test.setTimeout(90_000);
const { session, taskId, planningSessionId } = await seedTaskAndEnterPlanMode(
testPage,
apiClient,
seedData,
"Implement plan fresh-agent test",
);
// Sanity: only the planning session exists at this point.
const before = await apiClient.listTaskSessions(taskId);
expect(before.sessions).toHaveLength(1);
expect(before.sessions[0].id).toBe(planningSessionId);
const planningProfileId = before.sessions[0].agent_profile_id;
expect(planningProfileId).toBeTruthy();
// Primary button is visible while plan mode is active.
const primary = testPage.getByTestId("implement-plan-button");
await expect(primary).toBeVisible({ timeout: 10_000 });
// Open the chevron dropdown and click the fresh-agent menu item.
await testPage.getByTestId("implement-plan-menu-trigger").click();
const freshItem = testPage.getByTestId("implement-fresh-menu-item");
await expect(freshItem).toBeVisible({ timeout: 5_000 });
await freshItem.click();
// A second TaskSession should appear on the task. launchSession is async
// (WS round-trip + lifecycle prepare), so poll instead of asserting once.
await expect
.poll(
async () => {
const { sessions } = await apiClient.listTaskSessions(taskId);
return sessions.length;
},
{ timeout: 30_000, message: "fresh session never appeared" },
)
.toBe(2);
const { sessions } = await apiClient.listTaskSessions(taskId);
const freshSession = sessions.find((s) => s.id !== planningSessionId);
expect(freshSession).toBeDefined();
// Fresh session inherits the planning session's agent profile (the
// fresh-agent path passes agent_profile_id from the planning session into
// launchSession — no profile picker is shown).
expect(freshSession!.agent_profile_id).toBe(planningProfileId);
// Planning session was not deleted/replaced — fresh-agent path leaves it
// running in parallel.
expect(sessions.some((s) => s.id === planningSessionId)).toBe(true);
// Touch `session` so the unused-binding lint stays clean even after we
// dropped the dockview-tab assertion (which depended on lazy tab mount).
expect(session).toBeDefined();
});
test("dropdown is hidden until plan mode is enabled", async ({
testPage,
apiClient,
seedData,
}) => {
test.setTimeout(60_000);
const task = await apiClient.createTaskWithAgent(
seedData.workspaceId,
"Implement button hidden without plan mode",
seedData.agentProfileId,
{
description: "/e2e:simple-message",
workflow_id: seedData.workflowId,
workflow_step_id: seedData.startStepId,
repository_ids: [seedData.repositoryId],
},
);
await testPage.goto(`/t/${task.id}`);
const session = new SessionPage(testPage);
await session.waitForLoad();
await expect(session.idleInput()).toBeVisible({ timeout: 30_000 });
// No plan mode → no Implement button and no chevron trigger.
await expect(testPage.getByTestId("implement-plan-button")).not.toBeVisible();
await expect(testPage.getByTestId("implement-plan-menu-trigger")).not.toBeVisible();
// Toggle on → both appear.
await session.togglePlanMode();
await expect(testPage.getByTestId("implement-plan-button")).toBeVisible({ timeout: 10_000 });
await expect(testPage.getByTestId("implement-plan-menu-trigger")).toBeVisible();
});
});