Files
kandev/apps/web/components/task-create-dialog-helpers.ts
T
João Salavisa 45a46f9899 feat: support tasks without a repository (#850)
* feat: support tasks without a repository

Lets users create a task with no repository attached — useful for research,
brainstorming, design discussions, or pointing the agent at an existing
non-git folder. The create-task dialog gains a 3-mode segmented control
(Repo / URL / None); "None" mode replaces the chip row with a folder
picker that browses the host filesystem via a new GET /api/v1/fs/list-dir
endpoint and either commits an absolute path or falls back to a kandev-
managed scratch workspace at <homeDir>/tasks/<workspaceID>/<taskID>/.

The worktree executor is hidden from the picker in no-repo mode (it
inherently needs a repo); the lifecycle manager also short-circuits
worktree mode server-side as a belt-and-suspenders guard. The Changes
panel auto-closes for repo-less tasks since it has nothing to show, and
the cumulative-diff handler returns null instead of erroring when no
base commit exists.

Spec + plan added at docs/specs/tasks-without-repositories/.

* fix(backend): anchor folder picker to discovery roots (CodeQL path traversal)

CodeQL flagged the new GET /api/v1/fs/list-dir handler for piping a
user-controlled path straight into os.Stat / os.ReadDir. Restrict the
listing to paths inside the configured discovery roots (defaults to
$HOME, same allowlist as repository discovery), reject anything outside
with ErrPathNotAllowed → HTTP 403, and clip the breadcrumb's "up"
button at the root so the picker can't be used to walk above the
allowed prefix.

Tests cover: rejection of paths outside roots, traversal escapes (../),
default-to-first-root, and parent exposure for nested paths.

* fix(backend): use os.Root for folder picker (recognized CodeQL sanitizer)

Previous attempt anchored to discovery roots via isPathAllowed, but
CodeQL's data flow doesn't model that helper as a sanitizer and kept
flagging os.Stat / os.ReadDir. Switch to os.Root (Go 1.24+): open the
matching discovery root once and run Stat/Open/ReadDir against the
relative path within it. The OS itself enforces containment — symlinks
and traversal cannot escape — and CodeQL recognizes os.Root as safe.

* fix: address PR review feedback

- Changes panel auto-close now distinguishes "task loading" from
  "task has no repos" (returns boolean | null), so the panel isn't
  permanently removed during the first-render window before task
  data lands in the store.
- Reset noRepository / workspacePath in resetDiscoveryState so
  reopening the dialog after a None-mode task doesn't carry the
  flag forward.
- Folder-picker breadcrumb: dropped dead `i > 0 && i > 1` condition
  (always equivalent to `i > 1`); chevrons now render between every
  segment as expected.
- list-dir HTTP handler returns a generic error message instead of
  forwarding raw OS errors that leak host paths.
- Document the dataDir → kandevHome inversion convention next to
  the scratch-path computation so future readers don't mistake the
  filepath.Dir call for a fragile derivation.

* fix: address CodeRabbit review nitpicks

- Trim whitespace on workspace_path before persisting to task metadata
  so a value of "   " doesn't get stored as a non-empty path.
- Extract the workspace_path metadata key into models.MetaKeyWorkspacePath
  alongside the existing MetaKeyAgentProfileID / MetaKeyExecutorProfileID
  so the set/read sites can't drift apart.
- Folder picker: reset cached listing when the popover closes, so
  reopening reloads from `value` instead of showing the last browsed
  directory the user navigated away from without committing.
- Submit payload: send `workspace_path: undefined` instead of an empty
  string when the trimmed value is empty, matching the noRepository=false
  case and keeping the API contract clear.

* fix: scratch path lands in kandev home, not its parent

Claude caught a real bug — `m.dataDir` is set from `cfg.ResolvedHomeDir()`
in cmd/kandev/agents.go, not `ResolvedDataDir()` (the field name is
misleading and the comment was wrong). My previous use of
`filepath.Dir(m.dataDir)` therefore walked one level above the kandev
home, so scratch dirs landed at e.g. `~/tasks/<ws>/<task>` instead of
`~/.kandev/tasks/<ws>/<task>` — and at the project root in dev mode
where `KANDEV_HOME_DIR=<project>/.kandev-dev`, which is what the user
saw on their machine.

Use `m.dataDir` directly (it's already the kandev home), document the
field's misnamed-but-correct semantics, and tighten the test fixtures.

Also:
- folder-picker trigger gets `cursor-pointer` (CodeRabbit nitpick).

* fix: pass workspacePath through handleCreateWithoutAgent too

The "create without agent" path called buildCreateTaskPayload without
the new workspacePath field, so picking a folder + clicking "Create
without starting" silently dropped the path. Now matches the
performCreate (with-agent) path.

* fix: satisfy DialogFormState in new-subtask form stub

PR #852 (merged after this branch was created) introduced
new-subtask-form-state.ts which stubs out a DialogFormState for the
subtask dialog. Adding noRepository / setNoRepository / workspacePath /
setWorkspacePath to the type made that stub incomplete, breaking the
Next.js production build (caught by CI, missed by tsc --noEmit).

Add the four inert fields to the stub, alongside the existing fresh-
branch inert fields, and pull both groups into named constants to
keep the useMemo body under the per-function line cap.

* fix: keep toggle-github-url testid as alias on URL-mode button

The new source-mode segmented control replaced the previous
"or paste a GitHub URL" text link, which had data-testid="toggle-github-url".
The existing e2e suite (create-task-github-url.spec.ts and the new
subtask.spec.ts from #852) still selects the URL toggle by that testid.
Keep "toggle-github-url" as the testid on the URL-mode button so both
suites pass without a sweep across all e2e files. Click semantics are
unchanged — single click enters URL mode.

* test(e2e): update toggle assertion for new source-mode segmented control

create-task-github-url.spec.ts:892 was checking the old text-link
toggle's two-way behavior with text labels ("or paste a GitHub URL" /
"use a workspace repository"). The new segmented control has explicit
mode buttons; assert aria-checked instead of label text. The other 9
clicks on `toggle-github-url` in this file still work via the legacy
testid alias on the URL-mode button.

* refactor: extract useActiveTaskHasRepos to its own hook file

dockview-desktop-layout.tsx grew to 609 lines with the new hook +
the Changes panel guard, over the 600-line cap documented in
CLAUDE.md (lint passed but the convention is real). Move the hook
to hooks/domains/kanban/use-active-task-has-repos.ts. File drops
to 590 lines.

* chore: gitignore .claude/scheduled_tasks.lock runtime file

* fix(web): lock chip-row min-height so modal doesn't shift on mode toggle

The chip row uses flex-wrap; Repo mode (chip + branch + add button +
segmented control) sometimes occupies a different vertical extent than
None mode (single folder picker + segmented control), causing the
create-task modal to jump a few pixels when toggling between sources.
Set min-h-9 so the row always reserves at least one chip-row of
height regardless of the active mode.

* feat: let folder picker browse anywhere, drop allowed-roots gate

The picker is for choosing a starting folder for a repo-less task —
users legitimately want /tmp, /var/log/foo, or any directory they have
read access to. Coupling it to the repo-discover endpoint's
discoveryRoots ($HOME by default) was too tight: paths like /tmp
returned 403 "path is not within allowed roots".

Decouple ListDirectory from discoveryRoots. The repo-discover endpoint
(DiscoverLocalRepositories, ValidateLocalRepositoryPath,
LocalRepositoryStatus, ListBranches) stays anchored to the allowlist
since picking a repo to import is a workspace-scoped operation; the
folder picker trusts the local-process boundary instead.

CodeQL is kept happy by routing the FS operations through os.Root
opened at "/" — the Go stdlib sanitizer for path injection still
recognises it (containment to / is trivially satisfied for every
absolute path on the host).

---------

Co-authored-by: Kandev Agent <agent@kandev.dev>
2026-05-12 01:10:22 +01:00

292 lines
10 KiB
TypeScript

import type { useRouter } from "next/navigation";
import type { Task, Branch, LocalRepository, Repository } from "@/lib/types/http";
import type { AgentProfileOption } from "@/lib/state/slices";
import type { AppState } from "@/lib/state/store";
import type { StepType, TaskRepoRow } from "@/components/task-create-dialog-types";
import { selectPreferredBranch } from "@/lib/utils";
import { getLocalStorage } from "@/lib/local-storage";
import { STORAGE_KEYS } from "@/lib/settings/constants";
import { useContextFilesStore } from "@/lib/state/context-files-store";
import { linkToTask } from "@/lib/links";
import { INTENT_PLAN } from "@/lib/state/layout-manager";
import { createTask } from "@/lib/api";
import type { FileAttachment } from "@/components/task/chat/file-attachment";
import type { MessageAttachment } from "@/lib/services/session-launch-service";
type CreateTaskParams = Parameters<typeof createTask>[0];
export type { CreateTaskParams };
/** Converts FileAttachment array to MessageAttachment array for the launch request. */
export function toMessageAttachments(
attachments: FileAttachment[],
): MessageAttachment[] | undefined {
if (attachments.length === 0) return undefined;
return attachments.map((att) =>
att.isImage
? { type: "image" as const, data: att.data, mime_type: att.mimeType }
: {
type: "resource" as const,
data: att.data,
mime_type: att.mimeType,
name: att.fileName,
},
);
}
export function autoSelectBranch(branchList: Branch[], setBranch: (value: string) => void): void {
const lastUsedBranch = getLocalStorage<string | null>(STORAGE_KEYS.LAST_BRANCH, null);
if (
lastUsedBranch &&
branchList.some((b) => {
const displayName = b.type === "remote" && b.remote ? `${b.remote}/${b.name}` : b.name;
return displayName === lastUsedBranch;
})
) {
setBranch(lastUsedBranch);
return;
}
const preferredBranch = selectPreferredBranch(branchList);
if (preferredBranch) setBranch(preferredBranch);
}
export function computePassthroughProfile(
agentProfileId: string,
agentProfiles: AgentProfileOption[],
) {
if (!agentProfileId) return false;
return (
agentProfiles.find((p: AgentProfileOption) => p.id === agentProfileId)?.cli_passthrough === true
);
}
export function computeEffectiveStepId(
selectedWorkflowId: string | null,
workflowId: string | null,
fetchedSteps: StepType[] | null,
defaultStepId: string | null,
) {
return selectedWorkflowId && selectedWorkflowId !== workflowId && fetchedSteps
? (fetchedSteps[0]?.id ?? null)
: defaultStepId;
}
export function computeIsTaskStarted(
isEditMode: boolean,
editingTask?: { state?: Task["state"] } | null,
) {
if (!isEditMode || !editingTask?.state) return false;
return editingTask.state !== "TODO" && editingTask.state !== "CREATED";
}
export type ActivatePlanModeArgs = {
sessionId: string;
taskId: string;
setActiveDocument: AppState["setActiveDocument"];
setPlanMode: AppState["setPlanMode"];
router: ReturnType<typeof useRouter>;
};
export function activatePlanMode({
sessionId,
taskId,
setActiveDocument,
setPlanMode,
router,
}: ActivatePlanModeArgs) {
setActiveDocument(sessionId, { type: "plan", taskId });
setPlanMode(sessionId, true);
useContextFilesStore.getState().addFile(sessionId, { path: "plan:context", name: "Plan" });
router.push(linkToTask(taskId, INTENT_PLAN));
}
export type BuildCreatePayloadArgs = {
workspaceId: string;
effectiveWorkflowId: string;
trimmedTitle: string;
trimmedDescription: string;
repositoriesPayload: CreateTaskParams["repositories"];
agentProfileId: string;
executorId: string;
executorProfileId: string;
withAgent: boolean;
planMode?: boolean;
attachments?: MessageAttachment[];
parentId?: string;
workspacePath?: string;
};
export function buildCreateTaskPayload(args: BuildCreatePayloadArgs): CreateTaskParams {
return {
workspace_id: args.workspaceId,
workflow_id: args.effectiveWorkflowId,
title: args.trimmedTitle,
description: args.trimmedDescription,
repositories: args.repositoriesPayload,
state: args.withAgent ? "IN_PROGRESS" : "CREATED",
start_agent: args.withAgent ? true : undefined,
prepare_session: args.withAgent ? undefined : true,
agent_profile_id: args.agentProfileId || undefined,
executor_id: args.executorId || undefined,
executor_profile_id: args.executorProfileId || undefined,
plan_mode: args.planMode || undefined,
attachments: args.attachments,
parent_id: args.parentId || undefined,
workspace_path: args.workspacePath || undefined,
};
}
export function validateCreateInputs(inputs: {
trimmedTitle: string;
workspaceId: string | null;
effectiveWorkflowId: string | null;
/** Unified repos list. The form is valid if any row has a repo set OR URL mode is filled. */
repositories: TaskRepoRow[];
githubUrl?: string;
agentProfileId: string;
noRepository?: boolean;
}): boolean {
const hasRepo =
inputs.noRepository ||
inputs.repositories.some((r) => r.repositoryId || r.localPath) ||
Boolean(inputs.githubUrl?.trim());
return Boolean(
inputs.trimmedTitle &&
inputs.workspaceId &&
inputs.effectiveWorkflowId &&
inputs.agentProfileId &&
hasRepo,
);
}
/**
* Builds the repositories payload for task creation from the unified list.
*
* - URL mode produces a single entry with `github_url`.
* - Otherwise each row maps to either a workspace `repository_id` or a
* discovered `local_path`. Empty rows are dropped silently so a user
* can leave an unfinished chip without blocking submit; duplicate
* detection happens on the backend.
*/
export function buildRepositoriesPayload(opts: {
useGitHubUrl: boolean;
githubUrl: string;
githubBranch: string;
githubPrHeadBranch: string | null;
repositories: TaskRepoRow[];
/** Used to look up `default_branch` for `localPath` rows. */
discoveredRepositories: LocalRepository[];
/** Workspace repositories — used to look up `default_branch` for `repositoryId` rows. */
workspaceRepositories?: Repository[];
/**
* For the local executor (no worktree), the chip's branch field represents
* the working branch on disk, not the parent integration branch. Send it as
* `checkout_branch` so the session's `base_branch` stays anchored to the
* repo's `default_branch` (which is what git log / cumulative diff use as
* the merge-base reference). Without this, "new branch on local executor"
* collapses the merge-base recomputation to HEAD and the changes panel
* goes empty after a refresh.
*/
isLocalExecutor?: boolean;
/**
* Optional fresh-branch metadata. The UI gates this to single-row + local
* executor; when present we apply it to every row (which is at most one).
*/
freshBranch?: { confirmDiscard: boolean; consentedDirtyFiles: string[] };
}): NonNullable<CreateTaskParams["repositories"]> {
if (opts.useGitHubUrl && opts.githubUrl) {
return [
{
repository_id: "",
base_branch: opts.githubBranch || undefined,
checkout_branch: opts.githubPrHeadBranch || undefined,
github_url: opts.githubUrl.trim(),
},
];
}
const fresh = opts.freshBranch
? {
fresh_branch: true,
confirm_discard: opts.freshBranch.confirmDiscard,
consented_dirty_files: opts.freshBranch.consentedDirtyFiles,
}
: {};
// Fresh-branch flow inverts the chip's semantics: instead of "the working
// branch I'm on", row.branch becomes "the base I want to fork from". The
// backend then creates a new branch and rewrites repos[i].BaseBranch to it.
// Splitting here would force `base_branch=default_branch, checkout_branch=
// <picked-base>` and the backend would fork from the wrong base. Skip the
// split entirely when fresh-branch is active.
const isLocalExecutor = !!opts.isLocalExecutor && !opts.freshBranch;
return opts.repositories
.filter((row) => row.repositoryId || row.localPath)
.map((row) => {
const defaultBranch = resolveRowDefaultBranch(row, opts);
const branches = splitLocalExecutorBranches({
rowBranch: row.branch,
defaultBranch,
isLocalExecutor,
});
if (row.repositoryId) {
return {
repository_id: row.repositoryId,
base_branch: branches.base_branch,
checkout_branch: branches.checkout_branch,
...fresh,
};
}
return {
repository_id: "",
base_branch: branches.base_branch,
checkout_branch: branches.checkout_branch,
local_path: row.localPath,
default_branch: defaultBranch || undefined,
...fresh,
};
});
}
function resolveRowDefaultBranch(
row: TaskRepoRow,
opts: {
discoveredRepositories: LocalRepository[];
workspaceRepositories?: Repository[];
},
): string | undefined {
if (row.repositoryId) {
return opts.workspaceRepositories?.find((r) => r.id === row.repositoryId)?.default_branch;
}
return opts.discoveredRepositories.find((d) => d.path === row.localPath)?.default_branch;
}
/**
* For the local executor: return `base_branch=defaultBranch`,
* `checkout_branch=rowBranch` so the session anchors merge-base to the repo's
* integration branch while the preparer still checks out the user's working
* branch. When `rowBranch === defaultBranch` we omit checkout_branch — the
* preparer treats matching values as "use current state" and skips git ops.
*
* For non-local executors (worktree-based): keep the historical shape where
* `base_branch=rowBranch` (the worktree creates a new branch off of it).
*/
function splitLocalExecutorBranches(args: {
rowBranch?: string;
defaultBranch?: string;
isLocalExecutor: boolean;
}): { base_branch: string | undefined; checkout_branch: string | undefined } {
// Without a known default_branch we can't anchor base_branch to the
// integration ref — and using rowBranch as a stand-in reproduces the
// exact bug this PR fixes (changes panel collapses to HEAD on refresh).
// Fall through to the legacy non-split shape: a workspace repo with an
// unset default_branch is no worse off than before, and the backend's
// resolveRepoInput probe will populate it on the next CreateRepository
// call. Wait for that probe rather than synthesizing a guess here.
if (!args.isLocalExecutor || !args.defaultBranch) {
return { base_branch: args.rowBranch || undefined, checkout_branch: undefined };
}
const base = args.defaultBranch;
const checkout =
args.rowBranch && args.rowBranch !== args.defaultBranch ? args.rowBranch : undefined;
return { base_branch: base, checkout_branch: checkout };
}