Files
kandev/apps/web/components/task-create-dialog-handlers.ts
T
João Salavisa 45a46f9899 feat: support tasks without a repository (#850)
* feat: support tasks without a repository

Lets users create a task with no repository attached — useful for research,
brainstorming, design discussions, or pointing the agent at an existing
non-git folder. The create-task dialog gains a 3-mode segmented control
(Repo / URL / None); "None" mode replaces the chip row with a folder
picker that browses the host filesystem via a new GET /api/v1/fs/list-dir
endpoint and either commits an absolute path or falls back to a kandev-
managed scratch workspace at <homeDir>/tasks/<workspaceID>/<taskID>/.

The worktree executor is hidden from the picker in no-repo mode (it
inherently needs a repo); the lifecycle manager also short-circuits
worktree mode server-side as a belt-and-suspenders guard. The Changes
panel auto-closes for repo-less tasks since it has nothing to show, and
the cumulative-diff handler returns null instead of erroring when no
base commit exists.

Spec + plan added at docs/specs/tasks-without-repositories/.

* fix(backend): anchor folder picker to discovery roots (CodeQL path traversal)

CodeQL flagged the new GET /api/v1/fs/list-dir handler for piping a
user-controlled path straight into os.Stat / os.ReadDir. Restrict the
listing to paths inside the configured discovery roots (defaults to
$HOME, same allowlist as repository discovery), reject anything outside
with ErrPathNotAllowed → HTTP 403, and clip the breadcrumb's "up"
button at the root so the picker can't be used to walk above the
allowed prefix.

Tests cover: rejection of paths outside roots, traversal escapes (../),
default-to-first-root, and parent exposure for nested paths.

* fix(backend): use os.Root for folder picker (recognized CodeQL sanitizer)

Previous attempt anchored to discovery roots via isPathAllowed, but
CodeQL's data flow doesn't model that helper as a sanitizer and kept
flagging os.Stat / os.ReadDir. Switch to os.Root (Go 1.24+): open the
matching discovery root once and run Stat/Open/ReadDir against the
relative path within it. The OS itself enforces containment — symlinks
and traversal cannot escape — and CodeQL recognizes os.Root as safe.

* fix: address PR review feedback

- Changes panel auto-close now distinguishes "task loading" from
  "task has no repos" (returns boolean | null), so the panel isn't
  permanently removed during the first-render window before task
  data lands in the store.
- Reset noRepository / workspacePath in resetDiscoveryState so
  reopening the dialog after a None-mode task doesn't carry the
  flag forward.
- Folder-picker breadcrumb: dropped dead `i > 0 && i > 1` condition
  (always equivalent to `i > 1`); chevrons now render between every
  segment as expected.
- list-dir HTTP handler returns a generic error message instead of
  forwarding raw OS errors that leak host paths.
- Document the dataDir → kandevHome inversion convention next to
  the scratch-path computation so future readers don't mistake the
  filepath.Dir call for a fragile derivation.

* fix: address CodeRabbit review nitpicks

- Trim whitespace on workspace_path before persisting to task metadata
  so a value of "   " doesn't get stored as a non-empty path.
- Extract the workspace_path metadata key into models.MetaKeyWorkspacePath
  alongside the existing MetaKeyAgentProfileID / MetaKeyExecutorProfileID
  so the set/read sites can't drift apart.
- Folder picker: reset cached listing when the popover closes, so
  reopening reloads from `value` instead of showing the last browsed
  directory the user navigated away from without committing.
- Submit payload: send `workspace_path: undefined` instead of an empty
  string when the trimmed value is empty, matching the noRepository=false
  case and keeping the API contract clear.

* fix: scratch path lands in kandev home, not its parent

Claude caught a real bug — `m.dataDir` is set from `cfg.ResolvedHomeDir()`
in cmd/kandev/agents.go, not `ResolvedDataDir()` (the field name is
misleading and the comment was wrong). My previous use of
`filepath.Dir(m.dataDir)` therefore walked one level above the kandev
home, so scratch dirs landed at e.g. `~/tasks/<ws>/<task>` instead of
`~/.kandev/tasks/<ws>/<task>` — and at the project root in dev mode
where `KANDEV_HOME_DIR=<project>/.kandev-dev`, which is what the user
saw on their machine.

Use `m.dataDir` directly (it's already the kandev home), document the
field's misnamed-but-correct semantics, and tighten the test fixtures.

Also:
- folder-picker trigger gets `cursor-pointer` (CodeRabbit nitpick).

* fix: pass workspacePath through handleCreateWithoutAgent too

The "create without agent" path called buildCreateTaskPayload without
the new workspacePath field, so picking a folder + clicking "Create
without starting" silently dropped the path. Now matches the
performCreate (with-agent) path.

* fix: satisfy DialogFormState in new-subtask form stub

PR #852 (merged after this branch was created) introduced
new-subtask-form-state.ts which stubs out a DialogFormState for the
subtask dialog. Adding noRepository / setNoRepository / workspacePath /
setWorkspacePath to the type made that stub incomplete, breaking the
Next.js production build (caught by CI, missed by tsc --noEmit).

Add the four inert fields to the stub, alongside the existing fresh-
branch inert fields, and pull both groups into named constants to
keep the useMemo body under the per-function line cap.

* fix: keep toggle-github-url testid as alias on URL-mode button

The new source-mode segmented control replaced the previous
"or paste a GitHub URL" text link, which had data-testid="toggle-github-url".
The existing e2e suite (create-task-github-url.spec.ts and the new
subtask.spec.ts from #852) still selects the URL toggle by that testid.
Keep "toggle-github-url" as the testid on the URL-mode button so both
suites pass without a sweep across all e2e files. Click semantics are
unchanged — single click enters URL mode.

* test(e2e): update toggle assertion for new source-mode segmented control

create-task-github-url.spec.ts:892 was checking the old text-link
toggle's two-way behavior with text labels ("or paste a GitHub URL" /
"use a workspace repository"). The new segmented control has explicit
mode buttons; assert aria-checked instead of label text. The other 9
clicks on `toggle-github-url` in this file still work via the legacy
testid alias on the URL-mode button.

* refactor: extract useActiveTaskHasRepos to its own hook file

dockview-desktop-layout.tsx grew to 609 lines with the new hook +
the Changes panel guard, over the 600-line cap documented in
CLAUDE.md (lint passed but the convention is real). Move the hook
to hooks/domains/kanban/use-active-task-has-repos.ts. File drops
to 590 lines.

* chore: gitignore .claude/scheduled_tasks.lock runtime file

* fix(web): lock chip-row min-height so modal doesn't shift on mode toggle

The chip row uses flex-wrap; Repo mode (chip + branch + add button +
segmented control) sometimes occupies a different vertical extent than
None mode (single folder picker + segmented control), causing the
create-task modal to jump a few pixels when toggling between sources.
Set min-h-9 so the row always reserves at least one chip-row of
height regardless of the active mode.

* feat: let folder picker browse anywhere, drop allowed-roots gate

The picker is for choosing a starting folder for a repo-less task —
users legitimately want /tmp, /var/log/foo, or any directory they have
read access to. Coupling it to the repo-discover endpoint's
discoveryRoots ($HOME by default) was too tight: paths like /tmp
returned 403 "path is not within allowed roots".

Decouple ListDirectory from discoveryRoots. The repo-discover endpoint
(DiscoverLocalRepositories, ValidateLocalRepositoryPath,
LocalRepositoryStatus, ListBranches) stays anchored to the allowlist
since picking a repo to import is a workspace-scoped operation; the
folder picker trusts the local-process boundary instead.

CodeQL is kept happy by routing the FS operations through os.Root
opened at "/" — the Go stdlib sanitizer for path injection still
recognises it (containment to / is trivially satisfied for every
absolute path on the host).

---------

Co-authored-by: Kandev Agent <agent@kandev.dev>
2026-05-12 01:10:22 +01:00

193 lines
6.1 KiB
TypeScript

"use client";
import { useCallback } from "react";
import type { Repository } from "@/lib/types/http";
import type { DialogFormState, TaskRepoRow } from "@/components/task-create-dialog-types";
import { setLocalStorage } from "@/lib/local-storage";
import { STORAGE_KEYS } from "@/lib/settings/constants";
/**
* Centralizes form-field change handlers for the task-create dialog.
*
* The dialog stores all repos in a single `fs.repositories` list (no
* "primary vs extras" split), so per-row handlers are uniform: changing
* a repo on row N is the same op whether N==0 or N==5.
*
* Fresh-branch (local-executor opt-in: discard local changes and start on
* a new branch) is a separate concern that lives alongside.
*/
function clearFreshBranch(fs: DialogFormState) {
fs.setFreshBranchEnabled(false);
fs.setCurrentLocalBranch("");
// Set loading=true synchronously alongside the clear so the chip's
// autoselect effect (which runs bottom-up before useCurrentLocalBranchEffect
// can re-fire and set loading itself) sees the gate and skips. Otherwise
// the autoselect lands a last-used / preferred-default branch in row.branch
// before currentLocalBranch resolves, then the prefix logic computes
// "will switch to: master" instead of "current: master".
fs.setCurrentLocalBranchLoading(true);
}
function useRepositoryHandlers(fs: DialogFormState, repositories: Repository[]) {
/**
* Resolves a picker value into the right shape for a row:
* - If it matches a workspace repo id → `{ repositoryId, localPath: undefined }`.
* - Otherwise treat as a discovered on-machine path → `{ localPath, repositoryId: undefined }`.
* The branch is reset because the previous branch may not exist on the new repo.
*/
const handleRowRepositoryChange = useCallback(
(key: string, value: string) => {
const isWorkspaceRepo = repositories.some((r: Repository) => r.id === value);
const patch: Partial<TaskRepoRow> = isWorkspaceRepo
? { repositoryId: value, localPath: undefined, branch: "" }
: { repositoryId: undefined, localPath: value, branch: "" };
fs.updateRepository(key, patch);
if (isWorkspaceRepo) setLocalStorage(STORAGE_KEYS.LAST_REPOSITORY_ID, value);
// Switching the repo invalidates whatever local-status the fresh-branch
// panel had cached.
clearFreshBranch(fs);
},
[repositories, fs],
);
const handleRowBranchChange = useCallback(
(key: string, value: string) => {
fs.updateRepository(key, { branch: value });
setLocalStorage(STORAGE_KEYS.LAST_BRANCH, value);
},
[fs],
);
return { handleRowRepositoryChange, handleRowBranchChange };
}
function useProfileAndNameHandlers(fs: DialogFormState) {
const handleAgentProfileChange = useCallback(
(value: string) => {
fs.setAgentProfileId(value);
setLocalStorage(STORAGE_KEYS.LAST_AGENT_PROFILE_ID, value);
},
[fs],
);
const handleExecutorProfileChange = useCallback(
(value: string) => {
fs.setExecutorProfileId(value);
setLocalStorage(STORAGE_KEYS.LAST_EXECUTOR_PROFILE_ID, value);
},
[fs],
);
const handleTaskNameChange = useCallback(
(value: string) => {
fs.setTaskName(value);
fs.setHasTitle(value.trim().length > 0);
},
[fs],
);
const handleGitHubBranchChange = useCallback(
(value: string) => {
fs.setGitHubBranch(value);
setLocalStorage(STORAGE_KEYS.LAST_BRANCH, value);
},
[fs],
);
const handleWorkflowChange = useCallback(
(value: string) => fs.setSelectedWorkflowId(value),
[fs],
);
return {
handleAgentProfileChange,
handleExecutorProfileChange,
handleTaskNameChange,
handleGitHubBranchChange,
handleWorkflowChange,
};
}
function useGitHubAndFreshBranchHandlers(fs: DialogFormState) {
/**
* Toggles between "repo chips" mode and "GitHub URL" mode. URL mode
* replaces the chip row with a single URL input; flipping back restores
* the chip flow with whatever rows were already there.
*/
const handleToggleGitHubUrl = useCallback(() => {
const next = !fs.useGitHubUrl;
fs.setUseGitHubUrl(next);
if (!next) {
fs.setGitHubUrl("");
fs.setGitHubBranches([]);
fs.setGitHubUrlError(null);
fs.setGitHubPrHeadBranch(null);
}
fs.setGitHubBranch("");
clearFreshBranch(fs);
}, [fs]);
const handleToggleFreshBranch = useCallback(
(enabled: boolean) => {
fs.setFreshBranchEnabled(enabled);
// Clearing fs.repositories[].branch on toggle would force a re-pick from
// the per-row branch list; for simplicity leave whatever the user picked.
// The submit path re-validates anyway.
},
[fs],
);
const handleGitHubUrlChange = useCallback(
(value: string) => {
fs.setGitHubUrl(value);
fs.setGitHubBranch("");
fs.setGitHubBranches([]);
fs.setGitHubUrlError(null);
fs.setGitHubPrHeadBranch(null);
},
[fs],
);
/**
* Toggles "no repository" mode. Replaces the chip row with a folder picker.
* Clears the URL-mode state and the workspace_path so flipping back returns
* the user to a clean slate.
*/
const handleToggleNoRepository = useCallback(() => {
const next = !fs.noRepository;
fs.setNoRepository(next);
if (next) {
fs.setUseGitHubUrl(false);
fs.setGitHubUrl("");
fs.setGitHubBranch("");
// Clear the executor selection so the auto-fill effect re-picks a
// non-worktree default (worktree is unworkable in no-repo mode).
fs.setExecutorId("");
fs.setExecutorProfileId("");
} else {
fs.setWorkspacePath("");
}
}, [fs]);
const handleWorkspacePathChange = useCallback(
(value: string) => {
fs.setWorkspacePath(value);
},
[fs],
);
return {
handleToggleGitHubUrl,
handleToggleFreshBranch,
handleGitHubUrlChange,
handleToggleNoRepository,
handleWorkspacePathChange,
};
}
export function useDialogHandlers(fs: DialogFormState, repositories: Repository[]) {
const repo = useRepositoryHandlers(fs, repositories);
const profile = useProfileAndNameHandlers(fs);
const gh = useGitHubAndFreshBranchHandlers(fs);
return {
...repo,
...profile,
...gh,
};
}