2.5 KiB
2.5 KiB
id, title, status, wave, depends_on, plan, spec
| id | title | status | wave | depends_on | plan | spec | |
|---|---|---|---|---|---|---|---|
| 05-integration-settings | Integration settings migration | done | 2 |
|
plan.md | ../../specs/ui/requirements/settings-manual-save.md |
Task 05: Integration Settings Migration
Acceptance
- Page-level integration forms and GitHub scope/preset/query editors use the shared floating action without embedded Save buttons.
- GitHub/Jira/Linear/Sentry watcher enabled toggles are drafts; watcher dialogs, manual runs/resets, and confirmed deletes remain immediate.
- Resetting default queries/action presets stays local until Save.
Verification
cd apps && pnpm --filter @kandev/web test -- --run components/github components/gitlab components/jira components/linear components/sentry components/slack
cd apps/web && pnpm run typecheck
Files Likely Touched
apps/web/components/github/github-settings.tsxapps/web/components/github/github-repo-scope-section.tsxapps/web/components/github/action-presets-section.tsxapps/web/components/github/default-queries-section.tsxapps/web/components/github/review-watch-table.tsxapps/web/components/github/issue-watch-table.tsxapps/web/components/gitlab/gitlab-settings.tsxapps/web/components/jira/jira-settings.tsxapps/web/components/jira/task-presets-section.tsxapps/web/components/jira/jira-issue-watchers-section.tsxapps/web/components/linear/linear-settings.tsxapps/web/components/linear/linear-issue-watchers-section.tsxapps/web/components/sentry/sentry-issue-watchers-section.tsxapps/web/components/slack/slack-settings.tsx
Dependencies
Task 01.
Inputs
- Spec: Settings-wide coverage, Immediate actions, reset scenarios.
- Existing integration form save handlers and watcher dialog boundaries.
Output Contract
Report each migrated form/toggle, retained immediate commands, tests run, files touched, integration-specific risks, and update task/plan status.
Result
- Migrated GitHub, GitLab, Jira, Linear, Sentry, and Slack route-level forms to the shared floating action while retaining overlay-local connection and destructive commands.
- Drafted GitHub action presets/default queries/repository scope, Jira task presets, and GitHub/Jira/Linear/Sentry watcher enabled state until Save.
- Added existing Sentry instance editing to the route coordinator; new-instance creation keeps its explicit form action.
- Verified 363 focused integration tests, web typecheck, scoped ESLint, and affected Playwright scenarios.