Files

T

Carlos Florêncio 4b7ea239d4 fix(web): scope task title previews to Kanban (#2939 )

2026-08-24 19:24:15 +00:00

4.5 KiB

Raw Permalink Blame History

spec, created, status

spec	created	status
docs/specs/tasks/requirements/rich-task-title-previews.md	2026-08-18	complete

Implementation plan: Rich task title previews

Overview

The original implementation added one reusable title preview to the Kanban card, sidebar task row, and rich task list. This follow-up narrows the user-facing scope to Kanban parent cards: the title preview is rendered only when active direct subtasks exist, and the sidebar and rich task list keep their normal title navigation without a popup. Reuse the existing task and contribution stores and keep provider data derivation separate from the shared change-request presentation.

Backend

None. The feature uses existing task and contribution APIs.

Frontend

Preview and task hierarchy

TaskTitleHoverCard owns pointer and keyboard preview behavior. useTaskSubtasks selects direct active subtasks. TaskSubtaskRow owns subtask navigation and prevents its activation from reaching the parent row.

Contribution status

ChangeRequestTaskStatusSummary owns the generic status-summary layout. GitHub and GitLab components derive provider-specific rows and presentation data.

GitLab state

useWorkspaceMRs shares one in-flight workspace request between mounted consumers. It permits later refreshes and clears the workspace after failure.

Scope refinement

apps/web/components/task/task-item.tsx and apps/web/app/tasks/rich-task-list-row.tsx render their existing title content without TaskTitleHoverCard. The shared preview component gates the Kanban trigger on the presence of an active direct subtask, while preserving fine-pointer and coarse-pointer behavior. The separate GitHub PR and GitLab MR badge hovers remain unchanged.

Tests

What: pointer and keyboard preview behavior, subtask limits, and navigation isolation. File: apps/web/components/task/task-title-hover-card.test.tsx. How: component tests with a shared state provider.
What: GitLab state derivation, request sharing, and failed-refresh cleanup. File: apps/web/hooks/domains/gitlab/use-task-mr.test.ts and GitLab summary tests. How: hook and pure-function tests with mocked API responses.
What: provider-neutral status presentation. File: GitHub and GitLab status-summary render tests. How: render tests with provider-specific presentation data.
What: Kanban-only preview scope and childless-card gating. File: apps/web/components/task/task-title-hover-card.test.tsx and apps/web/components/kanban-card-content.test.tsx. How: component tests verify that a parent with active subtasks exposes a trigger, while a childless task does not.

E2E tests

Scenario: A fine pointer opens a preview on a Kanban parent card. File: apps/web/e2e/tests/kanban/task-title-hover-subtasks.spec.ts. What to verify: full title, direct subtasks, child navigation, and no overflow.
Scenario: A coarse pointer opens the task directly. File: apps/web/e2e/tests/kanban/mobile-task-title-hover-subtasks.spec.ts. What to verify: no hover content and task-tree access through the mobile switcher.
Scenario: Non-Kanban task titles do not open the preview. File: apps/web/e2e/tests/task/task-title-hover-surfaces.spec.ts. What to verify: hovering parent titles in /tasks and the AppSidebar leaves task-title-hover-card absent.
Scenario: A childless Kanban card does not open the preview. File: apps/web/e2e/tests/kanban/task-title-hover-subtasks.spec.ts. What to verify: hovering the title leaves the preview absent.

Verification results

Seven focused Vitest files passed: 130 tests.
TypeScript, ESLint, the locale audit, and the i18n ratchet passed.
The desktop Chromium flow passed four tests.
The mobile Chrome flow passed one test.
git diff --check passed.
Follow-up scope refinement: passed. The focused Vitest run passed 22 tests in two files. The managed desktop Chromium run passed five tests, including the Kanban parent preview and no-preview assertions for childless, /tasks, and sidebar surfaces. The managed mobile Chrome run passed one direct-navigation test. Web typecheck and ESLint passed, and git diff --check passed.

4.5 KiB Raw Permalink Blame History