1.6 KiB
1.6 KiB
id, title, status, wave, depends_on, plan, spec
| id | title | status | wave | depends_on | plan | spec | |
|---|---|---|---|---|---|---|---|
| 03-mobile-github-pr-review | Mobile GitHub PR review surface | done | 2 |
|
plan.md | ../../specs/ui/requirements/github-pr-review-actions.md |
Task 03: Mobile GitHub PR review surface
Acceptance
- A phone task with a linked GitHub PR shows Review in bottom navigation and opens the shared GitHub PR detail content.
- Multi-PR tasks use shared PR selection; tasks with no GitHub PR retain the existing GitLab MR Review behavior.
- Surface keeps one scroll owner, safe-area/bottom-nav clearance, touch-sized actions, and no viewport-wide horizontal overflow.
Verification
cd apps
pnpm --filter @kandev/web test -- --run \
components/task/mobile/session-mobile-layout.test.tsx \
hooks/domains/github/use-review-pr-selection.test.ts
Files likely touched
apps/web/components/task/mobile/session-mobile-layout.tsxapps/web/components/task/mobile/session-mobile-layout.test.tsxapps/web/components/review/review-pr-selector.tsx(only if composition needs an existing selector prop/test hook)apps/web/hooks/domains/github/use-review-pr-selection.tsapps/web/hooks/domains/github/use-review-pr-selection.test.ts
Dependencies
Task 02.
Inputs
- Plan mobile design contract.
- Existing GitLab mobile Review implementation in
session-mobile-layout.tsx. - Existing shared
ReviewPRSelectoranduseReviewPRSelection.
Output contract
Report summary, files changed, RED/GREEN/REFACTOR evidence, commands/results,
blockers, risks, and set only this task file's status to done. Do not edit
plan.md.