P33 upstream prep: detach dev-isolated children and fix quoting #89
Assignees
dreampiler (dreampiler)
Clear assignees
dreampiler (dreampiler)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: dreampiler/kandev#89
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Owner goal: move approved portable fork behavior upstream while keeping deployment-specific fork paths out of upstream. Candidate P33, proposal.md row 95: fix(scripts): detach dev-isolated.ps1 children from the caller and fix cmd quoting. Historical fork commits 83eae3dce5 (part of #195), c12a88b596 (#196), c909b590d0 (#198); W079/W080 are closed original work, not new upstream assignment. Reconcile the current upstream scripts and any existing upstream PR coverage first. Port only the generic child-process detachment and cmd quoting behavior; exclude the owner-specific installed-path guard noted in the proposal (including the kandev-kill.ps1 guard) unless source/design proves otherwise. Design pointer: 설계색인.md:55 → docs/windows_support.md; identify any directly applicable card invariant or report that the card has no script-specific entry rather than inventing one. Prepare a minimal upstream-ready change, focused script validation, and independent review. No upstream GitHub write, new PR, ledger/status edit, force push, shared-checkout write, or broad test framework.
P33 upstream-prep complete (no upstream write). Fork branch kd/upstream-p33-portable-scripts-v2 @ 008ef7443 (dreampiler/kandev); base upstream/main@71688b0f1; diff = scripts/dev-isolated.ps1 only. Ported generic child detachment + cmd quoting (+ build stderr from fork #196); fork-specific install-path guard excluded. Verified: PS parse PASS (3 scripts), module load PASS, CI test scripts/tests/isolated-instance.Tests.ps1 PASS; independent review sonnet run 9bd6fa60 confirmed approach and stale-listener guard sound. Remaining: W-091 upstream publication decision; fork PR #316 disposition. Follow-ups: early-exit fast-fail, recursive tree cleanup.
P33 follow-up (task 005795b9) prepared, reviewed, handed off; no upstream write. Local refs in worktree C:\Users\dream.kandev\tasks\p33-crlf-work-order_6z6vgttc\kandev-kd-upstream-p33-portable-scripts-v2: public head kd/upstream-p33-portable-scripts-public @9273a31e68e (1 commit, parent upstream merge-base 2705829f097, clean message); source kd/upstream-p33-portable-scripts-v2 @dcdbd837cae (008ef7443 -> b5f88f408ca -> dcdbd83); preserved kd/upstream-p33-portable-scripts-v2-src-55198a0. Code identical to 008ef7443; docs-only additions: .gitattributes eol=crlf for dev-isolated.ps1, task-02 work order reusing REQ/AC-LAUNCHER-ISOLATED-SCRIPTS-001(.5), plan link, isolated-scripts design sentence corrected (cmd.exe-wrapped Vite, actual listener PID). pr-docs validateCoverage covered; spec lint/doc catalog/commitlint hooks passed; independent review sonnet runs 0a3bc5ab and 5a358a2d: 0 findings. W-091 (5d5cbb5b) acknowledged at 18:32Z. Remaining: W-091 upstream publication of 9273a31e68e.
P33 #4500 review follow-up (task 005795b9) prepared, reviewed, handed off; no upstream write by this task. W-091 normal-FF pushed ad5c660595 (9273a31e68e -> ad5c660) to https://github.com/kdlbs/kandev/pull/4500 and resolved old threads; one bot recheck requested. Fixes in dev-isolated.ps1: check every listener row (backend+web), pass cmd paths via child env so % stays literal, stop discovered Vite/wrapper when web pidfile write fails; docs: plan/design/task-02 corrected, 2x Timeout comment. One-off checks 12/12 OK (temp files deleted); normal hooks passed. Review: default route 8a14f5a5 failed (unparseable, not a pass); pinned-profile run 8f20545d 0 findings (recorded as pinned, not default). Prepared but unpublished: public kd/upstream-p33-portable-scripts-public @9f350da8875 (FF of ad5, comment-only narrowing, to ship with next real fixup); source kd/upstream-p33-portable-scripts-v2 @3d23b0ad6c6. Preserved refs 008ef7443/55198a0/b5f88f4/dcdbd83/2511cd7. Remaining: W-091 bot/CI follow-up on #4500, upstream merge.