[상류 3단계] V1 local Git source collector 독립 준비 #212
Assignees
dreampiler (dreampiler)
Clear assignees
dreampiler (dreampiler)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: dreampiler/kandev#212
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
원 요구·승인
소유자 최신 실행 승인 3단계. feature-pr-map 59행 V1: native utility/review owner 준비, verified profile 실행, explicit local Git source. runtime review/utility 통합은 G2/G3 의존(이 단위 범위 밖). local source UI/API는 resolver 경계가 독립이면 따로 설 수 있다.
원 source (93 source-map 2026-10-29)
6e7d9c26ca66a63e32688aef93505b51b0314368, 현재 production 30f4653e0a259b7bf4641f206a8339ccb7bd97c5(git store D:/260720_Ai_Workspace_Tools/kandev-upstream-native-20261015/.git). 공개 방향 #4814 OPEN, 답 0(task-repository-bound source냐 explicit operator/admin path냐) — 재게시 0.
할 일
자기 Native 새 사본(base 현재 upstream main) → current main·열린 PR(#4740 등)과 동등성 대조(있으면 근거로 끝) → local source collector만 독립 준비. grant framework 추가 0, #4740 범위 확장 0. 기존 test 파일 최소 회귀, 새 commit, normal hooks, 바뀐 delta만 gate rv-run → 첫 결과·검토된 head·영문 PR 초안을 8e/current 96e9d7f4-0840-479a-b7b6-3e18d45b4da4에 각 1회. 결과에 '#4814 방향 대기 몫'과 '독립 준비 몫'을 구분. 공개는 93→5d. push/PR/댓글 0. 운영 변경 0.
KANDEV-UPSTREAM-S3-V1-LOCAL-GIT-SOURCE-20261029 - 독립 준비 결과 (RV APPROVE)
독립 준비 몫(DONE): task-bound local Git source collector를 현재 upstream main base(dc2d77359f1) 위 self-contained로 준비. head d3a82786003712293624132260be5bc41929c9a0, 6 파일 +733, 3 commits.
RV: workflow rv-run 3회 - 1회 REQUEST_CHANGES(.. traversal 미거부) fix f78b6d032a0, 2회 REQUEST_CHANGES(staged-only 누락) fix d3a82786003, 3회 APPROVE verdict_id FORMAL-rv-packet.md-1793263633425819800-36246-mid-1 (reviewer codex-cli-exec-luna6, findings 0, scope 8항목 covered true).
작업 사본 C:\Users\dream.kandev\tasks\kandev-upstream-s3-v_a8nnii56\kandev (branch feature/kandev-upstream-s3-v-gdc, working tree clean). rv-packet _UserHub/_task/kandev-upstream-s3-v1-local-git-source-20261029/rv-packet.md.
#4814 방향 대기 몫(미포함): caller-supplied arbitrary path 공개 API (set_review_source_kandev / run_code_review_kandev worktree_path / ActionTaskReviewSourceSet / review-source MCP 도구군 / saved-source 메타데이터). grant framework 0, #4740 확장 0.
게시/인계: fork 병합 아님. push/PR/댓글 0, 운영 변경 0. 준비 가지 보존, 검토된 로컬 커밋·base/head·영문 PR 초안을 게시 전담/관제에 인계. 공개는 93->5d.
이 단위 독립 준비·검토·인계 완료. flow item 종결 여부는 관제 판단(이 단위는 close-item 호출하지 않음).
8e receiving acceptance: ACCEPT stage-3 V1 task-bound local Git review source unit (task d3c424e3-2fc2-441a-8f64-59e07c84be63, single writer) for publication of its direction-free slice. 8e read-only checks: worktree kandev-upstream-s3-v_a8nnii56 branch feature/kandev-upstream-s3-v-gdc HEAD 2c5224a7f503bad496fb123578022b3447e4f4e5, clean, base upstream main dc2d77359f101fe398255112346b60c617477162, descendant of the earlier reviewed d3a82786003 (5 commits, no amend/force). Diff 10 files: new review/local_git.go, review/local_source.go, backendapp/review_local_source.go, edit agent/handlers/review_change_source.go, tests only in existing review/diff_test.go and backendapp/review_routing_test.go (no new test file), docs/plans/native-code-review-local-source plan.md + task-01, new requirement docs/specs/agents/requirements/native-code-review-local-source.md (REQ-AGENTS-NATIVE-CODE-REVIEW-LOCAL-SOURCE-001, AC .1-.3; the existing native-code-review.md is at the 20480-byte spec size cap), and native-code-review-recovery design mapping. 8e ran upstream pr-docs.cjs validateCoverage: covered, errors 0. Formal RVs: FORMAL-rv-packet.md-1793263633425819800-36246-mid-1 APPROVE (after two REQUEST_CHANGES fixed: path traversal rejection, staged-only changes) and FORMAL-rv-delta-test-docs.md-1793269241556153600-31137-mid-1 APPROVE findings 0 (8e read both). Scope: only the task's own persisted worktree on local executors; no caller-supplied backend path, which stays the #4814 direction-pending slice (not included). Source-reported: focused tests, golangci-lint 0, lint-spec-files and list-docs pass. No push/PR/comment. Publication: 93->5d new narrow PR.
8e publication acceptance: V1 task-bound local Git review source is published upstream as the new narrow PR kdlbs/kandev#4950 'fix(review): read task-bound local git sources when agentctl is unavailable' by sole publisher 5d (2026-10-29T15:02:43Z). 8e gh readback: OPEN, non-draft, MERGEABLE, head 2c5224a7f503bad496fb123578022b3447e4f4e5 = head accepted in artifact-note:20261029T102639287194Z. 5d readback: base main da9ff6332863 (8 commits ahead of source base dc2d77359f10) with a clean merge-tree, so the source head was pushed as is; 10 files +860/-0, only existing test files; review gate BLOCKED; 19 checks observed, 0 failed, 7 in progress; PR documentation coverage PENDING at that read (no pass claim). PR body states tests live in existing diff_test.go / review_routing_test.go, staged-only and parent-directory rejection, and that a caller-supplied arbitrary backend path API is excluded and #4814 is mentioned only as a separate permission question. No PostgreSQL / full CI / E2E pass claim. Maintainer review and merge remain external.
Done — both required corrections are applied, verified, reviewed, and reported.
Result (in response to
8e's 2 required items)New head:
2c5224a7f503bad496fb123578022b3447e4f4e5(basedc2d77359f1), 2 new commits on the same branch (c12cfeec72b,2c5224a7f50), no amend/force. Worktree clean.1) No new standing test files
internal/review/local_source_test.goandinternal/backendapp/review_local_fallback_test.go.internal/review/diff_test.goandinternal/backendapp/review_routing_test.go(minimal cases kept). No production behavior change.2) Docs coverage
docs/plans/native-code-review-local-source/plan.md+task-01-local-source-fallback.md.docs/specs/agents/requirements/native-code-review-local-source.md(REQ-AGENTS-NATIVE-CODE-REVIEW-LOCAL-SOURCE-001with AC .1–.3), mapped in the existingdocs/specs/agents/system-design/native-code-review-recovery.md.native-code-review.mdis at its spec size ceiling (20480 B), so adding a criterion there failslint-spec-files; I used a dedicated requirement document instead.Verification
validateCoverage(base..HEAD): statuscovered, ok true, 0 errors; work ordertask-01-local-source-fallback.md; triggering paths are the 4 production files.lint-spec-files.py --allpass;list-docs.py validatepass (1835 specs); moved cases pass; golangci-lint (changed packages) 0 issues; gofmt/diff clean.FORMAL-rv-delta-test-docs.md-1793269241556153600-31137-mid-1, findings 0, 3/3 scope items covered.Reported to
8eonce, including the corrected PR-draft Validation section (existing files).push/PR/comments 0, ops changes0, prepared branch preserved. The#4814-dependent caller-supplied path API remains out of scope.KANDEV-UPSTREAM-S3-V1-LOCAL-GIT-SOURCE-20261029 - 8e 재진입 #4950 review 5건 수정 결과
새 head 723d41a7dc6c7e3a067c621a661c940a3a3ecd81 (base dc2d77359f1, delta 2c5224a7f50..723d41a7dc6, 6 파일 +272/-38, 3 commits). 작업 사본 branch feature/kandev-upstream-s3-v-gdc 보존(clean).
처분: inline P1 2건(scope identity, live target base anchor) + CodeRabbit 본문 3건(C1 vanished untracked, C2 hunk line count, C3 status vocabulary) 모두 재현/계약 대조 후 수정. ChangedFile.Key()/RepositoryID 보존 유지, 새 test 파일 0.
RV delta APPROVE: FORMAL-rv-delta-review-fixes-r4.md-1793296567458845200-31224-mid-1 (findings 0, scope 5/5 covered).
게시/인계: fork 병합 아님, push/PR/댓글/resolve 0, 운영 변경 0. 준비 가지 보존. 8e 보고는 구현 단계에서 1회 완료(재전송 없음). 공개(5d)와 #4814 방향은 게시 전담/관제 몫. 비차단 제안 3개는 미포함.
이 재진입 결과 기록. flow 종결 여부는 관제 판단(이 단계는 close-item 호출 안 함).
8e 수락(#4950 리뷰 후속): d3c424e3 결과 agent-delivery-e67402e68c0f3e56278e742238b0d8cf. 8e 원본 readback - worktree kandev-upstream-s3-v_a8nnii56 branch feature/kandev-upstream-s3-v-gdc HEAD 723d41a7dc6c clean, 공개 #4950 head 2c5224a7f503에서 FF(merge-base --is-ancestor), 새 commit 3개(a372b9b b0d95f6 723d41a), delta 6 files +272/-38, test는 기존 review_routing_test.go·diff_test.go에만 추가. 8e 재실행 go test ./internal/review ./internal/backendapp(-run Local|Review|Diff|Hunk|Status|Scope) PASS, validateCoverage dc2d773..HEAD covered. RV-RUN-rv-delta-review-fixes-r4.md-1793296567458845200-31224-mid-1 APPROVE findings 0, packet이 head 723d41a7 기재. 처분: inline P1 2건(PRRT_kwDOQ2-eWs6xnXal scope key, PRRT_kwDOQ2-eWs6xnXav base anchor) 수정, CodeRabbit 본문 3건 수정(C1 race는 전용 case 없음 근거). r3 ID prefix 추정은 생산 버그 아님(Key 미변경). 다음: 93->5d 같은 #4950 non-force FF + thread 답글·resolve, public head readback.
8e 게시 readback(#4950 리뷰 후속): 5d가 비강제 FF 2c5224a7f50 -> 723d41a7dc6c 반영. 8e gh readback - #4950 OPEN, head 723d41a7dc6c7e3a067c621a661c940a3a3ecd81, inline thread PRRT_kwDOQ2-eWs6xnXal·PRRT_kwDOQ2-eWs6xnXav 모두 resolved(답글 4416329312, 4416330521), CodeRabbit 본문 3건은 issuecomment-6505037780로 답변(thread 아님). 5d 보고 기준 체크 실패 0·진행 2, docs coverage SUCCESS만 확인(전체 CI green 아님). 병합은 maintainer 리뷰 몫. C1은 코드상 수정됨(93 요약의 '미변경'은 오류, 5d에 정정 회신).
KANDEV-UPSTREAM-S3-V1-LOCAL-GIT-SOURCE-20261029 - #4950 goconst 후속 처분(중복 해소, 게시 없음)
공개 #4950 head가 e20786ab -> 48d7f9877fa42cb6333c08d5d3e0ce065a8fd36c(maintainer Carlos Florencio, 같은 3파일 goconst 수정)로 이동. 우리 로컬 수정 ff8e97321dd(wt/local-git-goconst)는 의미가 중복이라 게시·병합하지 않는다.
로컬 branch wt/local-git-goconst 및 로컬 delta RV APPROVE(FORMAL-rv-delta-goconst.md-1793321181105607100-4858-low-1) 기록 보존. push·추가 commit·amend/force/reset 0.
이 task는 더 할 일 없음. 다음 #4950 후속은 공개 head 48d7f987 위에서 시작. flow 종결 여부는 관제 판단(이 단계는 close-item 호출 안 함).