* fix(agentctl): start per-repo workspace trackers in passthrough mode
CLI passthrough mode starts the agent CLI via the PTY-based
InteractiveRunner instead of agentctl's startAgent / startOneShot, so the
per-repo workspace trackers created for multi-repo task roots were never
started. The bare root tracker exits immediately because it has no git
index, leaving polling completely idle — file edits made by the agent
never produced workspace-stream notifications and the Files panel stayed
stale. Move the tracker startup to instance.Manager.CreateInstance via a
new StartAllWorkspaceTrackers helper so polling fires for every repo
regardless of whether the agent runs via ACP or passthrough.
Fixes#982
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* fix(lifecycle): serialize workspace poll-mode pushes to prevent slow-stuck mode
When a session subscribes and then immediately focuses (the normal page-load
sequence), the workspace poll aggregator used to spawn two independent
goroutines — one pushing slow, one pushing fast — whose HTTP arrival order
at agentctl was undefined. With the slow request landing after the fast
request the tracker ended up in slow mode (~30s polling) while the
aggregator's lastPushed claimed fast, and the suppress-duplicate guard then
blocked any future focus event from reconciling the divergence. Multi-repo
passthrough sessions hit this every page load: the Files panel saw
~30s-stale state even with the per-repo trackers running.
Replace the fire-and-forget goroutine per push with a single in-flight
pusher per workspace plus a last-write-wins pending slot — concurrent
callers all converge on the same pusher, which drains the queue in order
so the final queued mode is what reaches the wire last.
Regression test in manager_subscription_test.go simulates the race with an
httptest server that adds artificial latency on slow pushes; the test
fails on the old parallel-goroutine implementation and passes on the
serialized one.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* fix(agentctl): address PR review feedback for passthrough tracker fix
- Goroutine leak: extract stopWorkspaceTrackers() and call it
unconditionally at the top of Manager.Stop(). Previously the early
return when status==Stopped skipped tracker teardown in passthrough
mode (where Start() never runs), leaking 2 goroutines per per-repo
tracker per stopped instance. stopShellAndProcesses delegates to the
same helper.
- Trim multi-line doc comments to one-liners per CLAUDE.md (the
StartAllWorkspaceTrackers docstring and the CreateInstance call-site
comment).
- Replace the fixed time.Sleep in the race regression test with a poll
on len(calls), exiting as soon as the pusher has drained, plus a
brief settle window after to keep the test sensitive to the late
racing slow push the fix guards against.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* fix(web): refresh expanded subtrees on polling-detected file changes
The agentctl workspace tracker emits a generic `refresh` event with empty
path when its poll cycle detects file changes (it knows something changed
but not which file). The Files panel previously only refreshed the root
folder on these events, so files added under an expanded subdir never
became visible — the merge preserved the stale subtree, and the user had
to manually collapse + re-expand to see new files.
This is the user-visible symptom of #982 (Files panel does not refresh
after agent makes changes in CLI passthrough mode): the backend fixes in
this PR get the events flowing, but the frontend needs to act on them
correctly. On a `refresh` event we now refresh every currently-expanded
folder in addition to the root; for multi-repo task roots we scope to
the affected repo's branch using `repository_name`.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* fix: address iteration-2 review feedback
- Trim doc + inline comment blocks per CLAUDE.md (manager.go,
file-browser-hooks.ts, workspace-files.ts).
- Replace the hand-rolled fmtSscanf/numErr port parser with strconv.Atoi
in the race regression test.
- Assert on slowCalls in the race test to lock in the queue-collapse
guarantee (at most one slow push lands).
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* fix: address iteration-3 review feedback
- Remove redundant stopWorkspaceTrackers call from stopShellAndProcesses
(it's already invoked at the top of Manager.Stop), and drop the now-
misleading "stopping workspace tracker" debug log from the regular
shutdown path.
- Trim three multi-line comment blocks in manager_subscription.go to
one-liners per CLAUDE.md (workspacePushTarget, pushAsync, pushLoop).
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* fix: trim multi-line comment block on pendingPush field
* fix: trim test docstring on race regression test
* fix(web): preserve sibling-repo subtrees on scoped refresh
The setTree reducer ran patchNode(updated) at the root, which re-matched
folderUpdates.has("") and overwrote the already-merged root children with
the raw depth-1 server response — wiping the loaded children of every
top-level repo that wasn't part of the refresh scope.
Recurse over updated.children instead of updated itself: the root has
already been merged in the block above, and each top-level repo either
gets its targeted update (if folderUpdates.has(path)) or is left alone
(preserving its loaded subtree).
Includes a regression test that fails on the old code: a refresh scoped
to "thm" used to discard "kandev"'s loaded README.md child.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* fix(web): trim three more comment blocks to one-liners
* fix: trim five more comment blocks to one-liners
---------
Co-authored-by: Kandev Agent <agent@kandev.dev>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
* fix(web): expand folder optimistically on first click in Files panel
The first click on a folder in the Files panel previously deferred the
expanded-state update until after loadNodeChildren resolved, so the
chevron and children only appeared once the WebSocket round-trip
finished. Users perceived the click as a no-op and had to click again.
Flip the expanded set synchronously, then load children in the
background. Extracts the toggle logic into a testable helper and locks
in the regression with unit tests.
Closes#983
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* docs(web): collapse toggleFolderExpand docstring to a single line
Per the CLAUDE.md "no multi-line comment blocks" rule flagged by review.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* fix(web): dedupe in-flight loadNodeChildren and collapse comment to one line
- Add `activeLoadsRef` + `isLoading(path)` to `useLoadingTimers`, and guard
`loadNodeChildren` against duplicate fetches for the same path. Rapid
double-clicks on a freshly collapsed folder no longer issue two
identical WebSocket round-trips (Greptile P2).
- Collapse the `toggleFolderExpand` comment to a single line per
CLAUDE.md (Claude review).
- Add `file-browser-load-children.test.ts` covering the dedupe contract,
the post-finish re-fetch path, and the children-already-loaded
short-circuit.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---------
Co-authored-by: Kandev Agent <agent@kandev.dev>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Carlos Florêncio