Commit Graph

413 Commits

Author SHA1 Message Date
su be83ab80b1 fix(web): stop vertical scroll on mobile column tabs (#583) 2026-04-14 11:42:25 +01:00
José Almeida 2b8513f902 feat: add multi-select and drag-to-move for file tree and changes panel (#490)
* feat: add multi-select and drag-to-move for file tree and changes panel

Add Shift-click range and Ctrl/Cmd-click toggle selection to the file
tree and staged/unstaged changes sections. Includes bulk actions
(delete, stage, unstage, discard), drag-and-drop file moving into
directories, keyboard shortcuts (Escape, Ctrl+A), and E2E tests.

* fix: move bulk action components to file-row to fix max-lines lint

* style: apply prettier formatting to all changed files

* fix: bulk delete all selected items and update anchor on stale shift-click

* fix: address CodeRabbit review comments

- Keep original file-row-* data-testid for backwards compat
- Remove eager onClearSelection from bulk actions (auto-pruned by hook)
- Variant-scope bulk-discard/bulk-unstage test ids
- Remove index.lock deletion from E2E GitHelper retry loop

* fix: fix E2E tests — create files after session open, remove DnD test

- Create files AFTER opening session so WS detects git status changes
- Add proper git env vars (GIT_AUTHOR_NAME, etc.) matching existing tests
- Use element.press("Escape") instead of page keyboard for proper focus
- Remove drag-to-directory test (Playwright dragTo doesn't support HTML5
  dataTransfer events needed by our DnD implementation)

* fix: rename E2E task titles to avoid ambiguous 'Changes' tab selector

* fix: make file list focusable for Escape key handler in E2E tests

* fix: improve selection styling and ignore right-clicks in selection handler

- Use text-accent-foreground on selected rows for dark mode readability
- Override child span colors with [&_span]:text-accent-foreground
- Use hover:bg-accent/80 instead of hover:bg-muted on selected items
- Skip selection handling on right-click (button === 2) so context menu
  works without clearing multi-selection

* fix: plain click should not select — only Ctrl/Cmd+click and Shift+click

Plain click now clears any selection and performs the original action
(open file / toggle folder / open diff). Selection only happens with
modifier keys. handleClick returns boolean to indicate whether the
click was consumed by selection logic.

* fix: fix multi-select bugs and expand E2E test coverage

Bug fixes:
- Change isSelected from boolean to function prop so children compute
  their own selection state (fixes nested file selection)
- Inline TreeNodeRow JSX into TreeNodeItem so ContextMenuTrigger asChild
  can attach refs directly (fixes right-click context menu)
- Set lastClickedRef on plain click so shift-click has a valid anchor
- Add click-outside handler to clear selection

E2E tests expanded to 14 file-tree tests + 3 changes-panel tests:
- Ctrl-click select, toggle, multi-select
- Plain click clears selection
- Shift-click range after plain click and ctrl-click anchors
- Directory selection and nested file selection
- Right-click context menu (single + bulk delete)
- Click outside clears selection
- Escape clears selection

* fix: move AlertDialog outside ContextMenu to fix delete action

The AlertDialog wrapping the ContextMenu caused Radix focus management
to intercept context menu item selection, making Delete trigger Rename.
Moving AlertDialog to a sibling of ContextMenu fixes the conflict.

* fix: reorder context menu — Delete first, Rename second

Radix ContextMenu auto-focuses the first item on open, which caused
accidental Rename triggers. Putting Delete first (the more common
action for selection) avoids this.

* fix: don't clear selection when clicking context menu or dialog

The click-outside handler was clearing selection when clicking on
context menu items or confirmation dialog buttons (rendered in portals
outside the tree container). Now skips clearing for elements with
role=menu, role=alertdialog, or role=dialog.

Also extended the bulk delete E2E test to verify both files are
actually removed after confirming the dialog.

* fix: hide file count in delete dialog when folder children not loaded

When a folder hasn't been expanded, its children aren't loaded yet so
countFilesInTree returns 0. Instead of showing "0 files", hide the
count entirely and just show "delete <folder name>".

* fix: show confirmation dialog for bulk discard in changes panel

Bulk discard was calling git.discard() directly, bypassing the
confirmation dialog. Now routes through handleBulkDiscardClick which
opens the DiscardDialog with a bulk message ("discard changes to N
files") before executing.

* fix: address remaining CodeRabbit review comments

- Deduplicate filenames on move: when moving files with identical names
  to the same directory, append "(1)", "(2)" etc. to avoid collisions.
  Both tree update and rename API calls use the same deduplication.
- Replace void operator with .catch(() => {}) for bulk stage/unstage
  to prevent unhandled promise rejections.
- Add document-level dragend listener as safety net to clear stuck drag
  state if the element's onDragEnd doesn't fire (Escape, out-of-window).

* test: add unit tests for file tree move deduplication and visible paths

* fix: address all remaining PR review comments

- Move onSelectionChange out of React state updater (side effect fix)
- Stabilize keyboard listener deps (pass callbacks not object)
- Remove unnecessary useMemo in BulkActionBar
- Fix ghost-restore on partial bulk delete (remove all at once)
- Fix blank filename on single-file bulk discard
- Add aria-selected and role=treeitem for accessibility
- Extract computeNextSelection params into object (max-params lint)

* fix: add missing bulk action props to WorkingTreeProps type

WorkingTreeSections referenced onBulkStage, onBulkUnstage, and
onBulkDiscard but WorkingTreeProps Pick didn't include them, causing
a TypeScript build failure.

* fix: address final review comments

- Add unit tests for computeNextSelection (8 tests covering ctrl-click,
  shift-click range, stale anchor, reverse range, shift+ctrl extend)
- Extract shared E2E helpers (GitHelper, makeGitEnv, openTaskSession,
  createStandardProfile) to e2e/helpers/git-helper.ts
- Fix misleading comment in bulk delete (says "re-insert only failed"
  but implementation restores full snapshot)

* fix: use Promise.all for bulk delete to prevent partial rollback

Individual .catch() handlers could restore already-deleted files
if a later delete failed. Now uses Promise.all so rollback only
happens if any delete rejects.

* test: add renderHook tests for useMultiSelect hook behaviors

- Stale-path pruning: items shrink → selected paths auto-pruned
- Plain click: returns false, clears existing selection
- selectAll/clearSelection: work correctly, fire onSelectionChange
- Install @testing-library/react for renderHook support

* fix: handle false returns from onDeleteFile in bulk delete Promise.all

* chore: remove unused @testing-library/react-hooks dependency
2026-04-11 17:43:21 +01:00
Carlos Florêncio 2ae996a2c1 fix(agentctl): register MCP tools with _kandev suffix to match sysprompt (#572) 2026-04-10 17:17:42 +01:00
José Almeida 2872d072cb fix(web): recalculate dockview layout after fast-path session switch (#571)
* fix(web): recalculate dockview layout after fast-path session switch

The fast path in tryFastSessionSwitch removed ephemeral panels but
never called api.layout() to redistribute column widths, leaving a
gap on the right side of the screen. Both slow-path branches already
make this call.

* test(web): add regression test for fast-path layout call

Verifies that performSessionSwitch calls api.layout() on both the
fast path and slow path, preventing the squished-layout regression.

* test(web): cover saved-layout fast path branch

* fix(web): replace no-explicit-any cast in test

* fix(web): fix test isolation with mockReturnValueOnce

Use mockReturnValueOnce and clearAllMocks for proper test isolation
between fast-path and slow-path test cases.

* test(web): fix mock shape to match LayoutGroupIds type
2026-04-09 23:07:49 +01:00
Carlos Florêncio 7ad7736e07 fix: move frontend off port 3000 and silence reverse-proxy panic logs (#568) 2026-04-09 18:50:43 +01:00
Carlos Florêncio ebefac814a docs: enforce test requirements and improve agent skill resilience (#543) 2026-04-09 16:27:19 +01:00
Carlos Florêncio d8ce686f4e fix(web): make PR Approve button look clickable (#567) 2026-04-09 16:16:13 +01:00
Carlos Florêncio 5ff930c6e0 fix(web): keep file tree and terminal waiting through long prepare (#564) 2026-04-09 12:49:47 +01:00
José Almeida afed5a8f85 fix(web): stop discarding branch selection for local executor (#558)
Commit 348ee25e disabled the branch selector for local executors and
also blanked the branch value at submit time. This caused the backend
to fall back to Repository.DefaultBranch, which may contain whatever
branch was checked out at repo discovery time rather than "main".

Keep the selector disabled (cosmetic) but send the auto-selected
branch value so the backend uses the correct base branch.
2026-04-08 20:23:46 +01:00
Carlos Florêncio a8092fd0a9 fix(web): sort nested file tree folders before files (#562) 2026-04-08 19:41:07 +01:00
Carlos Florêncio 2c222a8e7a fix(web): scroll dropdown selectors inside dialogs (#559) 2026-04-08 18:46:31 +01:00
Carlos Florêncio 41b405c64f fix(backend): prevent task reorder during silent session resume (#555) 2026-04-08 07:55:24 +01:00
Carlos Florêncio 73e6ef64b4 fix(orchestrator): persist live git status snapshot for sidebar diff badges (#556) 2026-04-07 23:06:39 +01:00
Carlos Florêncio 61e5d5cce9 feat(web): redesign task sidebar with repo-grouped layout and diff stats (#550) 2026-04-07 09:12:17 +01:00
Carlos Florêncio 03c164d6cd fix: handle file paths with spaces in git status and diff parsing (#552) 2026-04-06 19:25:26 +01:00
Carlos Florêncio a44489640b fix: changed branch and auto focus changes panel (#549) 2026-04-06 18:59:37 +01:00
Carlos Florêncio 52d6f7e9bf fix(web): persist PR panel dismissal across page refreshes (#547) 2026-04-06 13:52:53 +01:00
Carlos Florêncio 6d81734c66 fix(web): reset stale topbar branch when navigating between tasks (#546) 2026-04-06 12:52:42 +01:00
Carlos Florêncio f9ca582036 fix: compare ahead/behind counts against base branch instead of remote tracking branch (#544) 2026-04-06 09:51:58 +01:00
Carlos Florêncio e3f83173cf fix(web): open embedded VS Code in center group instead of right sidebar (#545) 2026-04-06 09:48:17 +01:00
Carlos Florêncio a704f4baca fix: add paragraph spacing to markdown body for visible line breaks (#540) 2026-04-06 09:01:09 +01:00
José Almeida 8e50fe90e9 feat(web): right-click context menu to move sidebar tasks between steps (#492)
* feat(web): add right-click context menu to move sidebar tasks between workflow steps

* fix: scope Move to submenu to task's own workflow steps

* fix: surgical rollback and disable actions during delete

* fix: wrap TaskItem in div for ContextMenuTrigger asChild ref forwarding

* refactor: unify right-click and 3-dot menus into single context menu

- Delete task-item-menu.tsx (DropdownMenu) — no longer needed
- TaskItem's 3-dot button now dispatches contextmenu event to trigger
  the wrapping ContextMenu
- TaskItemWithContextMenu tracks open state and passes menuOpen to
  TaskItem for hover visibility
- Add Duplicate item to the context menu
- Fix step color dots using block display

* fix: use Tailwind class for step color dots instead of inline style

* fix: disable Duplicate menu item until handler is implemented

* fix: defer move-to-step to let context menu close before optimistic update

* fix: defer move-to-step to let context menu close before optimistic update
2026-04-06 00:57:01 +01:00
Carlos Florêncio 8c6f16337d fix(acp): suppress stale events during session resume history replay (#527) 2026-04-03 15:15:02 +01:00
Carlos Florêncio 82eb59d91e fix: disable plan mode when moving to next workflow step (#525) 2026-04-03 15:07:46 +01:00
Carlos Florêncio 4c0c9a7fb0 fix: stabilize git operation callbacks to fix staging first-click bug (#535) 2026-04-03 15:03:59 +01:00
Carlos Florêncio 12310e12ba fix: show Push button when task has open PR and unpushed commits (#537) 2026-04-03 15:03:05 +01:00
Carlos Florêncio 7e97e07c2d fix: guard against missing referencePanel in dockview focusOrAddPanel (#538) 2026-04-03 15:02:40 +01:00
Carlos Florêncio 75aad972a7 fix: increment CI checks elapsed time for in-progress runs in PR panel (#529) 2026-04-03 14:29:02 +01:00
Carlos Florêncio 2238ef0825 feat: prioritize local changes above PR files in changes panel (#528) 2026-04-03 14:28:28 +01:00
Carlos Florêncio dbe778e4e8 feat: auto-show PR details panel when task has associated PR (#517) 2026-04-02 00:08:35 +01:00
Carlos Florêncio 1c6506911e feat: add workflow sorting with drag-and-drop reordering (#520) 2026-04-01 23:58:43 +01:00
Carlos Florêncio beb42acc29 feat: expose hidden keybindings in settings for user customization (#521) 2026-04-01 23:29:49 +01:00
Carlos Florêncio 0080ec9658 fix(kanban): clear stale activeSessionId when switching tasks (#523) 2026-04-01 23:23:54 +01:00
Carlos Florêncio 1587203c2e fix(web): add max-height and scrollbar to queue message editor textarea (#519) 2026-04-01 23:03:20 +01:00
Carlos Florêncio 6fea6277a8 fix: hide start agent button during preparation and fix auto-start race condition on step move (#516) 2026-04-01 23:00:05 +01:00
Carlos Florêncio 348ee25e6f feat: disable branch selector for local executor and implement base branch checkout (#515) 2026-04-01 22:55:02 +01:00
Carlos Florêncio 5fb1c12364 fix: stabilize diff viewer fileRefs to prevent auto-scroll on background updates (#513) 2026-04-01 22:53:47 +01:00
dependabot[bot] 533d697474 chore: bump happy-dom from 20.8.8 to 20.8.9 in /apps in the npm_and_yarn group across 1 directory (#495) 2026-03-31 23:51:04 +01:00
Carlos Florêncio f4723ebcae feat: sort tasks by creation date in kanban and sidebar (#511) 2026-03-31 23:31:18 +01:00
Carlos Florêncio c732675f33 fix(github): workspace-scoped PR data loading with cache and singleflight (#509) 2026-03-31 22:56:09 +01:00
Carlos Florêncio 447da7edb2 fix: re-inject plan mode instructions on follow-up prompts (#507) 2026-03-31 22:43:22 +01:00
Carlos Florêncio b832390914 fix: preserve task status when resuming agent after backend restart (#508) 2026-03-31 22:37:31 +01:00
Carlos Florêncio 1cd3a6b800 feat(web): rename sidebar sections to "Turn Finished" and "Running" (#506) 2026-03-31 21:01:51 +01:00
Carlos Florêncio c0b801a45a fix(github): break infinite PR sync loop and improve diff panel targeting (#503) 2026-03-31 00:25:51 +01:00
Carlos Florêncio c56dfe8537 feat(github): move PR monitoring to backend with lightweight polling (#502) 2026-03-30 23:26:01 +01:00
Carlos Florêncio 59ee830d71 feat(web): unified commit list and dockview panel fix (#500) 2026-03-30 22:44:10 +01:00
Carlos Florêncio 54b8d2939b fix(web): invalidate diff expansion cache when file changes (#501) 2026-03-30 21:17:49 +01:00
Carlos Florêncio be1b3a41db refactor(web): reorganize E2E tests into feature-based subdirectories (#499) 2026-03-30 14:34:24 +01:00
Carlos Florêncio db816d4222 fix(web): deduplicate agent and session tabs in task view (#496) 2026-03-30 12:19:55 +01:00
Carlos Florêncio 81341263fd feat(terminal): fix bottom padding and add font family setting (#489) 2026-03-29 22:27:37 +01:00