102 Commits

Author	SHA1	Message	Date
José Almeida	b001aa1eb8	feat(web): unified app sidebar (#1165) ... * feat(web): introduce unified AppSidebar and retire legacy nav surfaces Mounts a single collapsible AppSidebar at the root layout that replaces the former WorkspaceRail, OfficeSidebar, and dockview-embedded sidebar pane. Wires per-section expand + collapse state through a new UI slice with localStorage persistence, ports projects/agents/settings/tasks sections, and trims integrations / quick-chat / settings buttons + the home breadcrumb from the dockview top bar (debug-only MoreToolsMenu kept). Strips the sidebar column from every preset and the panel registry; persisted sidebar panels are dropped by the existing sanitize layer at restore time. * test(web): point workflow-filter e2e at AppSidebar's Home link The dockview top bar no longer renders the IconHome breadcrumb after the unified sidebar landed — the home navigation now lives in AppSidebar's primary nav. Update the workflow-filter spec to click that link instead. * feat(web): wire app-sidebar primary controls, nested settings, and footer migration Gates office-only nav (Inbox, Agents, Projects, New Task) behind the office feature flag, renames Tasks → Kanban as the bottom flex-grow section, replaces the gradient workspace picker with a minimal trigger when office is off, and moves Stats/Improve/What's-New/Office out of the kanban top bar into the AppSidebar footer + a dedicated Integrations section. Expands Settings into a collapsible deep tree mirroring the old SettingsAppSidebar so /settings pages can drop their nested SidebarProvider. * feat(web): make app-sidebar resizable and inline task top bar actions Adds a persistent drag-resize handle on the AppSidebar's right edge that clamps between APP_SIDEBAR_EXPANDED_WIDTH and 30vw; width is stored on the appSidebar slice and persisted to localStorage. Drops the dockview top bar's overflow popover (TopbarActionOverflow) in favor of always-inline clusters, and replaces the debug "More tools" dropdown with a single debug toggle button. * feat(web): polish app-sidebar headers and consolidate task views Section headers now lead with a clean uppercase label, drop the mono clash, lift contrast from /60 to /70, and end with the collapse chevron at the right so the section body aligns flush under the label. The Tasks section's filter bar (view chips + gear in a card-tinted strip) is replaced by a compact view dropdown that lives in the section header. Drag-to-reorder lives in the existing filter popover, which is now reachable from the same gear button. Settings moves below Tasks so the kanban list keeps the flex-grow seat in the sidebar. * feat(web): move settings group chevrons to the right * fix(web): drop chat from home topbar; calm tasks group headers The kanban top bar's Quick Chat button is removed now that Quick Chat lives in the AppSidebar; workspaceId stops being threaded into the tablet and desktop header variants. Group headers inside the Tasks section (kanban workflow steps) lose the opaque background strip and the section-label uppercase styling so they read as inline subgroup rows, not duplicate section dividers. The tasks-section wrapper drops its negative margin so the group rows sit flush under the TASKS label instead of bleeding out past it. * fix(web): restore agent logos on settings tree profile leaves SettingsLeaf gains a leadingIcon slot for pre-rendered visuals; agents group passes <AgentLogo agentName={agent.name}> so each profile row shows its agent's logo like it did before the old SettingsAppSidebar was retired. * feat(web): brand the sidebar, move New Task off the kanban top bar The Add task button (CreateTaskTopbarButton) leaves both the desktop and tablet kanban headers; New Task is now an unconditional primary nav item on the AppSidebar, falling back to a disabled affordance when no workspace is active. AppSidebar header gains a Kandev wordmark that links to /, with a single-letter K mark in collapsed-rail mode. PageTopbar's root variant no longer renders the parent brand label when backLabel is empty, so the home view's top-left "Kandev" goes away in favor of the sidebar. * feat(web): unbind sidebar toggle by default; drop Home from breadcrumbs TOGGLE_SIDEBAR's configurable default is now UNBOUND_SHORTCUT (the new sentinel for "no binding"); matchesShortcut already returns false on an empty key, so the keybind hook needs no change. Keyboard shortcuts settings show "Unbound", expose a Clear (X) button when a custom binding is set, and the reset icon falls back to unbound for entries whose default is unbound. PageTopbar's breadcrumb variant no longer prepends the Home back-link when backHref is "/" (the AppSidebar provides Home navigation). * feat(web): move New Task into the sidebar, retire the workspace selector - Extract AppSidebarNewTaskItem (office vs regular create dialog) with tests - Drop the Workspace selector from the kanban display dropdown and mobile menu sheet; the sidebar workspace picker is now the sole switcher - Factor SectionHeader out of AppSidebarSection; animate fixed sections via Collapsible while the grow (Tasks) section stays flex-driven - Polish brand header, share SIDEBAR_ITEM_ACTIVE accent-bar classes, move task group chevrons to the right, drop the task-item selected fill - Bump dockview layout keys to v3 and filter the orphaned 'sidebar' column so pre-AppSidebar default layouts no longer render a broken grid - Point the cross-workspace isolation e2e at the sidebar picker * feat(web): sidebar settings mode, subtask shortcut, accordion settings nav - Restore subtask creation: the sidebar New Task row now shows a trailing subtask affordance when viewing a task (regular mode), reopening the NewSubtaskDialog the retired dockview header dropdown used to provide - Fix settings pages not scrolling: scroll the content region (topbar stays pinned) via min-h-0 + overflow-y-auto - Add a footer gear that toggles a settings-only sidebar takeover; the gear spins on toggle. Mode is transient (never persisted) and force-expands a collapsed rail on entry - Make the settings nav a single-open accordion: opening one top-level group closes the others and reveals its subsections; route changes re-sync the open group. Extract the tree into a reusable SettingsTree - Repoint subtask e2e specs at the new sidebar affordance * test(web): restore create-task e2e flow after New Task moved to sidebar The New Task relocation removed the kanban-header create-task-button and made the sidebar entry auto-navigate + open the office dialog under the e2e profile (office on), breaking ~20 specs that drive the regular task-create dialog. - Give the sidebar New Task the create-task-button testid so KanbanPage resolves it again - Drop the post-create auto-navigation so creating a task stays on the board (matches the retired kanban button; specs find/click the new card) - Ungate the subtask affordance from office mode (subtasks use the compact NewSubtaskDialog in both modes, as the old dropdown did) - Add a useRegularMode() helper that runs a spec file with KANDEV_FEATURES_OFFICE disabled (backend.restart bracket) and apply it to the 18 create-task specs - Point the System sidebar-navigation spec at a /settings/system page so the single-open settings accordion has that group expanded Validated: create-task, create-task-disabled-tooltip, create-task-branch-selector, and subtask all green (modulo pre-existing idleInput agent-timing flakes that CI retries absorb). * fix(web): sidebar task navigation, settings-mode close + transitions - Clicking a task in the global sidebar from a non-task page now navigates to the task route (mounts the dockview) instead of only rewriting the URL via an in-place layout switch that assumed the dockview was already mounted - Make the settings-mode 'Settings' header a close affordance (the footer gear is far from the tree); clicking it exits the takeover regardless of which group is expanded, and it fades in when opened - Fade in the Tasks (grow) section content on expand, matching the other sections' animated reveal - Enable next-themes disableTransitionOnChange so dark/light flips switch every surface in the same instant rather than each animating at its own duration - Add a regression e2e for sidebar→dockview navigation * fix(web): clear sidebar task highlight when off the task route The AppSidebar is global, so tasks.activeTaskId lingered after navigating Home, leaving the last-opened task visually selected in the sidebar. Gate the selected/active highlight by route — only highlight while on /t/ or /office/tasks/. Expose data-active on the sidebar task item for testability. Adds an e2e: entering a task highlights it; returning Home clears it. * fix(web): never build the dockview default layout at zero width On a fresh client-side navigation into a task the dockview can mount before the grid has painted, so measureDockviewContainer returned api.width/height = 0. Building the default layout at width 0 makes dockview collapse the horizontal columns into a vertical stack (chat / files+changes / terminal) instead of the intended side-by-side layout. Fall back to the viewport when neither the live container nor the api report a usable size; the resize observer then snaps the grid to the exact container size. TDD: dockview-measure.test.ts covers the zero-size fallback. * fix(web): keep the default layout horizontal when swapping chat for the session tab Entering a task rendered a vertical stack (chat on top, files/changes in the middle, terminal at the bottom) instead of the side-by-side default. The chat->session-tab swap removed the 'chat' placeholder BEFORE adding the session panel; when chat was the only panel in the center group, removing it destroyed that group, the stored centerGroupId went stale, resolveInitialPosition returned undefined, and the session panel was appended as a new row — flipping the grid root to VERTICAL with three stacked groups. Fix: add the session panel into chat's live group first (resolveInitialPosition now prefers the chat panel's group), THEN remove the chat placeholder, so the center group never empties and the horizontal split is preserved. Also fixes the pre-existing pane-resize reload/clamp e2e failures, which were the same collapse. TDD: task-default-layout.spec.ts asserts the right column sits beside chat. * fix(web): remove the sidebar Settings section; settings is gear-only Settings was still a collapsible nav section in the sidebar AND auto-expanded on /settings routes. That also caused the reported bug: toggling the footer gear off while on a settings page revealed the normal sidebar with the Settings section already expanded, so the settings tree appeared to 'not close'. - Drop the Settings nav section (and its /settings route auto-expand) — the settings tree is reached only via the footer gear takeover - Delete the now-unused sidebar settings-section component - e2e: gear opens the tree and closes it even after navigating into a section * fix(web): show office sidebar sections only while inside Office Inbox, Projects, and Agents were gated on the office feature flag, so they were always visible when the feature was enabled. Gate them on actually being in the Office surface (an /office route, reached via the footer Office button) via a new useInOffice() hook — they stay hidden in the regular workspace and appear only after entering Office. Unit test for the hook; e2e (office fixture) asserts the sections appear on /office and are absent on the regular home. * fix(web): drop the colorful workspace selector, restore the minimal one The workspace picker swapped to a gradient/initials trigger (and gradient swatches in the dropdown) whenever office was enabled. Always use the plain name + chevron trigger and drop the gradient swatches, matching the previous design. Removes the now-unused workspace-gradient helper. * fix(web): align sidebar header, scope office New Task, exit settings on nav - Drop the doubled right border: the resize-handle hairline is transparent at rest, leaving the aside's border-r as the single edge (highlights on hover). - Collapse the expanded sidebar header into one h-10 row (brand · workspace picker · collapse) so it lines up with the page/dockview top bar. - Gate the sidebar New Task dialog on useInOffice() (actual /office route) instead of the bare office feature flag, so Kanban mode keeps the classic create dialog while office is enabled. - Close the settings takeover when navigating off the /settings surface (Home, Kandev brand, Office, etc.), tracked on a real pathname change so the gear still opens it in place and in-tree navigation keeps it open. - Lock in the already-working collapsed-gear-expands behaviour with an e2e. Tests: new-task-item unit (route gating), settings-gear e2e (Home closes, collapsed gear expands), office gating e2e (Kanban vs Office dialog). * fix(web): realign task top bar to h-10, refine sidebar workspace picker - Pin TaskTopBar to h-10 so its bottom border lines up exactly with the sidebar header (and the PageTopbar) — previously it had no fixed height and sat ~2px off, breaking the seam across the sidebar/content edge. - Redesign the workspace picker as a compact, muted secondary control inlined after the Kandev brand: brand and workspace share text-sm so they sit on a common baseline, with a faint '/' separator; the workspace reads as muted and the brand stays primary. - Drop the workspace switcher (and its irrelevant folder glyph) from the collapsed rail — collapsed now shows just brand + expand. Adds an e2e that measures the task top bar bottom edge against the sidebar header (within 1px). * fix(web): replace the /github and /gitlab presets rail with a scope bar The integration dashboards rendered their own w-60 border-r presets sidebar right next to the global AppSidebar — a redundant 'double sidebar' that looked off after the UI overhaul unified navigation. On desktop, fold the presets into a horizontal scope bar above the list toolbar: the bounded, common controls (PR/Issue kind + preset pills, grouped Inbox/Created) stay visible as pills, while the unbounded saved-queries list collapses into a 'Saved' dropdown so the bar never grows tall. The dashboard is now single-column like Kanban/Tasks. Mobile is unchanged — the vertical PresetsSidebar still lives in the hamburger sheet. Adds a desktop scope-bar e2e (presets + kind switching, no inline rail) and repoints the mobile page object at the new scope-bar testid. * fix(web): address CodeRabbit/cubic review — a11y, dedup, dup nav, lazy-load - Sidebar: fix Tasks auto-expand route prefix (/task/ -> /t/); forwardRef the workspace-picker trigger so DropdownMenuTrigger asChild wires it; aria-label the icon-only Add agent and keyboard-shortcut buttons. - Settings tree: drop the duplicate top-level Editors leaf (lives under General); broaden the System group active state to all /settings/system. - CSS: honour prefers-reduced-motion for .sidebar-fade-in. - Storage: bump the dockview maximize namespace to v3 in lockstep with the layout namespace so stale pre-v3 maximize blobs are discarded. - Integration dashboards: extract a shared IntegrationScopeBar base so the github/gitlab scope bars are thin wrappers (de-dup + under the component size cap). Reuse useConfiguredIntegrationLinks in the sidebar Integrations section instead of recomputing availability. - Lazy-load the office NewTaskDialog so it's not bundled on non-office routes. - tasks-view-picker: use onSelect for keyboard-activatable menu items. - Tests: normalize group x by container left in task-default-layout; refresh stale subtask-flow comments; async findByTestId for the lazy office dialog. * fix(web): gate the scope-bar delete button pointer-events while hidden The opacity-0 delete button stayed clickable, so a click on the right side of a saved-query row could hit the invisible button instead of selecting the query. Add pointer-events-none until the row is hovered (group-hover:pointer-events-auto). * fix(web): use onSelect for scope-bar saved-query menu items (keyboard a11y) Radix DropdownMenuItem fires onSelect for pointer AND keyboard activation; onClick missed keyboard users. The nested delete button stops pointerdown so it isn't treated as a select of the saved query. * fix(web): mobile sidebar hide, gear-gated settings test, office paused badge, picker a11y - AppSidebar is now hidden below md (mobile uses its own per-surface nav); it was an always-on absolute overlay covering mobile content. - Restore the sidebar-agent-paused-badge testid on the office agent row. - Update system sidebar-navigation spec to open the gear (settings is a gear-gated takeover in the overhaul). - Workspace picker menu items use onSelect for keyboard a11y. * test(web): reconcile main's E2E suite with the unified-sidebar overhaul Merging main un-gated the full E2E suite (was behind safe-to-test); ~50 of main's tests asserted pre-overhaul UI. Updated them to the overhaul: - Delete obsolete dockview-embedded-sidebar resize tests (feature removed); keep the right-pane resize tests. - Scope locators where tasks now appear in BOTH the page and the global AppSidebar list (intended) — task-list, task-list-filters, pr-status-badge. - Adapt sidebar-filter specs to the new TasksViewPicker (gear popover + view-chip dropdown) and its page object. - Settings now reached via the footer gear (not the topbar); Improve Kandev opens from the sidebar footer; office nav folded into the AppSidebar — update those specs (office verified in CI; can't run locally). - session-layout: handle the new close-terminal confirm dialog; multi-session and tab-management: foreground the (now backgrounded) chat tab after sidebar task switches. - Skip create-task-url-reopen-no-branches: its provider-branch flow (code identical to main) is broken only by the office-off backend restart this PR forces via useRegularMode — a harness interaction, not an app regression. * test(web): fix create-task-url-reopen branch listing (reload to drop stale cache) Un-skipped and fixed properly. Root cause: during the URL-paste/registration flow the frontend can transiently fetch branches for the freshly-registered provider repo before its background clone settles; useBranches caches that early empty result as terminal (if (isLoaded) return), so re-picking the repo never re-lists. Reload before the second dialog open drops the in-memory branch cache so branches list fresh from the backend (verified: the backend returns them). The provider-API path and product behaviour are unchanged from main. * fix(web): restore mobile search toggle + reconcile remaining E2E with overhaul - Restore main's mobile-search-toggle in kanban-header-mobile (my earlier --ours merge resolution dropped it, breaking the mobile-kanban search tests). - Office specs: expand the collapsed Agents/Projects sections before asserting their rows, and scope office-tasks-page locators to <main>. [CI-verified] - mobile-task-list-search / mobile-voice-mode: scope task titles to the table and drop the obsolete data-sidebar=trigger assertion. - app-sidebar.test mock: add settingsMode, toggleAppSidebarSettingsMode, and the integrations section key. - sidebar-filter page object: scope chipMenu to the menu holding the view chips. * test(web): finish E2E reconciliation — office sections, session timing, robustness - agent-error-handling: expand the collapsed Agents section before the paused badge check. - office execution-indicator/task-sorting: wait for a non-empty .font-mono identifier (assigned async by the backend). - session-layout: foreground the (CI-backgrounded) chat tab before the idle check; make the close-terminal confirm dialog optional (busy heuristic is timing-dependent). - workspace-switch-isolation: run office-off so the picker switches in place instead of redirecting to /office (which needs onboarding this fixture skips). - app-sidebar-page: condense JSDoc to one line per project convention. * test(web): match main's office identifier assertion (revert over-scoping) The round-2 office agent scoped the .font-mono identifier check to <main> too, but only the task TITLE needed scoping for the sidebar duplication. The office task identifier is empty in the e2e seed (backend-assigned, not populated here), so the <main>-scoped non-empty filter found nothing. Revert the identifier assertion to main's exact form (first .font-mono on the page); keep the title scoped to <main>. * test(web): restore non-empty .font-mono filter for office identifier checks Per review: wait for the backend-assigned (non-empty) identifier rather than the empty span. Unscoped so it finds the identifier wherever it renders, 15s window. * test(web): fix office identifier + realtime-dashboard specs at the root cause Ran office specs locally (they DO run here) and root-caused all three: - execution-indicator / task-sorting: the office task identifier is empty in e2e — tasks are seeded via the core /api/v1/tasks route, which bypasses the office identifier-assignment flow (the workspace KAN prefix only applies to office-flow-created tasks). Main's .font-mono.first() was a false-positive matching an element the overhaul removed. Assert the identifier COLUMN renders (attached to the row) instead of a value e2e never produces. - realtime-dashboard: the Recent Tasks card is fed by dashboard.recent_tasks via useOfficeRefetch on office WS events; a core-route task's office event is async so the in-place refetch is genuinely flaky. Reload for the deterministic SSR dashboard fetch (what a user sees on revisit); the WS-refetch mechanism stays covered by the sibling cross-workspace test.	2026-06-06 21:58:39 +01:00
João Salavisa	dfaab11959	feat: full GitLab integration — parity with GitHub (#1120) ... * feat(backend): full GitLab parity — store, service, poller, WS, presets Add the watcher/poll/write-action surface on top of the existing GitLab client + service skeleton: * 5 new SQLite tables (mr_watches, review_watches, review_mr_tasks, issue_watches, issue_watch_tasks, action_presets) + CRUD * Client + Service: MergeMR, GetProjectMergeMethods, GetProtectedBranch, ListUserProjects, SearchProjects, SetMRLabels, SetMRAssignees * Service: review/issue/MR watch CRUD + Check/Trigger, GetStats, CleanupAllReview/IssueTasks (cleanup-policy aware), TriggerMRSync, action-presets CRUD with defaults * Background poller (MR / review / issue loops) wired from main.go * ~35 GitLab WS action constants + handlers.go registrations * Mock controller for E2E seeding (MRs, issues, pipelines, discussions, approvals, branches) * eventBus + taskDeleter + taskSessionChecker plumbed through Service * Event types: GitLabMRFeedback / NewReviewMR / NewIssue / TaskMRUpdated * feat(web): GitLab frontend parity — types, API, store slice, domain hooks Extend the frontend GitLab integration on top of the new backend surface: * HTTP API client expansion (gitlab-api.ts): full CRUD for review/issue/MR watches, MR write actions (merge/approve/labels/assignees), MR files/commits/feedback, action presets, projects autocomplete, stats * Store slice expansion: review/issue/MR watches lists, action presets by workspace, stats + status with loading flags. Properties prefixed with gitlab to avoid collision with GitHub slice * Domain hooks: use-gitlab-status, use-gitlab-stats, use-gitlab-review-watches, use-gitlab-issue-watches, use-gitlab-action-presets — mirror github hook shapes * Type model: ReviewWatch, IssueWatch, MRWatch, ActionPresets, Stats, ProjectMergeMethods, MRApproval, Pipeline, MRFeedback, etc. * Backend controller HTTP routes for watches/presets/write-actions/ projects/stats so the frontend HTTP API client has endpoints to hit All passes: backend (build + vet + lint + tests), web (typecheck + lint + 2400 tests). * fix(gitlab): wire orchestrator event handlers, fix label-filter drop, add tests Address Claude review blockers on the parity PR: 1. Wire orchestrator subscriptions for GitLab review/issue watch events. Add event_handlers_gitlab.go with handleGitLabNewReviewMR / handleGitLabNewIssue, dedup reservation handshake, and task-creator interfaces (mirrors event_handlers_github.go). main.go now calls orchestratorSvc.SetGitLabService so the dedup APIs are usable 2. Fix silent label-filter drop: when a custom_query is set on an issue watch, labels were being appended to the unused filter arg. Fold labels into customQuery (or default filter) so they actually reach GitLab; extracted appendLabelsToQuery helper with explicit handling of pre-existing labels= clauses 3. Switch event payloads to pointer types (mirrors GitHub) so handlers can type-assert pointer events 4. Backend tests: store_watches_test.go (CRUD + reserve/assign for all 4 new tables + presets), service_watches_test.go (label-filter helper, cleanup policy, project normalisation), action_presets_test.go 5. Frontend slice tests: review/issue watch CRUD round-trips, action presets + stats reducer coverage All green: backend (build+vet+lint+tests), web (typecheck+lint+2403 tests). * fix(gitlab): address remaining blockers — cleanup wiring, safe defaults, nil guards Address the second round of Claude review blockers: 1. main.go: wire SetTaskDeleter + SetTaskSessionChecker on services.GitLab (mirrors GitHub). Without these, manual cleanup sweeps would always error with "task deleter not configured" 2. service_cleanup.go: default cleanup policy on transient DB error is now CleanupPolicyNever (preserve tasks) instead of CleanupPolicyAuto (silently delete). Genuine "watch was deleted" path also falls under the safe-side default; user can manually delete the orphan tasks 3. service_watches.go: add nil guards on requireStore() so the 6 MR-watch list/get/delete methods return an errStoreUnavailable error instead of panicking when the SQLite store failed to construct at boot 4. use-gitlab-status.ts + use-gitlab-stats.ts: add per-mount attemptedRef so an unreachable GitLab doesn't trigger an infinite re-fetch loop — the previous useEffect re-ran every render because the failure path left status null, satisfying the !status guard * fix(gitlab): propagate session-check errors, clamp poll interval on update Address remaining Claude blockers: * service_cleanup.go: HasUserAuthoredMessage transient errors are now preserved (return false → skip delete) instead of silently ignored; the alternative was occasionally deleting tasks a user had touched * service_watches.go: extract clampPollInterval helper applying the same bounds (0 → default, <60 → 60) as the create path; both applyReviewWatchPatch and applyIssueWatchPatch use it so user-supplied zero or tiny values via UpdateXxxWatchRequest no longer hammer GitLab * fix(gitlab): clear dupl lint, fix preset retry loop + per-workspace watch cache * service_watches.go: applyReviewWatchPatch / applyIssueWatchPatch get nolint:dupl markers — they share shape but per-domain field validation lives in the create paths, so deduplicating via generics would obscure the contract. Restores backend lint to 0 issues * use-gitlab-action-presets.ts: per-workspace attemptedRef set so a failing preset fetch doesn't retry on every render * use-gitlab-review-watches.ts + use-gitlab-issue-watches.ts: track lastFetchedRef per consumer so a workspace switch triggers a refetch. The slice-level loaded flag is shared across instances and can't double as a per-workspace cache key * fix(gitlab): add nil-store guards across review/issue watch + cleanup paths Round-3 Claude finding: ReviewWatch / IssueWatch / preset / reservation methods still called s.requireStore().X() directly. If NewStore fails at boot (table migration error), the service struct's store is nil and every list/get/update/create/reserve method panics on first request. Apply the same store-nil → errStoreUnavailable pattern from f95a929 to every remaining method: * CreateReviewWatch / CreateIssueWatch * GetReviewWatch / ListReviewWatches / ListAllReviewWatches / UpdateReviewWatch / TriggerReviewWatchAll * GetIssueWatch / ListIssueWatches / ListAllIssueWatches / UpdateIssueWatch / TriggerIssueWatchAll * ReserveReviewMRTask / AssignReviewMRTaskID / ReleaseReviewMRTask * ReserveIssueWatchTask / AssignIssueWatchTaskID / ReleaseIssueWatchTask * lookupReviewPolicy / lookupIssuePolicy (return CleanupPolicyNever) * fix(gitlab): nil-store guards on CheckXxxWatch + DeleteXxxWatch + cleanup paths Round-4 Claude finding: 4 remaining panic sites the previous nil-guard pass missed — these run from the background poller (every 5 min) and the manual delete/cleanup flows, so a boot-time NewStore failure would crash the orchestrator process on first tick. * service_watches.go: add store-nil guards to DeleteReviewWatch / DeleteIssueWatch / CheckReviewWatch / CheckIssueWatch * service_cleanup.go: guard CleanupAllReviewTasks / CleanupAllIssueTasks entry points; wrap the trailing DeleteReviewMRTask / DeleteIssueWatchTask calls in `if store := s.requireStore(); store != nil` blocks so the cleanup succeeds even when the dedup-row delete is unreachable * refactor(gitlab): split service_watches.go to stay under 800-line revive limit CI's --new-from-rev lint caught service_watches.go at 808 lines (limit 800). Split into three focused files: * service_events.go (94 LOC) — publish helpers for MR feedback / new review MR / new issue / watch lifecycle events * service_issue_watches.go (302 LOC) — Issue watch CRUD + Check + Trigger + fetch + helpers * service_reservations.go (59 LOC) — Reserve/Assign/Release dedup handles used by the orchestrator event handlers service_watches.go is now 505 lines and contains MR watch + Review watch only. No behavioral change. * fix(gitlab): address inline code-review feedback Address actionable inline comments from Claude/CodeRabbit/cubic/Greptile: * appendLabelsToQuery: use url.ParseQuery for exact key match instead of strings.Contains; previously false-matched keys like mylabels= and silently dropped the watch's labels (test added) * fetchReviewMRs: drop dead `filter = watch.CustomQuery` assignment — SearchMRs's buildMRSearchQuery returns customQuery verbatim and ignores filter when customQuery is non-empty * store.go: add workspace_id indexes on gitlab_review_watches and gitlab_issue_watches (the 5-min poller and HTTP list endpoints did full table scans) * mock_client.SearchProjects: switch from == to case-insensitive Contains so partial-query autocomplete returns the seeded project, matching the doc comment * Poller: add sync.Mutex to guard `started` field; Start/Stop are now safe to call concurrently (go test -race would have flagged the previous read/write race) * Add ErrWatchNotFound sentinel; controller_watches.go maps it to HTTP 404 via httpRespondError helper. Update/Trigger handlers previously returned 500 for missing watches, hiding the distinction from real server faults * service_events.go: log Publish errors on watch lifecycle events instead of swallowing them silently * handlers.go: reject malformed JSON payloads in list-style WS handlers rather than silently falling through to broader list/search behavior * event_handlers_gitlab.go: remove dead gitlabRepoSlug helper + blank-identifier suppression * ci: re-trigger to clear flaky E2E shard 3 * fix(gitlab): address final review round — nil guards, store merge, logs, body validation - CheckMRWatch, UpdateReviewWatch, UpdateIssueWatch: nil guards for store/req - handlers: wsNewDiscussionNote rejects empty body - action_presets: Update reads raw stored row (no default freezing); Reset validates workspace_id - service_search.GetStats: log Warn per sub-call failure before zero - event_handlers_gitlab: log Release* dedup-row errors with context - web/store.ts: post-slice merge restores every GitLab sub-state field; extract buildStateOverrides helper - web/default-state.ts: add GitLab fields to defaultState + mergeInitialState via mergeGitLabFields helper - web/gitlab-api.ts: UpdateXxxWatchRequest now Omit workspace_id Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>	2026-06-02 22:10:07 +01:00
João Salavisa	cb7b5429d5	fix(tasks): harden multi-branch add_branch and surface it in UI (#1239) ... Three areas were broken in the MCP add_branch_to_task flow: 1. Predictable branch names. autoBranchName counted up from existing branch-N rows. Concurrent add_branch calls raced onto the same name and the worktree directory leaked ordering. Now uses a random branch-<3 random chars> suffix via worktree.SmallSuffix. 2. Sibling materialize did not flow to the UI. The materializer published AgentctlReady with the NEW sibling worktree's path, which the frontend handler wrote onto the session row — clobbering the primary's worktree_id/branch and pointing the file browser at the sibling instead of the task root. Added TaskWorkspacePath to the payload, detected the sibling case on the frontend (existing worktree_id != payload's), kept the primary's id/branch, repointed worktree_path to the task root, bumped commits refetch, and dropped the pre-multi-repo legacy git-status entry so the Changes panel stops surfacing the frozen single-repo snapshot. File browser's resetKey now includes the worktree count so the tree reloads when the sibling lands. 3. workspace_path promotion + agentctl rescan refused to act on historical envs. A few envs had workspace_path pointing at the source repo's local_path (orchestrator computeWorkspacePath fallback to req.RepositoryPath when resp.WorktreePath is empty) instead of the primary worktree. The materializer's promotion gate compared against env.WorkspacePath's parent, so those envs were never promoted, and agentctl's resolveRescanPath only accepted parent-of-current so the rescan to the real task root was rejected. Trackers stayed on the wrong directory and the sibling's commits never appeared in the Commits panel even after a full reload. Anchored promotion on env.TaskDirName (basename cross-check) and added a recovery branch to resolveRescanPath that accepts any absolute directory which actually contains git-repo subdirs — the bearer-token middleware already gates the endpoint and scanRepositorySubdirs validates the children, so the relaxed check stays safe. Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>	2026-06-02 00:14:00 +01:00
Carlos Florêncio	956e0a551d	feat(web): collapse mobile task search into a topbar icon (#1157)	2026-05-30 12:54:05 +01:00
Carlos Florêncio	b38dc21fb0	fix: stop changes panel from showing stale or flickering content (#1128)	2026-05-28 23:35:32 +01:00
Carlos Florêncio	8a7b7a0b60	feat(agentctl): azure Repos PR follow-ups after #1066 (#1071)	2026-05-25 18:15:52 +01:00
Carlos Florêncio	68aefc0e08	feat(web): system settings pages (status, database, backups, logs, updates, licenses, about) (#942)	2026-05-25 09:04:16 +01:00
José Almeida	3bc092bf20	feat(terminal): first-class user terminals — stable seq, rename, park/resume (#1009) ... * feat(terminal): persist user terminals with stable seq + park state Ordinary user shells now have a DB-backed `user_terminals` row keyed by the agentctl PTY id, carrying a per-task monotonic seq (gaps preserved on delete), custom_name override, and open/parked state. The terminal service owns the create/list/rename/park/resume/destroy surface and guards reject `bottom-panel` (cmd+J) + `script-*` ids so passthrough flows are untouched. Closing a tab now parks (PTY keeps running); destroy kills the PTY and removes the row. * feat(web): expose terminal seq badge, rename, and parked-terminals menu Wires the right-panel strip and SSR page state to the new task-keyed terminals endpoint and discriminated UserShell union, adds the `#N` badge for ordinary terminals, plumbs context-menu / double-click rename, and renders a "Parked" submenu so closed-but-running terminals can be resumed. Closing a managed tab now parks instead of destroying so the PTY (and its buffer) survives accidental closes. * test(terminal): e2e coverage for first-class persistent entities Covers the persistence guarantees the user explicitly called out: monotonic seqs, refresh-survives-rename-and-park, gap-preserving destroy, park+resume cycle, and bottom-panel/script guards. Exercises the new user_shell.{create,list,rename,park,resume,destroy} WS actions through the shared ApiClient.wsRequest helper. * fix(terminal): atomic seq allocation + propagate destroy errors - Repository.Create folds MAX(seq) read + INSERT into a single `INSERT … SELECT` statement so concurrent creates can no longer pick the same seq. Locked in with TestCreate_ConcurrentSeqAllocation (25 parallel creates, all unique). - wsUserShellStop now propagates the service-Destroy error so the frontend stops optimistically removing a row the backend failed to delete. - Service.Destroy / CleanupTask log PTY-stop failures at Warn (instead of silently swallowing) while keeping the proceed-on-failure semantics intentional — the DB row is the source of truth for "user expects this terminal gone". - IsUserShellAlive copies ProcessID under the read lock before calling r.Get(), removing the post-unlock pointer-deref race. - Get-not-found test asserts errors.Is(err, ErrNotFound) so it locks to the repository contract. * fix(web): close-tab waits for backend ack + className undefined guard - handleCloseTab defers `removeTerminal` into the `.then()` of the park/destroy promise. A failed backend call leaves the tab visible rather than vanishing it optimistically; the next `user_shell.list` poll reconciles state. - session-tabs guards `tab.className` with `?? ""` so an undefined value no longer produces "undefined group relative..." in the rendered class string. - user-shells.test simplification: `createSessionRuntimeSlice` only consumes `set`, so the test passes the slice creator straight to `immer()` instead of wrapping it in an adapter with unused args. * fix(terminal): task-scoped mutations + legacy-shell list + UI hardening Round-2 review feedback (cubic P1/P2, claude, coderabbit): Backend: - Rename/Park/Resume/Destroy now require a task_id and verify the terminal belongs to that task via a shared requireOwnership helper. Cross-task mutations return ErrTaskMismatch instead of silently succeeding by raw terminal id. - wsUserShellList no longer drops managed-shaped agentctl shells when the terminal service is disabled or task_id is missing — legacy passthrough callers see their existing shells again. `managedCovered` flag scopes the orphan filter to the DB-backed path. - service_test.go uses the shared-cache in-memory SQLite + MaxOpenConns(1) setup, matching repository_test.go and removing the flake-one-race-away warning. - New cross-task guard tests: TestRename_RejectsCrossTask, TestPark_RejectsCrossTask, TestDestroy_RejectsCrossTask, plus a TestRename_EmptyTaskIDSkipsOwnership for internal callers. Frontend: - updateUserShell patch type narrowed to Partial<Omit<UserShellInfo, "terminalId">> so the row key can't be silently mutated. - destroyUserShell now throws on a missing WS client instead of silently resolving — handleCloseTab's .then() no longer fires prematurely. - rename/park/resume/destroy API client + useTerminals hook plumb the active task id through every mutating call. E2E: - New "cross-task mutating ops are rejected" spec creates a terminal under task A and verifies task B can't rename/park/destroy it by raw id. - Existing specs updated to send task_id with their mutating calls. * fix(terminal): require task_id on all mutators + wire taskID into hooks Round-3 review feedback (cubic P1, claude blocker, coderabbit): Backend: - requireOwnership no longer skips the ownership check when taskID is empty. The previous carve-out was reachable from the WS layer (where task_id is user-controlled), so an attacker who guessed a terminal id could omit task_id and mutate any row. CleanupTask walks the repo directly and never touched the bypass. - TestRename_EmptyTaskIDRejected pins the new contract. Frontend (the real bug claude caught): - useUserShells now accepts a taskId parameter and forwards it on the user_shell.list WS call. Without it the backend's DB-backed ordinary- shell path was skipped and the Zustand store wiped the SSR-hydrated panel strip on the first WS fetch. - Response mapping switched to a discriminated union: id (new field) falls back to terminal_id (legacy), and kind/seq/state/pty_status/ display_name/custom_name flow into the store so the parked-terminals submenu actually populates. - useTerminals + useMobileTerminals read the active task id from the store and pass it through to useUserShells. - destroyUserShell now retries with user_shell.stop when the server returns an unknown-action error — keeps the rollout-window compatibility intact for older backends that only know the legacy action name. * fix(terminal): list parked, rollout-safe kind default, helper extraction Round-4 review feedback (claude + greptile P1): - useUserShells now sends include_parked: true so the "Parked terminals" submenu populates after a page reload. Previously the WS list returned only state=open rows; parked terminals were invisible until the user parked something in the same session. The main strip still hides parked entries via buildTerminalsFromShells. - useAddTerminal stops blindly defaulting kind to "ordinary" — that misclassified legacy passthrough payloads (terminal_id without seq) during a rollout where the frontend is newer than the backend. The managed-tab path then called parkUserShell on a server that didn't know the action. Now only tags as ordinary when kind is explicit or the row carries a seq. - handleCloseTab extracted into a standalone useCloseTab + helpers hoisted into use-terminals-build.ts / use-terminals-types.ts. Brings use-terminals.ts back under the 600-line file limit and the useTerminalActions wrapper inside the 100-line function limit. * fix(terminal): scope-keyed shell cache + null-task guard + tighter rollout default Round-5 review feedback (cubic P1, coderabbit x4): - useUserShells now keys its fetch cache on env+task (`${env}:${task}`), not just env. An earlier load without a task id (e.g. before the active task hydrated) no longer pins the store on a legacy-only shell list and blocks the task-scoped refetch. - useMobileTerminals delays auto-create until a real taskID is available. Previously a null taskID could bootstrap a legacy non-persistent shell, mark the env as auto-created, and starve the real task of its first-class terminal. Guard key is now env:task, and releaseAutoCreatedEnvironment clears every scope on that env. - useAddTerminal tightens the rollout check: a row is "ordinary" only when `seq !== undefined`. A bare `kind: "ordinary"` without seq from an older backend stays legacy so close → destroy on the first click. - useRemoveTerminal reads the current activeTab from a ref instead of closing over the value captured when handleCloseTab first ran. Async park/destroy resolves after a user tab-switch no longer clobber the newer selection with the stale fallback shift. Tests: - New "waits for taskID before auto-creating — null taskID is a no-op" case in use-mobile-terminals.test.ts confirms the null-task guard. - All existing mobile-terminal + slice + E2E tests pass. * fix(terminal): live activeTab lookup + selectable-tab guard Round-6 review feedback (cubic P2 x2): - getActiveTab now reads the active tab from the Zustand store via storeApi.getState() instead of a useRef/useEffect pair. Closes the post-render race where an async close handler could resolve between the new render's commit and the effect-driven ref sync. - computeTerminalTabValue requires activeTab to be selectable (present in `terminals` or === "commands") before honoring it. A stale id left over from a parked/destroyed terminal no longer pins the panel on a nonexistent tab and blocks the fallback shift to a real shell. * chore(terminal): inline savedTabFromStorage to drop file under line cap Round-7 review feedback (claude suggestion): the useMemo around the synchronous getSessionStorage call was zero-value memoisation that pushed use-terminals.ts three lines over the 600-line max-lines limit. Inlined; file now at 600 lines. * chore(terminal): drop savedTabExists local + comment to land under 600 lines Round-8 follow-up (claude): the previous commit's two-line comment block held the file at 603 lines (still over the 600-line cap). Inline savedTabExists at the only call site and remove the redundant comment — the round-7 PR thread already explains why the useMemo was removed. File now at 599 lines. * fix(terminal): plumb task_id through dockview + tolerate legacy destroys Manual-test feedback: clicking X on a dockview terminal panel surfaced "destroy terminal: terminal does not belong to the supplied task" because the dockview path was creating + destroying terminals without sending task_id at all. The new requireOwnership guard then correctly rejected the empty task_id against a non-empty term.TaskID. Frontend: - addTerminalPanel grows task_id + title parameters; stamps both into panel params at creation time so the destroy cleanup can pass them back to user_shell.destroy / .stop. - Every dockview-side createUserShell call site now passes the active task_id, so the backend creates a DB-backed ordinary terminal (with seq + displayName) instead of a legacy passthrough shell. - destroyUserShell + stopUserShell already accepted an optional task_id; dockview-layout-setup.onDidRemovePanel now reads the stamped task id from panel params and forwards it. Backend: - wsUserShellStop now requires both terminalSvc and a non-empty req.TaskID before routing through the managed service. An empty task_id falls through to the legacy passthrough StopUserShell so older clients (and dockview panels persisted before task_id was stamped) keep working. Known follow-ups (separate task): the #N badge, rename context menu, and parked-terminals dropdown still only show on the mobile/tablet right-panel strip. Desktop dockview shows the seq inside the panel title text but doesn't expose the badge/rename/parked-list UI yet. * feat(terminal): dockview tab badges + rename context menu + existing-terminals list Manual-test feedback round 2: - Custom dockview tab component (TerminalTab) renders the #N pill only when the active env has more than one ordinary terminal — mirrors the session-tab badge semantics. Right-click on any ordinary terminal tab now exposes Rename / Park / Destroy. - Dockview + menu picks up a new "Terminals" section listing every ordinary terminal for the active task (open and parked). Clicking a row focuses the existing dockview panel if one is mounted, otherwise re-opens it; parked rows are auto-resumed via user_shell.resume before the panel is added. The base "Terminal" action was renamed to "New Terminal" so the existing-terminals list is distinguishable in the menu. - Reopen menu uses a stable EMPTY_SHELLS sentinel for its store selector to avoid Zustand infinite re-renders when the env has no shells. E2E: - terminal-new-tab.spec uses getByRole("menuitem", { name: "New Terminal", exact: true }) to disambiguate from the new "Terminals" submenu label. - Full terminal suite still passes (26/26). * fix(terminal): tab title shows "Terminal" with seq as badge, populate store on session page Re-reading the user feedback: the title text was rendering as "Terminal 1" (backend's displayName), and the dockview "+" menu's Terminals section was empty because nothing on desktop was calling useUserShells to populate the store. - TerminalTab.pickDisplayName now returns the literal "Terminal" for ordinary terminals (custom names still override). The seq lives only in the sibling badge — same split as session-tab where the agent name is the title and the seq is a pill before it. Reading "Terminal 1" out of "[1] Terminal" instead of "[1] Terminal 1". - LeftHeaderActions (dockview "+") now calls useUserShells on mount. Without this the desktop layout never triggered the WS list fetch, so the Terminals submenu and the badge "count > 1" check both saw an empty store and silently disappeared. - TerminalReopenMenuItems also calls useUserShells defensively (cheap thanks to scope-keyed cache) so it works when mounted in isolation. * feat(terminal): "New X" rows live inside their section labels User feedback: move "New Agent" under the Agents section header and "New Terminal" under the Terminals section header so the dockview "+" menu reads top-to-bottom as Agents → New Agent → existing sessions → Terminals → New Terminal → existing terminals → other panels. - SessionReopenMenuItems accepts an optional onNewSession prop and renders the "New Agent" row as the first item under the "Agents" label. Render gate now keeps the section visible whenever the create handler is supplied, even with zero existing sessions. - TerminalReopenMenuItems gets a matching onNewTerminal prop with the same behaviour ("New Terminal" row under the "Terminals" label). - dockview-add-panel-items drops its standalone "New Agent" and "New Terminal" rows since both now live inside their sections. * feat(terminal): auto-migrate default panel to DB-backed ordinary terminal The legacy `terminal-default` dockview panel was hard-wired to a non-managed `shell-default` PTY so it never picked up an ordinary seq/customName/parked state — the new "Terminal N" badge UX could only show a badge once the user had explicitly created a second terminal. With useEnsureDefaultTerminalOrdinary the default panel is upgraded into a real `shell-<uuid>` row on session-page mount, so every visible tab is now a first-class ordinary terminal. Plus a UI-level e2e spec asserting the multi-terminal title + badge contract, and an expectation bump on the existing rename+park spec since visiting the session page now mints 1 extra ordinary terminal. * fix(terminal): park ordinary terminals on tab close so they survive refresh Dockview's tab X close button routed straight to stopUserShell (an alias for destroyUserShell), wiping the DB row on close — after a refresh the user had no way to resume a still-running PTY they had just tucked away. The X is now a "hide for now" affordance: ordinary terminals get parked (PTY survives, row stays in DB, reappears in the "+" → Terminals menu with a `parked` pill), while scripts / bottom-panel / legacy passthrough shells stay on the destroy path because they have no resume story. Permanent delete still lives on the right-click Destroy menu item and (in the next commit) on each reopen-menu row. * fix(terminal): preserve DB-backed terminal panel ids across layout restore The serializer's normalizePanel rewrote every user-created terminal panel id to `terminal-saved-N` and dropped environmentId/taskID from params, so after a reload that panel couldn't be matched back to its live PTY or its store record — the tab rendered with no badge and a stale fallback title. Treat `shell-<uuid>` panel ids the same way we already treat `terminal-default`: preserve id and params on restore. Legacy ephemeral `terminal-saved-*` ids still mint a fresh PTY on restore. Also force tabComponent=terminalTab and title="Terminal" for any restored terminal panel so layouts persisted before the badge UX land on the new presentation. * feat(terminal): destroy button on reopen-menu rows for permanent delete Destroy used to live only on the tab's right-click menu — useless once the tab was already closed. Each ordinary terminal row in the dockview "+" → Terminals submenu now ends with an × button that confirms-then calls destroyUserShell, killing the PTY and dropping the DB row so the terminal does not reappear after reload. Pairs with the previous close-to-park change: closing the tab parks (soft, resumable), the × button on the menu row destroys (hard, permanent). * fix(terminal): reopen-menu focuses existing tab, drops parked pill, says Terminate Three small fixes to the dockview "+" → Terminals submenu: 1. Clicking a row whose terminal is already mounted now FOCUSES the existing panel instead of duplicating it. The default-migrated panel keeps its registry id `terminal-default` even after the migration to a `shell-<uuid>` PTY, so a direct getPanel(uuid) miss would fall through to addTerminalPanel and create a second tab for the same PTY. Fall back to scanning `params.terminalId` so the lookup catches that case. 2. Drop the "parked" pill from the row — parking is now an internal detail (close = park) that the user doesn't need to read off the menu. Clicking the row brings the terminal back into view either way, so distinguishing it visually is noise. 3. Rename the row × tooltip + confirm copy from "Destroy" / "Permanently delete" to "Terminate" to match the new tab-context-menu label. Spec: add a test that asserts no duplicate tab when reopening an already-open terminal, and drop the parked-pill assertion from the existing close+reload test. * feat(terminal): empty-group watermark uses the rich + menu When a user splits a group (split-right / split-down) the new half is empty and dockview renders the watermark. Before this, the watermark showed a hard-coded Agent/Plan/Terminal/Browser row and clicking "Terminal" called createUserShell without a taskId — so it spawned a legacy passthrough shell that never appeared in the user-shell list, and clicking "Agent" only ever focused the singleton chat panel (invisible if the task had multiple sessions). The watermark now renders the same AddPanelMenuItems content the header "+" uses, so the user gets: - The Agents list (existing sessions, greyed when already open) - The Terminals list (existing terminals, greyed when already open) - The Browser/Plan/VS Code/Changes/Files/PR options …served behind a single "Add panel" dropdown trigger centered on the empty group. * feat(terminal): inline rename on the tab; drop Park, rename Destroy → Terminate The tab title is now editable in place — picking Rename from the right-click context menu swaps the title for an input. Enter commits, Escape / blur-with-no-change cancels, and the new name is pushed through renameUserShell + the user-shell store so the API and badge list stay in sync. Replaces the previous window.prompt which felt out of place in the dockview chrome. While here: - Drop the "Park (hide, keep PTY)" context-menu item. Tab close already parks ordinary terminals, so the explicit Park action was redundant and broke the "one obvious affordance per outcome" rule. - Rename "Destroy" → "Terminate" in the context menu. Matches the reopen-menu × tooltip and reads more like a system action than a destructive UI primitive. Spec adds an inline-rename test asserting the input appears, accepts typed text, and commits the new title to the tab. * fix(terminal): right-click Terminate closes the tab; drop displayName DOM warning Two unrelated fixes both landing in terminal-tab.tsx: - Terminate used to fire the WS destroy and update the store, but left the dockview panel mounted with a dead PTY underneath. Now it optimistically drops the shell row from the store, closes the panel via api.close(), then sends the destroy — same effect as the X close but routed to the hard-destroy path (the onDidRemovePanel cleanup sees no shell entry and skips its park branch). - TerminalTabBody typed `displayName` as a prop but never destructured it, so {...props} spread it into DockviewDefaultTab and on into a DOM div, triggering "React does not recognize the `displayName` prop on a DOM element". Drop it from the spread. * feat(terminal): polish + menu — badge-style indices, flush-left New rows, terminate closes panel Polish pass on the dockview "+" → Agents / Terminals submenus: - Replace the plain `#N` text with the same pill-style badge the tabs use (small bg, rounded, 11px). Agents and terminals both pick this up — so the menu row reads "[N] label" matching the tab style. - Drop the empty index-column placeholder span on the "New X" rows so the icon + label sit flush-left under the section header instead of awkwardly indented. - Strip the backend "Terminal {seq}" suffix from row labels — the badge already carries the number, so showing "Terminal 1" next to the "1" pill duplicated it. Custom-renamed terminals still show their name. - The row × button now also closes the dockview panel if the terminal is currently open, mirroring the right-click → Terminate flow. Spec: switch the row-by-seq lookups from `hasText: "#N"` (now stale since the `#` prefix is gone) to a `has:` filter against the new `reopen-terminal-seq-N` badge testid, and add a regression test for right-click → Terminate closing the tab and removing the row in one gesture. * fix: address terminal review feedback * fix: resolve terminal review suggestions * fix: catch terminal close stop failures * fix: harden terminal terminate failures * fix: use pinned pnpm docker arg * fix: satisfy backend lint after main merge * fix: stabilize e2e after layout merge	2026-05-24 12:59:30 +01:00
João Salavisa	68aeefa296	feat(gitlab): add GitLab integration with MR / discussions support (#861) ... * feat(gitlab): add GitLab integration with MR / discussions support Adds a GitLab integration parallel to the GitHub one: PAT and glab CLI auth, self-managed host configuration, MR feedback (approvals + discussions + pipelines), and discussion reply / resolve so agents can address review comments. The pr skill detects the host from git remote and creates a real GitLab merge request via glab or REST. Closes #820 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * refactor(gitlab): address review feedback and tighten lint surface - Add service_test.go covering ConfigureToken / ClearToken / ConfigureHost. - Drop speculative MRWatch / TaskMR / ReviewWatch / IssueWatch / preset scaffolding that had no migrations or handlers behind it. - Consolidate /approvals into one round-trip via fetchApprovals. - Use http.DefaultClient in CheckHost (context already carries the deadline). - Rename misleading id → configured in ConfigureToken. - Introduce mrStateOpen constant so the lint goconst rule passes. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(gitlab): address PR review feedback (CodeQL SSRF, races, atomicity) - connectivity: parse host with url.Parse, validate http/https scheme, build probe URL via &url.URL{} so user-controlled host can't smuggle into the request — clears the CodeQL go/request-forgery alert. - pat_client: guard cached username with sync.RWMutex; IsAuthenticated now propagates non-401/403 errors instead of masking transport failures; GetMRStatus skips pipelines query when HeadSHA / HeadBranch are both empty; parseNextLink drops cross-host links instead of returning bare absolute URLs that get() would double-prefix. - service: findTokenSecret returns (bool, string, error) and all callers propagate the secrets.List error so a backend outage isn't mistaken for "token absent"; ConfigureHost persists to hostStore before mutating in-memory host + client + authMethod under one lock. - repoclone: SSH clone URL falls back to ssh:// form when the host has a port (scp-style git@host:path can't carry one). - gitlab/client_helpers: namespace fallback uses LastIndex("/") so subgroup paths (acme/team/squad/repo) are preserved. - pr skill / plan doc: drop hardcoded --target-branch main, derive host from git remote instead of $CI_SERVER_URL, build curl payload with jq -n; fix /pipelines/:id/jobs → :pipeline_id typo. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(gitlab): preserve host base path in CheckHost; broaden validation; test - connectivity: extract validateHost so the parse / scheme / hostname / userinfo / opaque-URL checks each have a single home. Preserve the configured base path (TrimRight slash) so a host like https://gitlab.acme.corp/gitlab probes /gitlab/api/v4/version instead of dropping the prefix. - connectivity_test: cover validateHost (default, https, http, trailing slash, subpath, missing scheme, ftp, empty host, userinfo) and CheckHost end-to-end (version endpoint, base-path preservation, scheme rejection, unreachable host). - pr skill: drop the broken `glab repo view --json defaultBranch` branch — glab doesn't accept --json, so the lookup silently fell back to "main" every time. Fetch default_branch via the GitLab REST API directly using the PAT we already have. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(gitlab): override filter defaults, refresh auth uncached, mock pipelines - appendFilter: Del before re-Add so user-supplied filter keys actually override caller defaults (e.g. state=closed swaps the seeded state=opened instead of appending a second value GitLab silently ignored). - IsAuthenticated: probe /user directly instead of routing through the username cache; a token revoked upstream now surfaces as not-connected immediately. Cache is opportunistically refreshed on success. - MockClient.GetMRFeedback: include pipeline state in HasIssues, matching the real PATClient behavior so test flows can't miss a broken MR. - pr skill: document `glab mr note create --reply <id>` for replies (bare `glab mr note` opens a new thread); fix host-extraction block to handle ssh://host:2222/team/repo.git without leaking the port into PROJECT. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(gitlab): guard mock pipelines on empty MR head; preserve HTTPS port in pr skill - MockClient.GetMRFeedback now mirrors PATClient: skip the pipelines fetch when HeadSHA and HeadBranch are both empty. The mock'\''s ListPipelines ignores its branch argument and returns every pipeline seeded under the project, so without this guard a brand-new MR would inherit a sibling MR'\''s failing pipeline and flip HasIssues to true. Tests cover both the empty-head and head-present cases. - pr skill: derive HOST scheme-aware so https://host:8443 keeps the port (HTTPS API endpoint), ssh://host:2222 strips it (different transport), and scp-style git@host stays portless. Avoids silently re-routing self-managed API calls to the default 443. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(gitlab): export SeedPipelines; mock GetMRStatus parity; drain bodies; test cache hit - MockClient: add exported SeedPipelines(project, iid, []) alongside the other Seed* methods; mirror PATClient.GetMRStatus by populating PipelineState / jobs counts via summarizePipelines, guarded on a non-empty head ref. Brings mock parity with the real client so any future test seeding pipelines sees the same MRStatus shape. - PATClient HTTP plumbing: drain resp.Body via io.Copy(io.Discard, ...) when result == nil in both getWithTotal and doWrite, so HTTP/1.1 can reuse the connection instead of opening a new TCP socket per call. - TestPATClient_GetAuthenticatedUser: assert calls == 1 after the second GetAuthenticatedUser hit so the cache contract is actually verified (a non-caching implementation would have passed the prior version). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(gitlab): surface connection errors, align MR pipeline guards, fix mock seed key - service.GetStatus now captures the IsAuthenticated error into a new Status.ConnectionError field (empty on healthy / 401-403, populated on network / 5xx / parse failures). Frontend GitLabStatus + settings page render a distinct "Unreachable" badge + alert so users don't delete a still-valid token during a transient GitLab outage. - PATClient.GetMRFeedback now guards on HeadSHA || HeadBranch, matching GetMRStatus and MockClient.GetMRFeedback (which had been updated in an earlier round). The three call sites were inconsistent — a mock test with HeadBranch-but-no-SHA would pass while the real client silently dropped pipelines. - MockClient.pipelines is now keyed by project alone (was map[mockMRKey][]Pipeline). SeedPipelines takes (project, []) so successive seeds for the same project deterministically overwrite, instead of leaving multiple entries that ListPipelines would resolve in Go's unspecified map-iteration order. - Tests: TestService_GetStatus_{PopulatesConnectionErrorOn5xx, ClearsConnectionErrorOn401} cover the new error surface; TestMockClient_SeedPipelines_OverwritesByProject locks the key change. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(gitlab): tighten validateHost; init Status scopes; close token-host race - validateHost: drop the parsed.Opaque != "" branch — Go only sets Opaque for opaque URIs, which have an empty Host the prior check already rejects. Narrow the userinfo error to mention the actual user:password@host shape so the message matches what users see. - service.GetStatus: initialize RequiredScopes: []string{} on the nil-client defensive branch so the JSON payload keeps the always-an-array contract declared on the TypeScript side. The branch is effectively unreachable (every Provide path returns at least a NoopClient) but the empty-slice fallback costs nothing. - service.ConfigureToken: build the installed client inside the write lock using the up-to-date s.host instead of the pre-probe snapshot. A concurrent ConfigureHost between RUnlock and Lock used to leave s.client pointing at the prior host while s.host advertised the new one — every subsequent API call would silently target the wrong instance until the next reconfigure. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(gitlab): drop MR-commit stats fields; rename AuthorName; log post-lock host - MRCommitInfo: drop Additions / Deletions / FilesChanged. GitLab's /merge_requests/:iid/commits endpoint doesn't return a stats object, so those fields were always 0 — better to omit them than feed callers silently-wrong numbers. Rename AuthorUsername to AuthorName since the API returns a display name, not a login handle. Doc-comment records the per-commit endpoint to use if a future revision wants real stats. - ListMRCommits: drop the Stats anonymous struct from the JSON decode target now that the destination fields are gone. - service.ConfigureToken: capture installedHost inside the write lock and log that value. The previous log used the pre-validation host snapshot, so a concurrent ConfigureHost between snapshot and lock would leave the log entry referring to a stale value while the client itself was correctly built against the new host. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(gitlab): encode subgroup paths; sentinel-route errors; mock approval parity - pat_client.SearchGroupProjects now encodes the group path through a new groupRef helper that %2F-substitutes slashes (mirrors projectRef). Subgroup paths like "acme/team" used to land at /groups/acme/team/projects, which GitLab routed to the parent group only and returned 404 for. Subgroups now work end-to-end. - service.ErrInvalidToken sentinel + controller errors.Is routing: token validation failures now wrap a package-level sentinel and the HTTP layer switches on it via errors.Is, replacing the fragile strings.Contains prefix check that would silently fall through to 500 if the message ever changed. Coverage: TestService_ConfigureToken_WrapsErrInvalidToken. - MockClient gains seedable approvals: SeedApprovals(project, iid, list, required) backs a dedicated approvals + requiredApprovals map. ListMRApprovals, GetMRFeedback, and GetMRStatus all consume them so ApprovalState / ApprovalCount / RequiredApprovals match what the real PATClient.GetMRStatus computes. Coverage: TestMockClient_GetMRStatus_UsesSeededApprovals. - ClearToken: same host-snapshot race ConfigureToken was fixed for last round — NewClient now runs under the write lock against s.host rather than a pre-acquired snapshot. - CheckHost: drain resp.Body before close so http.DefaultClient's keep-alive pool can reuse the connection for the next probe. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(gitlab): full-path projectRef round-trip; unlock during glab probe - splitFullReference now returns (namespace, fullPath) where fullPath is the namespace-qualified project path ("group/sub/project") instead of the last segment alone. Callers can pass MR.ProjectPath straight to projectRef for round-trip API calls (GetMR, GetMRFeedback, etc.) — matches GitLab's own path_with_namespace convention. Existing test cases updated. - ClearToken: build the fallback client OUTSIDE the write lock so NewClient's glab subprocess (bounded by glabAuthTimeout = 10s) doesn't freeze every concurrent GetStatus / GetMRFeedback / Client() RLock reader for the duration. Brief WLock now only wraps the field swap. Tradeoff with the concurrent-ConfigureHost race is documented in-code: narrow stale-host window vs. 10s of blocked readers, and the next reconfigure resolves it. - New regression test TestPATClient_SearchGroupProjects_EncodesSubgroupSlash asserts the request URL is /groups/acme%2Fteam/projects so a future refactor that swapped groupRef back to a bare url.PathEscape would fail visibly instead of silently 404ing subgroup lookups. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(gitlab): equality-guard ClearToken's client swap against ConfigureHost race ClearToken builds the fallback client outside the write lock to avoid blocking RLock readers for up to 10s while glab auth-probes. The swap-only critical section now compares s.host against the pre-probe snapshot before assigning — if a concurrent ConfigureHost moved the host underneath us, we leave its (newer, correctly-targeted) client alone instead of overwriting with our stale-host build. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(web): add GitLab to the settings integrations sidebar The /settings/integrations/gitlab page existed and the index card listed GitLab alongside the other integrations, but the settings sidebar nav (IntegrationsNavGroup) only listed GitHub / Jira / Linear / Slack. The page was unreachable through the standard sidebar. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(gitlab): task-MR topbar surface + DB-backed task↔MR store Phase 1 of the GitLab UI build-out: brings the MR side of the task topbar to parity with the existing GitHub PR button. Backend - gitlab_task_mrs table + Store wiring (UpsertTaskMR, ListTaskMRsByTask, ListTaskMRsByWorkspaceID, DeleteTaskMR), uniqued on (task_id, repository_id, project_path, mr_iid) for multi-repo. - service.SyncTaskMR folds a live GetMRStatus probe into an upsert; ListTaskMRsByTask / ListTaskMRsByWorkspace expose the rows. - Three HTTP endpoints: GET /workspaces/:id/task-mrs, GET /tasks/:taskID/mrs, POST /tasks/:taskID/mrs/sync. - initGitLabService now takes a *db.Pool and constructs gitlab.Store. Failures non-fatal: integration keeps working without the table. Frontend - TaskMR type + listWorkspaceTaskMRs / listTaskMRs / syncTaskMR API. - lib/state/slices/gitlab slice (taskMRs.byTaskId) wired through default-state, store.ts AppState, and slices/index exports. - hooks/domains/gitlab/use-task-mr.ts: useWorkspaceMRs (fetch-on- workspace-switch) and useTaskMRs (per-task selector). - components/gitlab/mr-topbar-button.tsx — single/multi MR variants, status icons mirroring pr-task-icon priority order. - task-top-bar.tsx renders PRTopbarButton and MRTopbarButton side-by- side; each returns null when empty, so the union handles GitHub-only, GitLab-only, and multi-repo tasks without an explicit switch. - kanban-board.tsx hydrates useWorkspaceMRs alongside useWorkspacePRs. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(gitlab): add /gitlab page for browsing user MRs and issues Adds the GitLab counterpart to /github so users can browse their own merge requests and issues from inside kandev, parallel to the existing GitHub "My GitHub" page. Backend - /api/v1/gitlab/user/mrs and /user/issues — paginated wrappers around the existing SearchMRsPaged / ListIssuesPaged client methods. paginationFromQuery clamps page/per_page the same way as the client. Frontend - /gitlab SSR page + client with MR/Issue tabs, scope filters (assigned / created / review-requested), and a free-text search box that falls back to raw GitLab query-string for power users. - searchUserMRs / searchUserIssues API helpers + MR / Issue / *SearchPage types in lib/types/gitlab. - useGitLabAvailable hook (probes /status + refreshes on window focus) feeds the integrations menu so the GitLab link only shows when a token is configured or auth is green. Tests - task-top-bar.test mocks the new MRTopbarButton so renders no longer pick up useAppStore without a StateProvider. - integrations-menu.test wires the new useGitLabAvailable mock and gitlabReady prop into mockAvailability / getAvailableIntegrationLinks fixtures. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(gitlab): stable empty array in useTaskMRs to avoid infinite re-render useTaskMRs returned `state.taskMRs.byTaskId[taskId] ?? []` — that fresh literal made the zustand selector produce a new reference on every render when the task had no MRs, triggering an infinite re-render loop in MRTopbarButton that crashed the task page with a Next.js client-side exception. The page never mounted session-chat, so Docker E2E tests that drive `/t/:id` (slow-bootstrap progress, external-stop resume, environment reset) all timed out waiting for the chat panel. Mirror the GitHub side's `EMPTY_PRS` pattern: hoist a module-level `EMPTY_MRS = []` and return it for the empty case. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(gitlab): address PR review — cache header, in-flight cancel, tests - Top-level `cache: "no-store"` in 5 sites (use-task-mr.ts, gitlab-api.ts, gitlab-page-client.tsx). The earlier `init: { cache: "no-store" }` placement was silently overwritten by fetchJson with undefined, so probes hit the browser cache instead. - useWorkspaceMRs now invalidates in-flight responses and calls resetTaskMRs when the workspace becomes null, so the previous workspace's MRs don't linger after sign-out / workspace switch. - Drop unpopulated UnresolvedThreads/DiscussionCount from TaskMR (model, schema, TS type). SyncTaskMR's source MRStatus never populated them and no surface reads them; the dropped columns are skipped via an explicit projection in store.go so existing dev DBs keep binding. - Extract MRList/IssueList inline fetches in /gitlab into useGitLabUserMRs / useGitLabUserIssues — matches CLAUDE.md "never fetch in components". - Tests for store (UpsertTaskMR, composite key, workspace-JOIN isolation, ordering, Delete), service (SyncTaskMR mock round-trip + field mapping + store-unset error, ListTaskMRsByWorkspace JOIN isolation, ListTaskMRsByTask), pat_client (ListIssuesPaged X-Total), gitlab-api (5 new fns), gitlab-slice (setTaskMR composite key), and the use-task-mr / use-user-search hooks. - pr SKILL.md: skip note for steps 5–6 on GitLab remotes. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(gitlab): only wrap 401/403 probe errors as ErrInvalidToken Network failures, 5xx, and DNS errors during `ConfigureToken` previously surfaced to the user as HTTP 400 "invalid token: …" — during a GitLab outage a user with a valid token might delete it assuming it was rejected. Now only `*APIError` with 401/403 is mapped to `ErrInvalidToken`; other errors propagate unwrapped so the controller routes them to "GitLab unreachable" instead. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-23 23:17:16 +01:00
João Salavisa	1b58a64fd8	feat(automations): /settings/automations with run-mode + per-automation config (#1016) ... * feat: add automation system with triggers, backend-driven metadata, and PR association Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat(automations): execution_mode + flat /settings/automations Layered on top of #406's automation subsystem: - Add execution_mode to Automation (task | run, default task). Run-mode firings create an ephemeral kanban-hidden task tagged with origin=automation_run. The session pipeline still runs against it, but users surface them through the AutomationRun history instead of the kanban. Pragmatic shim while AutomationRun-as-true-session-owner is deferred to a follow-up. - Thread IsEphemeral + Origin through ReviewTaskRequest + reviewTaskCreatorAdapter so the orchestrator can create the hidden task in one call. - Run-mode always auto-starts (the user never sees the task to drag). - Flat /settings/automations route replaces the per-workspace sidebar entry. Picks the only workspace, shows a picker for many, or shows a CTA for zero workspaces. - Editor exposes execution mode + table shows it as a badge column. Spec at docs/specs/office/automations-settings.md documents the design, deferred items, and scenarios. * feat(automations): per-automation repository picker Adds a repository_id field on Automation so users can pin scheduled and webhook automations to a specific workspace repository instead of always falling through to "first repo". github_pr triggers ignore the field and keep using the PR's own repo — the editor disables the picker with a hint when a PR trigger is selected. Backend: - repository_id column folded into the canonical CREATE TABLE (no migration needed — PR #406 introduces the table). - RepositoryID threaded through model, DTOs, store INSERT/UPDATE, and service.CreateAutomation. - resolveAutomationRepository prefers the explicit ID, falls back to workspace-first on empty. Frontend: - repository_id on the Automation TS type + Create/Update payloads. - Repository SelectField in ConfigSection backed by useRepositories; "Auto" sentinel represents the empty/fallback choice. - Disabled with help-text for github_pr triggers. * feat(automations): repo picker shows discovered repos too Matches the task-creation dialog's UX: the editor's repository picker now lists registered workspace repos AND filesystem-discovered repos under the workspace's roots. Picking a discovered repo registers it with the workspace at save time (via createRepositoryAction), captures the new id, and writes it onto the automation. After the first save the picker selection is promoted from "discovered" to "registered" so re-saving doesn't re-register. Form state holds a RepositorySelection union (auto | registered | discovered) rather than a plain id string so the picker can carry the metadata needed to register. github_pr triggers still disable the picker — PR events always override any configured repo with the PR's own. * fix(automations): add idempotent ALTERs for in-branch columns The canonical CREATE TABLE covers fresh installs, but `CREATE TABLE IF NOT EXISTS` is a no-op for DBs already initialised from an earlier commit on this branch (PR #406's original schema). Without these ALTERs, dev DBs created before execution_mode + repository_id existed on the row hit "no such column" errors. Three idempotent ALTERs: task_title_template, execution_mode, repository_id. SQLite returns a duplicate-column error when the column already exists; we swallow it. * fix(automations): use generateUUID in non-secure contexts crypto.randomUUID is only defined in secure contexts (HTTPS or localhost). PR #406's editor used it directly, which throws "crypto. randomUUID is not a function" when the app is reached via a plain hostname like nova:58204. Switch to lib/utils.generateUUID, which falls back to a Math.random-based implementation when crypto isn't available. * fix(automations): polish run-mode lifecycle, validation, and editor UX Run-mode automations were partly broken end-to-end: - workflow_id was sent for ephemeral tasks (rejected by task service) and was required by the editor + automation service, so "Create Automation" was always disabled and silently failed - a permission_request hanging the agent left the run pinned at task_created forever; nothing reaped the ephemeral worktree - trigger config inputs (cron, branches, authors) did not re-sync with the loaded automation on page reload - runs row never linked back to the underlying task for task-mode automations, and the table header highlighted on hover Backend - skip workflow fields in CreateReviewTask / StartTask for run-mode - relax automation.Service.CreateAutomation: workflow only required for task-mode - auto-reject permission prompts on ephemeral automation tasks and mark the AutomationRun failed with the requested action - on agent completion / failure for ephemeral automation tasks, flip the run to succeeded/failed and remove the worktree + branch immediately (new RunStatusSucceeded + MarkRunSucceededByTaskID) - wire worktree.Manager into the orchestrator service Frontend - show Execution Mode first; hide Workflow / Workflow Step in run-mode - canSave no longer requires workflow in run-mode - surface save errors via toast instead of silent failure - sync trigger-config local input state with loaded prop value - runs table: clickable row → /tasks/<id> for task-mode runs, non-clickable in run-mode; suppress header hover * fix(automations): address PR review feedback Backend - automation/scheduler.go: parseCronFields returns an error for unsupported expressions instead of silently defaulting to hourly - automation/webhook.go: constant-time secret compare, header-only (no more ?secret= query param), reject with 409 when no enabled webhook trigger exists - automation/service.go: enforce max_concurrent_runs in FireTrigger via maybeSkipForConcurrencyCap (records a skipped run when capped) - cmd/kandev/e2e_reset.go: surface automation delete errors as 500 instead of swallowing them - orchestrator/event_handlers_git.go: auto-reject permission with cancelled=true so the message status is "rejected" and the session isn't flipped back to running - orchestrator/event_handlers_agent.go: finalizeAutomationRunIfEphemeral now runs at the top of handleAgentFailed, before the resume/recoverable early returns, so session-backed run-mode failures get cleaned up Frontend - state/slices/automations/automations-slice.ts: declare _get/_api so the call site's arity matches and CodeQL stops flagging ignored trailing arguments - automations/schedule-selector.tsx: clearing the input now propagates ""; cron is trimmed before validation+save - automations/triggers-section.tsx: switching to webhook mode deletes the existing scheduled/condition triggers so they don't keep firing hidden in the background - automations/trigger-configs/github-ci-config.tsx: useEffect re-sync for checkNames, matching the other trigger configs - hooks/domains/settings/use-automations.ts: per-workspace fetch via loadedWorkspaceRef + render-safe loadedWorkspaceId state; inFlightWorkspaceRef discards stale responses after workspace switch --------- Co-authored-by: Carlos Florêncio <carlosmflorencio@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Kandev Agent <agent@kandev.dev>	2026-05-22 22:01:59 +01:00
João Salavisa	35242b2982	feat(web): drag-reorder subtasks within a parent task (#962) ... * feat(web): drag-reorder subtasks within a parent task Adds per-parent subtask ordering in the sidebar. Drag a subtask under its parent to reorder; the chosen order is independent of the global sort and persists per browser via localStorage. - New `sidebarTaskPrefs.subtaskOrderByParentId` slice field and matching `setSubtaskOrder(parentId, ids)` action, persisted to localStorage under `kandev.sidebar.subtaskOrderByParentId`. - `applyView` applies the per-parent override after `separateSubtasks`, so it never touches root order or the active sort spec. - TaskSwitcher exposes `onReorderSubtasks(parentId, ids)`; each parent's subtask list lives in its own nested DndContext / SortableContext using the existing dnd-kit setup. - Task-deletion cleanup strips the deleted id as both parent key and subtask entry from `subtaskOrderByParentId` in store + localStorage. * refactor(web): address PR review feedback on subtask reordering - Extract `pruneSubtaskOrder(map, taskId)` helper in `local-storage.ts`; use it in both `cleanupTaskStorage` and `removeTaskFromSidebarPrefs` to keep the two cleanup paths in lockstep. - Move `SortableSubtaskRow`, `SortableSubtaskList`, and `useSubtaskDnd` into a new sibling file `task-switcher-subtask-dnd.tsx` so the switcher stays under the 600-line soft limit. - `SortableSubtaskList` now short-circuits to a plain row map when `onReorderSubtasks` is undefined — read-only callers no longer get a misleading grab cursor or unused DnD scaffolding. * fix(web): add stable keys to non-DnD subtask render path When `onReorderSubtasks` is undefined, the early-return branch in `SortableSubtaskList` mapped subtasks without keys, falling back to React's index-based reconciliation. Wrap each child in a keyed `Fragment` so reorders or size changes reconcile correctly. * refactor(web): single-source DRAG_ACTIVATION_DISTANCE Export the constant from `task-switcher-subtask-dnd.tsx` and import it in `task-switcher.tsx` instead of declaring the same value twice. --------- Co-authored-by: Kandev Agent <agent@kandev.dev>	2026-05-21 01:31:42 +01:00
Carlos Florêncio	0b2085688b	feat(office): autonomous agent management layer (#914)	2026-05-16 20:07:57 +01:00
José Almeida	0743477d48	feat: persist N-entry FIFO message queue (#864) ... * feat(orchestrator): persist N-entry FIFO message queue Replaces the single-slot, latest-wins, in-memory queue with a SQLite-backed FIFO queue (default cap 10 per session, configurable via KANDEV_QUEUE_MAX_PER_SESSION). Drain stays one-per-turn so each entry gets its own user message and `on_turn_*` workflow cycle. Inter-task `message_task_kandev` returns a structured `queue_full` error with sender attribution when the target session is saturated, so the calling LLM can decide whether to retry. Surfaces a new WS action `message.queue.remove` for single-entry deletion; `message.queue.cancel` now means clear-all. Edit/remove are keyed on the entry's UUID, returning `entry_not_found` when atomic-take won the drain race. * feat(web): N-entry queue state, API, and optimistic hook Replaces the single-slot QueueStatus with an ordered `entries[]` per session plus capacity meta (`count`, `max`). API exposes typed `QueueFullError` and `QueueEntryNotFoundError`; the hook surfaces optimistic edit/remove with drain-race rollback (refetch on `entry_not_found`). * feat(web): inline ghost-message queue UI with sender chips Replaces the floating QueuedMessageIndicator overlay with a stack of ghost messages rendered above the chat input. Each ghost shows a sender chip (user / agent) and per-entry edit/remove. A small "n/max queued · clear all" pill summarizes capacity. Inter-task entries are visually distinct and edit is gated to the original sender. * fix(queue): address review — auth guard, TOCTOU, error UX - Add `messagequeue.QueuedByUser` / `QueuedByAgent` constants and centralize the `queue_full` error code so the WS and MCP handlers stay in sync. - WS `message.queue.{add,append,update}` default empty user_id to QueuedByUser so the UpdateContent ownership guard always runs against a non-empty owner; inter-task entries (`queued_by="agent"`) can no longer be overwritten by user-initiated edits even when `user_id` is omitted from the payload. - memoryRepository: hold the mutex through the whole append-or-insert path (prior split released the lock between tail-check and Insert, allowing two same-sender callers to race past coalescing). TransferSession now shifts source positions past the destination's max so transferred entries always drain after pre-existing destination entries, matching SQLite semantics. - Frontend: surface edit/clear/remove failures via `sonner` toasts (drain race → "message already sent"); exit edit mode on failure instead of leaving the textarea silently stuck. Hide the remove button on read-only (agent) ghosts. - `useQueue.clearAll` no longer derives `max` from pre-clear entry count; resets to `metaMax ?? 0` so the next status_changed event lands authoritative capacity. - `senderKindOf` drops the unreachable metadata fallback; route on `queued_by` alone since `dispatchTaskMessage` always sets it. - Test loggers now write to stderr per CLAUDE.md "stderr for logs" guideline. * test(web): align queue e2e selectors with new ghost-message UI The ghost-message rewrite renamed button titles ("Cancel queued message" → "Remove queued message", "Edit message" → "Edit queued message") and introduced a `data-testid="queued-ghost-list"` container. The `message-queue.spec.ts` Playwright tests still pointed at the old titles. * fix(queue): address second review pass — auth, drain race, tests - WS handlers (`add` / `append` / `update`) now reject `user_id="agent"` outright, closing the gap a hostile WS client could exploit by impersonating the inter-task sender identity to overwrite agent entries (greptile P1). - WS `update` / `remove` now require `session_id` so the post-mutation `MessageQueueStatusChanged` broadcast can never be silently skipped. - `sqliteRepository.TakeHead` checks `RowsAffected()` after DELETE; when two concurrent take callers race past the busy-timeout the loser sees 0 affected rows and now returns `nil, nil` instead of the already-drained message (would otherwise dispatch the same prompt twice). - `Service.GetStatus` returns `Entries: []` instead of `nil` on the error path so the wire shape stays consistent (frontend already guards but strict consumers wouldn't tolerate the type mismatch). - New tests: `queue-api.test.ts` covers `rethrowQueueError` mappings (queue_full / entry_not_found / generic / Error pass-through); `session-slice.upsert.test.ts` covers `setQueueEntries`, `removeQueueEntry`, and `clearQueueStatus`. Backend gains an agent-impersonation handler test. - `rethrowQueueError` now surfaces `WSError.message` for non-queue errors instead of stringifying the whole object. - Cleanup: replace unused `a, c := ...` discards in service_test with `_, _ = ...`. * fix(queue): scope update/remove by session_id (cross-session deletion guard) The MCP `queue_full` error payload deliberately discloses sibling-task entry IDs (so the calling agent's LLM can reason about the wedge state). Without a session_id filter on `DeleteByID` / `UpdateContent`, a hostile agent that received that payload could call `wsRemoveEntry` / `wsUpdateMessage` against another task's entries and delete or rewrite them — only the per-entry UUID was being checked. - `Repository.UpdateContent` and `Repository.DeleteByID` now require `sessionID` and add `AND session_id = ?` to the SQL guard. The memory repo mirrors the scope (lookup keyed on session before the entry scan). - `Service.UpdateMessage` / `Service.RemoveEntry` take `sessionID`; the WS handlers thread `req.SessionID` through (already validated as non-empty in the previous fixup). - TypeScript: `session_id` is now required on `updateQueuedMessage` / `removeQueuedEntry` params so callers fail at compile time, matching the backend contract. - Tests cover the cross-session attack: `RemoveEntry`/`UpdateMessage` with an attacker-supplied session_id but a real entry id from another session must return `ErrEntryNotFound` and leave the victim entry untouched. SQLite repo gets parallel coverage. * fix(queue): propagate transfer error + tighten WSError narrowing - `Service.TransferSession` now returns an error so callers can fail closed instead of silently leaving entries orphaned on the previous session. The two existing call sites pick the right policy: `switchSessionForStep` (reusing an existing session) propagates the error so the workflow switch aborts; the new-session path logs and continues, since the new session is already committed and rolling back here would leave a half-switched workflow. - `asWSError` now also narrows on `message` / `details`, so WS payloads without a `code` field are still mapped to a meaningful `Error.message` via `rethrowQueueError` (instead of "[object Object]"). Native `Error` instances explicitly skip the WS-error branch so they pass through untouched, preserving the existing pass-through guarantee. - `queue-api.test.ts`: `expect.assertions(N)` on the catch-only tests so a missing throw fails the test instead of silently passing. * fix(queue): check TransferSession error in service tests The TransferSession signature change in 83abe6d7 broke errcheck on two test sites that hadn't been updated. Wrap them in require.NoError.	2026-05-11 22:40:36 +01:00
Carlos Florêncio	f97ac8bbc1	feat: streaming agent install, PTY login terminal, docker container UX (#869)	2026-05-11 17:52:05 +01:00
José Almeida	14c19ea538	feat(web): add CI hover popover on PR top-bar button (#846) ... * feat(github): plumb CI popover fields + branch protection cache Adds RequiredReviews/UnresolvedReviewThreads/ChecksTotal/ChecksPassing to TaskPR + PRStatus. Extends the GraphQL PR query with reviewThreads to populate UnresolvedReviewThreads on every poll. New branch_protection.go holds an in-memory TTL cache + BranchProtectionFetcher interface; PATClient/GHClient implement REST/CLI lookups so SyncTaskPR can resolve required_approving_review_count for the PR's base branch. SyncTaskPR preserves existing counts when a lightweight (GraphQL) sync returns 0 so the popover doesn't flap during the polling cycle. * feat(github): mock controller hooks for CI popover e2e Extends associateTaskPR to accept review/check counts, required_reviews, and unresolved_review_threads, and switches to ReplaceTaskPR so re-POSTing the same task drives the popover live-refresh path. Adds POST /pr-feedback to seed PRFeedback (checks/reviews/comments) keyed by a deterministic synthetic head_sha, and PUT /auth-health to flip the mock client's authenticated flag for the "Reconnect GitHub" branch. Mock client gains ReplaceCheckRuns/ReplaceReviews/ReplaceComments helpers and an authenticated field that defaults to true. * feat(web): CI hover popover on PR top-bar button Hovering the PR top-bar button now reveals a popover with Passed/In-Progress/Failed counts, a workflow-rollup list under the non-empty buckets (with "open on GitHub" + "+ ctx" affordances on failed rows), a review-state row ("Approved 1 / 2 required"), and unresolved-comments count. Click on the button keeps the existing "open PR detail panel" behavior so shipped tests stay green. PRFeedback is lazy-fetched on hover-open via a new SWR-style hook backed by a 20-entry LRU cache slice; the popover refetches whenever the underlying TaskPR's updated_at changes (the WS handler already applies poll deltas). Bucket logic + workflow grouping live in a small util with vitest coverage. The aggregate-popover variant for multi-PR tasks ships but the multi-PR trigger preserves its existing DropdownMenu so per-row click → addPRPanel still works. * test(e2e): pr-topbar-popover scenarios A–F covering CI popover 11 specs covering: count rows + zero-bucket hiding, workflow rollup with (N/M passed) badge under Failed, review row + unresolved comments, hover open + leave close, failed-row open/+ctx affordances, header external link, "No checks have started" empty state, "Reconnect GitHub" auth-lost branch, and live count updates on a re-associate. Adds api-client helpers (mockGitHubSeedPRFeedback, mockGitHubSetAuthHealth, extended mockGitHubAssociateTaskPR) and SessionPage popover accessors. * fix(github): address bot review comments on CI popover - branch_protection.go: evict stale entries on read so the cache map cannot grow unbounded over a long-running deployment; rewrite the comment to drop the inaccurate singleflight claim (no dedup logic exists, concurrent misses race harmlessly to set()). - gh_client.go: replace fragile strings.Contains "HTTP 404" with an isNotFoundErr helper that tolerates the formats current and future gh CLI versions use ("HTTP 404", "404 Not Found", "status: 404"). - graphql.go: extend reviewThreads with totalCount and attribute the un-fetched tail to the unresolved bucket so PRs with >100 threads don't silently undercount in the popover. - pr-ci-popover.tsx: drop the dead "icon" initializer in PRReviewRow (every branch overwrites it). Memoize useAddCheckToContext so PRWorkflowRow's reference equality stays stable across renders. - pr-topbar-button.tsx: collapse the duplicate JSDoc on usePopoverInteractions. * fix(github): address remaining bot review comments + tests Real correctness fixes: - Replace the "0/0 means counts omitted" heuristic with an explicit PRStatus.ChecksPopulated flag so the rich REST sync can clear stale totals when checks are removed from a PR upstream. - Refresh tp.BaseBranch from status.PR on each SyncTaskPR so a retargeted PR's branch-protection lookup keys off the new branch. Persist base_branch in UpdateTaskPR. - Cache 403 from /branches/.../protection (token lacks Administration: Read scope) the same way as 404 — otherwise every poller tick burns rate-limit quota retrying. Both PATClient and GHClient. - usePRCIPopover: refetch on every popover-open transition (not just on updated_at change), via a wasEnabledRef gate. Restores the intended SWR semantics that the lastSyncedRef-only guard suppressed. - groupChecksByWorkflow: prefer the URL of a job matching the group's bucket so clicking a "failed" workflow row navigates to a failing job, not an earlier passing one. Tests: - branch_protection_test.go: cache hit/miss/TTL/eviction, error not cached, no-rule cached, client-without-fetcher path. - pat_client_test.go: TestPATClient_FetchBranchProtection table-test for 200/200-with-null/404/403/500. - service_test.go: ChecksPopulated preserve-on-zero, accept real zero, base-branch retarget, change-publish for the new fields. * refactor(github): trim associateTaskPR + drop unreachable PRAggregatePopover - mock_controller.go: extract associateTaskPRRequest struct, buildTaskPRFromRequest, and ensureMockPRForRequest helpers so the handler is back under the 80-line Go limit. - pr-ci-popover.tsx: remove unreachable PRAggregatePopover export. Multi-PR tasks currently use the existing DropdownMenu trigger (no hover popover), so the aggregate component was dead code. * fix(github): drop unused anchorRef + tests for is{NotFound,Forbidden}Err - pr-topbar-button.tsx: anchorRef was leftover from the dropped click-to-pin onInteractOutside guard. Removed. - gh_client_test.go: tests for the new isNotFoundErr / isForbiddenErr helpers covering each accepted format and a few non-matches so a future gh CLI wording change is caught. * fix(github): UnresolvedReviewThreadsPopulated guard + drop unreachable nil checks - service.go: mirror the ChecksPopulated/preserve dance for UnresolvedReviewThreads. The REST single-PR poller (getPRStatus) doesn't fetch review threads, so without this guard every REST sync would clobber the GraphQL-populated value to 0 and emit a spurious github.task_pr.updated event. The GraphQL path (convertBatchedPRResult) sets the new flag. - branch_protection.go: drop unreachable s == nil / fetcher == nil checks. fetchRequiredReviews is only invoked from SyncTaskPR on a service constructed via NewService, which always initialises the cache. After a successful type assertion, the interface value cannot be nil; the !ok branch already covers nil-interface inputs. - service_test.go: new TestSyncTaskPR_UnresolvedThreads_PreservesOnLightweightSync covers the regression. Existing NewFieldsPublishEvent threads-change case updated to set UnresolvedReviewThreadsPopulated. * refactor(web): drop CI popover progress bar — last-updated is enough The animated progress bar was visual noise; the "updated Ns ago" timestamp tells the user the same thing without the indicator. Footer also hides entirely until the first fetch lands so an empty popover doesn't show a useless "" line. * fix(web): background-sync PRFeedback so popover is fresh on first hover The on-hover SWR fetch was the only refresh path, so opening the popover showed the previously-cached value while a new fetch raced behind it — visibly stale until the refetch landed. The button icon, by contrast, updates the moment a github.task_pr.updated WS push lands. Add a usePRFeedbackBackgroundSync hook mounted at the PRTopbarButton that subscribes to the same pr.updated_at change signal and refetches PRFeedback into the cache in the background. The popover hook still fires an on-open refetch as a safety net for the very first hover (before any sync). No extra polling — fetches are gated on real TaskPR changes, matching the icon's cadence. * feat(web): CI status chip in chat status bar + tweak elapsed label - New <PRStatusChip> renders a compact colored circle in the chat status bar (left of the TodoIndicator, just above the input). Hover opens the same PRCIPopover anchored to the chip's top edge so the card expands upward — matching the user's "open bottom-up" ask. The chip mounts the background-sync hook so the popover is fresh on first hover even when the top-bar PR button isn't visible. - elapsedLabel: "just now" → "updated just now" so the footer reads the same regardless of how recently the cache was refreshed. * fix(web): chip color was missing — use static class map for Tailwind JIT \`getPRStatusColor().replace("text-", "bg-")\` produced class strings at runtime, which Tailwind's content scanner doesn't pick up — the chip rendered with no background. Replace with a static lookup so each literal `bg-*` class appears in the source and gets compiled into the bundle. * fix(web): chip uses currentColor SVG so the dot actually renders The previous bg-* approach relied on Tailwind compiling the literal class strings. Even with a static map some palette entries (notably bg-muted-foreground) didn't surface as a usable utility, so the chip remained transparent. Apply getPRStatusColor's text-* class to the button wrapper and fill an SVG circle with currentColor — the text-* utilities are already compiled (PRTaskIcon uses them) so the dot is guaranteed to render in the right color. * fix(web): redesign PR status chip — clipboard icon + status glyph - Move chip to right of TodoIndicator (was left). - Render as "[clipboard icon] [status glyph]" instead of a bare circle: passed → green CircleCheck, failed → red CircleX, in_progress → yellow Loader2 (spinning), merged/neutral → muted dot. Status icons reuse already-compiled text-* utilities so colors render reliably. * fix(github): ReviewCount = approved-reviewer count + ReviewCountsPopulated guard Two bugs feeding the popover's "Approved (0)" misreport: - Semantic: REST path set ReviewCount to len(reviews), which double-counts authors who left multiple reviews and includes COMMENTED rows. Replace with countApprovedReviewers — distinct authors whose latest review state is APPROVED. GraphQL converter gets the parallel countApprovedReviewerNodes helper and also populates PendingReviewCount from ReviewRequests.TotalCount (was unset, so the chip's "(K requested)" suffix was always missing). - Clobber: GraphQL polls used to write ReviewCount/PendingReviewCount=0 on every cycle because the converter never set them. Add ReviewCountsPopulated to PRStatus and gate SyncTaskPR's writes on it the same way ChecksPopulated already does, so a partial sync path preserves the persisted values instead of resetting them to zero. * fix(web): popover nitpicks (icon, review row, indent, badge) - Chip icon: ClipboardCheck → ListCheck. - PRReviewRow always renders (drop the early-return). Fresh PRs with no approvals + no protection rule now show "Awaiting review" instead of vanishing. - Indent workflow rows under the In Progress / Failed group headers (pl-5) so the hierarchy reads more clearly. - In-progress workflow badge: "0/1 ran" → "1 running". The old phrasing hid whether the job had even started. * feat(web): stacked pass-rate progress bar in CI popover Mirrors TodoIndicator's progress bar at the top of the CI section, but split into three coloured segments: green (passed) | yellow (in_progress) | red (failed) sized proportionally to each bucket's count. The label reads "Pass rate · K/N (P%)" so the user gets the same at-a-glance summary TODOs shows. Skipped/cancelled-but-not-failed jobs aren't counted — the bar always reflects the actionable picture. * fix(web): right-align review counts + drop chip hover bg - Move approval/required counts to the right edge of the review row ("Approved" on the left, "1 / 2" on the right), mirroring the bucket-row layout. The "(K requested)" suffix becomes a "· K requested" trailing fragment on the right side. - PRStatusChip: drop hover:bg-accent/50 so the trigger doesn't grow a background plate when the popover is open. * fix(web): switch CI chip icon to IconChecklist * fix(github): clear bot review-comment backlog Real correctness fixes: - pr-status-chip: pending checks / pending review now beat checks_state === "success" in chipStatus precedence — a PR with CI green but reviewers outstanding is no longer rendered as "passed". - branch_protection: drop the unreachable Reset() method. - pr-topbar-button: stop double-mounting usePRFeedbackBackgroundSync; the chip already covers it. - use-pr-ci-popover: dedupe key combines prFeedbackKey + updated_at so switching tasks with same-timestamp PRs still refetches. - use-pr-ci-popover: drop stale comment about the removed progress bar. Refactor: - client_helpers + graphql: extract reviewSample + latestReviewStateByAuthor helper so the three near-identical per-reviewer dedup loops share one implementation. Tests: - countApprovedReviewers + reduceReviewSummary unit tests. - TestSyncTaskPR_ReviewCounts_PreservesOnLightweightSync + AcceptsRealZero mirror the existing ChecksPopulated guards. - groupChecksByWorkflow distinct-URL test verifies the failed-job URL-selection fix. - branch_protection TTL tests now use testing/synctest — instant virtual time, no real-sleep flake on CI. * fix(web): clicking the CI chip no longer closes the popover HoverCard treats the trigger button as outside the content's bounding box, so a click on the chip fired Radix's onPointerDownOutside and auto-closed the popover. Add a triggerRef + onPointerDownOutside guard on HoverCardContent that filters out clicks landing on the trigger — clicking the chip is now a no-op while the popover stays open via hover.	2026-05-11 16:55:58 +01:00
José Almeida	7ec639bf2f	feat(web): mobile parity (session/terminal/repo pickers + multi-terminal) (#840) ... * refactor(web): extract shared use-session-actions hook from SessionTab Move WS-level session lifecycle handlers (set primary, stop, resume, delete) into hooks/domains/session/use-session-actions so the same logic can power both the dockview tab context menu and upcoming mobile controls. Dockview-specific panel removal stays local in SessionTab via the onDeleted callback. * feat(web): humanize task and session state labels Mobile task sheet was rendering raw enum values like "IN_PROGRESS". Add formatTaskStateLabel + formatTaskSessionStateLabel helpers and use them in the mobile task sheet badge. Session state badge in the new mobile sessions picker also reuses the formatter. * feat(web): mobile session/terminal/repo pickers + multi-terminal support Address parity gaps on mobile by introducing per-pane header pills that open bottom-sheet pickers, scoped to the relevant view rather than overloading the left task sheet. Pickers: - Sessions pill in chat header → bottom sheet with launch / set-primary / stop / resume / delete (with confirm). Pill shows agent label + idx/total badge. - Terminals pill in terminal header → bottom sheet with add / close (with confirm) / switch. Replaces an earlier chip-strip prototype. - Repos pill on the top bar (multi-repo only) → bottom sheet listing task repositories; switching jumps to a session on that repo. Each pill renders with a chevron-down icon + count badge so the trigger reads as a button, not a status badge. Multi-terminal: - New useMobileTerminals hook wraps useTerminals and auto-creates a first shell when the env reports zero. - MobileTerminalPane multi-mounts PassthroughTerminal instances keyed by terminalId so switching preserves scrollback. Active xterm registers itself in a small mobile-active-terminal sender registry; the existing key-bar reroutes input through xterm.paste() so Ctrl / ^C / arrows reach whichever terminal is currently visible, not just the per-session default shell. - Skip the WebGL renderer addon on mobile (new disableWebgl prop on PassthroughTerminal). The WebGL atlas miscomputed glyph scaling after the desktop→mobile responsive switch and rendered text at several times the intended font size; the canvas renderer is correct and fast enough for shell use. Refactors: - Left sheet reverts to a single-purpose task list (the sectioned-hub variant was rolled back in favour of per-pane pickers). - session-task-switcher-sheet-hooks extracted from the sheet to keep it under the file-size lint cap. * fix(web): address review feedback on mobile pickers + multi-terminal Bots flagged a real first-mount bug and a handful of smaller items; addressed each: - mobile-terminal-pane: track xterm in state instead of a ref so the active-sender registration effect re-runs once xterm is ready. With the ref, the effect ran once on mount, found xtermRef.current === null while PassthroughTerminal was still initializing (notably under the ResizeObserver fallback path when the container starts at 0×0), and silently never registered — leaving the key-bar wired to the default shell instead of the visible terminal. - send-shell-input: wrap the activeSender call in try/catch so a stale registry entry (xterm GC'd mid-frame) falls back to the WS path instead of dropping the keystroke and silently consuming modifiers. Added tests for the activeSender routing branch (success, modifier consumption, fallback on throw). - mobile-sessions-section: remove the dead `showCloseConfirm ? "Delete" : "Delete"` ternary and the unused prop on SessionActionsMenu. - use-mobile-terminals: clear the auto-create guard when addTerminal() rejects so the user gets a retry instead of an empty terminal list. - mobile-repo-pill: sort taskRepos by position before falling back to the first repo, so the pill label matches the picker's ordering when no session is active yet. - session-task-switcher-sheet-hooks: catch loadTaskSessionsForTask rejection in handleSelectTask (was an unhandled rejection that left the sheet open on backend errors), and stabilize useCallback deps in handleWorkspaceChange by spreading the SheetNavOptions fields so a fresh literal each render doesn't defeat memoization. Extracted selectTaskWithoutPrimarySession to keep useSheetActions under the function-size lint cap. * fix(web): preserve task.repositories in sheet-hooks kanban mappers mapSnapshotToKanban (workspace switch) and handleTaskCreated (newly created task) only carried the first repository_id, dropping the full TaskRepository array. The mobile repo picker (useTaskRepoCount + MobileReposSection) reads task.repositories.length, so it silently disappeared after a workspace switch and for freshly created multi-repo tasks. Map the array with the same shape the SSR mapper uses (id, repository_id, base_branch, checkout_branch, position). Also address a small nit: wrap addTerminal in an arrow at the New terminal button so the click MouseEvent isn't passed as the (unused) first argument. * fix(web): de-dup mobile terminal auto-create + add state-label tests + repo-tap toast - use-mobile-terminals: move the auto-create-first-shell guard from per-instance refs to a module-level Set keyed by environmentId. MobileTerminalPane mounts useMobileTerminals three times for the same session (the pane itself, the picker pill via useActiveTerminalPillLabel, and the picker sheet content via MobileTerminalsList — Vaul keeps it mounted while closed). With per- instance guards, all three effects ran on first commit and each fired createUserShell, racing into up to three shells. The shared Set ensures only the first effect to observe an empty list creates, with retry-on-failure preserved (delete + next render re-checks). - mobile-repos-section: tapping a repo with no sessions now toasts a hint to open the session picker, instead of silently doing nothing. - state-labels: add tests covering known mappings, null/undefined fallbacks, and unknown-state passthrough for both formatters. * fix(web): single useMobileTerminals via context + tests + drop dead export Address two follow-up review items: - Lift useMobileTerminals to a single MobileTerminalsProvider owned by MobileTerminalPane. The picker pill and the picker sheet's list now read state from useMobileTerminalsContext instead of calling useMobileTerminals themselves. The previous setup had three independent useState-backed lists that drifted out of sync after addTerminal/removeTerminal — the pane could show a stale active terminal and the pill count could lag until a server WS push reconciled them. The module-level guard (added in 9488bb0c) fixed the creation race; this fix ensures the live list stays consistent too. - Drop the dead `subscribeActiveTerminalSender` export from the mobile active-terminal registry. The keybar reads via getActiveTerminalSender; notify/subscribe was speculative scaffolding with no production consumer. Test trimmed accordingly. - Add use-mobile-terminals.test.ts covering the auto-create logic (initial create, skip when shells exist, skip while loading, multiple instances trigger only one creation, retry after failure). Module-level guard exposes a __resetAutoCreatedEnvironmentsForTest helper so tests start from a clean slate. * test(web): capture binary AttachAddon frames in mobile keybar e2e helper The mobile-terminal-keybar Playwright spec asserted on captured shell.input WS frames. After this PR, the on-screen mobile terminal is a PassthroughTerminal with its own AttachAddon WebSocket, and the keybar routes input through xterm.paste() — bytes go on the binary terminal WS, not the kandev gateway's shell.input action. The capture helper missed those frames and every keybar-asserts-on-frame test failed (Ctrl+L, Shift+Tab, Esc, arrows, symbols, etc.). Extend attachShellInputCapture to also decode binary terminal frames (skipping the resize tag 0x01 prefix used by useSendResize) so the existing assertions on `data` continue to work regardless of which transport carried them. * fix(web): keybar control chars + session pill propagation + terminal close ordering Round-3 review feedback. Several real bugs that the previous rounds' mocks hadn't caught: - mobile-terminal-pane: switch from xterm.paste(data) to xterm.input(data, true). paste() wraps the payload in bracketed-paste escapes (\\e[200~…\\e[201~) under bash/zsh/fish, so every control byte from the keybar (^C, arrow keys, Esc, ^D, Tab) was landing in the shell as literal pasted text instead of as a control signal. - session-mobile-layout: TaskChatPanel and the agent PassthroughTerminal were rendering with the URL-derived `sessionId` prop instead of the store-driven `effectiveSessionId`. The session picker would update the top bar and terminal pane (which already read effectiveSessionId) but the chat content and passthrough agent stayed on the old session until a navigation refresh. Both consumers now follow effectiveSessionId; the now-unused `sessionId` prop is removed from MobileChatPanelContent + MobilePanelArea. - mobile-terminals-section: rework handleConfirmClose. Stop the remote shell first (and only mutate the picker on success), advance setRightPanelActiveTab to a remaining terminal when the closed one was active so terminalTabValue doesn't dangle, and call releaseAutoCreatedEnvironment when terminals drop to 0 so the pane recreates a default shell on next render instead of getting stuck on "Starting terminal…". Extracted as a useTerminalCloseHandler hook to keep the list under the function-size lint cap. - session-task-switcher-sheet-hooks: handleTaskCreated now merges session-derived fields (primarySessionId, sessionCount, etc.) from the existing kanban entry, with meta.taskSessionId as the priority source — so an "edit" call doesn't wipe the existing session and a "create with session" call sets primarySessionId correctly. Extracted into buildKanbanTaskUpsert + mergeSessionFields + mapTaskRepositories helpers. - session-task-switcher-sheet-hooks: mapSnapshotToKanban now carries optional step fields (allow_manual_move, prompt, is_start_step, show_in_command_panel, agent_profile_id) so the kanban store keeps step capabilities after a workspace switch. - use-mobile-terminals: add releaseAutoCreatedEnvironment(envId) — a runtime API to clear the module-level guard for one env, used by the picker when the user closes the last terminal. - use-mobile-terminals.test: extract SESSION_ID constant. * fix(web): restore mobile keybar modifier transforms with manual input routing Round-3 swapped mobile from ShellTerminal → PassthroughTerminal, which made AttachAddon auto-send xterm.onData straight to the WebSocket. That bypassed sendShellInput's modifier transform — so OS-keyboard input on mobile (e.g. tap Ctrl on the key-bar, then press "l") sent the raw "l" instead of "\\x0c" (form feed). Multiple e2e keybar tests caught this; my prior xterm.input(data, true) attempt only fixed the key-bar tap path, not OS-keyboard typing. Add `manualInputRouting` + `onWsReady` props to PassthroughTerminal (plumbed through useWebSocketConnection / startReconnectLoop / connectWebSocket). When `manualInputRouting` is true, AttachAddon is constructed with `bidirectional: false` so it only handles PTY → screen, and the consumer is responsible for forwarding xterm.onData itself. Mobile TerminalSlot now: - passes manualInputRouting=true and an onWsReady callback that registers an active-terminal sender writing raw bytes to that terminal's dedicated WS (replacing the prior xterm.input registry). - attaches its own xterm.onData listener that calls sendShellInput, which applies the key-bar's sticky Ctrl/Shift transforms before forwarding via the registered sender. Net effect: both key-bar taps AND OS-keyboard typing flow through sendShellInput on mobile, so modifiers apply uniformly. Desktop unaffected (default bidirectional AttachAddon path unchanged). Also extracted teardownWebSocket into ws-reconnect to keep the use-passthrough-terminal file under the line-count cap after the new options. * fix(web): tighten mobile sender registration + Set Primary + launch return - mobile-sessions-section: drop the borrowed isSessionStoppable guard on the "Set as Primary" item. The backend session.set_primary action has no such restriction, so a COMPLETED or FAILED session was being silently grayed out. Disable only when isPrimary or state isn't loaded yet. - mobile-terminal-pane: register the active key-bar sender only while the dedicated WebSocket is OPEN. Previously the sender went into the registry as soon as the tab became active, so during connect / reconnect it would silently no-op instead of letting sendShellInput fall through to its WS path. Track ws in state, drop it on close, and gate registration on readyState === OPEN. - session-task-switcher-sheet-hooks: early-return after a successful launchSession so we don't redundantly call setActiveTask after setActiveSession. Mirrors the existing "sessions exist" branch.	2026-05-06 19:05:21 +01:00
Carlos Florêncio	b1cd2d2076	feat(github): rate-limit awareness, poller throttling, and GraphQL batching (#821)	2026-05-06 16:51:06 +01:00
João Salavisa	5e3248a66b	feat(web): pin tasks and drag-to-reorder in sidebar (#829) ... Co-authored-by: Kandev Agent <agent@kandev.dev>	2026-05-05 22:06:24 +01:00
João Salavisa	83de4793fd	feat: add Linear issue watchers (#805)	2026-05-05 08:28:09 +01:00
Carlos Florêncio	c042050469	fix: stabilize task switch flow and session recovery (#818)	2026-05-04 18:53:33 +01:00
João Salavisa	e9a7869463	refactor(web): drop dead taskPRs loading state and unused removeTaskPR (#791) ... * refactor(web): drop dead taskPRs loading state and unused removeTaskPR The taskPRs.loaded/loading fields were written but never read — useWorkspacePRs uses its own fetchedRef for fetch-once gating instead. removeTaskPR was defined but never called. Removing all three avoids a footgun in multi-repo tasks where removeTaskPR would have wiped every repo's PR state at once. * refactor(web): use plain deepMerge for taskPRs hydration taskPRs no longer carries loading/loaded fields, so the mergeWithLoading helper has nothing to preserve. Switching to deepMerge makes the intent explicit. --------- Co-authored-by: Kandev Agent <agent@kandev.dev>	2026-05-03 12:00:22 +01:00
João Salavisa	a510b46e4e	feat(multi-repo): support tasks spanning multiple repositories (#767) ... * feat(task): add task_environment_repos schema and model for multi-repo support Phase 0 of multi-repository task support: introduces the per-repository child table and model alongside legacy single-repo fields (dual-write, no behavior change). Lays the foundation for the orchestrator/lifecycle refactor in subsequent phases. - New task_environment_repos table with FK CASCADE on task_environments. - New task_dir_name column on task_environments (idempotent ALTER). - TaskEnvironmentRepo model + Repos slice + RepoFor helper on TaskEnvironment. - CRUD methods + interface extension; env getters preload Repos. - Idempotent backfill from legacy single-repo task_environments rows. - Tests cover round-trip, CRUD, preload ordering, embedded create, cascade delete, and backfill from a legacy-shaped row. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(lifecycle): add Repositories list to LaunchRequest and EnvPrepareRequest Phase 1.1 of multi-repository task support: extends the lifecycle types with explicit per-repo lists, while keeping the legacy single-repo top-level fields as the synthesized fallback. No caller behavior changes yet — preparers still see length-1 specs for single-repo launches. - LaunchRequest.Repositories []RepoLaunchSpec + RepoSpecs() helper. - EnvPrepareRequest.Repositories []RepoPrepareSpec + RepoSpecs() helper. - EnvPrepareResult.Worktrees []RepoWorktreeResult for per-repo outcomes. - runEnvironmentPreparer forwards req.Repositories into the prepare request, inheriting the request-level RepoSetupScript when each per-repo entry has none. - Tests cover explicit-list precedence, synthesized fallback, and repo-less requests. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(worktree,lifecycle): support multiple worktrees per session Phases 1.2 and 1.3 of multi-repository task support. The pieces are intertwined so they ship together — the preparer's per-repo loop depends on the manager being able to hold one worktree per (session, repository) pair instead of one per session. Worktree manager: - In-memory cache key changes from sessionID to (sessionID|repositoryID). - New MultiRepoStore optional capability + SQLite implementation: GetWorktreesBySessionID and GetWorktreeBySessionAndRepository. - New Manager methods: GetAllBySessionID, GetBySessionAndRepo. Existing GetBySessionID returns the first match (single-repo callers unchanged). - Manager.Create's "already exists" check is now repo-scoped so the second repo's create no longer returns the first repo's worktree. - All cache write/delete sites updated to the composite key. WorktreePreparer: - New prepareMultiRepo path activated when EnvPrepareRequest.Repositories has >=2 entries; single-repo and repo-less behavior is byte-identical. - prepareOneRepo runs validate -> sync -> create -> fetch-PR -> per-repo setup-script for each spec; rolls back already-created worktrees on any failure. - Workspace path becomes the task root (parent of any repo subdir); legacy WorktreeID/WorktreeBranch/MainRepoGitDir mirror Worktrees[0] for downstream code that hasn't been migrated yet. - Per-repo setup script runs verbatim (no script-engine resolution yet — the per-repo placeholder namespace lands in a follow-up). Tests: - Manager: GetAllBySessionID, GetBySessionAndRepo (hit + miss), GetBySessionID single-repo compat, cache key separation. - Preparer: multi-repo creates one worktree per repo; rollback removes active worktrees on partial failure; per-repo setup script runs in each worktree directory and emits its own step. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(orchestrator): resolve all task repos and persist per-repo rows on launch Phase 1.4 of multi-repository task support: the orchestrator now reads every repository linked to a task, forwards the full list through the adapter into the lifecycle layer, and persists one TaskEnvironmentRepo plus one TaskSessionWorktree row per repo when the launch is multi-repo. Single-repo and repo-less tasks keep their previous code path verbatim (dual-write — legacy single-repo fields stay populated from the primary). - New resolveAllRepoInfo / resolveTaskRepoInfo on the executor; primary is the first by Position. - buildLaunchAgentRequest takes both the primary repoInfo and the full list, populating req.Repositories []RepoSpec only when length > 1. - New RepoSpec / RepoWorktreeResult on the orchestrator's executor package mirror the lifecycle types so the adapter can translate between them without leaking lifecycle types into the orchestrator public API. - Adapter (cmd/kandev/adapters.go) forwards req.Repositories into lifecycle.LaunchRequest and surfaces per-repo prepare results back on LaunchAgentResponse.Worktrees. - persistTaskEnvironment writes env.Repos in the same create transaction; persistTaskEnvironmentRepos handles the existing-env reuse path. TaskEnvironment.TaskDirName is now persisted. - persistWorktreeAssociation loops over resp.Worktrees in multi-repo, inserting one row per repo with its own RepositoryID. - ResumeSession now also populates req.Repositories from task repos and stamps the existing TaskDirName so the preparer reuses the same task root. - repoStore / executorStore interfaces extended with the new repo and env-repo CRUD methods; mocks updated accordingly. Tests: - LaunchPreparedSession with two task repositories populates req.Repositories in order and keeps legacy single-repo top-level fields filled from the primary. - The same launch persists one TaskEnvironment + 2 TaskEnvironmentRepo + 2 TaskSessionWorktree rows. - Single-repo launch still produces zero entries in req.Repositories and exercises only the legacy fields. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(agentctl): git endpoints accept optional repo subpath for multi-repo Phase 2 of multi-repository task support: every per-call git endpoint gains an optional `repo` field (form param for GET, JSON for POST) that selects a sub-directory of the workspace. Empty `repo` = workspace root, preserving single-repo behavior verbatim. - Manager.GitOperatorFor(subpath) returns a per-subpath GitOperator (cached). Validates the subpath against path traversal, absolute paths, and missing directories. - New api server helper gitOpForRepo() emits a 400 with a per-operation GitOperationResult on invalid subpaths. - Repo field added to: pull, push, rebase, merge, abort, commit, rename-branch, stage, unstage, discard, create-pr, revert-commit, show-commit, reset, log, cumulative-diff. (git/status still reads from the workspace tracker — that endpoint will gain multi-repo support when the tracker itself is split per repo.) - Tests cover empty subpath, valid subpath caching, traversal rejection, and missing-directory rejection. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(web/comments): scope diff comments by repository for multi-repo tasks Phase 3 of multi-repository task support: comments now carry an optional repositoryId so two repos with the same file path render their own comment threads instead of bleeding together. - CommentBase.repositoryId (optional, backwards compatible). - getCommentsForFile gains an optional repositoryId arg; legacy comments without a repositoryId match any repo filter so persisted data keeps showing. - Diff store interface in lib/diff/types.ts mirrors the new arg. - Tests cover per-repo filter, omitted-arg fallback, and legacy data. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(github): per-repo PR association on task PRs and watches Phase 4 of multi-repository task support: github_task_prs and github_pr_watches gain a repository_id column so multi-repo tasks can have one PR per repo without colliding on (task_id) uniqueness. - Idempotent ALTER TABLE adds repository_id to both tables. - TaskPR.RepositoryID and PRWatch.RepositoryID model fields. - New GetTaskPRByRepository and ListTaskPRsByTask lookups; existing GetTaskPR keeps single-PR semantics for callers not yet migrated. - ReplaceTaskPR's delete is scoped by repository_id when set so a multi-repo task replacing one repo's PR no longer wipes the other. - Tests cover per-repo storage and scoped replace. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(web): foundations for multi-repo task UI Phase 5 of multi-repository task support: primitives the upcoming UI work needs without changing any visible behavior yet. - TaskRepository.checkout_branch surfaces the optional PR head branch field that the backend already exposes. - primaryTaskRepository(repos) picks by lowest Position so consumers match the backend's "primary" semantics instead of `[0]`. - New useTaskRepositories(taskId) / useTaskPrimaryRepository(taskId) hooks read the live kanban task and return its repos sorted by position. Future kanban/diff/UI consumers should use these instead of poking task.repositories directly. - Tests cover lowest-position selection and empty/single-repo edge cases. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(web): kanban card shows multi-repo "+N" chip and hydrates full repo list Phase 6 (subset) of multi-repository task support. The kanban now exposes the per-task repository list to the UI and renders a compact "+N" badge on cards whose tasks span more than one repository. - KanbanState.tasks[].repositories slim shape (id, repository_id, base_branch, checkout_branch, position). - SSR mapper hydrates the full list and uses primaryTaskRepository() to pick the position-aware primary instead of [0]. - useKanbanData passes repositories through to the card props. - KanbanCard renders the primary repo name with a small "+N" chip when len(repositories) > 1; tooltip names the count. - useTaskRepositories / useTaskPrimaryRepository hooks return the slim KanbanTaskRepository shape so multi-repo consumers share one read path. Larger UI surfaces (task-create dialog, diff view, file browser, mobile sheets) still target the primary repo only — they will be ported as the multi-repo task creation flow lands. No visible change for single-repo tasks. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(task): reject duplicate repositories on multi-repo task create Phase 8 of multi-repository task support: surface duplicate-repository input as a clean validation error instead of letting the unique (task_id, repository_id) constraint surface mid-loop with some rows already inserted. - createTaskRepositories tracks seen repository IDs and returns "repository <id> listed more than once for the task" before any CreateTaskRepository call. - Tests cover the rejection path and confirm two distinct repos still succeed with both rows persisted in Position order. Repository discovery and per-repo cloning were already covered by Phase 1.4 (resolveAllRepoInfo loops ensureRepoCloned) and the existing repository_discovery service is repo-list aware by design. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(web/task-create): repeatable repository rows for multi-repo task creation Users can now actually create a multi-repo task: a "+ Add repository" button below the primary repo + branch selectors expands the form with additional (repository, base-branch) rows. Each extra row picks from a filtered repository list that excludes the primary and any other already- chosen extras, so duplicates are impossible to enter. - ExtraRepositoryRow type + form-state hook (extraRepositories, add / remove / update / reset). Lives in its own file so the main state hook stays under the file-length lint cap. - ExtraRepositoryRows component renders the rows and the "+ Add" button; per-row branches are loaded on demand via the existing useRepositoryBranches hook. - buildRepositoriesPayload accepts the extras and appends them after the primary, dropping rows with empty repository_id silently so an unfinished row does not block submit. The backend's duplicate-repo validation (Phase 8) catches anything that slips through. - DialogFormBody is split: CreateModeSelectors (selectors + extra rows) and useDialogHandlers move to dedicated files, keeping touched files under the lint thresholds. - Tests cover the multi-repo payload (ordering, drop-empty, no-primary recovery, single-repo unchanged) and the existing store-multi-repo.test.ts gets named constants to satisfy the no-duplicate-string rule. Verified: pnpm exec tsc --noEmit clean, vitest 608/608 green, eslint --max-warnings 0 clean. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(agentctl): per-repo workspace tracker for multi-repo git/status The git/status endpoint now accepts an optional ?repo=<subpath> query param that selects a sub-directory of the workspace, completing the per-repo plumbing started in the multi-repo phase. Single-repo callers keep the workspace-root behavior unchanged. - Manager.GetWorkspaceTrackerFor(subpath) returns a per-subpath WorkspaceTracker (lazy + cached). Validation reuses a new resolveSubpath helper shared with GitOperatorFor, so both code paths reject path traversal / absolute paths / missing dirs the same way. - Per-subpath trackers are NOT started (no polling goroutines); the multi-repo path uses them only for synchronous GetCurrentGitStatus queries which fall through to getGitStatus when no cache is present. This keeps per-repo cost cheap. - handleGitStatus reads c.Query("repo") and routes through the new resolver, returning a 400 with an error payload on invalid input. - Tests cover empty subpath (root), valid subpath caching, traversal rejection. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(web/review): group file tree by repository for multi-repo task changes The review file tree now renders per-repo top-level nodes when a task's changes span multiple repositories, so the same file path in two repos no longer collapses into a single ambiguous entry. - ReviewFile.repository_id and ReviewFile.repository_name (optional) identify which repo each file belongs to. Single-repo callers leave them unset and the tree falls back to the existing flat grouping. - buildFileTree splits into buildMultiRepoTree (when 2+ distinct repository_names are present) and buildFlatTree (the original logic). Repo roots have isRepoRoot=true and a repositoryId for downstream filters; their children are full path subtrees per repo. - collapse() skips repo roots so a repo with a single changed file still shows its repo header. - ReviewFileTree renders repo roots with a stronger label, a top border, and an "N files" count badge; data-testid="repo-root-node" for E2E coverage. File-level rendering is unchanged. - Tests cover the flat-tree fallback (no repo info, single repo), multi-repo grouping, repo-root pinning, and same-filename-different- repos isolation. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(web/task-top-bar): "+N" repo chip on multi-repo task header The task page top-bar breadcrumb now shows a small "+N" chip next to the primary repository name when the task spans more than one repository, matching the kanban-card treatment introduced earlier. Hover surfaces the exact count via tooltip ("frontend (+2 more repos)"). - resolveTaskProps populates repositoryCount from task.repositories.length. - TaskTopBar threads repositoryCount through to the new RepositoryBreadcrumb subcomponent. - The chip carries data-testid="topbar-extra-repo-count" for E2E selectors. - TopBarLeft was nearing the function-length / complexity caps; the breadcrumb extraction restores headroom for future additions. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(web/task-create): disable "Add repository" when no other repos available When the user only has the primary repository in their workspace, clicking "+ Add repository" used to insert a row whose dropdown was empty — looking like a bug ("no other repos show up"). The button now disables itself when there are no remaining workspace repositories to choose from, with a tooltip explaining why ("All workspace repositories are already added"). The previous "primary not selected" guard is also surfaced via tooltip. - ExtraRepositoryRows computes remainingCount = repos − used (primary + already-added extras) and gates the Add button on it. - New computeAddButtonHint helper returns a per-state title string for the disabled cases. - Tests cover: dropdown shows the unused workspace repos when opened (the click path the user reported wasn't actually broken — the gate was just missing); Add button disabled when only the primary exists. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(agentctl): workspace tracker falls back to first repo subdir for multi-repo task roots The "Changes" panel was empty for multi-repo tasks because the agent's workspace path is the task root — a plain holder directory that holds one git worktree per repository as siblings. The workspace tracker tried to run git commands against that bare root and silently failed, so no git status updates ever reached the UI. The tracker now detects this at construction: when the configured workDir isn't itself a git repo, it falls back to the first immediate child directory that is. The user gets the primary repo's changes in the panel; cross-repo aggregation is a follow-up. - preferGitRepoChildIfRootIsBare scans os.ReadDir entries (skipping hidden / non-directory entries) and returns the first that has a valid git index. Logs an info line when the rewrite happens so it's visible in the agentctl log. - Repo-less tasks (e.g. quick chat) and single-repo tasks keep their previous behavior verbatim — the fallback only fires when the root itself fails resolveGitIndexPath. - Tests cover: fallback when the workdir is a multi-repo holder, no-fallback for a real git repo, no-fallback when no git child exists. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(multi-repo): per-repo workspace tracking — Changes panel shows all repos The agent's workspace tracker is now split per-repository for multi-repo task roots. Each repo gets its own tracker that polls git independently and stamps its repository name onto every emitted event. The Changes panel aggregates files from every repo and groups them under per-repo headers using the file-tree machinery from Phase 6. Backend (agentctl): - GitStatusUpdate / FileListUpdate gain a RepositoryName field. Empty for single-repo workspaces (legacy clients see no change). - WorkspaceTracker carries repositoryName and stamps it onto every emitted status/file-list. Two constructors: NewWorkspaceTracker for the legacy single-repo path (with the bare-root fallback) and NewWorkspaceTrackerForRepo for explicit per-repo trackers. - Manager scans direct child directories for git repos at construction. When 2+ repos are found, builds one tracker per repo subdir on top of the root tracker (which stays bound to the bare task root and emits nothing useful). Single-repo workspaces are unchanged. - Manager.SubscribeWorkspaceStream / UnsubscribeWorkspaceStream fan out one client subscription across the root + all per-repo trackers via AttachWorkspaceStreamSubscriber / DetachWorkspaceStreamSubscriber on the tracker. The WS handler switched from the single-tracker subscribe to the manager fan-out. - Tests cover: per-repo trackers spawn for multi-repo task roots, single-repo doesn't, both repos emit GitStatusUpdates tagged with RepositoryName. Frontend: - GitStatusEntry / GitStatusData carry repository_name (optional). - session-runtime gitStatus.byEnvironmentRepo new map keyed by env id then repository name; setGitStatus routes per-repo updates into it while still updating the legacy byEnvironmentId for single-repo consumers. clearGitStatus drops both maps. - migrateEnvKeyedData migrates the new per-repo map alongside the existing keys when sessionId resolves to an environmentId. - WS git-status handler forwards repository_name from event.status. - New useSessionGitStatusByRepo hook returns sorted [{repo, status}] pairs for the active session. - task-changes-panel mergeReviewFiles iterates statusByRepo when available, stamping repository_name onto every uncommitted file so the Changes panel groups them under per-repo headers (using the ReviewFile.repository_name plumbing from Phase 6). - Tests: per-repo routing, no overwrite on sibling repo update, legacy single-repo fallback, clear-on-cleanup. Verified: pnpm exec vitest run 623/623, eslint --max-warnings 0 clean, tsc --noEmit clean, make test (backend) clean, make lint 0 issues. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(web/changes-panel): per-repo group headers above each repo's files The Changes panel now renders a sticky "frontend / N files" header above the diffs from each repository so the user can visually distinguish where each change lives. Single-repo tasks render unchanged (no header shown when there's only one unnamed group). - ReviewDiffList groups its file list by repository_name (preserving the caller's order within each group), then renders one RepoGroupHeader per group followed by the existing FileDiffSection list. Header gating rule: show when len(groups) > 1 OR the single group has a non-empty repository name. - Group key uses "repo:path" so a file with the same path in two repos no longer collides on React's reconciliation. - groupFilesByRepository + RepoGroupHeader live in a sibling review-diff-list-groups.tsx file to keep review-diff-list.tsx under the 600-line lint cap. - Tests cover: no header for plain (no repo_name) files, one header per repo for 2+ groups, header shown even for a single named repo, file paths land under the right group's section. Verified: vitest 627/627, eslint clean, tsc clean. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(lifecycle): propagate RepositoryName through PublishGitStatus The agentctl WorkspaceTracker stamps every per-repo GitStatusUpdate with RepositoryName, but the lifecycle PublishGitStatus translation into GitEventPayload was dropping that field. The orchestrator then forwarded a status with empty repository_name, the frontend store routed everything into the empty-key bucket, and the Changes panel's multi-repo grouping never triggered — no header, no per-repo split. - GitStatusData gains RepositoryName (omitempty so single-repo payloads stay byte-identical on the wire). - PublishGitStatus copies update.RepositoryName onto the payload. - Test asserts the field survives the publish → subscribe round trip via the in-memory event bus on the GitEvent.<sessionID> subject. Restart the agentctl process for any running multi-repo task to pick up the new field; new launches get it automatically. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(web/changes-panel): per-repo group headers in the dockview Changes tab The Changes tab in the dockview panel (the Files / Changes (N) tab the user actually interacts with — not the standalone Review dialog) was still rendering a flat file list, so multi-repo task changes either collided onto the legacy single-status (showing only one repo's files) or rendered without grouping. - FileInfo gains repository_name (optional, single-repo unchanged). - useSessionGit aggregates files from useSessionGitStatusByRepo when multi-repo data is present, stamping each FileInfo with its repository_name. Falls back to the legacy single status for single-repo workspaces. Aggregation extracted into aggregateFilesAcrossRepos to keep useSessionGit under the 100-line function lint cap. - ChangedFile (changes-panel.tsx + changes-panel-timeline.tsx) carries repositoryName through to the renderer. - FileListSection delegates to a new FileListBody that groups rows by repositoryName; renders a small per-repo subheader when 2+ repos OR any single named repo is present, otherwise falls back to the pre-multi-repo flat list (same DOM shape). - Tests cover: no header for plain (no repo_name) files, headers per repo for 2+ groups, single named repo still gets a label. Restart the backend so the per-repo trackers spawn for in-flight multi-repo tasks; new launches are unaffected. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(multi-repo): per-repo git ops, unified branch endpoint, chip-style task create Bundles a string of multi-repo fixes and refactors that came up while testing the feature end-to-end: - workspace_path stored on multi-repo TaskEnvironment was one level too high, so agentctl booted with the wrong WorkDir on cold start; fixed in resolveTaskEnvWorkspacePath + GetWorkspaceInfoForSession. - Stage/Unstage/Discard/Commit/Revert/Reset/Amend now thread `repo` through agentctl client → WS handler → frontend hook → SessionGit fan-out, so the right git repo is targeted (was running at the task root, which isn't a git repo for multi-repo tasks). - agentctl GitLog is multi-repo aware: when no `repo` is specified and per-repo trackers exist, fans out one log per repo and merges sorted newest-first with RepositoryName stamped on each commit. - Per-repo grouping for files (Changes panel) and commits, with collapsible group headers; commits section defaults to collapsed. Algorithm extracted into one generic groupByRepositoryName helper (was copy-pasted three times). - Task creation dialog rewritten around a unified `fs.repositories[]` list — no more "primary vs extras" split. Chip-style row with one pill per repo + branch, "+" to add, x to remove, GitHub URL toggle inline. Discovered (on-machine) repos appear in any chip's dropdown. Removes ~6 fields and 3 helpers from the dialog state. - Branch listing endpoints collapsed to one: GET /workspaces/:id/branches?repository_id=X | path=Y Frontend collapses to a single useBranches hook with a tagged-union source. Drops two HTTP routes, two service methods, two API client funcs, and one whole hook file. Tests added across the chain: workspace_path resolver, sort-commits- by-date, manager poll-mode propagation, RepoSubpaths, chip grouping + collapse + per-repo isLatest, group-by-repo helper, dialog payload builder + chip wiring + discovered-repo flow. * feat(multi-repo): unified per-repo git controls for all VCS operations Changes panel and top-bar VCS button render per-repo Stage all, Commit, Unstage all, Push, Pull, Rebase, Merge, and Create PR uniformly across single-repo and multi-repo workspaces. Operations route to the correct git repo subpath; fan-outs collect per-repo results and surface partial success in the toast layer. Backend: - Stamp RepositoryName on Reset/BranchSwitch/FileChange notifications and forward through orchestrator handlers - Surface per-repo errors from handleGitLogMultiRepo via PerRepoErrors Frontend: - pull/push/rebase/merge/abort/commit fan out via PerRepoOperationResult - Per-repo group headers always render with action buttons - Top-bar dropdown lists per-repo Pull/Rebase/Merge entries - pendingStageFiles keyed per-repo to prevent cross-repo clears - useRepoDisplayName distinguishes loading from multi-repo - Commit dialog file summary respects stageAll - New helpers: changes-panel-helpers.ts, changes-panel-repo-groups.tsx, use-repo-display-name.ts Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(multi-repo): plumb repo through file/commit/diff endpoints; per-repo PRs and review UI - backend: thread `repo` subpath through pull/push/rebase/merge/abort, file content/update, cumulative-diff, and commit-show endpoints; per-repo fan-out for log + cumulative-diff with each repo's own merge-base; emit full `repositories` array on task.updated WS payload - github: store/list TaskPRs as []*TaskPR (per-repo); orchestrator/web store rekey to `Record<taskId, TaskPR[]>` - web: aggregate PR icon (count badge + worst-of color, multi-PR tooltip); branch hover card renders one row per repo with each repo's task base branch; review dialog merges per-repo file maps with composite keys and propagates repository_name through diff/expand/revert; commit-detail panel scopes to the owning repo - kanban card: chip row of repo names (up to 2 + "+N" overflow, tooltip lists all) - task-create dialog: gate non-worktree executors to multi-repo only; move fresh-branch toggle inline next to the repo chips (icon-only, with title/aria-label) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(multi-repo): scope PR watches/associations and review UI per repository Schema: add repository_id to UNIQUE constraints on github_pr_watches and github_task_prs (with idempotent copy-and-rename migration) so one task spanning N repos can hold one watch/PR per repo without collisions. Plumb repository_id through CreatePRWatch/EnsurePRWatch/AssociatePRWithTask /AssociatePRByURL, fan TriggerPRSync across all per-repo watches, and disambiguate status sync by (task, owner, repo, pr_number) instead of "first match". Add Repo to wsCreateFile/Delete/Rename and wsCreatePR/ RenameBranch so file and git ops target the right working tree. Frontend review dialog: switch reviewedFiles, staleFiles, fileRefs, selectedFile and comment counts to NUL-separated `${repo}\x00${path}` keys so same-named files in different repos no longer share state. useTaskPR consumes the new {prs: TaskPR[]} envelope. Also: snapshot repoTrackers slice before background refresh in SetWorkspacePollMode to prevent races with Stop(), and key mergeCumulativeFiles by NUL-separated (repo, path) to match. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * chore: apply prettier formatting Unblock CI prettier check on files modified earlier on this branch that pre-date the current prettier config. * fix: address PR review feedback and unblock E2E Backend: - ListWorkspaceTaskPRs background sweep now uses TriggerPRSyncAll so multi-repo tasks refresh every per-repo PR (was only the most recently updated watch). Caught by claude review on #767. Frontend (no behaviour change): - Replace literal NUL byte (0x00) in FILE_KEY_SEP and the inline key builder in use-review-dialog with the explicit escape so the source is plain ASCII. The runtime separator is unchanged; this just removes a footgun that GitHub's diff renders as a visible space. - Show the auto-resolved branch as a small read-only pill next to the GitHub URL input so the URL-mode dialog surfaces the branch the task will run on (previously only the URL was visible). E2E: - changes-panel-focus / pr-detection / pr-switcher-changes: expand the commits-section before asserting on commit text -- the section starts collapsed since the chip-style refactor. - repository-selector-scroll: open the popover via repo-chip-trigger instead of the legacy single repository-selector testid. * test(e2e): align task-create dialog tests with chip refactor Updates three more tests that broke when the dialog migrated from a single repository/branch combobox to per-row repo/branch chips and the URL-mode toggle relabel: - create-task.spec.ts (pre-select + remembers-selections): switch repository-selector / branch-selector lookups to repo-chip-trigger / branch-chip-trigger. - create-task-github-url.spec.ts (toggle test): the inverse-state label is now "use a workspace repository", not the legacy "or select a repository". No code changes — purely test alignment with the existing UI. * fix(web): re-apply workbench-chrome topbar + restore branch-selector behaviour Two regressions surfaced by the multi-repo merge into main: 1. task-top-bar.tsx had been resolved in our favour at the workbench-chrome merge (#761), losing the TopbarActionOverflow wiring that the new test asserts on. Re-applies main's topbar structure (TopbarCluster groups, TopbarActionOverflow, IntegrationsMenu, MoreToolsMenu, SettingsButton) on top of our multi-repo additions: repositoryCount + RepositoryBreadcrumb "+N" chip, gitStatus + isMultiRepo plumbing, and the GitAheadBehindBadges suppression for multi-repo. GitAheadBehindBadges moved to its own file to stay under the file-length cap. 2. The chip-style task-create dialog dropped the legacy branch-selector semantics. Restored: - Local-executor branch lock: the per-row branch chip is now disabled when isLocalExecutor and fresh-branch is off. The user's checkout dictates the branch for local execution; fresh-branch unlocks it. - Branch override: when locked, the chip shows currentLocalBranch instead of the value the user picked under a different executor (so worktree -> local doesn't display a stale "develop" pick). - Branch refresh: useBranches now exposes a refresh() callback for id-based sources (calls listRepositoryBranches with refresh=true), and Pill renders BranchRefreshButton in its popover header when onRefresh is wired. - URL-mode branch picker: GitHubUrlSection now renders a real branch-chip-trigger Pill backed by fs.githubBranches instead of a read-only span, restoring the "branch selectable in URL mode" behaviour (URL mode is always remote-clone, so the local-executor lock does not apply). E2E spec updated: bulk-rename legacy branch-selector / repository-selector testids to branch-chip-trigger / repo-chip-trigger.first(). All 13 create-task-branch-selector tests pass locally. * ci: force workflow re-run * fix(web): unblock E2E shard 2 Three issues showed up only after the merge with main, which brought back the E2E shard 2 tests touching git/changes-panel and improve-kandev: 1. Wire the TaskCreateDialog slot props (extraFormSlot, aboveDescriptionSlot, bottomSlot, descriptionPlaceholder) through to DialogPromptSection. They were declared on the public API but dropped on the floor before this change, so Improve Kandev's contributor banner ("@octocat" / "@kandev-maint") never rendered. Also gate the "or paste a GitHub URL" toggle on lockedFields.repository so the locked-repo dialog hides it (matches main's behaviour and the existing test expectation). 2. Revert "commits section starts collapsed" (introduced in 9e8079de). The collapsed-by-default tradeoff is genuine, but it broke 14+ E2E tests that assert on commit text in the changes panel — the win wasn't worth the test churn. Updated the unit test to match. 3. Update the git-changes-panel E2E tests to use the stable `[data-testid^="commit-row-"]` selector instead of `commitsList li`. The chip-style refactor introduced a per-repo group <li> wrapper, so counting all <li> descendants now over-counts (1 wrapper + N commits). Same fix in the "distinguishes pushed and unpushed" test which queried `li` with text and matched both the wrapper and the commit row. Locally verified: full shard 2 (45 tests) passes; full unit-test suite (943 tests) passes; lint + typecheck clean. * fix: address claude review feedback Three findings from claude[bot] review on PR #767: - types.ts: add 13 unit tests for reviewFileKey / splitReviewFileKey covering bare paths, composite keys, slashes/spaces in paths, repo names containing slashes, and full round-trip. Asks were repeated across five review rounds; the round-trip coverage is what catches the FILE_KEY_SEP NUL-vs-space class of bug at the type level. - mergeCumulativeFiles (api/git.go): shallow-copy each per-file payload before stamping repository_name + path so the source map isn't mutated. The previous code wrote directly into the per-repo result map, which would have permanently rewritten the original entry if any future caller iterated the same source twice. - buildRepoSpecs (executor_execute.go / executor_resume.go): drop the unused execCfg parameter (and the speculative "reserved for future per-repo config" suppression). Per repo overrides do not exist today and the speculative scaffolding masked an actual dead arg. * docs(readme): mention multi-repository task support * fix(web/topbar): drop standalone ahead/behind badges (duplicate of split button) The Create PR / Push button already shows the inline ↑N ↓N counts, so the separate "3 ahead" / "2 behind" badges next to the PR icon were just visual noise. Removes the GitAheadBehindBadges component (now unused) and the gitStatus / isMultiRepo prop chain that fed it. * fix(github): heal legacy repository_id='' rows on github_task_prs A task that pre-dated the multi-repo schema kept its github_task_prs row with repository_id=''. After the schema migration, a subsequent sync would resolve the task's primary repository_id and CreateTaskPR with the new value -- but GetTaskPRByRepository(task, repo) returned nil because the legacy row had an empty repository_id, so the new code inserted a duplicate row instead of updating the legacy one. Net effect: two rows for the same PR, surfacing as a "+2" PR badge on a single-repo task. Adds backfillTaskPRsRepositoryID, run on schema init right after migratePRTablesForMultiRepo: 1. Dedup pass: when a (task, owner, repo, pr_number) tuple has both a legacy (repository_id='') and a per-repo row, drop the legacy one. 2. Backfill pass: any remaining empty-repo rows get stamped with the task's primary repository_id from task_repositories. The backfill is gated on task_repositories existing -- github-store unit tests init only this package's schema, and the dedup pass alone is the load-bearing fix for the symptom. Tests cover the dedup path, the cross-package-skip path, and idempotency. * test(github): cover UPDATE backfill path for orphan legacy rows Adds TestBackfillTaskPRsRepositoryID_BackfillsOrphanRow per claude review feedback. The two prior tests cover the DELETE dedup path and the early-exit when task_repositories is absent, but the UPDATE path that stamps the primary repository_id onto an orphan legacy row had no coverage -- a wrong column name or off-by-one WHERE would have slipped through silently. * feat(web/changes-panel): group PR Changes by repository Multi-repo tasks now have one TaskPR per repo, but the PR Changes section was still rendering files flat using only the primary PR. Adds useActiveTaskPRsWithFiles, which fans out one WS request per TaskPR and tracks each fetch by (owner/repo/pr_number/last_synced_at) so a server-side sync invalidates the cache. Each PR's files are stamped with the resolved repository_name (looked up from the workspace repos slice), and PRFilesGroupedList groups by that name -- mirroring how Commits and Changes already render. Single- repo tasks (one group, empty name) still render flat. Mechanics: - PRChangedFile gains an optional repository_name. - mapPRFilesToChangedFiles takes a repository_name and stamps it. - New PRFilesGroupedList + PRFilesRepoGroup live in changes-panel-pr-files.tsx so changes-panel-timeline.tsx stays under the 600-line cap; PRFilesSection delegates to them. - Hook uses refs (not state) for the in-flight / fetched dedup so setState is only called when results arrive. - Stable EMPTY_PRS sentinel avoids the new-array-each-render trap that would re-trigger every effect downstream. - Workspace repo lookup memoised once via useMemo so the merged file list isn't rebuilt on every render. * fix(web/changes-panel): show per-repo PR header when task is multi-repo Previous logic only stamped repository_name on PR files when prs.length > 1 (2+ PRs). For a multi-repo task with only ONE PR yet (one repo doesn't have a branch / hasn't been pushed), no per-repo header rendered, even though STAGED and COMMITS already grouped under their repo names. Now gates the stamp on the task itself being multi-repo, matching how the other sections decide. * fix(executor): serialise concurrent LaunchPreparedSession per session Two paths in task_operations.go call LaunchPreparedSession on the same session_id: 1. PrepareTaskSession spawns a background goroutine with launchWorkspace= true the moment a session is created (so file browsing works before the user clicks Start). 2. StartTaskWithSession runs a foreground launch when the agent is actually started (workflow auto-start, user click). Without serialisation both reach agent_manager.LaunchAgent in parallel. The fast-path check at the top of LaunchPreparedSession (session.Agent ExecutionID != "") only kicks in once the first call has *persisted* its execution id; the second call grabs a stale snapshot, runs the full env-prep + builds runtime, then loses the executionStore.Add race and fails with "already has an agent running (race resolved during register)". Visible in the UI as "Environment setup failed". Multi-repo amplifies the window because env prep runs sequentially per repo (~2x the time for two repos), so what was a rare flake on single-repo became consistent on multi-repo tasks. Fix: acquire the per-session lock (the same sync.Map used by the resume path) at the entry of LaunchPreparedSession and re-fetch the session under the lock so the fast-path check sees the AgentExecutionID the first holder just persisted. Second caller now takes the existing- workspace path and starts only the agent subprocess, matching the intended single-launch semantics. Adds TestLaunchPreparedSession_SerialisesConcurrentLaunches that fires two concurrent LaunchPreparedSession calls with the first one blocked inside LaunchAgent. Without the lock, both reach LaunchAgent and the test fails with call_count == 2; with the lock only the first does. * fix(orchestrator): per-repo push detection so each repo's PR gets associated Multi-repo tasks would only get one PR detected per task: the agent pushes branches in BOTH repos, but the pushTracker keyed by sessionID alone meant agentctl's per-repo git status events overwrote each other's ahead counts. Whichever repo's events interleaved unfavourably lost its >0 -> 0 transition and silently dropped its push detection. Net effect: only the first/last repo's PR got an associated TaskPR row; the other PR existed on GitHub but Kandev never knew about it. Fix: - pushTracker is now keyed by "<sessionID>|<repository_name>" so each repo's transitions are tracked independently. Empty repository_name preserves the legacy single-repo behaviour. - trackPushAndAssociatePR forwards data.Status.RepositoryName to detectPushAndAssociatePR. - detectPushAndAssociatePR resolves owner/name/repository_id for the specific repo via new resolvePushRepo helper (looks up the task's task_repository whose repository.Name matches the event), then uses GetPRWatchBySessionAndRepo to scope the existing-watch check. - New associatePRFromPushScoped takes the per-repo repository_id directly instead of always resolving the primary one. CheckSessionPR (manual "check now") wired through the same scoped helper. Existing tests pass with the explicit empty repository_name argument. The user's existing task with the missing kandev PR row needs a manual push retrigger or DB heal — the migration only deduped legacy empty rows; this fix prevents the gap from recurring on future tasks. * feat(web): one PR button per repo in topbar + per-PR detail panels PRTopbarButton previously rendered just the primary TaskPR via useActiveTaskPR(), so multi-repo tasks with N PRs only surfaced one. Switch to useTaskPR(activeTaskId).prs and render one button per PR -- each opens its own dockview panel keyed by owner/repo/pr_number. Plumbing: - dockview-store / dockview-panel-actions: addPRPanel(prKey?: string) builds id "pr-detail|<key>" when a key is supplied; the legacy single-repo "pr-detail" id stays for the auto-add path. - dockview-desktop-layout: forwards `params` to PRDetailPanelComponent so the panel can receive its prKey. - pr-detail-panel: new prTaskKey helper + the panel looks up the matching TaskPR from the per-task list when params.prKey is set, falling back to useActiveTaskPR() for legacy panels and tooltips. - pr-topbar-button: rewritten to render a button per PR, each labelled with #pr_number and tooltipped with owner/repo + title; click opens the per-PR panel. * feat(web): collapse multi-PR topbar to a dropdown + show every PR in the + menu Two follow-ups on top of per-PR panels: - The dockview "+" panel-add menu still listed only state.pr (the primary TaskPR), so a 2-repo task only offered "PR #2" -- never the kandev one. Switch to state.prs[] and render one menu item per PR; multi-repo rows are labelled "PR #N -- repo" so the user can tell them apart. Each item opens its own panel via addPRPanel(prTaskKey(pr)). - The topbar grew one outline button per PR after the previous commit, which doesn't scale (3+ PRs would crowd out other actions). Single PR keeps the existing single-button rendering; 2+ collapses to one outline button labelled "N PRs" with the aggregated status colour (red if any failing, etc.) and a dropdown listing each PR with repo, number, title, and per-PR status icon. Click an item -> open that PR's panel. useLeftHeaderState now reads useTaskPR(taskId).prs and forwards the full list through AddPanelMenuState as `prs`. * fix(web/changes-panel): PR files arrive after race-cancelled fetch useActiveTaskPRsWithFiles dropped responses from the previous effect instance via a `cancelled` flag, but since the dedup tracking refs (inFlightRef / fetchedRef) carry across renders, the next effect's early-continue still saw the key in inFlightRef and skipped a fresh request. The ref then got populated by the cancelled response and fetchedRef permanently locked the key out of any future fetch. Net effect: every render after the first prs reference change left the merged prFiles array empty -- the PR Changes section never showed up on multi-repo tasks even though both PRs existed and the WS request would have returned files. Drop the cancellation flag entirely. Per-key dedup is enough to prevent duplicate requests, and the .then handlers use functional setState so they're safe to land after the effect re-runs. * test: cover review-feedback gaps (mapPRFilesToChangedFiles, push multi-repo, lock test channel-sync) Three follow-ups from claude review on PR #767: 1. apps/web/components/task/changes-panel-helpers.test.ts: 5 new tests for mapPRFilesToChangedFiles. Covers status mapping (added / removed / renamed / modified / fallback), forwarding of plus/minus/oldPath, and the new repository_name stamping behaviour (multi-repo path stamps every row; single-repo path defaults to "" so PRFilesGroupedList skips per-repo sub-headers). 2. event_handlers_github_test.go: TestDetectPushAndAssociatePR gains two multi-repo cases. resolvePushRepo must scope CreatePRWatch + AssociatePRWithTask to the repository_id matching the event's repository_name (not silently fall back to primary); unknown repository_name must drop the event rather than mis-associate. mockGitHubService captures lastCreateWatchRepositoryID / lastAssociateRepositoryID so the per-repo scoping is asserted directly. 3. executor_test.go: TestLaunchPreparedSession_SerialisesConcurrentLaunches replaces the time.Sleep(50ms) coordination with a buffered `entered` channel + bounded select wait per CLAUDE.md. The test now waits for the first launch to enter LaunchAgent, then asserts no second entry arrives within a 100ms window — without the lock the second goroutine reaches LaunchAgent in microseconds, so the timeout serves as the "didn't race in" oracle, not a synchronisation primitive. * fix(orchestrator): detect push when first poll lands post-sync trackPushAndAssociatePR only fired on a >0→0 ahead transition, which required two distinct status events to be observed. In multi-repo tasks, any repo whose first agentctl status poll happened to land after the push had already completed (ahead=0 with remote branch set on the very first observation) silently dropped the push event — the watch was never created, the PR never associated. Reproduced on task 4fdff41b-095a-4158-a311-4a1a23abe064 where 2/3 repos pushed but only one PR appeared. Now also fire on first observation when the status already reflects a post-push state (ahead=0 + RemoteBranch set). detectPushAndAssociatePR is idempotent against an existing watch, so a spurious fire on a worktree that started from an already-synced remote just costs one GitHub FindPRByBranch call. The deferred pushTracker.Delete in detectPushAndAssociatePR is removed: keeping ahead=0 stored is what suppresses repeated firing on subsequent status events. Cleanup now happens at session-delete time via a new pushTrackerForget helper that walks all (session|repo) entries. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(web/topbar): restore pr-topbar-button testid for single-PR case The multi-PR refactor renamed PRSingleButton's testid from pr-topbar-button to pr-topbar-button-${pr_number}, breaking E2E tests that relied on the stable selector (task-topbar-overflow.spec.ts and the prTopbarButton page-object helper used by vcs-button-context). Restore the canonical testid and expose pr_number via data-pr-number for any test that needs to discriminate. PRMultiButton already uses the same testid; with at most one PR-area control rendered at a time, sharing the testid is unambiguous. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(orchestrator): create one PR watch per repo on multi-repo tasks The orchestrator only ever ensured a watch for a task's PRIMARY repository. Both call sites that create watches were primary-only: - ensureSessionPRWatch (called when a session starts/resumes) used resolvePrimaryTaskRepositoryID and made one EnsurePRWatch call. - buildTaskBranchList (used by the poller's reconciler) keyed dedup by sessionID alone, so as soon as the primary repo got a watch the whole session was marked "watched" and the poller skipped every other repo. Result: in a multi-repo task, the secondary repos never got a watch row, so the periodic GitHub poller never searched for their PRs and never associated them. Push detection (which fires on >0→0 ahead transitions vs origin/main) doesn't help here either because Ahead is measured against the integration branch, not the upstream tracking branch — pushing doesn't change Ahead. Reproduced on task a7a59bd8: PRs existed on github for both kandev and aistats, but only the primary (kandev) was associated. Refactor: - resolveSessionWatchTargets walks task_repositories × session worktrees and returns one (repo_id, owner, repo, branch) target per repo. Branch priority preserves the legacy precedence (checkout_branch > primary fallback > worktree branch) so PR- review-style synthetic worktree names don't clobber the real one. - ensureSessionPRWatch loops over targets and ensures one watch per repo. - buildTaskBranchList emits one TaskBranchInfo per (session, repo) and dedups against (session_id, repository_id) pairs from ListActivePRWatches — replacing the old session-only dedup that suppressed non-primary repos. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-02 20:26:42 +01:00
José Almeida	396325b2c9	feat: allow reordering sidebar views (#764)	2026-05-01 23:50:05 +01:00
Carlos Florêncio	e16debeaca	fix(preview): server-authoritative session ensure for kanban preview (#760)	2026-05-01 18:01:17 +01:00
Carlos Florêncio	9f1e372967	feat: refresh + smarter filter for new-task branch selector (#750)	2026-05-01 13:24:12 +01:00
João Salavisa	5693c10d8c	feat(jira): poll JQL queries to auto-create tasks (issue watchers) (#746) ... * feat(jira): poll JQL queries to auto-create tasks (issue watchers) * fix(jira): address review feedback on issue watcher - Poller: gate per-watch by `LastPolledAt` + `PollIntervalSeconds` so the user-configured cadence actually applies (was silently ignored, every watch polled every 5 min). Tick interval reduced to 60s to match the smallest valid per-watch interval. - Service: validate `pollIntervalSeconds` against the documented 60-3600s bounds on create/update so the UI's range check is enforced server-side. - Service: stamp `last_polled_at` via a fresh `context.Background()` with a short write deadline; the poller's ctx may be cancelled at shutdown, which would otherwise drop the timestamp on the floor. - Service/store: replace per-ticket `HasIssueWatchTask` round-trips with a single `ListSeenIssueKeys` set lookup (up to 50× fewer DB queries per tick on broad JQL queries). - Hook: reset cached watch list on workspace switch — the store's `loaded` flag is global, so without this the table renders the previous workspace's watchers stale. - Section component: pull the CRUD callbacks from a single `useJiraIssueWatches` call and pass them down, instead of invoking the hook twice on the same workspace. - Dialog: add the three placeholders (`{{issue.type}}`, `{{issue.reporter}}`, `{{issue.project}}`) supported by the backend interpolator but missing from the help text. * fix(jira): repair workspace-switch refetch + drop double trigger toast The previous a9bd9fa attempt at the workspace-switch reset was incomplete: `setJiraIssueWatches([])` flips `loaded=true`, so the fetch effect's `if (!workspaceId || loaded || loading) return` guard still short-circuited and the new workspace's data was never fetched. Switching workspaces left the table empty with no recovery path. - Add a dedicated `resetJiraIssueWatches` action that zeroes both `items` and `loaded`, and use it from the hook's workspace-change effect. - Drop the inline "Checking JIRA…" toast in the watcher table — the parent's `wrappedTrigger` already fires a result toast on completion, so the click was double-toasting. * fix(jira): reject empty workflowId/workflowStepId on issue-watch PATCH `applyIssueWatchPatch` writes the field whenever the patch pointer is non-nil, but Go's JSON decoder returns a non-nil pointer to "" for an explicit `{"workflowId": ""}` body. The post-patch JQL check guarded against the same hole for `jql`; this extends it to the workflow fields. Without it, a stripped row would silently drop every event the orchestrator tries to handle (the watcher looks active but produces no tasks). * fix(jira): require workspace ownership on issue-watch mutate/trigger The PATCH/DELETE/trigger handlers looked up watches by the path :id with no workspace check, while the list/create handlers correctly required workspace_id. A user authenticated to workspace A who learned a watch UUID from workspace B could mutate it, delete it, or trigger it (running JQL with workspace B's stored credentials and creating tasks there). Closes the IDOR by: - backend: PATCH/DELETE/trigger now require ?workspace_id=... and 404 on mismatch (404 not 403, so probing can't enumerate IDs across workspaces). - frontend: api client + hook thread workspaceId through all mutation calls. - store: drop the no-longer-used HasIssueWatchTask method (replaced by ListSeenIssueKeys after the N+1 fix); test now asserts via the bulk-fetched set. --------- Co-authored-by: Kandev Agent <agent@kandev.dev>	2026-05-01 11:01:02 +01:00
José Almeida	89332e1cbb	fix: render passthrough terminal in quick chat (#744) ... * fix(backend): start agent immediately for passthrough quick-chat sessions Passthrough profiles need a running PTY for the terminal to attach. When launchPrepare is called with a passthrough profile, upgrade the request to launchStart so the PTY exists by the time the frontend renders the terminal. * fix(web): render passthrough terminal in quick chat for passthrough profiles Quick chat used MessageList + ChatInputArea unconditionally, so passthrough profiles showed an empty chat with no agent output (PTY never attached). Render PassthroughTerminal when the active session is passthrough, mirroring the task-page branch. Passthrough is detected via session.is_passthrough or, before WS hydrates, via the agent profile's cli_passthrough flag — looked up through a new agentProfileId stored on quickChat session entries (set by the picker on selection and seeded by SSR for restored sessions). * style(web): apply prettier formatting * fix(web): address review feedback on quick-chat passthrough rendering - Narrow `metadata.agent_profile_id` to string at runtime via a `readAgentProfileId` helper instead of a blind type cast. - Collapse `useIsQuickChatPassthrough` into a single `useShallow` selector to avoid three separate store subscriptions. * fix(backend): prevent launchPrepare ↔ launchStart recursion for passthrough When passthrough quick-chat sessions hit a workflow step that blocks auto-start, launchStart's downgrade to launchPrepare would have re-upgraded back into launchStart and looped forever. Skip the passthrough upgrade when AutoStart=true, since that flag uniquely identifies the downgrade path. Adds tests for `isPassthroughProfile` and a regression test that runs the launchStart→launchPrepare path under a deadline so future recursions surface. * test(web): cover existing agentProfileId preservation on reopen * style(web): apply prettier formatting * test(backend): seed task with blocked workflow step in recursion regression Without persisted task and step, shouldBlockAutoStart short-circuited to false, the test bypassed the launchStart→launchPrepare downgrade entirely, and removing the recursion guard would still pass. Seed the task with a WorkflowStepID mapping to a step lacking auto_start_agent so the guard is the only thing preventing the bounce. Verified by temporarily removing the guard — the test now times out as expected. * test(backend): cover ResolveAgentProfile error path in isPassthroughProfile	2026-04-30 18:36:26 +01:00
João Salavisa	3d2a04e776	feat(orchestrator): deferred task move with hand-off prompt + boot/turn-end event split (#743) ... * feat(orchestrator): reuse existing same-profile session on workflow step switch When a workflow step transition needs a different agent profile, look up an existing session on the same task that already uses the target profile and promote it back to primary instead of creating a fresh one. Reuses COMPLETED and FAILED sessions (CANCELLED stays excluded — explicit user stops shouldn't be auto-revived). Backend (event_handlers_workflow.go): - findReusableSessionForProfile: most recently updated session matching the target profile, skipping CANCELLED. - reuseSessionForStep: promotes the session to primary; if terminal, revives via reviveReusedSession. - reviveReusedSession: distinguishes "previously launched" (has executors_running record -> flip to WAITING_FOR_INPUT, lazy-resume via ResumeSession with stored token) from "never launched" (no record -> flip to CREATED so autoStartStepPrompt routes through StartCreatedSession for a full fresh launch). Clears stale ErrorMessage/CompletedAt so the UI stops surfacing prior failures. - createNewSessionForStep + completeAndStopSession: shared helpers. Backend (task_operations.go): - StartCreatedSession no longer calls processOnTurnStartViaEngine. User-initiated messages already fire on_turn_start in dispatchPromptAsync. Workflow-driven auto-start prompts arrived because the workflow just transitioned us into this step via on_turn_complete; firing on_turn_start again cascades the workflow back out and the redirect-to-active-session logic delivers the prompt to the wrong session's agent. Frontend (web): - task.updated handler follows focus to the new primary when the user is viewing the task and was sitting on the previous primary. - pinnedSessionId tracks user-initiated session selection (setActiveSession sets it; setActiveSessionAuto leaves it alone). The terminal-handoff branch in maybeAdoptSessionOnTransition skips replacement when the terminating session matches the pin, so manually clicking a session no longer yanks focus back to the workflow primary each time the pinned session terminates. Tests: - TestSwitchSessionForStep_ReusesExistingProfileSession (never-launched). - TestSwitchSessionForStep_ReusesPreviouslyLaunchedSession (launched). - TestSwitchSessionForStep_ReusesFailedSession (FAILED reuse + cleanup). - tasks.test.ts: focus-follow behavior across 4 scenarios. - agent-session.test.ts: pinnedSessionId guard plus migration to setActiveSessionAuto for WS-driven adoption. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(orchestrator): deferred task move with hand-off prompt + boot/turn-end event split Adds move_task_kandev MCP tool that lets a workflow agent (e.g. QA at "Review") move a task to another step with a prompt for the receiving agent. The move is queued as a PendingMove and applied on the calling agent's turn-end so on_enter processing doesn't race the still-running turn. Also splits agent.ready into agent.boot_ready + agent.ready at the lifecycle layer. Previously both signals shared one event and the orchestrator disambiguated them via a resumeInProgressSessions flag — which had a race when the boot signal arrived before persistResumeState wrote state=STARTING, causing the boot to fire on_turn_complete against the just-revived step and ping-pong the task forward through the workflow. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix: address PR #743 review feedback (Greptile + CodeRabbit) Backend: - isTransientPromptError no longer treats ErrExecutionNotFound as transient, preventing executeQueuedMessage from infinite-requeueing on permanent missing-execution errors. autoStartStepPrompt's explicit errors.Is check before the transient branch keeps the recovery path working (Greptile P2 #1) - applyPendingMove drains the orphaned hand-off prompt on ApplyTransition failure so it can't be misdelivered to the source step on a future turn (Greptile P2 #2) - handleMoveTask returns errors instead of panicking when messageQueue is nil; queueMoveTaskPrompt returns an error so the deferred path fails fast if the queue can't accept the prompt (CodeRabbit CR-2) - handleMoveTask rejects when no primary session exists and a hand-off prompt is required, instead of silently dropping it (CodeRabbit CR-3) - autoStartStepPrompt preserves attachments from queued messages (was: silently dropped); attachment-only messages are no longer skipped; the fallback path also forwards attachments (CodeRabbit CR-5) - applyPendingMove reinserts the pending move on early failure paths (config missing, task/step load errors) so a future turn-end retries naturally (CodeRabbit CR-6) - registerKanbanTools split into 3 helpers (list/profile/task) to satisfy backend function-size lint limits (CodeRabbit CR-1) Web: - maybeAdoptSessionOnTransition's auto-adopt path also checks pinnedSessionId to handle the reverse-event-ordering race (old COMPLETED arrives before new STARTING) — pinned sessions are no longer yanked off the user. Regression test added (CodeRabbit CR-7) Tests: - mockAgentManager records (executionID, prompt) pairs; new helper capturedPromptsForExecution actually filters by exec ID instead of returning all captured prompts (CodeRabbit CR-4) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(web): respect pinned session in primary-follow-focus path When the user clicks a session, setActiveSession sets pinnedSessionId. If a workflow profile switch then updates the task's primarySessionId while the user happens to still be on the previous primary, the focus-follow block in tasks.ts was calling setActiveSessionAuto(taskId, newPrimary) and silently overriding the explicit pin. Add pinnedSessionId !== previousPrimary as a fifth condition. Regression test in tasks.test.ts covers exactly this sequence. Addresses Greptile P1 on PR #743. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix: address CodeRabbit review on PR #743 (3 new comments) - handleMoveTask idle path now rolls back the queued hand-off prompt when taskSvc.MoveTask fails, so a "you were moved..." message can't be delivered on a future turn for a transition that didn't actually happen. Added TakeQueued to the MessageQueuer interface to support this. - lookupSession now returns (*models.TaskSession, error) so callers can distinguish a backend lookup failure from a legitimate "no primary session" state. handleMoveTask maps the error case to ErrorCodeInternalError instead of collapsing it into ErrorCodeValidation. - queueMoveTaskPrompt returns errors instead of log-and-continue (signature change already shipped); existing tests updated to reflect the new contract. - Refactored TestPendingMove_ReviewToInProgress_OneTransitionOnly: the ~280-line monolithic test is now split into a pendingMoveScenario builder + assertion helpers, each well under the 80-line / 50-statement lint limit. All 14 review threads resolved. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix: relax move_task_kandev prompt requirement; fix CI lint CI surfaced two issues after rebasing onto main: - nestif lint warning on autoStartStepPrompt's queued-message merge block. Extracted the take-and-merge logic into takeAndMergeHandoffMessage helper, flattening the nested conditionals. - E2E test settings/config-management 'agent can move a task to a different step' failed because my CR-3 fix made the move_task_kandev prompt parameter required. That broke admin/config-mode moves where there's no agent to hand off to. Made prompt optional: when supplied AND the source session is mid-turn, the deferred-move flow runs (queue prompt + record PendingMove); otherwise just move the task. Refactored handleMoveTask into deferMoveTaskWithPrompt and applyMoveTaskImmediate to keep each function under the 80-line lint limit. Tool descriptions in mcp/server/server.go and mcp/server/config_handlers.go updated to reflect prompt's now-optional status. moveTaskHandler in config_handlers.go forwards prompt only when set. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(mcp): treat 'no primary session' as a not-found, not an internal error GetPrimarySessionByTaskID returns a plain error string ("no primary session found for task: <id>") when the repo has no rows. My CR-B refactor was treating ALL lookup errors as ErrorCodeInternalError, which broke the E2E test 'agent can move a task to a different step' (config-mode move on a freshly-created task that has no agent yet). Match the not-found message and return (nil, nil); only real backend failures bubble up as InternalError. Distinguishing properly with errors.Is would require an exported sentinel that doesn't exist; matching the noRowsErr substring is the pragmatic fix. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>	2026-04-30 18:17:36 +01:00
José Almeida	12bd5b2cf3	feat: plan checkpointing with rewind UI (#694) ... * feat(backend): plan revision history with checkpoint/revert Persist every plan edit as an immutable TaskPlanRevision with author attribution (agent vs user) and expose WS actions to list, fetch, and revert to past revisions. Emits task_plan.revision.created and task_plan.reverted events so the UI can react in real time. * feat(web): plan revision history UI with rewind to past versions Add a rewind button to the plan panel that opens a revisions list showing each checkpoint with author (agent name or user) and timestamp, and lets the user restore any past revision as the new head. Plan state, hooks, and WS handlers are extended to load, cache, and react to revision-created/reverted events. * test(web): e2e coverage for plan checkpointing and rewind Cover the full revision flow: plan edit creates a checkpoint, the revisions panel lists authors and timestamps, and reverting restores the selected revision as the new head. Extends session page object and backend fixtures with revision-related helpers. * fix(web): stabilize plan revisions state and avoid re-render loop Zustand selector returned a fresh [] for missing revisions, fanning out re-renders that tripped React's infinite-loop guard when the plan panel mounted. Swap to a frozen empty-array sentinel, auto-load revisions on mount so WS events fired before connect aren't lost, and gate the popover's on-open fetch so reopening doesn't re-sort rows mid-click. * test(web): make plan checkpointing e2e resilient to agent auto-layout Agent-authored plan writes auto-open the plan panel and can push the chat tab inactive, so the chat idle placeholder isn't always visible once the agent finishes. Accept either chat or plan panel as the idle signal, make openPlanPanel and openRewind idempotent, reopen the popover after a revert cancel (the confirm dialog closes it), and drop the toast assertion since no Toaster is mounted in the app. * fix(backend): atomic plan revision write + review polish - Add `WritePlanRevision(ctx, head, rev, coalesceLatestID)` repository method that wraps HEAD upsert + MAX+1 compute + insert/merge in a single write tx, closing the TOCTOU race on `revision_number` and partial-failure divergence between HEAD and history. `upsertPlan` and `RevertPlan` both route through it. - Add `ErrRevisionIDRequired`; return it for empty `TargetRevisionID` (was previously conflated with `ErrRevisionNotFound`). Handler maps to validation. - Backfill fallback `author_kind` changed `"user"` → `"agent"` to match `CreateTaskPlan` and the column default. - Extract shared `revisionSelectCols` constant; rename `max` local (shadowed Go builtin) and `dto` local (shadowed package name). * fix(web): address plan-revisions review feedback - `mcpWrite` uses `JSON.stringify(content).slice(1, -1)` to escape backslashes, quotes, and control chars in one pass — closes the CodeQL finding. - `clearTaskPlan` now evicts `revisionContentCache` entries for the task's revisions before dropping the maps, preventing orphaned cache growth. - `RevertConfirmDialog` wraps `onRevert` in try/catch/finally so rejections surface a toast and the dialog always dismisses. - Hoist `TaskPlanRevision` import in `task-plan-panel.tsx`. - `RevisionRow` derives relative time from props every render with a 30s tick, so prop changes refresh immediately. - Strengthen author-switch e2e with `.not.toBeEmpty()` to also reject empty or truncated renders. * fix(web): evict revision content cache on coalesced update Coalesced writes update an existing revision's content on the backend, but the WS `upsertPlanRevision` payload carries only metadata. Without eviction, a cached preview of the revision stays stale after the agent re-writes the plan within the coalesce window. * fix(web): plan history UI polish from local testing - Drop the redundant "Plan" title in the panel header bar; the dockview/mobile tab already labels the panel. - Author display: show "You" with the user icon for user-authored revisions, and the agent profile name with the AgentLogo (resolved from the active session's `agent_profile_snapshot.agent_name`) for agent revisions, matching the icon used elsewhere in the app. - Replace ScrollArea with a plain `max-h-96 overflow-y-auto` div so the popover stays bounded when revision counts grow past ~7 rows. - Drop the em dash from the revert dialog description. * feat(web): add lineDiff helper for plan revision compare Tiny wrapper around the `diff` package that classifies each line as add / remove / context and strips the trailing-newline phantom entry. Also exposes `diffSummary` for the dialog header counts. Pure functions; backed by Vitest. * feat(web): plan revision preview + compare state Adds two task-scoped store keys for the new dialogs: - `previewRevisionIdByTaskId` — at most one open preview per task; cleared on `clearTaskPlan`. - `comparePairByTaskId` — ordered 2-slot pair. `toggleComparePair` reuses a `nextPair` helper that handles unselect (already-picked id), fill (open slot), and FIFO eviction (full pair). `clearTaskPlan` resets it too. * feat(web): plan revision preview + diff dialogs - `useTaskPlan` exposes `previewRevisionId`, `setPreviewRevision`, `comparePair`, `toggleCompareSelection`, `clearComparePair` (extracted into `usePreviewCompareState` to keep the surrounding hook within the size cap). - New `PlanRevisionPreviewDialog`: read-only modal for a single revision with Restore + "Compare with current" CTAs. Restore routes through the existing RevertConfirmDialog so the confirmation copy stays consistent. - New `PlanRevisionDiffDialog`: line-level unified diff between two revisions with adds/removes highlighted; orders the pair by revision_number so the older one is always "before"; Restore targets the older side. - Popover row split into a clickable body (opens preview), a Compare toggle (icon button per row), and the existing Revert button. Compare chips appear at the top of the popover with a Diff CTA when both slots are filled. - Both dialogs are remounted via key on revision/pair change so loader state resets without ESLint-flagged setState-in-effect resets. * test(web): e2e coverage for plan preview and compare-diff dialogs Extends the SessionPage POM with locators for the new preview and diff dialogs (chips, compare toggle, restore buttons, body + summary). Adds two scenarios in plan-checkpointing.spec.ts: - Click a revision row body → preview shows the right content; the Restore CTA opens the existing confirm dialog and the revert lands. - Toggle compare on two revisions → diff opens with v1 → v2 ordering and shows at least one add and one remove line; the Restore CTA targets the older side. * feat(web): render markdown in plan preview + diff dialogs Adds a shared `PlanReadOnlyMarkdown` Tiptap renderer that reuses the same StarterKit + tiptap-markdown + tables/tasks/code-block extensions as the live plan editor (minus interactive bits — slash menu, drag handles, comment marks). Wired into both dialogs: - Preview replaces the raw `<pre>` block with the rendered Tiptap view. - Diff dialog now stacks two rendered sides (Before / After) with red/green tinted borders, kept above the existing line-level breakdown so the user gets both rendered comparison and an exact textual change list. Tiptap doesn't ship a free diff/track-changes extension (it's part of Tiptap Pro), so the side-by-side rendering plus the line-level list together stand in for that. * fix(web): plan diff dialog — text-only with unified/split modes Following local feedback: - Drop the rendered-markdown side-by-side panes from the diff dialog. Diff view is text-only again, like a code review. - Add a Unified / Split mode toggle. Split mode aligns each remove with the adjacent add on the same row (single-line edits stay paired) and stripes empty cells where one side has nothing. - Fix the highlight-truncation bug: long lines used to lose their tinted background past the viewport on horizontal scroll because the row width was capped to the visible area. Rows now use `min-w-full w-max` so the background extends through the full scroll width. Preview dialog keeps the rendered Tiptap markdown — only the diff reverted to plain text. E2E covers both modes and the cell kinds. * feat(web): formatPreciseTime util for minute-level timestamps Returns 'just now', 'Xs ago', 'Xm ago' for the first hour, then 'Today, HH:MM', 'Yesterday, HH:MM', or '{Mon} {DD}[, YYYY], HH:MM' for older entries — keeps exact minute-of-day visible instead of decaying to 'yesterday'/'2d ago'. * fix(web): render markdown via setContent in plan read-only renderer The tiptap-markdown extension's parser only fires on `setContent` calls, not on the initial `content` option. Passing `content: value` to `useEditor` was treating the markdown source as raw text, so the preview dialog rendered unparsed markdown. Drop the `content` option and instead call `editor.commands.setContent(content, { emitUpdate: false })` from a useEffect once the editor is created — which is what the live plan editor effectively relies on through tiptap-markdown's setContent override. * fix(web): plan history UX — bigger modals, split layout, simpler compare - Bump dialog widths: preview now `max-w-5xl w-[92vw]`, diff `max-w-6xl w-[95vw]`, both with taller max-height. Plenty of room for rendered markdown and side-by-side diffs. - Replace the table-based split layout with a CSS grid (`grid-cols-2 w-max`). The table-fixed cells were overflowing into each other when content was wider than half the dialog; the grid lets the natural width drive a single horizontal scrollbar on the parent and keeps the two columns properly separated. - Switch row timestamps to `formatPreciseTime` so users see minute-of-day ("Today, 14:32", "Yesterday, 09:14", "Apr 21, 11:08") instead of decaying to "yesterday". - Simplify the compare flow: drop the per-row Compare toggle, the chip strip at the top of the popover, and the standalone "Diff" button. Compare is now a side effect of preview — open any version, then click "Compare with previous" or "Compare with current". E2E test updated to use the new path. * test(web): update plan checkpointing e2e for the new compare flow Drops the locators for the row Compare toggle, chips, and standalone Diff button (those UI bits are gone). Adds a locator for the new "Compare with previous" preview button. The compare scenario now opens the diff via preview → "Compare with current" instead of the old chip flow. * fix(web): preview renderer reuses live editor's markdown styles `globals.css` keeps heading sizes / list spacing / code-block padding under .markdown-body and .tiptap-plan-wrapper, and the live editor opts in by applying both classes (plus a conditional .dark for theming). The read-only renderer was using `prose prose-sm` instead, which doesn't actually take effect on the .ProseMirror node — leaving everything the same size. Switch the read-only renderer to the same class set, follow the live editor's `useTheme` -> `dark` pattern, override `!h-auto` so the renderer sizes to its content, and trim the editor's default 0.75rem padding inside the dialog body. * fix(web): split diff has fixed width with synced horizontal scroll The previous split layout grew the whole dialog wider when content overflowed which felt wrong. Now: - The dialog stays at its fixed width. - Each pane has its own `overflow-x-auto` so each side is capped at half the dialog and gets its own horizontal scrollbar. - A scroll listener keeps both panes' `scrollLeft` in lockstep (with a re-entrancy guard so the bounce-back doesn't form a loop) — corresponding rows stay aligned visually no matter which side the user scrolls from. - The diff body's overflow-x is hidden in split mode (the panes own it) and only overflow-y stays on the body so vertical scroll covers both panes at once. * feat(backend): resolve agent profile name from session for plan revisions The MCP-side handlers (handleCreateTaskPlan / handleUpdateTaskPlan) don't carry the agent's display name in the request, so without a lookup every agent-authored revision was rendering as the literal "Agent" fallback in the history UI. PlanService now looks up the task's session and reads the agent profile display name from `agent_profile_snapshot` (preferring "label", then "name", then "agent_display_name") when the request is an agent write without an explicit author_name. Active session is tried first; falls back to the most recent session by started_at so plans written between turns still get the right author name. If no usable session/snapshot exists, the existing "Agent" fallback applies. The repo dependency type is widened from `repository.PlanRepository` to a small private `planRepo` interface that adds the two session lookups — the SQLite repository (`*sqliterepo.Repository`) already implements both, so no caller wiring changes. * fix(web): plan history popover row + restore button polish - Popover content's default `gap-4` between flex children (from @kandev/ui's PopoverContent) was rendering as visible space above the top-most row. Override with `gap-0` so the list sits flush against the header. - Switch row layout from `items-start` to `items-center` so the Restore button stays vertically centered against the row body even when the body grows taller (timestamp + restored-from marker on revert rows). - Rename the per-row "Revert" button to "Restore" and prefix it with IconRestore so it matches the dialog wording and the restored-from marker icon. The data-testid stays `plan-revision-revert-button` for e2e selector stability. * fix(backend): plan revision review feedback + lint - `wsGetTaskPlanRevision` now returns a 400 validation error when `revision_id` is empty, matching `wsRevertTaskPlan`'s `ErrRevisionIDRequired` branch (was silently mapped to 404 via the service's lookup miss). - `agentDisplayNameFromSnapshot` tries `name` first, then `label`, then `agent_display_name`. The orchestrator's canonical key wins over any stale older `label` that may still be in a session snapshot. - Add `idx_task_plan_revisions_task_number` on `(task_id, revision_number DESC)`. `GetLatestTaskPlanRevision` runs on every plan write (coalesce check); the existing `(task_id, created_at)` index doesn't help since these queries order by `revision_number`. - Drop `Deprecated:` from `NextTaskPlanRevisionNumber`'s doc comment so staticcheck stops flagging the existing test usage. The TOCTOU caveat stays in the prose. * fix(web): plan revision review feedback, prettier, e2e resilience - `loadRevisionContent` reads `revisionContentCache` lazily through the store API inside the callback, so its identity stays stable. Selecting the cache map at the hook level was recreating the callback whenever any task's content was cached, retriggering downstream content-fetch effects. - `task.plan.reverted` WS event becomes a no-op handler. `task.plan.revision.created` fires for the same row first and already upserts; the duplicate handler was double-evicting the `revisionContentCache` entry and triggering an extra Zustand update. - e2e: agent author assertion now uses `not.toHaveText("You")` + `not.toBeEmpty()` instead of the literal `"Agent"` (which only matched the legacy fallback — agent rows now resolve to the profile display name). - e2e: `openPlanPanel` retries the toggle a few times after a page reload — the panel toggle can race hydration and silently no-op, which broke the persistence test. - Apply prettier to the files flagged by the formatting check. * fix(plan): toast on silent revert failure + revision ownership check - task-plan-revisions: when `onRevert` (the hook's `revertTo`) swallows the error and returns null, the dialog used to close silently with no feedback. Add an `else` branch that fires `toast.error("Failed to restore plan")`. - wsGetTaskPlanRevision: accept an optional `task_id` and reject with a 400 "Revision does not belong to task" when the loaded revision's task doesn't match. Mirrors `wsRevertTaskPlan`'s ownership check so a WS client can't read content for an arbitrary revision UUID outside the tasks it already holds a reference to. - plan-api `getPlanRevision` takes optional `taskId`; `loadRevisionContent` threads the active task id so the check is exercised on the happy path.	2026-04-27 10:22:58 +01:00
Carlos Florêncio	d431688557	feat(web): auto-open plan panel with unseen-changes indicator (#650)	2026-04-25 18:21:33 +01:00
João Salavisa	ccc62d9324	feat(github): configurable quick-action presets and PR branch checkout (#689) ... * feat(github): configurable quick-action presets and PR branch checkout - Add workspace-scoped action presets (icon, label, hint, prompt template) for PRs and Issues, editable from GitHub settings with reset-to-defaults. - When starting a task from a PR, check out the PR head branch directly in the worktree instead of branching off main. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(github): extract action-preset service to keep service.go under line limit Splits the preset CRUD methods out of the oversized service.go and applies prettier formatting to three frontend files flagged by CI. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(github): address review feedback on action presets - Prevent infinite refetch loop when fetching presets fails by tracking attempted workspaces in a ref instead of re-entering the effect on every loading-state change. - Drop unused savePR/saveIssue helpers from the hook; only save() is consumed. - Reorder the init spread in updateGitHubActionPresets/resetGitHubActionPresets so callers can't accidentally overwrite method/body. - Tighten the GitHubActionPreset.icon type with string & {} so known icon keys keep autocomplete. - Sharpen the eye-icon test to assert the exact IconEye mapping. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(github): address second round of review feedback - Seed preset editor drafts from current store state via lazy initializers so a warm mount shows the user's saved customisations instead of silently reverting to defaults when Save is clicked. - Guard Reset button with its own in-flight state to prevent double-firing. - Stop freezing resolved defaults into the stored row on a partial update; persist only what the store has for the untouched kind so future default improvements still reach those workspaces. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * refactor(github): tighten quick-actions editor UI Replace the stacked PR/Issue editors and multi-line preset cards with a tabbed layout and single-line rows. Each row shows icon · label · hint inline; an "Edit prompt" toggle reveals the template textarea only when needed. Drops the redundant section headings, up/down reorder buttons, and verbose template helper label (hint moved into the textarea placeholder). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * fix(github): widen icon select trigger so the icon is visible The icon select trigger had a fixed 40px width which the SelectTrigger's built-in chevron, padding, and icon gap all competed for, clipping the icon out of view. Drop the width override so the trigger sizes to its content. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>	2026-04-24 14:10:59 +01:00
Carlos Florêncio	e1d21e39a9	feat(web): collapse subtasks in sidebar (#662)	2026-04-23 18:40:58 +01:00
João Salavisa	c11a6bbfd2	feat(github): add issue watcher with task creation and auto-cleanup (#672) ... * feat(github): add issue watcher with task creation and auto-cleanup Add a GitHub Issue Watcher feature that polls for new issues matching configurable filters and automatically creates tasks for them. This complements the existing PR Review Watcher with the same patterns. Backend: - Issue watch CRUD (models, store, service, controller, WS handlers) - Poller integration with configurable intervals - Event-driven task creation via orchestrator - Repository resolution and worktree support for issue tasks - Auto-cleanup of tasks for closed issues (CleanupClosedIssueTasks) - GetIssueState client method across all implementations - Default branch auto-detection from cloned repo HEAD Frontend: - Issue watch settings UI (table, dialog, placeholders) - Issue link icon on task cards (green circle-dot) - API client, store slice, and hook for issue watches - SSR and WS hydration of issue metadata * fix: resolve golangci-lint errors (goconst, nestif, dupl) and prettier formatting * fix(github): fix issue watch update shape, trigger key, and label quoting - httpUpdateIssueWatch now returns the full IssueWatch object instead of {updated:true} so the frontend store correctly refreshes after edits - httpTriggerIssueWatch returns new_issues_found to match TriggerIssueResponse type; was returning new_issues so the toast count was always 0 - buildIssueFilter uses conditional quoting instead of fmt.Sprintf %q to avoid Go escape sequences in GitHub search qualifiers Co-authored-by: João Salavisa <undefined@users.noreply.github.com> * fix: resolve eslint warnings (max-lines-per-function, no-nested-ternary) * test(github): add issue watcher tests and fix review feedback - Add TestInterpolateIssuePrompt (4 cases: empty/all/none/partial) - Add TestCreateIssueTask (3 cases: skip/reserve+assign/release on fail) - Add TestShouldDeleteIssueTask (4 cases: open/closed+sessions/closed/error) - Fix WS response key new_issues -> new_issues_found - Fix fmt.Printf -> fmt.Fprintf(os.Stderr) in store.go - Add CleanupClosedIssueTasks call in WS trigger handler * fix: address PR review feedback and CI failures - Split test files to fix revive file-length-limit (service_test.go, event_handlers_github_test.go) - Add session checker guard in CleanupClosedIssueTasks - Normalize poll intervals on UpdateIssueWatch - Add cleanup call in TriggerAllIssueChecks loop - Log cleanup errors in controller and WS handler - Prefer refs/remotes/origin/HEAD in detectGitDefaultBranch - Add aria-label to issue task icon - Fix TypeScript type errors: add linkedIssues to GitHubSlice, fix hook exports, remove invalid imports * fix: split test files exceeding revive limit and clean up minor issues - Split service_test.go (883→779 lines): move TestTriggerPRSync_* to service_pr_sync_test.go - Split event_handlers_github_test.go (806→677 lines): move TestCreateReviewTask_* and helpers to event_handlers_github_review_test.go - Remove redundant s.taskSessionChecker nil-check inside shouldDeleteIssueTask (early guard at CleanupClosedIssueTasks already ensures it is non-nil) - Remove unreachable dead guard in detectAndPersistDefaultBranch (repo.DefaultBranch is always "" at that call site) - Fix bogus #0 issue badge in task-session-sidebar.tsx when issueNumber is absent Co-authored-by: João Salavisa <undefined@users.noreply.github.com> * fix: address Claude review — poll clamp and prompt injection - Handle v <= 0 in UpdateIssueWatch poll interval (fall back to default) - Remove {{issue.body}} from default template to prevent prompt injection - Update test expected output for new default template * fix: remove {{issue.body}} from frontend DEFAULT_ISSUE_WATCH_PROMPT Mirrors the backend fix — the UI pre-fills the prompt so the backend fallback was never reached. The placeholder stays in ISSUE_WATCH_PLACEHOLDERS for explicit opt-in. * feat(github): add isIssueWatch sidebar filter dimension Add isIssueWatch boolean to KanbanState, TaskSwitcherItem, and sidebar filter registry — mirroring the isPRReview pattern. Issue-watch tasks (created from issue_watch_id in metadata) can now be explicitly filtered in the sidebar, just like PR review tasks. Files changed: - sidebar-view-types: add isIssueWatch dimension - filter-dimension-registry: add Issue watch filter meta - apply-view: add isIssueWatch extractor - kanban types: add isIssueWatch field - TaskSwitcherItem: add isIssueWatch field - use-all-workflow-snapshots: derive isIssueWatch from metadata - ssr/mapper: derive isIssueWatch from metadata - task-session-sidebar: pass isIssueWatch, extract helpers to fix complexity * fix: correct deleteIssueWatch response type to match backend Backend httpDeleteIssueWatch returns {"deleted": true}; the frontend type was { success: boolean } — a mismatch with no functional impact (return value is ignored) but wrong per TypeScript contract. Co-authored-by: João Salavisa <undefined@users.noreply.github.com> * refactor: extract metadata helpers to shared lib/metadata-utils.ts - Move isPRReviewFromMetadata, isIssueWatchFromMetadata, and issueFieldsFromMetadata to a shared module to eliminate duplicate definitions (sonarjs/no-identical-functions). - Fix deleteIssueWatch response type: { success: boolean } -> { deleted: boolean } to match the actual backend response. * style: fix prettier formatting * test(web): add tests for isIssueWatch filter dimension and metadata-utils Co-authored-by: João Salavisa <undefined@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> * style: fix prettier formatting in test files * fix(github): cascade-delete issue watch tasks on watch deletion and add isPRReview to SSR mapper - DeleteIssueWatch now wraps in a transaction and deletes related github_issue_watch_tasks rows before removing the watch; prevents orphaned dedup rows accumulating after a watch is deleted - snapshotToState in mapper.ts now also sets isPRReview from metadata, matching the mapping already done in use-all-workflow-snapshots.ts Co-authored-by: João Salavisa <undefined@users.noreply.github.com> * style: extract duplicate string constant in metadata-utils test * style: extract repeated WS error strings into constants in handlers.go goconst min-occurrences: 3 — 'invalid payload' (6x) and 'id required' (4x) both exceed the threshold. Extract to package-level constants. Co-authored-by: João Salavisa <undefined@users.noreply.github.com> * style: extract repeated issue key strings into constants in event_handlers_github.go goconst min-occurrences: 3 — 'issue_number' (9x) and 'issue_watch_id' (5x) both newly introduced in this PR exceed the threshold. Co-authored-by: João Salavisa <undefined@users.noreply.github.com> * style: fix prettier formatting in metadata-utils test --------- Co-authored-by: Kandev Agent <agent@kandev.dev> Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: João Salavisa <undefined@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-04-21 17:32:46 +01:00
José Almeida	f6f45b5777	feat: add filter/group/sort and saved views to task sidebar (#644) ... * feat(web): add sidebar view types and apply-view engine Introduces the typed representation of a sidebar view (filter clauses, sort spec, group key) and the pure engine that applies a view to a list of tasks to produce a filtered, sorted, grouped result. * feat(web): add built-in sidebar view presets Provides the four shipped presets (All tasks, No PR reviews, Active, Archived). The 'No PR reviews' preset filters out PR-watcher tasks that would otherwise crowd the sidebar. * feat(web): persist sidebar views in ui store Adds sidebar view state to the ui slice with draft semantics for saved views, localStorage persistence of active view + user-created views, and root store wiring. * feat(web): add filter dimension registry and clause editor Registry of filterable task dimensions (status, workspace, workflow, task type, etc.) plus the primitive UI pieces — clause editor, sort picker, group picker, and a hook that supplies operator and value options for a selected dimension. * feat(web): add sidebar filter bar, popover, and view manager Composes the filter primitives into the user-facing surfaces: the top filter bar, the popover that hosts clause editing and sort/group selection, the chips that switch between views, and the manager for saving, renaming, and deleting user views. * refactor(web): extract NewTaskButton component Pulls the Create Task button and its command-palette registration into a standalone memoized component in preparation for reuse across sidebar surfaces. * feat(web): integrate filter/view system into task sidebar Wires the filter bar, view chips, and apply-view engine into the task sidebar (desktop and mobile sheet). Updates task-switcher to consume the grouped list from the engine and adds mock data for tests and previews. * test(web): add e2e coverage for sidebar filter/view system Page object for the filter popover plus Playwright specs covering built-in presets, clause editing, sort/group, saved-view draft semantics, and persistence across reloads. * refactor(web): trim sidebar built-in views to a single seeded default Drop the "No PR reviews", "Active", and "Archived" built-in view presets and the isBuiltIn protection flag. The sidebar now seeds a single "All tasks" view on first load; users can rename, overwrite, or delete it like any other view. Deletion is guarded against removing the last remaining view so the user can never lock themselves out. * fix(web): humanize executor type labels in sidebar filter and grouping The executor-type filter dropdown and group-by label were rendering raw backend identifiers like "worktree" and "local_docker". Route both through the existing getExecutorLabel() helper so the sidebar shows "Worktree" and "Local Docker" like the rest of the app. * feat(web): replace "Has PR" filter with "Is PR review" The old dimension matched any task with an associated PR, including tasks a user manually linked. The new dimension isolates tasks created by the GitHub PR-review watcher specifically, which is what the filter is useful for — hiding a wall of auto-generated review tasks. The flag is derived from the review_watch_id metadata key the backend already stamps onto watcher-created tasks, threaded through the kanban snapshot and into the sidebar TaskSwitcherItem. A small migration drops unknown dimensions (including the old "hasPR") from stored views so the popover does not crash when reading legacy data. * fix(web): tighten sidebar filter popover layout Reduce the popover width (w-96 → w-[22rem]), trim section padding (p-3 → p-2.5) and label margins (mb-2 → mb-1.5), and drop the "No filters applied." placeholder. Extract a shared SectionLabel to keep the three section headers visually aligned. * feat(web): show workflow step color dot in sidebar filter dropdown Surface the step color on the workflow-step filter's value dropdown so each option renders with the same coloured circle used elsewhere (task switcher, kanban column, command panel). Adds an optional color field on filter value options; only workflow-step options populate it today. * feat(web): replace cramped in/not-in filter editor with a multiselect dropdown The previous "in/not in" value input rendered selected values as tiny 10px pills inside a fixed-height row that overflowed and truncated as the list of options grew. Replace it with a combobox-style multiselect (Popover + Command) that shows a compact summary ("N selected" or the single label with its color dot) and opens a searchable, scrollable list with check indicators on click. * fix(web): show workflow and step names (not UUIDs) in sidebar grouping Group-by Workflow and Workflow Step rendered raw UUID strings as group headers because `TaskSwitcherItem` did not carry the resolved names. Pass `workflowName` and `workflowStepTitle` through `toSidebarItem` and prefer them in the group extractors. * fix(web): drop redundant true/false selector on boolean sidebar filters Boolean dimensions (PR review, Archived, Has diff) previously exposed both an operator (is / is not) and a value selector (true / false), which gives four user inputs for two real states. Hide the value input for boolean clauses and always store `true`; negation is expressed via the operator. Rename "Is PR review" to "PR review" since the dimension label no longer needs to read as a question. * refactor(web): drop Sort by Repository and relabel State to Status Sorting by repository duplicates what Group by Repository already offers, and "State" leaks a backend term into the picker. Remove the repository sort key (comparator, type, picker option) and rename the state option to "Status". Stored views referencing the removed key are migrated back to `state` at load time so the popover does not crash. * fix(web): tighten sidebar filter popover section spacing The FILTERS, SORT, and GROUP BY section labels each sat above their controls with both padded containers (p-2.5) and a 6px bottom margin, leaving visible dead space above each header. Reduce container padding to p-2 and label margin to mb-1 so sections read as a compact stack. * chore(web): apply prettier formatting drift in sidebar-filter area * revert(web): undo store.ts prettier reformat to stay under max-lines cap The packed single-line UIA declaration in store.ts is load-bearing for the 600-line ESLint cap: the previous chore commit unpacked it to 9 lines and pushed the file to 609 lines, turning the max-lines warning into a lint failure. Restore the packed layout (the /* prettier-ignore */ comment is there for exactly this reason). * refactor(web): label boolean filter ops as Show/Hide instead of is/is not * fix(web): pull section labels flush to sidebar filter popover borders * refactor(web): inline rename and save-as into sidebar view header row * refactor(web): split ViewHeaderRow into mode, display, and action subcomponents * feat(backend): persist sidebar views in user settings Adds a SidebarViews field to UserSettings (stored in the existing users.settings JSON blob) plus validation in the service layer: views are capped at 50, ids and names must be non-empty and unique. * feat(web): hydrate and sync sidebar views to backend Moves the source of truth for saved sidebar views from localStorage to the user settings endpoint. Views hydrate from SSR on first load; create/rename/overwrite/delete/duplicate/toggle-collapsed all PATCH the backend with optimistic updates and revert-on-failure. The active view id and draft remain per-device in localStorage. A sync bridge surfaces PATCH errors as toasts and runs a one-time migration to upload any pre-existing local views. As a side effect, localStorage writes and PATCH side effects are moved out of immer producers to avoid proxy-serialization risk. * chore(web): apply prettier to store.ts sidebar actions block * fix(web): run migrateView on SSR-hydrated sidebar views Defensively drop clauses with unknown dimensions and reset stale sort keys when views come from the backend, matching the localStorage load path. Also notes the default-state module and sidebar views in the store structure docs. * docs: note default-state module and sidebar views in store structure * fix(web): type sidebar view storage wrappers properly Drop the as-unknown-as-SidebarView and as-never casts at call sites by making the local-storage getters/setters accept the domain type and do the JsonValue cast once inside the wrapper. * refactor(web): stop PATCHing on sidebar group collapse toggles collapsedGroups is per-device visual state; routing it through mutateViews made every expand/collapse click fire a user-settings PATCH. Keep it local (in-memory + localStorage cache); the next real view mutation picks up whatever state is current. * fix(web): skip sidebar view migration when settings hydrated from server After SSR hydration the in-memory views are already the backend's truth, so migrating re-POSTs the same data every page load. Gate the one-shot migration on userSettings.loaded — only run if the server didn't answer and the slice fell back to localStorage.	2026-04-20 13:44:24 +01:00
Carlos Florêncio	5b04c9c675	perf: focus-gated git polling to reduce CPU on retained worktrees (#610)	2026-04-18 11:33:04 +01:00
Carlos Florêncio	1c6506911e	feat: add workflow sorting with drag-and-drop reordering (#520)	2026-04-01 23:58:43 +01:00
José Almeida	d1a028fdb6	feat: introduce subtasks, allow sessions to task reuse executor (#419)	2026-03-29 15:33:40 +01:00
José Almeida	f1da9644f4	feat: agent-native config mode (#396) ... * feat: add MCP mode pipeline for config vs task tool registration Thread McpMode field through the entire instance creation chain: CreateInstanceRequest → InstanceOverrides → InstanceConfig → MCP Server. This allows config-mode MCP sessions to register a different set of tools than the default task-mode sessions. * feat: add config-mode MCP tools and agentctl handlers Register config-mode tools (workflow steps, agents, MCP config, tasks) when MCP server mode is "config". Add 16 new WS action constants and agentctl-side handlers that forward tool calls to the backend via the existing BackendClient channel. * feat: add backend MCP handlers for config-mode operations Add backend WebSocket handlers for workflow step CRUD, agent CRUD, MCP config get/update, and task move/delete/archive/state operations. Wire config dependencies via SetConfigDeps pattern to avoid breaking the existing NewHandlers constructor. * feat: add config-mode system prompt and unit tests Add ConfigContext system prompt listing all config-mode MCP tools. Add unit tests for mode-based tool registration, agentctl config handler forwarding, backend handler validation, and system prompt content. * test: add exhaustive E2E tests for config-mode MCP handlers 38 end-to-end tests covering the full handler → service → DB pipeline for all 16 config-mode operations: workflow step CRUD, agent CRUD, agent profiles, MCP config, and task management (move, delete, archive, update state). Includes handler registration verification and two full pipeline integration tests. * fix: remove E2E test that depends on agent CLIs installed in CI TestE2E_Agent_CreateMultipleAndList tried to create claude-code and codex agents, which aren't available in CI. Agents are unique by type ID so creating duplicates also fails. Removed the test since CreateAndList already validates the create+list flow. * test: remove Go E2E tests for config-mode handlers Replacing with Playwright E2E tests. * test: add Playwright E2E tests for config-mode features 13 tests covering workflow steps, task operations, agent/profile settings pages, MCP config, and workflow settings round-trips. * feat: add dynamic MCP mode reconfiguration for agentctl instances Add SetMode() to the MCP server that clears and re-registers tools for the new mode. Expose it via PUT /api/v1/mcp/mode on per-instance servers, a SetMcpMode client method, and a lifecycle Manager.SetMcpMode wrapper. This enables switching from task to config MCP tools on workspaces that were prepared before plan_mode was set on the session. * feat: wire McpMode through executor launch and resume pipelines Add McpMode to LaunchOptions so callers can set it at launch time. StartTask and StartTaskWithSession now pass McpMode="config" when plan mode is active. startAgentOnExistingWorkspace reconfigures the MCP server via SetMcpMode before starting the agent subprocess. The AgentManagerClient interface gains SetMcpMode; the lifecycle adapter, executor, and all mock implementations are updated. * fix: pass plan_mode from workflow step when auto-starting moved tasks handleTaskMovedNoSession was hardcoding planMode=false when calling StartTask. Now it loads the target step and checks for enable_plan_mode in on_enter actions, passing the correct value so config-mode MCP tools are registered for the agent. * test: fix config-mode E2E tests and add SetMcpMode mock stubs - Add SetMcpMode stubs to all AgentManager mock implementations - Fix strict mode violations with { exact: true } on tool name assertions - Expand collapsed tool call groups before asserting individual names - Remove temporary diagnostic code * fix: address CodeRabbit review comments - Add servers parameter to update_mcp_config tool schema - Add mutex protection to SetMode for thread safety - Create session before building prompt so config context has session ID - Fix inconsistent ask_user_question tool name reference (use _kandev suffix) * refactor: use canonical ws.ActionMCP constants and handle marshal errors - Import ActionMCP* constants from pkg/websocket instead of duplicating them locally in config_handlers.go and handlers.go - Handle json.MarshalIndent error in forwardToBackend instead of ignoring it * fix: extract McpModeConfig constant and fix Prettier formatting - Add McpModeConfig constant to avoid repeated "config" string (goconst) - Fix Prettier formatting in config-management E2E spec * fix: validate task state before update and strengthen sysprompt tests - Add TaskState validation in handleUpdateTaskState to return proper validation error instead of internal error for invalid states - Strengthen format-contract assertions (exact %s counts, no %! markers) - Extract repeated test data into constants per project guidelines * refactor: decouple config MCP mode from plan_mode, use session metadata Replace plan_mode-based config MCP activation with config_mode in session metadata. Add isConfigModeSession() helper used across executor_execute, executor_interaction, and executor_resume. Propagate task.Metadata to session.Metadata in PrepareSession so config_mode flows from task creation through to the agent launch. * refactor: remove task tools from config MCP mode and update sysprompt Remove task management tools (list_tasks, move_task, delete_task, archive_task) from ModeConfig registration — they remain available in ModeTask. Update ConfigContext system prompt to remove task tool docs and add example requests section. Update MCP server tests for new tool count (18→14) and remove deleted task handler tests. * feat: add config-chat endpoint and workspace config agent profile Add default_config_agent_profile_id column to workspaces with SQLite migration. Add POST /workspaces/:id/config-chat endpoint that creates an ephemeral task with config_mode metadata and starts a session with config MCP tools. Extract resolveConfigChatDefaults helper to stay within lint complexity limits. * feat: add config chat UI with workspace settings integration Add config chat modal component and hook for starting config sessions. Add configChat state slice with open/close actions. Add workspace API client for config-chat endpoint. Add configuration agent profile selector to workspace settings form. Add config chat button to settings layout sidebar. * test: rewrite config-mode E2E tests to use metadata and session_id Rewrite config-management E2E tests to use createTaskWithAgent with config_mode metadata instead of a custom fetch helper. Fix navigation to use task.session_id instead of task.id. Add metadata parameter support to ApiClient.createTaskWithAgent. * fix: use floating FAB for config chat and pass default agent profile Move config chat button from header to a floating action button in the bottom-right corner with a sparkles icon. Pass the workspace's default agent profile ID when opening the config chat to avoid "no agent profile configured" error. Add default_config_agent_profile_id to workspace slice type. * feat: async agent launch for config-chat and extract helpers The config-chat endpoint now launches the agent asynchronously when a prompt is provided, matching the start_agent flow used by task creation. Extract deleteTaskOnError and launchConfigChatAgent helpers. Remove LaunchWorkspace from prepare step to avoid blocking. * feat: first-interaction agent profile selection for config chat Open the config chat modal immediately on FAB click. If no default config agent profile is set, the empty state now shows a profile selector before starting. The selected profile is saved as the workspace default_config_agent_profile_id for future sessions. * test: fix config E2E tests — remove duplicate method, use real tools Remove duplicate startConfigChat method in ApiClient that overrode the correct 3-param signature. Replace invalid create_agent test (requires registered agent type) with update_agent test. Remove fragile tool calls group UI assertion from multi-tool test. * fix: resolve 'no active session' error in config chat Add openConfigChatModal action that only sets isOpen and workspaceId without touching sessionId. Previously, open() called openConfigChat with empty sessionId which was truthy, causing QuickChatContent to render with an invalid session. * feat: add minimal toolbar mode for config chat input Thread minimalToolbar prop through ChatInputArea → ChatInputContainer → ChatInputBody → ChatInputToolbar → QuickChatContent. When enabled, renders only the submit/cancel button, hiding plan toggle, MCP indicator, context popover, model selector, and other controls. * feat: replace config chat dialog with floating popover panel Replace Dialog with Popover from @kandev/ui so the config chat floats up from the FAB button. Reduce FAB size to h-12/w-12 with larger h-7/w-7 icon. Rename tooltip to "Configuration Chat". Remove standalone ConfigChatFAB component from settings layout. * feat: filter config chat tasks from quick chat listing Add exclude_config query parameter to ListTasksByWorkspace that filters out tasks with metadata.config_mode=true. Apply it in the quick chat sessions API call to prevent config chat tasks from appearing as tabs. * refactor: move config agent profile setting to agents page Remove the Configuration Agent Profile selector from workspace settings and add a dedicated ConfigChatAgentSection to the agents settings page with auto-save on change. * feat: redesign config chat empty state with inline text input Replace clickable template buttons with subtle suggestion hints that fill the textarea on click and disappear once the user starts typing. Add a persistent Textarea + send button at the bottom so users can type directly without clicking templates. This prevents the "no active session" error since QuickChatContent only renders after startSession succeeds. * fix: config chat UX polish — non-clickable suggestions, profile persistence - Make suggestion prompts purely visual (non-interactive text hints) - Update workspace store after saving config agent profile so the profile selector doesn't reappear on subsequent opens - Use useAppStoreApi for store access in callbacks * fix: add inline error display and prevent accidental popover dismiss - Show API errors inline below the input instead of via toast (which can be hidden behind the popover) - Prevent popover from closing on outside click via onInteractOutside, so the user doesn't lose their typed input or active session - Surface error state from useConfigChat hook to the empty state UI * fix: use config-specific placeholder in config chat input Add placeholderOverride prop through ChatInputArea and QuickChatContent so the config chat shows "Ask anything about your configuration..." instead of the default "Continue working on the task..." placeholder. * feat: add default_config_agent_profile_id to workspace DTO and API Wire the field through WorkspaceDTO, FromWorkspace(), HTTP/WS request structs, service layer, and public API types so the config chat default profile persists across page reloads and SSR hydration. * feat: add config chat store actions and prompt delivery via WS Add configChat slice actions (open, close, rename, tab management), pendingPrompt state in useConfigChat hook, and initialPrompt support in QuickChatContent so prompts are delivered via WS after subscription is established rather than via HTTP (avoiding race condition). * fix: resolve dual store issue and message fetch race condition Replace StateProvider with StateHydrator in settings layout to prevent a shadow Zustand store that intercepted WS events. Fix message fetch race condition by merging WS-delivered messages with fetch results instead of replacing them. * feat: make config chat global with command panel integration Add ConfigChatProvider at root layout so the popover is available on all pages. FAB button only visible on settings pages; hidden anchor on other pages for popover positioning. Add "Configuration Chat" command to the command panel (Cmd+K). Add close button and header bar to the popover. * test: add E2E tests for config chat popover and command panel Add tests for opening config chat via FAB on settings page (with full agent response flow) and opening via command panel on kanban page. Fix api-client endpoint and add workspace update fields for E2E setup. * fix: compress props destructuring to satisfy max-lines-per-function lint Rebase merged both sides' additions into ChatInputEditorArea and ChatInputToolbar, pushing them over the 100-line function limit. Use object parameter with compact destructuring to reduce line count. * fix: register config task tools and add exhaustive E2E coverage Config-mode MCP task tools (list_tasks, move_task, delete_task, archive_task) were defined but never registered — registerConfigTaskTools() was never called in registerTools(). Fixed the registration and expanded E2E tests from 5 to 15, covering all testable config-mode MCP tools (workflow, agent, MCP config, and task management) with API-side verification of side effects. * feat: replace create/delete agent with create/delete agent profile in config mode Agent creation/deletion via MCP isn't practical since agents map to registered types. Replace with create_agent_profile and delete_agent_profile tools that manage the per-agent configuration presets users actually need to work with. Wires full chain: agentctl MCP tools → WS actions → backend handlers → controller layer. * chore: fix Prettier formatting * fix: compress props destructuring to satisfy max-lines-per-function lint * test: update MCP tests for agent profile tools and correct config tool count * fix: address CodeRabbit review — normalize MCP mode, set default, consolidate tests * fix: address CodeRabbit review — error leaks, search filter bug, stale prompt, sysprompt tools * feat: expose all workflow step fields in config-mode MCP tools * feat: add workflow CRUD to config-mode MCP tools * fix: split workflow CRUD E2E test into separate tests * fix: prevent cascade deletion of config session in delete workflow E2E test The config-chat endpoint picks the newest workflow (ORDER BY created_at DESC) for the ephemeral task. When the test created a deletable workflow right before starting the config session, the session's own task landed under that workflow. Deleting the workflow then cascaded and wiped the running session's task, causing the MCP tool call to hang. Add a "Config Anchor" bumper workflow so the config session uses it instead of the deletable one. * feat: add executor management to config-mode MCP tools Add 8 new MCP tools for executor and executor profile CRUD in config mode: list/create/update/delete for both executors and profiles. Wired through the full stack (WS actions, backend handlers, agentctl tools, sysprompt) with unit tests and E2E coverage. * fix: auto-focus config chat input and rename popover title * fix: remove executor CRUD MCP tools, keep executor profile management Executors are pre-defined system entities (local, worktree, docker, sprites). Only executor profiles should be managed via config chat. Removes create_executor, update_executor, delete_executor MCP tools while keeping list_executors and all executor profile tools. * fix: add realtime UI sync for workflow steps and agent profiles via MCP Workflow step and agent profile changes made through the config chat MCP tools were not broadcasting events to the frontend. Executor profile events worked because they went through the task service which has event bus integration. - Add WorkflowStep and AgentProfile event types to the event bus - Add WS notification action constants for workflow step events - Publish events from MCP handlers after step/profile CRUD operations - Register gateway subscriptions for the new event types - Add frontend WS handlers for workflow.step.created/updated/deleted * fix: reuse existing config chat session when opened from command panel The command panel always called openConfigChatModal() which reset the session state, causing the profile picker to show again. Now it checks for an existing active session first, matching the FAB behavior. * fix: suppress FAB tooltip while config chat popover is open When closing the popover via the X button, the mouse ends up over the FAB area and the tooltip re-appears. Force the tooltip closed while the popover is open so it cannot re-trigger on close. * fix: thread default_config_agent_profile_id through all workspace data paths The field was defined on the workspace type but never populated in: - SSR mapper (page.tsx) — missing from initial hydration - WS workspace handlers — wiped on workspace.created/updated events - Backend publishWorkspaceEvent — not included in event data This caused the config chat to always show the profile picker when opened from the command panel, since the saved default was lost. * fix: address PR review comments — workspace sync, type fixes, missing tool doc - Sync configChat.workspaceId when promoting next tab in closeConfigChatSession - Add update_task_state_kandev to ConfigContext system prompt - Fix workflow step WS event types (workflow.step.* instead of step.*) - Fix const reassignment in E2E tests (const → let) * refactor: clean up dead code and register missing MCP tools - Register update_task_state, delete_workflow_step, and reorder_workflow_steps as MCP tools in agentctl config mode - Remove dead handleCreateAgent/handleDeleteAgent WS handlers and their ActionMCP constants (only profiles are managed) - Rename openConfigChatModal to startNewConfigChat across frontend - Update sysprompt, tests, and tool counts * fix: remove extra next.config.ts machine * fix: address CI failures — prettier formatting and funlen split * fix: address coderabbit review comments across config-mode stack - Include prompt field in workflow step broadcast payloads - Align sysprompt task-state values with actual backend enum - Return error instead of continuing when MCP mode switch fails - Validate mode values in agentctl set-mcp-mode endpoint - Use errors.Is() for sentinel error comparison - Fix nullish coalescing to allow clearing config agent profile - Expand StepPayload type with missing config-step fields - Derive config agent Select value from store instead of local state * fix: reuse persisted config chat session and reduce toolbar complexity - Look up configChat.sessions for workspace before creating new session - Extract MinimalToolbar and move defaults to module-level object to reduce ChatInputToolbar cyclomatic complexity from 16 to 7 * fix: E2E executor test strict mode violation and invalid cleanup - Use exact match for list_executors text to avoid matching 2 elements - Remove cleanup that tried to delete pre-existing system executor - Reuse persisted config chat session for workspace in global commands - Reduce ChatInputToolbar cyclomatic complexity with module-level defaults	2026-03-13 00:44:06 +00:00
Carlos Florêncio	ca926a7614	feat: show auth methods and login guidance on authentication errors (#422)	2026-03-12 23:14:50 +00:00
João Salavisa	a405e13530	feat(web): add bottom terminal panel with Cmd+J hotkey (#414)	2026-03-10 23:10:16 +00:00
Carlos Florêncio	bb1caaba11	feat: add ACP agent variants for Claude, Codex, Copilot, and Amp (#387)	2026-03-10 17:30:04 +00:00
Carlos Florêncio	3820feb819	feat: suggest agent install commands and fix TUI agent startup (#398)	2026-03-09 21:54:30 +00:00
João Salavisa	d84b8873ea	feat: quick chat implementation (#393)	2026-03-08 22:37:37 +00:00
João Salavisa	28a27afd1a	refactor: move git status and commits to real-time agentctl queries (#366)	2026-03-05 08:35:02 +00:00
José Almeida	123b2f6eed	feat: start task from GitHub URL (#365) ... * feat(backend): accept github_url in task creation and clone on launch Add github_url field to task creation DTO and propagate through HTTP/WS handlers and service layer. When a task is created with a GitHub URL instead of a local repository, the service resolves (or creates) the repository record via FindOrCreateRepository and triggers a clone/fetch via repoclone.Cloner during executor pre-flight. Wire RepoCloner into the orchestrator executor so remote repositories are fetched before the agent process starts. On resume, RepoUpdater performs a fetch to ensure the worktree is up-to-date. * feat(backend): add GitHub branches endpoint for remote repos Add ListRepoBranches to the GitHub client interface (GHClient, PATClient, NoopClient, MockClient) and expose it via GET /api/v1/github/repos/:owner/:repo/branches. The mock controller gains POST /api/v1/github/mock/branches for seeding branch data in E2E tests. * feat(web): add GitHub URL input to task create dialog Add a toggle in the task create dialog that switches between the existing repository selector and a free-text GitHub URL input. When a valid GitHub URL is entered (owner/repo parsed), branches are fetched from the new backend endpoint and auto-selected. The dialog state, effects, validation, and submit logic are extended to support the github_url flow alongside the existing repository flow. * test(e2e): add tests for task creation from GitHub URL Add E2E tests verifying: - Full flow: toggle to GitHub URL mode, enter URL, create task, verify agent runs and completes in session view - Toggle behavior: switching between GitHub URL and repository selector modes updates UI correctly * fix(web): dynamic URL input sizing and extract RepoSourceInput Replace fixed-width GitHub URL input with size-based auto-sizing (matching InlineTaskName pattern). Extract RepoSourceInput component from DialogHeaderContent to stay within cyclomatic complexity limits. Add testId prop to Combobox and wire it to ExecutorProfileSelector for E2E test targeting. * test(e2e): add worktree executor test and fix GitHub URL repo seeding Update GitHub URL E2E tests to pre-seed a repository with GitHub provider info pointing to the local git repo, avoiding actual clone attempts during task creation. Add test for GitHub URL task creation with worktree executor type, verifying the full flow including executor profile selection. Extend ApiClient with listExecutors and provider fields on createRepository for test seeding. * fix(backend): use protocol-aware clone URL for provider-backed repos The ensureRepoCloned function was hardcoding HTTPS clone URLs via repositoryCloneURL(), but the user's git setup may require SSH. Add BuildCloneURL to the RepoCloner interface so the executor uses the Cloner's configured protocol (SSH/HTTPS) instead of always generating HTTPS URLs. Falls back to HTTPS if BuildCloneURL fails. This fixes workspace loading issues (terminal, file tree) for cloned repos when the user has SSH-only authentication configured. * test(e2e): enhance GitHub URL test with terminal and changes panel verification * feat(web): add inline validation for GitHub URL input - Show inline error for invalid URL format (not matching github.com/owner/repo) - Show inline error when repository is not found or not accessible - Mock client returns error for unknown repos (matches real GitHub API) - E2E tests for invalid URL, nonexistent repo, and error-clearing on valid input * fix(web): fix GitHub URL branch auto-select and E2E test stability - Pick branch by name (main/master) for GitHub URL mode instead of using selectPreferredBranch which returns origin-prefixed names - Add test timeout for worktree executor test - Use shorter filename in terminal test to avoid xterm line-wrap issues * fix(web): fix GitHub URL dialog polish and wrong-repo bug UI fixes: - Align toggle button text with dropdown text content (pl-3) - Match GitHub URL input height to dropdown trigger (min-h-9) - Position error text absolutely to prevent layout shift - Remove redundant toast on repo-not-found (inline error suffices) Bug fix: - Prevent repo auto-select from overriding GitHub URL mode by guarding useRepositoryAutoSelectEffect with useGitHubUrl - Reorder getRepositoriesPayload to check useGitHubUrl first, preventing stale repositoryId from winning over the GitHub URL Add E2E test verifying correct repo usage across consecutive tasks. * fix(web): fix dialog height mismatch and error text overlap - Use exact h-9 on GitHub URL input to match dropdown trigger height - Move error text from absolute-positioned overlay to inline next to the toggle button, preventing overlap while keeping layout stable * fix(web): make GitHub URL input auto-size to content Reduce minimum size from 30 to 20 and shorten placeholder so the "/ task-name" sits closer to the URL text, matching the dropdown's compact w-auto behavior. * fix(web): polish GitHub URL input sizing, floating error, and placeholder color - Match input height (h-7) and padding (px-2) to Combobox trigger button - Size input width to exactly fit placeholder text - Show validation error as floating popover below input instead of inline - Keep placeholder text grey even when input has error state - Extract useGitHubUrlState hook to fix max-lines-per-function lint * fix(backend): return proper HTTP status codes from GitHub branches endpoint Add GitHubAPIError type to distinguish upstream GitHub API status codes. The branches endpoint now returns 404 (not 500) for non-existent repos, which the logging middleware correctly logs as DEBUG instead of ERROR. * feat(web): show error toast when a task session fails to start Add session failure notification plumbing: WS handler detects FAILED state with error_message, pushes to Zustand store, and a global bridge component shows an error toast via the ToastProvider. Also adds data-testid attributes to toast elements and types error_message on the session state changed payload. * style: fix prettier formatting in task-create-dialog and related files * fix(web): extract ToastList component to fix max-lines-per-function lint * fix: address code review feedback for GitHub URL task creation - Preserve 403 status instead of collapsing to 401 in branches endpoint - Use clone-generic error instead of remote-docker-specific in ensureRepoCloned - Trim whitespace in GitHub URL validation (backend + frontend) - Add GitHubURL field to wsUpdateTask path - Fix DefaultBranch mapping to prefer repoInput.DefaultBranch over BaseBranch - Clear githubBranchesLoading on early-return paths to prevent stuck state - Gate GitHub branch loading by mode to avoid false loading states - Encode owner/repo in API path for special characters - Add aria-label, aria-invalid, aria-errormessage for accessibility * fix(e2e): improve diff-update test stability with fresh locator and longer timeout * fix(backend): add --paginate flag to gh api branches call for repos with >100 branches * fix: address second round of code review feedback - Add pagination support to PATClient.ListRepoBranches for repos with >100 branches - Validate owner/repo in mock controller addBranches endpoint - Use aria-describedby instead of aria-errormessage for broader AT support - Add aria-live region to toast container for screen reader announcements - Assert absence of FIRST_MODIFICATION in diff-update E2E test * fix(backend): downgrade HTTP request logger from error to warn for 4xx/5xx responses * fix: address third round of code review feedback - Validate repositoryID/localPath in UpdateRepositoryLocalPath - Copy slices in mock client to prevent external mutation - Extract GitHub header constants and shared setter in PATClient - Redact clone URL from logs to prevent credential leaks - Guard against persisting empty localPath after clone - Show fallback toast message when FAILED state has no error_message	2026-03-05 00:47:58 +00:00
Carlos Florêncio	22c0fd2a57	fix: improve claude plan mode reliability and cleanup (#346)	2026-03-02 14:29:34 +00:00
Carlos Florêncio	8b5681bee2	feat: startup health status (#344)	2026-03-02 09:37:55 +00:00
Carlos Florêncio	4317bdd06a	perf: optimize settings page load (#268)	2026-02-23 09:47:23 +00:00
Carlos Florêncio	dff0b49c51	docs: add github integration (pr watcher) (#262)	2026-02-23 00:16:37 +00:00
Carlos Florêncio	a23ab5be3a	feat: remote executors + secrets (#257)	2026-02-21 22:14:56 +00:00