Commit Graph

3 Commits

Author SHA1 Message Date
José Almeida 42556971ef feat(web): tabbed multi-PR CI popover for topbar button and chat status chip (#1356)
* feat(web): tabbed multi-PR CI popover for topbar button and chat status chip

* test(e2e): cover multi-PR CI popover tabs, chip aggregate, and dropdown

* fix(web): address multi-PR popover review feedback

- suppress hover popover while the PR dropdown is open (no stacked overlays)
- repo-scope tab testids so same-number PRs on different repos stay unique
- guard non-array taskPRs store value in PRStatusChip (same as PRTaskIcon)
- add tablist/tab/aria-selected semantics to the popover tabs

* fix(web): warm default PR only, skip terminal PRs, add tabpanel ARIA

- chip background-sync warms pickDefaultPR (the tab the popover opens), not list head
- PRFeedbackWarmer skips merged/closed PRs (no wasted fetches in topbar path)
- tabpanel role + aria-controls/labelledby wire tabs to the panel

* fix(web): complete ARIA tabs keyboard model in multi-PR popover

- roving tabindex: only the active tab in the page tab order
- ArrowLeft/ArrowRight move selection + focus within the tablist (wrapping)
- stable useId-scoped tabpanel id so every tab's aria-controls resolves
- document topbar-only scoping of prCheckGroup e2e helpers

* refactor(web): skip duplicate rank call for first PR in pickDefaultPR
2026-06-12 19:34:27 +01:00
Carlos Florêncio 72441fb69a feat(web): add PR closed banner and hide CI chip on terminal state (#1161) 2026-05-30 12:54:32 +01:00
João Salavisa c913522626 fix(web): make PR CI status reachable on mobile via tap-activated drawer (#1060)
* fix(web): make PR CI status reachable on mobile via tap-activated drawer

PRStatusChip's HoverCard was hover-only, so touch users in the chat
status bar had no way to open the CI status surface. Branch on
useIsMobile(): keep the existing HoverCard on desktop, and on mobile
render a vaul Drawer hosting the same PRCIPopover body so tapping the
chip opens a bottom-sheet "modal" with passes / failures / reviews.

The desktop topbar PR button isn't mounted in SessionMobileTopBar (and
its click path is Dockview-only), so the chip is the only surface that
needs the fix today. New mobile-chrome e2e spec covers tap-to-open,
failed-bucket content, and close.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* docs(e2e): rephrase PR CI accessors section comment

The block now spans desktop hover popover + chip + mobile drawer
locators, not just the hover popover.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* test(web): cover PRStatusChip desktop/mobile branching in jsdom

Adds focused unit tests around the new mobile drawer path:
- desktop branch renders a chip and click does NOT mount the drawer
- mobile branch starts with no drawer, click mounts drawer + popover
  inner + close button (regression guard for the e2e's toHaveCount(0)
  precondition)
- chip data-* attrs preserved across both branches
- failed PR maps to data-status='failed'
- no-checks PR shows the popover's empty state inside the drawer

Close-on-dismiss can only be verified in a real browser (happy-dom
doesn't fire vaul's CSS transition events) — covered by the
mobile-pr-ci-chip.spec.ts e2e.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(web): a11y polish on mobile PR/CI chip drawer trigger

Addresses bot review feedback on #1060:
- Add aria-haspopup="dialog" + aria-expanded={open} on the mobile chip
  button (mirrors the established mobile-pill-button.tsx pattern).
- Add a visually hidden DrawerDescription to satisfy Radix's accessible
  Dialog contract and suppress the console warning observed during
  unit tests.
- Annotate the e2e failed-bucket count assertion with the arithmetic
  (3 total - 2 passing = 1 failed) so future seed-value edits stay
  in sync.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Kandev Agent <agent@kandev.dev>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-24 14:39:02 +01:00