Commit Graph

90 Commits

Author SHA1 Message Date
Carlos Florêncio d3945b00ce fix(web): read session state at call time in comment run to prevent stale queue (#588) 2026-04-15 19:55:57 +01:00
Carlos Florêncio 204fac1cca feat: acp-first profiles, models, and modes (#566) 2026-04-15 13:22:32 +01:00
José Almeida 2b8513f902 feat: add multi-select and drag-to-move for file tree and changes panel (#490)
* feat: add multi-select and drag-to-move for file tree and changes panel

Add Shift-click range and Ctrl/Cmd-click toggle selection to the file
tree and staged/unstaged changes sections. Includes bulk actions
(delete, stage, unstage, discard), drag-and-drop file moving into
directories, keyboard shortcuts (Escape, Ctrl+A), and E2E tests.

* fix: move bulk action components to file-row to fix max-lines lint

* style: apply prettier formatting to all changed files

* fix: bulk delete all selected items and update anchor on stale shift-click

* fix: address CodeRabbit review comments

- Keep original file-row-* data-testid for backwards compat
- Remove eager onClearSelection from bulk actions (auto-pruned by hook)
- Variant-scope bulk-discard/bulk-unstage test ids
- Remove index.lock deletion from E2E GitHelper retry loop

* fix: fix E2E tests — create files after session open, remove DnD test

- Create files AFTER opening session so WS detects git status changes
- Add proper git env vars (GIT_AUTHOR_NAME, etc.) matching existing tests
- Use element.press("Escape") instead of page keyboard for proper focus
- Remove drag-to-directory test (Playwright dragTo doesn't support HTML5
  dataTransfer events needed by our DnD implementation)

* fix: rename E2E task titles to avoid ambiguous 'Changes' tab selector

* fix: make file list focusable for Escape key handler in E2E tests

* fix: improve selection styling and ignore right-clicks in selection handler

- Use text-accent-foreground on selected rows for dark mode readability
- Override child span colors with [&_span]:text-accent-foreground
- Use hover:bg-accent/80 instead of hover:bg-muted on selected items
- Skip selection handling on right-click (button === 2) so context menu
  works without clearing multi-selection

* fix: plain click should not select — only Ctrl/Cmd+click and Shift+click

Plain click now clears any selection and performs the original action
(open file / toggle folder / open diff). Selection only happens with
modifier keys. handleClick returns boolean to indicate whether the
click was consumed by selection logic.

* fix: fix multi-select bugs and expand E2E test coverage

Bug fixes:
- Change isSelected from boolean to function prop so children compute
  their own selection state (fixes nested file selection)
- Inline TreeNodeRow JSX into TreeNodeItem so ContextMenuTrigger asChild
  can attach refs directly (fixes right-click context menu)
- Set lastClickedRef on plain click so shift-click has a valid anchor
- Add click-outside handler to clear selection

E2E tests expanded to 14 file-tree tests + 3 changes-panel tests:
- Ctrl-click select, toggle, multi-select
- Plain click clears selection
- Shift-click range after plain click and ctrl-click anchors
- Directory selection and nested file selection
- Right-click context menu (single + bulk delete)
- Click outside clears selection
- Escape clears selection

* fix: move AlertDialog outside ContextMenu to fix delete action

The AlertDialog wrapping the ContextMenu caused Radix focus management
to intercept context menu item selection, making Delete trigger Rename.
Moving AlertDialog to a sibling of ContextMenu fixes the conflict.

* fix: reorder context menu — Delete first, Rename second

Radix ContextMenu auto-focuses the first item on open, which caused
accidental Rename triggers. Putting Delete first (the more common
action for selection) avoids this.

* fix: don't clear selection when clicking context menu or dialog

The click-outside handler was clearing selection when clicking on
context menu items or confirmation dialog buttons (rendered in portals
outside the tree container). Now skips clearing for elements with
role=menu, role=alertdialog, or role=dialog.

Also extended the bulk delete E2E test to verify both files are
actually removed after confirming the dialog.

* fix: hide file count in delete dialog when folder children not loaded

When a folder hasn't been expanded, its children aren't loaded yet so
countFilesInTree returns 0. Instead of showing "0 files", hide the
count entirely and just show "delete <folder name>".

* fix: show confirmation dialog for bulk discard in changes panel

Bulk discard was calling git.discard() directly, bypassing the
confirmation dialog. Now routes through handleBulkDiscardClick which
opens the DiscardDialog with a bulk message ("discard changes to N
files") before executing.

* fix: address remaining CodeRabbit review comments

- Deduplicate filenames on move: when moving files with identical names
  to the same directory, append "(1)", "(2)" etc. to avoid collisions.
  Both tree update and rename API calls use the same deduplication.
- Replace void operator with .catch(() => {}) for bulk stage/unstage
  to prevent unhandled promise rejections.
- Add document-level dragend listener as safety net to clear stuck drag
  state if the element's onDragEnd doesn't fire (Escape, out-of-window).

* test: add unit tests for file tree move deduplication and visible paths

* fix: address all remaining PR review comments

- Move onSelectionChange out of React state updater (side effect fix)
- Stabilize keyboard listener deps (pass callbacks not object)
- Remove unnecessary useMemo in BulkActionBar
- Fix ghost-restore on partial bulk delete (remove all at once)
- Fix blank filename on single-file bulk discard
- Add aria-selected and role=treeitem for accessibility
- Extract computeNextSelection params into object (max-params lint)

* fix: add missing bulk action props to WorkingTreeProps type

WorkingTreeSections referenced onBulkStage, onBulkUnstage, and
onBulkDiscard but WorkingTreeProps Pick didn't include them, causing
a TypeScript build failure.

* fix: address final review comments

- Add unit tests for computeNextSelection (8 tests covering ctrl-click,
  shift-click range, stale anchor, reverse range, shift+ctrl extend)
- Extract shared E2E helpers (GitHelper, makeGitEnv, openTaskSession,
  createStandardProfile) to e2e/helpers/git-helper.ts
- Fix misleading comment in bulk delete (says "re-insert only failed"
  but implementation restores full snapshot)

* fix: use Promise.all for bulk delete to prevent partial rollback

Individual .catch() handlers could restore already-deleted files
if a later delete failed. Now uses Promise.all so rollback only
happens if any delete rejects.

* test: add renderHook tests for useMultiSelect hook behaviors

- Stale-path pruning: items shrink → selected paths auto-pruned
- Plain click: returns false, clears existing selection
- selectAll/clearSelection: work correctly, fire onSelectionChange
- Install @testing-library/react for renderHook support

* fix: handle false returns from onDeleteFile in bulk delete Promise.all

* chore: remove unused @testing-library/react-hooks dependency
2026-04-11 17:43:21 +01:00
Carlos Florêncio 2ae996a2c1 fix(agentctl): register MCP tools with _kandev suffix to match sysprompt (#572) 2026-04-10 17:17:42 +01:00
Carlos Florêncio ebefac814a docs: enforce test requirements and improve agent skill resilience (#543) 2026-04-09 16:27:19 +01:00
Carlos Florêncio 5ff930c6e0 fix(web): keep file tree and terminal waiting through long prepare (#564) 2026-04-09 12:49:47 +01:00
Carlos Florêncio a8092fd0a9 fix(web): sort nested file tree folders before files (#562) 2026-04-08 19:41:07 +01:00
Carlos Florêncio 2c222a8e7a fix(web): scroll dropdown selectors inside dialogs (#559) 2026-04-08 18:46:31 +01:00
Carlos Florêncio 41b405c64f fix(backend): prevent task reorder during silent session resume (#555) 2026-04-08 07:55:24 +01:00
Carlos Florêncio 73e6ef64b4 fix(orchestrator): persist live git status snapshot for sidebar diff badges (#556) 2026-04-07 23:06:39 +01:00
Carlos Florêncio 61e5d5cce9 feat(web): redesign task sidebar with repo-grouped layout and diff stats (#550) 2026-04-07 09:12:17 +01:00
Carlos Florêncio 03c164d6cd fix: handle file paths with spaces in git status and diff parsing (#552) 2026-04-06 19:25:26 +01:00
Carlos Florêncio a44489640b fix: changed branch and auto focus changes panel (#549) 2026-04-06 18:59:37 +01:00
Carlos Florêncio 52d6f7e9bf fix(web): persist PR panel dismissal across page refreshes (#547) 2026-04-06 13:52:53 +01:00
Carlos Florêncio 6d81734c66 fix(web): reset stale topbar branch when navigating between tasks (#546) 2026-04-06 12:52:42 +01:00
Carlos Florêncio e3f83173cf fix(web): open embedded VS Code in center group instead of right sidebar (#545) 2026-04-06 09:48:17 +01:00
Carlos Florêncio a704f4baca fix: add paragraph spacing to markdown body for visible line breaks (#540) 2026-04-06 09:01:09 +01:00
Carlos Florêncio 8c6f16337d fix(acp): suppress stale events during session resume history replay (#527) 2026-04-03 15:15:02 +01:00
Carlos Florêncio 82eb59d91e fix: disable plan mode when moving to next workflow step (#525) 2026-04-03 15:07:46 +01:00
Carlos Florêncio 12310e12ba fix: show Push button when task has open PR and unpushed commits (#537) 2026-04-03 15:03:05 +01:00
Carlos Florêncio 7e97e07c2d fix: guard against missing referencePanel in dockview focusOrAddPanel (#538) 2026-04-03 15:02:40 +01:00
Carlos Florêncio 75aad972a7 fix: increment CI checks elapsed time for in-progress runs in PR panel (#529) 2026-04-03 14:29:02 +01:00
Carlos Florêncio 2238ef0825 feat: prioritize local changes above PR files in changes panel (#528) 2026-04-03 14:28:28 +01:00
Carlos Florêncio dbe778e4e8 feat: auto-show PR details panel when task has associated PR (#517) 2026-04-02 00:08:35 +01:00
Carlos Florêncio 1c6506911e feat: add workflow sorting with drag-and-drop reordering (#520) 2026-04-01 23:58:43 +01:00
Carlos Florêncio beb42acc29 feat: expose hidden keybindings in settings for user customization (#521) 2026-04-01 23:29:49 +01:00
Carlos Florêncio 0080ec9658 fix(kanban): clear stale activeSessionId when switching tasks (#523) 2026-04-01 23:23:54 +01:00
Carlos Florêncio 1587203c2e fix(web): add max-height and scrollbar to queue message editor textarea (#519) 2026-04-01 23:03:20 +01:00
Carlos Florêncio 6fea6277a8 fix: hide start agent button during preparation and fix auto-start race condition on step move (#516) 2026-04-01 23:00:05 +01:00
Carlos Florêncio 348ee25e6f feat: disable branch selector for local executor and implement base branch checkout (#515) 2026-04-01 22:55:02 +01:00
Carlos Florêncio 447da7edb2 fix: re-inject plan mode instructions on follow-up prompts (#507) 2026-03-31 22:43:22 +01:00
Carlos Florêncio b832390914 fix: preserve task status when resuming agent after backend restart (#508) 2026-03-31 22:37:31 +01:00
Carlos Florêncio 1cd3a6b800 feat(web): rename sidebar sections to "Turn Finished" and "Running" (#506) 2026-03-31 21:01:51 +01:00
Carlos Florêncio c56dfe8537 feat(github): move PR monitoring to backend with lightweight polling (#502) 2026-03-30 23:26:01 +01:00
Carlos Florêncio 59ee830d71 feat(web): unified commit list and dockview panel fix (#500) 2026-03-30 22:44:10 +01:00
Carlos Florêncio 54b8d2939b fix(web): invalidate diff expansion cache when file changes (#501) 2026-03-30 21:17:49 +01:00
Carlos Florêncio be1b3a41db refactor(web): reorganize E2E tests into feature-based subdirectories (#499) 2026-03-30 14:34:24 +01:00
Carlos Florêncio db816d4222 fix(web): deduplicate agent and session tabs in task view (#496) 2026-03-30 12:19:55 +01:00
Carlos Florêncio 81341263fd feat(terminal): fix bottom padding and add font family setting (#489) 2026-03-29 22:27:37 +01:00
Carlos Florêncio 3a50cf42e5 fix(web): show both send and cancel buttons when agent is busy (#487) 2026-03-29 22:13:39 +01:00
Carlos Florêncio acd2b9770d fix(web): hide duplicate local commits when PR commits exist (#494) 2026-03-29 22:11:42 +01:00
José Almeida f479393928 fix(github): reliable PR-task association across all launch paths (#485)
* fix(github): reliable PR-task association across all launch paths

Three bugs caused inconsistent PR detection for agent-opened PRs:
- StartCreatedSession never called ensureSessionPRWatch
- Push detection bailed out when a pr_number=0 watch existed
- PR watch branch was never updated after agent branch switches

* fix: extract searchPRForExistingWatch to reduce nesting depth

* fix: address review feedback and fix e2e test timeouts

- Fix UNIQUE constraint error when associatePRFromPush was called with
  an existing watch (update pr_number instead of creating new watch)
- Add UpdatePRWatchPRNumber to GitHubService interface
- Fix e2e test timeouts: increase budget to 180s, remove unnecessary
  clickTab("Changes"), replace 35s hard wait with polling assertion

* fix(e2e): accept both /t/ and /s/ URL patterns in PR detection tests

Task cards in the Done column navigate to /t/<task-id> (task view),
not /s/<session-id> (session view). The toHaveURL assertion must
accept both URL patterns.
2026-03-29 20:32:18 +01:00
Carlos Florêncio 3a71ae2fe6 fix: complete all non-terminal tool calls when turn ends (#488) 2026-03-29 17:36:50 +01:00
José Almeida d1a028fdb6 feat: introduce subtasks, allow sessions to task reuse executor (#419) 2026-03-29 15:33:40 +01:00
Carlos Florêncio 82d5168b67 refactor: centralize default prompts and fix PR review scoping (#476) 2026-03-28 16:51:24 +00:00
Carlos Florêncio 7da6550093 fix(orchestrator): fail session with guidance when PR branch is missing (#466) 2026-03-26 19:35:17 +00:00
Carlos Florêncio 7ac5b3bb17 fix(web): prevent pointer-events: none from getting stuck on body after dialog navigation (#474) 2026-03-26 15:46:48 +00:00
Carlos Florêncio c6bf43ded9 fix: resolve stale execution ID after backend restart (#473) 2026-03-26 15:11:23 +00:00
José Almeida 7d900fea91 feat(vcs): add commit body field and AI generation for commit description and PR title (#465)
* feat(vcs): add commit body/description field to commit dialog

Add an optional description textarea below the commit title in both
desktop and mobile commit dialogs, with a dedicated AI generate button
for the description. Add builtin-commit-description utility agent and
E2E test.

* style: fix prettier formatting in mobile git controls and E2E test

* fix(e2e): use specific testid selectors for commit dialog inputs

The commit dialog now has two textboxes (title + body), so
getByRole("textbox") is ambiguous. Use getByTestId selectors
and add exact match for the Commit button.

* fix(ui): add cursor-pointer to mobile commit button

* fix(ui): remove "(optional)" from description label and "Generate" text from button

* fix(ui): match PR dialog style for commit description generate button

* feat(vcs): add AI generate button for PR title

Add builtin-pr-title utility agent and wire up a generate button
inside the PR title input, matching the commit title pattern.
Extract shared dialog field components into vcs-dialog-fields.tsx
to stay within the 600-line file limit.

* refactor(ui): unify generate buttons as icon-only sparkles inside inputs

Move AI generate buttons inside both title inputs and description
textareas (top-right corner) for a consistent look. Remove the
"Generate" label variant — all buttons are now icon-only sparkles.

* style: fix prettier formatting in utility agent generator hook

* fix(a11y): add aria-labels to generate buttons and PR title input

* ci: retrigger E2E tests

* fix(e2e): improve commit dialog button click reliability

Add exact match and enabled check before clicking the dialog
Commit button, increase close timeout.

* ci: retrigger checks

* fix(e2e): improve pre-hooks test commit button reliability

Add exact match, enabled check, and longer dialog timeout to match
the commit-body test pattern.

* fix(ui): prevent dialog field overflow and improve commit description prompt

- Add min-w-0 to relative wrappers in commit and PR dialog fields to
  prevent text inputs/textareas from overflowing the dialog bounds
- Rewrite commit description prompt to use system-role framing that
  prevents weaker models from adding conversational preamble
2026-03-26 13:24:30 +00:00
Carlos Florêncio ec01a55354 fix(web): prevent dockview layout from not filling viewport after session switch (#471) 2026-03-26 10:04:04 +00:00