Commit Graph

456 Commits

Author SHA1 Message Date
João Salavisa b3aaa804f1 fix: use dynamic merge-base for git commits to filter main branch commits (#504)
* fix: use dynamic merge-base for git commits to filter main branch commits

When a feature branch is rebased on main, the stored base_commit_sha
becomes outdated. Using git log base_commit..HEAD would include main
branch commits that were merged after the stored base commit.

This fix adds dynamic merge-base calculation using the session's
base_branch (target branch like origin/main). When fetching commits:
- The backend computes git merge-base HEAD target_branch
- This returns only commits not yet merged into the target branch
- Works correctly even after rebases

Changes:
- Extended SessionReader interface with GetSessionBaseBranch method
- Added GetMergeBase to GitOperator for computing merge-base
- Updated git log API to accept target_branch parameter
- Modified wsGitCommits handler to pass target branch for filtering

* fix: update executor_test mock to match new GetGitLog signature

* fix: update remaining mocks to match new GetGitLog signature

* fix: update integration test mock for GetGitLog signature

* fix: address code review feedback

- Use GetOrEnsureExecution in wsGitCommits to recover workspaces after backend restarts
- Fix archive snapshot to use baseBranch for merge-base when baseCommit is empty
- Extended ExecutionLookup interface with GetOrEnsureExecution method

* fix: distinguish not-ready errors from unexpected errors in wsGitCommits

Address CodeRabbit review feedback:
- Use errors.Is() to detect ErrSessionWorkspaceNotReady sentinel error
- Return ready:false gracefully for workspace-not-ready and session-not-ready errors
- Return actual errors for unexpected failures (database errors, etc.)
- Add comprehensive tests for error handling paths
2026-04-15 21:29:59 +01:00
João Salavisa e8c34411ae feat(mcp): add start_agent and local_path params to create_task (#505)
* feat(mcp): add start_agent and local_path params to create_task

Add control over task creation behavior in MCP create_task tool:

- Add start_agent boolean param (default true) to optionally skip
  auto-starting an agent when creating tasks
- Add local_path param for specifying local repository folder path
  when creating top-level tasks (worktree flow)
- Add repository_id and base_branch params for explicit repo config
- Improve tool description with clear guidance on when to use
  parent_id='self' vs creating top-level tasks
- Update backend handler to respect start_agent flag
- Relax description requirement for subtasks when start_agent=false

This fixes the issue where agents creating tasks from plans would
always auto-start immediately and couldn't specify repositories
for top-level tasks.

* test(mcp): add integration tests for source_task_id inheritance paths

Cover the source-task path in resolveTaskRepositories that had no test
coverage at any layer: valid source_task_id inherits repos and missing
source_task_id silently falls through rather than failing.

Co-authored-by: João Salavisa <undefined@users.noreply.github.com>

---------

Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: João Salavisa <undefined@users.noreply.github.com>
2026-04-15 21:26:27 +01:00
Carlos Florêncio 9d816e7a63 fix(backend): reject session resume when task is archived (#593) 2026-04-15 15:03:11 +01:00
Carlos Florêncio 28069398e7 fix: migrate agent_profiles to drop CHECK(model != '') constraint (#590) 2026-04-15 15:02:27 +01:00
Carlos Florêncio 7fbca75354 fix(mcp): inherit repo and default to worktree executor for MCP-created tasks (#592) 2026-04-15 14:14:19 +01:00
Carlos Florêncio 204fac1cca feat: acp-first profiles, models, and modes (#566) 2026-04-15 13:22:32 +01:00
su f757e07460 fix(backend): always enable cgo on build (#586) 2026-04-15 10:11:27 +01:00
José Almeida e86b6655a3 fix(worktree): handle submodules in worktree creation (#579)
* fix(worktree): handle submodules in worktree creation

Repos with git submodules failed during worktree creation when git-crypt
was also present. The `git checkout HEAD -- .` command in
unlockGitCryptAndCheckout() tried to process submodule gitlink entries,
but git resolved their git dirs relative to the worktree-specific git
dir instead of the common dir, causing "not a git repository" errors.

- Detect submodule paths via `git ls-tree -r HEAD` (mode 160000)
- Exclude submodule paths from git-crypt checkout using :(exclude) pathspecs
- Initialize submodules after worktree creation via `git submodule update --init`
  (non-fatal — unreachable URLs are logged as warnings)
- Add submodule init to all worktree creation paths (git-crypt and non-git-crypt)

* fix(worktree): address review — recursive submodule init, consistent call sites

- Add --recursive to git submodule update --init for nested submodules
- Call initSubmodules unconditionally in git-crypt path (matching manager.go)

* fix(worktree): restore submodule index entries after git-crypt checkout

The :(exclude) pathspec used to skip submodules during git checkout also
prevents their gitlink entries from being written to the index. This
leaves git status showing them as staged deletions.

After checkout, run git reset HEAD for each excluded submodule path to
copy the gitlink entry from HEAD back into the index.

* test(worktree): add git status assertion to submodule unlock test

Validate that the index reset after :(exclude) checkout leaves no
staged deletions for submodule paths.

* fix(worktree): use literal pathspec for submodule exclusion

Use :(literal,exclude) instead of :(exclude) to prevent glob
metacharacters in submodule paths from being interpreted as patterns.

* fix(worktree): fix initSubmodules docstring to match --recursive flag
2026-04-14 15:59:25 +01:00
João Salavisa 3b63013294 fix(worktree): disable inherited git-crypt filters when repo is locked (#577) 2026-04-13 19:23:31 +01:00
João Salavisa 2ecfec4b52 fix(worktree): handle locked git-crypt repos and localized git errors (#532) 2026-04-13 18:30:37 +01:00
Carlos Florêncio 2ae996a2c1 fix(agentctl): register MCP tools with _kandev suffix to match sysprompt (#572) 2026-04-10 17:17:42 +01:00
dependabot[bot] 2a4e2d7c68 chore: bump the go_modules group across 1 directory with 2 updates (#563) 2026-04-09 22:54:09 +01:00
José Almeida 135b63e067 fix(backend): prevent worktree branches from inheriting upstream tracking (#570)
When creating a worktree from a remote-tracking ref (e.g. origin/feature/foo),
git automatically sets the new branch's upstream to that ref. This caused new
task branches to incorrectly track the original remote branch instead of
starting with no upstream.

Add -c branch.autoSetupMerge=false to gitAddWorktree and
gitAddWorktreeWithGitCrypt. The explicit CheckoutBranch flow (PR reviews)
is unaffected — it sets upstream via setUpstreamIfExists after creation.
2026-04-09 22:48:26 +01:00
Carlos Florêncio 7ad7736e07 fix: move frontend off port 3000 and silence reverse-proxy panic logs (#568) 2026-04-09 18:50:43 +01:00
Carlos Florêncio b0a86a62d9 fix(backend): associate PRs with tasks after branch rename or PR replacement (#565) 2026-04-09 15:50:23 +01:00
Carlos Florêncio 4f40986488 fix(backend): reduce log noise from expected error states (#560) 2026-04-08 19:16:05 +01:00
Carlos Florêncio 41b405c64f fix(backend): prevent task reorder during silent session resume (#555) 2026-04-08 07:55:24 +01:00
Carlos Florêncio 73e6ef64b4 fix(orchestrator): persist live git status snapshot for sidebar diff badges (#556) 2026-04-07 23:06:39 +01:00
Carlos Florêncio 61e5d5cce9 feat(web): redesign task sidebar with repo-grouped layout and diff stats (#550) 2026-04-07 09:12:17 +01:00
Carlos Florêncio df9a9bf309 fix(agentctl): prevent git process pile-up causing excessive CPU usage (#554) 2026-04-06 21:36:25 +01:00
Carlos Florêncio 03c164d6cd fix: handle file paths with spaces in git status and diff parsing (#552) 2026-04-06 19:25:26 +01:00
Carlos Florêncio 1c11c7906b fix(github): clean up orphaned review PR dedup records when task is already deleted (#551) 2026-04-06 19:00:00 +01:00
Carlos Florêncio a44489640b fix: changed branch and auto focus changes panel (#549) 2026-04-06 18:59:37 +01:00
Carlos Florêncio f9ca582036 fix: compare ahead/behind counts against base branch instead of remote tracking branch (#544) 2026-04-06 09:51:58 +01:00
Carlos Florêncio 83f5355ea1 fix: skip git polling when workspace has no valid git repository (#541) 2026-04-05 21:32:47 +01:00
Carlos Florêncio bccd4d5f40 fix: always set upstream tracking on git push and fix task worktree startPoint (#536) 2026-04-03 15:40:40 +01:00
Carlos Florêncio 653ec2a1df perf: optimize git clone/fetch for large repos with many tags (#533) 2026-04-03 15:34:53 +01:00
Carlos Florêncio 8c6f16337d fix(acp): suppress stale events during session resume history replay (#527) 2026-04-03 15:15:02 +01:00
Carlos Florêncio 99008f448d fix: associate PR with task when creating task from PR URL (#539) 2026-04-03 15:09:27 +01:00
Carlos Florêncio 51e2338541 fix: prevent duplicate task.state_changed events and N+1 git show calls (#534) 2026-04-03 15:08:02 +01:00
Carlos Florêncio e72cd46552 fix: stop runtime instance in CleanupStaleExecutionBySessionID to prevent leaked git polling (#531) 2026-04-03 14:30:17 +01:00
Carlos Florêncio 3dabf72af2 fix: remove prompt timeout and prevent auto-resume of errored sessions (#530) 2026-04-03 14:29:38 +01:00
Carlos Florêncio 1c6506911e feat: add workflow sorting with drag-and-drop reordering (#520) 2026-04-01 23:58:43 +01:00
Carlos Florêncio b07356b29b feat(debug): enable pprof memory profiling in dev/debug mode (#518) 2026-04-01 23:21:29 +01:00
Carlos Florêncio 6fea6277a8 fix: hide start agent button during preparation and fix auto-start race condition on step move (#516) 2026-04-01 23:00:05 +01:00
Carlos Florêncio 348ee25e6f feat: disable branch selector for local executor and implement base branch checkout (#515) 2026-04-01 22:55:02 +01:00
Carlos Florêncio d7b8fdce60 fix: stop workspace tracker after consecutive git failures (#514) 2026-04-01 22:54:21 +01:00
Carlos Florêncio f4723ebcae feat: sort tasks by creation date in kanban and sidebar (#511) 2026-03-31 23:31:18 +01:00
Carlos Florêncio c732675f33 fix(github): workspace-scoped PR data loading with cache and singleflight (#509) 2026-03-31 22:56:09 +01:00
Carlos Florêncio 447da7edb2 fix: re-inject plan mode instructions on follow-up prompts (#507) 2026-03-31 22:43:22 +01:00
Carlos Florêncio b832390914 fix: preserve task status when resuming agent after backend restart (#508) 2026-03-31 22:37:31 +01:00
Carlos Florêncio c0b801a45a fix(github): break infinite PR sync loop and improve diff panel targeting (#503) 2026-03-31 00:25:51 +01:00
Carlos Florêncio c56dfe8537 feat(github): move PR monitoring to backend with lightweight polling (#502) 2026-03-30 23:26:01 +01:00
Carlos Florêncio 59ee830d71 feat(web): unified commit list and dockview panel fix (#500) 2026-03-30 22:44:10 +01:00
Carlos Florêncio e519d182fb chore: add dedicated sub-agents for skill delegation (#497) 2026-03-30 10:17:22 +01:00
Carlos Florêncio 81341263fd feat(terminal): fix bottom padding and add font family setting (#489) 2026-03-29 22:27:37 +01:00
Carlos Florêncio 3a50cf42e5 fix(web): show both send and cancel buttons when agent is busy (#487) 2026-03-29 22:13:39 +01:00
José Almeida f479393928 fix(github): reliable PR-task association across all launch paths (#485)
* fix(github): reliable PR-task association across all launch paths

Three bugs caused inconsistent PR detection for agent-opened PRs:
- StartCreatedSession never called ensureSessionPRWatch
- Push detection bailed out when a pr_number=0 watch existed
- PR watch branch was never updated after agent branch switches

* fix: extract searchPRForExistingWatch to reduce nesting depth

* fix: address review feedback and fix e2e test timeouts

- Fix UNIQUE constraint error when associatePRFromPush was called with
  an existing watch (update pr_number instead of creating new watch)
- Add UpdatePRWatchPRNumber to GitHubService interface
- Fix e2e test timeouts: increase budget to 180s, remove unnecessary
  clickTab("Changes"), replace 35s hard wait with polling assertion

* fix(e2e): accept both /t/ and /s/ URL patterns in PR detection tests

Task cards in the Done column navigate to /t/<task-id> (task view),
not /s/<session-id> (session view). The toHaveURL assertion must
accept both URL patterns.
2026-03-29 20:32:18 +01:00
Carlos Florêncio 3a71ae2fe6 fix: complete all non-terminal tool calls when turn ends (#488) 2026-03-29 17:36:50 +01:00
José Almeida d1a028fdb6 feat: introduce subtasks, allow sessions to task reuse executor (#419) 2026-03-29 15:33:40 +01:00