diff --git a/apps/web/components/task/executor-prepare-status.tsx b/apps/web/components/task/executor-prepare-status.tsx index aa038a5a01..157361b163 100644 --- a/apps/web/components/task/executor-prepare-status.tsx +++ b/apps/web/components/task/executor-prepare-status.tsx @@ -1,7 +1,7 @@ "use client"; import { useMemo } from "react"; -import { IconAlertTriangle, IconCheck, IconLoader2 } from "@tabler/icons-react"; +import { IconAlertTriangle, IconLoader2 } from "@tabler/icons-react"; import { useAppStore } from "@/components/state-provider"; import type { @@ -129,13 +129,13 @@ function lastIndexWhere(items: T[], pred: (item: T) => boolean): number { } export function PrepareStatusSection({ summary }: { summary: PrepareSummary }) { - if (summary.phase === "idle") return null; + if (summary.phase === "idle" || summary.phase === "ready") return null; if (summary.phase === "resuming") return ; if (summary.phase === "preparing" || summary.phase === "preparing_fallback") { return ; } if (summary.phase === "failed") return ; - return ; + return null; } function ResumingRow() { @@ -207,28 +207,3 @@ function FailedRow({ summary }: { summary: PrepareSummary }) { ); } - -function ReadyRow({ summary }: { summary: PrepareSummary }) { - return ( -
- - - Environment ready - {summary.durationMs ? ` · ${formatDuration(summary.durationMs)}` : ""} - -
- ); -} - -function formatDuration(ms: number): string { - if (ms < 1000) return `${ms}ms`; - const secs = Math.round(ms / 1000); - if (secs < 60) return `${secs}s`; - const mins = Math.floor(secs / 60); - const remSecs = secs % 60; - return remSecs > 0 ? `${mins}m ${remSecs}s` : `${mins}m`; -} diff --git a/apps/web/components/task/executor-settings-button.test.tsx b/apps/web/components/task/executor-settings-button.test.tsx index 114b0f4fb9..af16872e44 100644 --- a/apps/web/components/task/executor-settings-button.test.tsx +++ b/apps/web/components/task/executor-settings-button.test.tsx @@ -143,7 +143,9 @@ describe("ExecutorSettingsButton", () => { expect(screen.getByText(/Reconnecting to the existing environment/)).toBeTruthy(); }); - it("shows an Environment ready row once preparation completes", async () => { + it("hides the prepare-status section once preparation completes", async () => { + // The READY badge next to the executor name conveys ready-state; the + // dedicated "Environment ready · 12s" row is redundant noise. mockPrepareState = { sessionId: SESSION_ID, status: "completed", @@ -154,9 +156,7 @@ describe("ExecutorSettingsButton", () => { render(); screen.getByTestId(SETTINGS_BUTTON_TESTID).click(); - const status = await screen.findByTestId(PREPARE_STATUS_TESTID); - expect(status.dataset.phase).toBe("ready"); - expect(screen.getByText(/Environment ready/)).toBeTruthy(); - expect(screen.getByText(/13s/)).toBeTruthy(); + expect(screen.queryByTestId(PREPARE_STATUS_TESTID)).toBeNull(); + expect(screen.queryByText(/Environment ready/)).toBeNull(); }); }); diff --git a/apps/web/components/task/executor-settings-button.tsx b/apps/web/components/task/executor-settings-button.tsx index 0f271bd219..31eff0093b 100644 --- a/apps/web/components/task/executor-settings-button.tsx +++ b/apps/web/components/task/executor-settings-button.tsx @@ -313,7 +313,7 @@ function EnvironmentInfo({ } return ( -
+
{formatExecutorType(env.executor_type)}