feat: move GitLab MR linking to task menus (#1868)

This commit is contained in:
Carlos Florêncio
2026-07-23 14:46:07 +01:00
committed by GitHub
parent e53fd038a8
commit f6007de1cb
21 changed files with 753 additions and 71 deletions
+124
View File
@@ -0,0 +1,124 @@
---
spec: docs/specs/gitlab-integration/spec.md
created: 2026-07-22
status: approved
---
# Implementation Plan: GitLab Task Link Menu
## Overview
Align GitLab task linking with the existing GitHub interaction: unlinked tasks
do not reserve top-bar space, and linking starts from the task's contextual
`Link` submenu. Reuse the existing GitLab MR dialog and task-menu plumbing, then
update desktop and mobile E2E coverage to prove the new entry points.
## Frontend
### Top-bar behavior
- Update `apps/web/components/gitlab/mr-topbar-button.tsx` so an unlinked task
renders no generic link action.
- Preserve the linked-MR status/dropdown control, including `Link another merge
request`, open, and unlink behavior.
### Shared task link menu
- Extend `apps/web/components/kanban-card-menu-items.tsx` and
`apps/web/components/task/task-switcher-context-menu.tsx` with a
`GitLab Merge Request` link action.
- Wire the existing `TaskMRLinkDialog` through kanban-card and sidebar/mobile
task-switcher link state. Surface the action only while GitLab is configured
for the active workspace.
- Reuse the task's repository associations and the existing workspace
repository list; do not add a new API or duplicate link submission logic.
### Mobile design contract
- **Desktop outcome:** right-clicking a task opens `Link` > `GitLab Merge
Request`; submitting the existing dialog links the MR and reveals its status
control in the task top bar.
- **Mobile entry point:** the visible `Task actions` ellipsis in the existing
task-switcher drawer opens the same contextual menu; no long press is needed.
- **Nearest exemplar:**
`apps/web/components/task/mobile/session-task-switcher-sheet.tsx` and
`apps/web/components/task/task-item.tsx` provide the discoverable ellipsis,
responsive menu treatment, and touch geometry.
- **Hierarchy and presentation:** task row > actions menu > `Link` submenu >
`GitLab Merge Request` > existing link dialog. This is a short secondary
action, so the responsive context-menu bottom sheet plus existing dialog is
preferable to a new route or full-height surface.
- **Scrolling and geometry:** retain the menu primitive's safe-area-aware,
internally scrolling mobile surface and 44px menu rows. The task-switcher
drawer remains the outer list scroll owner while the portalled menu is open.
- **Shared logic:** desktop and mobile use the same availability hook, menu
callbacks, target state, repository resolution, and `TaskMRLinkDialog`.
## Tests
- **What:** the shared link-menu model includes `GitLab Merge Request` only
when its callback is present.
**File:** `apps/web/components/kanban-card-menu-items.test.tsx`.
**How:** extend the existing menu-entry unit tests and assert ordering and
omission.
- **What:** a task-switcher link selection closes the menu and targets the
selected task.
**File:** `apps/web/components/task/task-switcher.test.tsx` or a focused
colocated test if the existing helper coverage is sufficient.
**How:** exercise the existing provider-neutral selection helper with the new
callback plumbing.
- **What:** the GitLab top bar renders no generic action without linked MRs and
keeps the linked-MR control behavior.
**File:** `apps/web/components/gitlab/mr-topbar-button.test.ts` or a focused
component test where practical.
**How:** prefer testing extracted render-policy logic; do not add broad React
component tests solely for markup.
## E2E Tests
- **Desktop scenario:** update
`apps/web/e2e/tests/gitlab/gitlab-parity.spec.ts` so an unlinked task has no
`Link MR` top-bar button, then right-click the task row, choose `Link` >
`GitLab Merge Request`, submit the dialog, and verify the linked-MR status
control appears and survives reload.
- **Mobile scenario:** extend
`apps/web/e2e/tests/gitlab/mobile-gitlab-parity.spec.ts` or the focused mobile
task-link menu spec so the visible `Task actions` ellipsis opens the menu,
the nested GitLab action is touch reachable and viewport-contained, and the
dialog opens without right-click or long press.
## Implementation Waves
Wave 1:
- [x] [task-01-frontend-link-menu](task-01-frontend-link-menu.md)
Wave 2:
- [x] [task-02-e2e-contextual-linking](task-02-e2e-contextual-linking.md)
## Verification
```bash
cd apps && pnpm --filter @kandev/web test -- --run components/kanban-card-menu-items.test.tsx components/task/task-switcher.test.tsx components/gitlab/mr-topbar-button.test.ts
cd apps/web && pnpm run typecheck
cd apps/web && pnpm e2e:run tests/gitlab/gitlab-parity.spec.ts tests/gitlab/mobile-gitlab-parity.spec.ts
make fmt
make typecheck test lint
```
## Verification Status
- Targeted desktop and mobile GitLab Playwright coverage passes (6/6), including
validated screenshots, mobile touch targets, and viewport containment.
- Aggregate format, typecheck, unit, and lint checks pass. Aggregate tests pass
with `TMPDIR=/tmp`.
## Risks
- Task menu props cross kanban, desktop sidebar, and mobile task-switcher
surfaces; missing one caller would make the action viewport-dependent.
- GitLab availability is workspace-scoped. The action must disappear when the
active workspace has no configured GitLab connection.
- Removing the generic top-bar entry invalidates the existing manual-link E2E
steps; those must be changed rather than deleted.
@@ -0,0 +1,68 @@
---
id: "01-frontend-link-menu"
title: "GitLab MR contextual link action"
status: done
wave: 1
depends_on: []
plan: "plan.md"
spec: "../../specs/gitlab-integration/spec.md"
---
# Task 01: GitLab MR Contextual Link Action
## Acceptance
- An unlinked task renders no generic GitLab `Link MR` action in desktop or
mobile task top bars, while linked MR status/dropdown behavior is unchanged.
- A GitLab-configured workspace exposes `GitLab Merge Request` in the shared
task `Link` submenu on kanban cards, desktop sidebar rows, and the mobile task
switcher; unconfigured workspaces omit it.
- Selecting the action opens the existing `TaskMRLinkDialog` for the selected
task and active workspace with that task's repositories.
## Files Likely Touched
- `apps/web/components/gitlab/mr-topbar-button.tsx`
- `apps/web/components/gitlab/mr-topbar-button.test.ts`
- `apps/web/components/kanban-external-link-availability.ts`
- `apps/web/components/kanban-card-menu-items.tsx`
- `apps/web/components/kanban-card-menu-items.test.tsx`
- `apps/web/components/kanban-card.tsx`
- `apps/web/components/task/task-switcher-context-menu.tsx`
- `apps/web/components/task/task-switcher.tsx`
- `apps/web/components/task/task-switcher.test.tsx`
- `apps/web/components/task/task-session-sidebar-link-actions.ts`
- `apps/web/components/task/task-session-sidebar-task-linking.ts`
- `apps/web/components/task/task-session-sidebar-dialogs.tsx`
- `apps/web/components/task/mobile/session-task-switcher-sheet.tsx`
## Inputs
- Spec `What` bullets and the three contextual-link/top-bar scenarios.
- Plan `Frontend`, `Mobile design contract`, and `Tests` sections.
- Existing GitHub menu callback plumbing and `TaskGitHubPRDialog` wiring.
- Existing `TaskMRLinkDialog`, `useGitLabAvailable`, and linked-MR top-bar
dropdown behavior.
## Implementation Notes
- Follow `/tdd` and `/mobile-parity`; do not spawn subagents.
- Add the failing menu-policy/unit coverage before production changes.
- Keep the action label provider-specific: `GitLab Merge Request`.
- Preserve `Link another merge request` inside the linked-MR top-bar dropdown.
- Do not add backend endpoints, state slices, or a second GitLab link dialog.
- Update only this task file's status. Do not edit `plan.md`.
## Verification
```bash
cd apps && pnpm --filter @kandev/web test -- --run components/kanban-card-menu-items.test.tsx components/task/task-switcher.test.tsx components/gitlab/mr-topbar-button.test.ts
cd apps/web && pnpm run typecheck
```
## Output Contract
Report the behavior implemented, files changed, RED/GREEN evidence, targeted
test and typecheck results, mobile parity observations, blockers, and residual
risks. Set this task to `in_progress` before code changes and `done` only after
acceptance and verification pass.
@@ -0,0 +1,70 @@
---
id: "02-e2e-contextual-linking"
title: "GitLab contextual linking E2E"
status: done
wave: 2
depends_on: ["01-frontend-link-menu"]
plan: "plan.md"
spec: "../../specs/gitlab-integration/spec.md"
---
# Task 02: GitLab Contextual Linking E2E
## Acceptance
- Desktop E2E proves an unlinked task has no generic top-bar link action and
can link an MR through right-click `Link` > `GitLab Merge Request`.
- Mobile E2E proves the visible `Task actions` ellipsis exposes the same nested
action, opens the link dialog, and does not rely on right-click or long press.
- The desktop flow proves the linked-MR status control appears after linking
and survives reload; mobile menu surfaces remain viewport-contained with
touch-sized rows and no document horizontal overflow.
## Files Likely Touched
- `apps/web/e2e/tests/gitlab/gitlab-parity.spec.ts`
- `apps/web/e2e/tests/gitlab/mobile-gitlab-parity.spec.ts`
- Optional focused page-object helper under `apps/web/e2e/pages/` only when it
removes repeated stable selectors.
## Dependencies
- `01-frontend-link-menu`
## Inputs
- Spec contextual-link/top-bar scenarios.
- Plan `E2E Tests` and `Mobile design contract` sections.
- Existing manual-link section in `gitlab-parity.spec.ts`.
- Existing mobile task-actions geometry coverage in
`apps/web/e2e/tests/task/mobile-sidebar-task-actions.spec.ts` and nested-link
coverage in `apps/web/e2e/tests/task/mobile-external-link-menu.spec.ts`.
## Implementation Notes
- Follow `/e2e`, `/tdd`, and `/mobile-parity`; do not spawn subagents.
- Confirm the updated test fails for the expected missing menu action before
relying on the implementation.
- Use the managed `pnpm e2e:run` runner so production frontend assets are
rebuilt before the tests execute.
- Update only this task file's status. Do not edit `plan.md`.
## Verification
```bash
cd apps/web && pnpm e2e:run tests/gitlab/gitlab-parity.spec.ts tests/gitlab/mobile-gitlab-parity.spec.ts
```
## Verification Status
The targeted desktop and mobile GitLab Playwright scenarios pass (6/6).
Desktop and mobile screenshots were validated, along with mobile menu touch
targets and viewport containment. Aggregate format, typecheck, unit, and lint
checks pass, and aggregate tests pass with `TMPDIR=/tmp`.
## Output Contract
Report changed E2E scenarios, the exact command and result, rendered desktop
and phone observations, failure artifact paths if any, blockers, and residual
risks. Set this task to `in_progress` before changes and `done` only after both
desktop and mobile acceptance criteria pass.