fix: retain session failures across recovery surfaces (#3669)

This commit is contained in:
Carlos Florêncio
2026-09-15 09:36:47 +01:00
committed by GitHub
parent 54e2e21f32
commit eeeb6f5586
101 changed files with 4057 additions and 1704 deletions
@@ -47,6 +47,12 @@ const (
const (
LaunchErrorPhaseBootstrap = "bootstrap"
// Error scopes identify the owner of a failure. Session failures belong in
// the session transcript; task failures belong to the task shell and remain
// visible while the task changes tabs or sessions.
ErrorScopeSession = "session"
ErrorScopeTask = "task"
AgentErrorCauseOperationResume = "resume"
AgentErrorCauseOperationRestoreWorkspace = "restore_workspace"
@@ -138,6 +144,8 @@ func isKnownAgentErrorCauseCode(code string) bool {
type TaskLaunchError struct {
Message string `json:"message"`
OccurredAt time.Time `json:"occurred_at"`
Scope string `json:"scope,omitempty"`
SessionID string `json:"session_id,omitempty"`
Code string `json:"code,omitempty"`
Details string `json:"details,omitempty"`
RecoveryActions []string `json:"recovery_actions,omitempty"`
@@ -210,6 +218,7 @@ func isKnownRecoveryAction(action string) bool {
}
func normalizeLastAgentError(value LastAgentError) LastAgentError {
value.Scope = normalizeErrorScope(value.Scope, ErrorScopeSession)
value.Message = truncateUTF8Bytes(value.Message, maxLaunchErrorMessageBytes)
value.Code = truncateUTF8Bytes(value.Code, maxLaunchErrorCategoryBytes)
value.RecoveryActions = NormalizeRecoveryActionsForCategory(value.Code, value.RecoveryActions)
@@ -233,8 +242,10 @@ func normalizeLastAgentError(value LastAgentError) LastAgentError {
}
func normalizeTaskLaunchError(value TaskLaunchError) TaskLaunchError {
value.Scope = normalizeErrorScope(value.Scope, ErrorScopeTask)
value.Message = truncateUTF8Bytes(value.Message, maxLaunchErrorMessageBytes)
value.Code = truncateUTF8Bytes(value.Code, maxLaunchErrorCategoryBytes)
value.SessionID = truncateUTF8Bytes(value.SessionID, maxLaunchErrorIDBytes)
value.RecoveryActions = NormalizeRecoveryActionsForCategory(value.Code, value.RecoveryActions)
value.TaskRepositoryID = truncateUTF8Bytes(value.TaskRepositoryID, maxTaskRepositoryIDBytes)
value.StampValue = boundedLaunchErrorStamp(value.StampValue)
@@ -242,6 +253,17 @@ func normalizeTaskLaunchError(value TaskLaunchError) TaskLaunchError {
return value
}
func normalizeErrorScope(value, fallback string) string {
switch strings.TrimSpace(value) {
case ErrorScopeSession:
return ErrorScopeSession
case ErrorScopeTask:
return ErrorScopeTask
default:
return fallback
}
}
// LoadTaskLaunchError reads and validates the task-owned launch error.
func LoadTaskLaunchError(metadata map[string]interface{}) (TaskLaunchError, bool) {
if metadata == nil {