From e2483650d43248599544915d8256a214298e063d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Flor=C3=AAncio?= Date: Sun, 24 May 2026 14:45:42 +0100 Subject: [PATCH] fix(agentctl): allow native ACP CLIs in probe allowlist (#1059) --- .../server/utility/acp_executor_test.go | 31 ++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/apps/backend/internal/agentctl/server/utility/acp_executor_test.go b/apps/backend/internal/agentctl/server/utility/acp_executor_test.go index c2b0865698..3e9490ee27 100644 --- a/apps/backend/internal/agentctl/server/utility/acp_executor_test.go +++ b/apps/backend/internal/agentctl/server/utility/acp_executor_test.go @@ -1,6 +1,35 @@ package utility -import "testing" +import ( + "maps" + "path/filepath" + "slices" + "testing" +) + +func TestResolveProbeCommand_AllowsEveryListedBinary(t *testing.T) { + t.Parallel() + + for _, name := range slices.Sorted(maps.Keys(allowedProbeCommands)) { + t.Run(name, func(t *testing.T) { + t.Parallel() + if got := resolveProbeCommand(name); got != name { + t.Fatalf("resolveProbeCommand(%q) = %q, want %q", name, got, name) + } + path := filepath.Join("/usr/local/bin", name) + if got := resolveProbeCommand(path); got != name { + t.Fatalf("resolveProbeCommand(%q) = %q, want %q", path, got, name) + } + }) + } +} + +func TestResolveProbeCommand_RejectsUnknown(t *testing.T) { + t.Parallel() + if got := resolveProbeCommand("claude"); got != "" { + t.Fatalf("resolveProbeCommand(claude) = %q, want empty", got) + } +} func TestSanitizeInferenceChunk_DropsPiVersionBanner(t *testing.T) { t.Parallel()