dreampiler/kandev
1
0
Fork 0
Code Issues 43 Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: preserve client-side navigation for task links (#3844)

Browse Source
This commit is contained in:
Carlos Florêncio
2026-09-21 18:22:29 +01:00
committed by GitHub
parent daccac2888
commit e1f43436b2
51 changed files with 1769 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/web/components/github/my-github/quick-task-launcher.test.tsx
+2 -2
View File
@@ -292,7 +292,7 @@ describe("QuickTaskLauncher issue linking", () => {
expect(mocks.upsertTaskIssue).toHaveBeenCalledWith(WORKSPACE_ID, link);
});
expect(mocks.push).toHaveBeenCalledTimes(autoFocus ? 1 : 0);
if (autoFocus) expect(mocks.push).toHaveBeenCalledWith("/tasks/task-1");
if (autoFocus) expect(mocks.push).toHaveBeenCalledWith("/t/task-1");
},
);
@@ -302,7 +302,7 @@ describe("QuickTaskLauncher issue linking", () => {
mocks.dialogProps?.onSuccess?.({ id: "task-1" } as Task);
expect(mocks.push).toHaveBeenCalledWith("/tasks/task-1");
expect(mocks.push).toHaveBeenCalledWith("/t/task-1");
await waitFor(() => expect(mocks.linkTaskIssue).toHaveBeenCalledTimes(1));
expect(mocks.upsertTaskIssue).not.toHaveBeenCalled();
});
apps/web/components/github/my-github/quick-task-launcher.tsx
+2 -1
View File
@@ -2,6 +2,7 @@
import { useMemo } from "react";
import { useRouter } from "@/lib/routing/client-router";
import { linkToTask } from "@/lib/links";
import type { Icon } from "@tabler/icons-react";
import { TaskCreateDialog } from "@/components/task-create-dialog";
import { useAppStore } from "@/components/state-provider";
@@ -236,7 +237,7 @@ export function QuickTaskLauncher({
});
}
onClose();
if (meta?.autoFocus !== false) router.push(`/tasks/${task.id}`);
if (meta?.autoFocus !== false) router.push(linkToTask(task.id));
};
if (!workspaceId || !defaultWorkflow || !defaultStep || !dialog) return null;