From d46ec16770adc2ee04ab9edae835030a0e99c70b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Almeida?= <57680069+zeval@users.noreply.github.com> Date: Fri, 31 Jul 2026 10:55:29 +0100 Subject: [PATCH] fix: improve interactive accent contrast (#2075) --- apps/packages/ui/src/context-menu.tsx | 10 +-- apps/packages/ui/src/dropdown-menu.tsx | 10 +-- apps/packages/ui/src/menubar.tsx | 10 +-- apps/packages/ui/src/select.tsx | 2 +- apps/packages/ui/src/table.tsx | 2 +- .../[id]/components/instruction-file-list.tsx | 6 +- .../office/components/new-task-bottom-bar.tsx | 4 +- .../components/new-task-participant-row.tsx | 2 +- .../components/new-task-selector-row.tsx | 8 +-- .../app/office/components/new-task-stages.tsx | 8 +-- apps/web/app/office/page-client.tsx | 2 +- apps/web/app/office/tasks/task-group.tsx | 6 +- apps/web/app/office/tasks/task-sort.tsx | 4 +- .../settings/export/export-file-tree.test.tsx | 2 +- .../settings/export/export-file-tree.tsx | 4 +- .../office/workspace/skills/skill-list.tsx | 4 +- .../monaco/diff-viewer-context-menu.tsx | 9 ++- .../editors/tiptap/plan-bubble-menu.tsx | 4 +- .../components/github/multi-pr-ci-popover.tsx | 6 +- .../components/review/review-file-tree.tsx | 4 +- apps/web/components/shared/file-tree.test.tsx | 2 +- apps/web/components/shared/file-tree.tsx | 4 +- .../components/task/base-branch-picker.tsx | 6 +- .../task/changes-panel-file-row.test.tsx | 6 +- .../task/changes-panel-file-row.tsx | 4 +- .../task/changes-panel-pr-files.tsx | 6 +- .../chat/messages/message-comment-surface.tsx | 2 +- .../components/task/file-browser-parts.tsx | 6 +- .../task/mobile/mobile-repos-section.tsx | 4 +- .../task/mobile/mobile-sessions-section.tsx | 4 +- .../task/mobile/mobile-terminals-section.tsx | 4 +- .../task/simple/OfficeSimplePane.tsx | 2 +- .../simple/components/priority-picker.tsx | 6 +- .../task/simple/components/status-picker.tsx | 6 +- .../task/simple/components/sub-issues-row.tsx | 2 +- .../task/simple/subtask-stepper.tsx | 2 +- .../components/task/task-pr-picker-dialog.tsx | 4 +- .../web/e2e/tests/pr/pr-multi-popover.spec.ts | 70 +++++++++++++++++++ ...29-interactive-accent-surface-semantics.md | 49 +++++++++++++ docs/decisions/INDEX.md | 1 + 40 files changed, 213 insertions(+), 84 deletions(-) create mode 100644 docs/decisions/2026-07-29-interactive-accent-surface-semantics.md diff --git a/apps/packages/ui/src/context-menu.tsx b/apps/packages/ui/src/context-menu.tsx index 506f7cf6ad..31ceb27435 100644 --- a/apps/packages/ui/src/context-menu.tsx +++ b/apps/packages/ui/src/context-menu.tsx @@ -76,7 +76,7 @@ function ContextMenuItem({ data-inset={inset} data-variant={variant} className={cn( - "focus:bg-accent focus:text-accent-foreground data-[variant=destructive]:text-destructive data-[variant=destructive]:focus:bg-destructive/10 dark:data-[variant=destructive]:focus:bg-destructive/20 data-[variant=destructive]:focus:text-destructive data-[variant=destructive]:*:[svg]:text-destructive not-data-[variant=destructive]:focus:**:text-accent-foreground min-h-7 gap-2 rounded-md px-2 py-1 text-xs/relaxed [&_svg:not([class*='size-'])]:size-3.5 group/context-menu-item relative flex cursor-default items-center outline-hidden select-none data-[disabled]:pointer-events-none data-[disabled]:opacity-50 data-[inset]:pl-8 [&_svg]:pointer-events-none [&_svg]:shrink-0", + "focus:bg-muted focus:text-foreground data-[variant=destructive]:text-destructive data-[variant=destructive]:focus:bg-destructive/10 dark:data-[variant=destructive]:focus:bg-destructive/20 data-[variant=destructive]:focus:text-destructive data-[variant=destructive]:*:[svg]:text-destructive min-h-7 gap-2 rounded-md px-2 py-1 text-xs/relaxed [&_svg:not([class*='size-'])]:size-3.5 group/context-menu-item relative flex cursor-default items-center outline-hidden select-none data-[disabled]:pointer-events-none data-[disabled]:opacity-50 data-[inset]:pl-8 [&_svg]:pointer-events-none [&_svg]:shrink-0", className, )} {...props} @@ -97,7 +97,7 @@ function ContextMenuSubTrigger({ data-slot="context-menu-sub-trigger" data-inset={inset} className={cn( - "focus:bg-accent focus:text-accent-foreground data-open:bg-accent data-open:text-accent-foreground not-data-[variant=destructive]:focus:**:text-accent-foreground min-h-7 gap-2 rounded-md px-2 py-1 text-xs [&_svg:not([class*='size-'])]:size-3.5 flex cursor-default items-center outline-hidden select-none data-[inset]:pl-8 [&_svg]:pointer-events-none [&_svg]:shrink-0", + "focus:bg-muted focus:text-foreground data-open:bg-muted data-open:text-foreground min-h-7 gap-2 rounded-md px-2 py-1 text-xs [&_svg:not([class*='size-'])]:size-3.5 flex cursor-default items-center outline-hidden select-none data-[inset]:pl-8 [&_svg]:pointer-events-none [&_svg]:shrink-0", className, )} {...props} @@ -134,7 +134,7 @@ function ContextMenuCheckboxItem({ ) ) { diff --git a/apps/web/app/office/components/new-task-bottom-bar.tsx b/apps/web/app/office/components/new-task-bottom-bar.tsx index ab93d2c1f3..e8a29f0bdc 100644 --- a/apps/web/app/office/components/new-task-bottom-bar.tsx +++ b/apps/web/app/office/components/new-task-bottom-bar.tsx @@ -69,7 +69,7 @@ function StatusChip({ draft, onUpdate }: Props) {