dreampiler/kandev
1
0
Fork 0
Code Issues 46 Pull Requests Actions 54 Packages Projects Releases Wiki Activity

feat: make new task auto-focus optional (#3653)

Browse Source
This commit is contained in:
José Almeida
2026-09-14 15:01:29 +02:00
committed by GitHub
parent 0f4bf79b8d
commit cc6077fd7f
67 changed files with 1486 additions and 98 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/web/components/github/my-github/quick-task-launcher.test.tsx
+27 -20
View File
@@ -24,7 +24,10 @@ const LOCAL_REPO_ID = "local-repo";
const mocks = vi.hoisted(() => ({
dialogProps: undefined as
| { initialValues?: Record<string, unknown>; onSuccess?: (task: Task) => void }
| {
initialValues?: Record<string, unknown>;
onSuccess?: (task: Task, mode?: "create" | "edit", meta?: { autoFocus?: boolean }) => void;
}
| undefined,
push: vi.fn(),
createTaskPR: vi.fn(),
@@ -267,27 +270,31 @@ describe("QuickTaskLauncher repository defaults", () => {
});
describe("QuickTaskLauncher issue linking", () => {
it("links and immediately stores a newly created task for the launched issue", async () => {
const link = {
task_id: "task-1",
task_title: "Review: add Download option",
owner: "kdlbs",
repo: "kandev",
issue_number: 1567,
issue_url: ISSUE_URL,
issue_title: "add Download option",
};
mocks.linkTaskIssue.mockResolvedValue(link);
renderIssueLauncher([repo({ id: LOCAL_REPO_ID })]);
it.each([true, false])(
"links and stores the launched issue with auto-focus %s",
async (autoFocus) => {
const link = {
task_id: "task-1",
task_title: "Review: add Download option",
owner: "kdlbs",
repo: "kandev",
issue_number: 1567,
issue_url: ISSUE_URL,
issue_title: "add Download option",
};
mocks.linkTaskIssue.mockResolvedValue(link);
renderIssueLauncher([repo({ id: LOCAL_REPO_ID })]);
mocks.dialogProps?.onSuccess?.({ id: "task-1" } as Task);
mocks.dialogProps?.onSuccess?.({ id: "task-1" } as Task, "create", { autoFocus });
expect(mocks.linkTaskIssue).toHaveBeenCalledWith("task-1", { issue: ISSUE_URL });
await waitFor(() => {
expect(mocks.upsertTaskIssue).toHaveBeenCalledWith(WORKSPACE_ID, link);
});
expect(mocks.push).toHaveBeenCalledWith("/tasks/task-1");
});
expect(mocks.linkTaskIssue).toHaveBeenCalledWith("task-1", { issue: ISSUE_URL });
await waitFor(() => {
expect(mocks.upsertTaskIssue).toHaveBeenCalledWith(WORKSPACE_ID, link);
});
expect(mocks.push).toHaveBeenCalledTimes(autoFocus ? 1 : 0);
if (autoFocus) expect(mocks.push).toHaveBeenCalledWith("/tasks/task-1");
},
);
it("navigates when issue linking fails", async () => {
mocks.linkTaskIssue.mockRejectedValueOnce(new Error("offline"));
apps/web/components/github/my-github/quick-task-launcher.tsx
+2 -2
View File
@@ -206,7 +206,7 @@ export function QuickTaskLauncher({
const handleOpenChange = (open: boolean) => {
if (!open) onClose();
};
const handleSuccess = (task: Task) => {
const handleSuccess = (task: Task, _mode?: "create" | "edit", meta?: { autoFocus?: boolean }) => {
if (payload?.kind === "pr" && workspaceId) {
const repositoryId = pickRepositoryIdForPR(
task.repositories,
@@ -236,7 +236,7 @@ export function QuickTaskLauncher({
});
}
onClose();
router.push(`/tasks/${task.id}`);
if (meta?.autoFocus !== false) router.push(`/tasks/${task.id}`);
};
if (!workspaceId || !defaultWorkflow || !defaultStep || !dialog) return null;